summaryrefslogtreecommitdiff
path: root/svx/source
AgeCommit message (Collapse)Author
2021-12-18use more cppu::BaseMutexNoel Grandin
Change-Id: I1ee9aff2774a673666c332c116aa5b0ba0d8b585 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127077 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-17Fix typosAndrea Gelmini
Change-Id: I7f1636226c4fbe29d9d2ef850318a9d57f1b5450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127009 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-17sd theme: add a "theme" palette to the color pickerMiklos Vajna
This implements listing the current theme colors (which depend on what is the master page of the current slide) in the color picker and also allows picking those colors. The colors are picked as-is for now, not yet setting the color theme index in the document model. Change-Id: I2553725c29c2a9f9de80f86b38d22a06bf9c0364 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126994 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-12-17fix for crash converting ooo31011-1.sxw and tdf#146132Noel Grandin
./instdir/program/soffice.bin --headless --convert-to odt ./ooo31011-1.sxw regression from commit 681e10eecf67a1a01bdec2cc9b834e0345e25206 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Dec 9 11:12:49 2021 +0200 tdf#146137 tdf#146132 image redrawing It is because we cache high-level primitives, and then during paint, we decompose those high-level primitives, and that triggers layout, which triggers an invalidate i.e. an ActionChanged(), which blows away the cached data we are iterating over. Change-Id: Id18e47b6c2b71a5404f24b075a43d2040a5e3509 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126995 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-17use more OInterfaceContainer3::notifyEachNoel Grandin
Change-Id: I0dd6e9f1514792e73a31e81896d09c27c1912318 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126966 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-17simplify ViewObjectContactOfUnoControl_Impl::getUnoObjectNoel Grandin
Change-Id: I7dd9758180c629fc0de4e59ffef7d33e62d43dcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126965 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-16Fix typosAndrea Gelmini
Change-Id: I66feced8bed05c7859e36a6d2f746a7faf30c7a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126915 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-12-16use more OInterfaceContainerHelper3 in toolkitCaolán McNamara
Change-Id: I3861a254d660662cbf575e9669cbacba36634856 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126855 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-16Remove transitional header drawinglayer/primitive2d/polygonprimitive2d.hxxGabor Kelemen
follow up to commit 1103727fb24b368419ea0cfd2382560ef6b82f43 Change-Id: I227042f4703f3f4c18a8dc0355f044d2ad7dfb2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126838 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-15Recheck include/[a-d]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I42475b8e75951d5dcae2fe6b0ad0bca64441e7f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-15tdf#145904,tdf#145956 improve extrusion of custom shapesRegina Henschel
The patch addressed these errors: The property Origin is relative to the bounding rectangle of the shape not to the snap rectangle. That error is visible e.g. for a block arc. Rotation center x- and y- values are relative to the snap rectangle and not absolute. Rotation center z-value is in Hmm and needs conversion to Twips in Writer. Rotation is around rotation center, which might be different from shape center. That has been ignored. I have moved calculation of the 2D logic rectangle of the scene to main method to be able to reuse the transformation and other values. I consider using a special local class as unneeded overhead. I have reordered some parts to bring geometry relevant parts together. Change-Id: I35ad0721091b365ae99cd3d7b2afb0ad7efe47fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126847 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-14Stream::Tell returns sal_uInt64Noel Grandin
Change-Id: I02e49d4f59c17a9868c4111ac91b5dd2715e689c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126630 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-14tdf#145999 -1 was the representation of unlimited cell widthCaolán McNamara
when using UniString -1 -> 0xFFFF i.e. old-time EDIT_NOLIMIT Change-Id: Ie40fa65a88a2b8961d70635ca5e4ec851567e089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126834 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-14ofz#42338 avoid timeout in autogrow frames during ppt importCaolán McNamara
Change-Id: I4bcd8b5ee59609016451ddce5eaeb445f7c793c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126827 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-12only use css::awt::XPopupMenu methodsCaolán McNamara
a working example smart tag extension can be found at https://forum.openoffice.org/en/forum/viewtopic.php?p=387917#p387917 Change-Id: I2b6232542b27ff7286aa6d4e9bff177e47729954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-12prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: I29b91b97e36682473241f3d7ab9cde46765830f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126700 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-10cid#1485150 suppress Uncaught exceptionCaolán McNamara
Change-Id: I3baac0b02a3d1eef150cb78873ffbee51282b0db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126654 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-10Related tdf#102506: make Find Bar Ctrl+F searching by value by defaultJulien Nabet
Change-Id: I4c001b60eecbcdae95cde6d79cc91bb887d7a742 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126490 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-12-10merge setUnoShape and impl_setUnoShapeNoel Grandin
since the one purely forwards to the other Change-Id: I5f614cc1eb819572a55da57d9d6c9ae56b9139c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126608 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-09cid#1485150 silence Uncaught exceptionCaolán McNamara
Change-Id: Ic7944a6b6a956a9b699e5743b78b98cbb522721f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126582 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-09tdf#146137 tdf#146132 image redrawingNoel Grandin
regression from commit fe6a140a537eda1b6703c44ff5ee49d2ba875b81 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Dec 7 14:55:13 2021 +0200 used cache value in ViewObjectContact::getPrimitive2DSequence we need to blow away the cached data when the object changes Change-Id: I3be8d57b166b6f7e3a04bd8fc34c83eed5ff8857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126573 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-09VCL implement GetGlyphOutline fallbackArmin Le Grand (Allotropia)
Change-Id: Ia0b32f7fb9f39d8bea18afd12df3cc95ba8077ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126463 Tested-by: Jenkins Tested-by: Armin Le Grand <Armin.Le.Grand@me.com> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-09meRememberedAnimationKind is deadNoel Grandin
and removing it actually makes chart loading faster, because we now avoid always instantiaing the ObjectItemSet Change-Id: I48420bcc38c61e4f6b211724271bc61db0e1f0d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126572 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-09svx: fix crash in ViewContact::ActionChanged()Miklos Vajna
Crashreport: sdr::contact::ViewContact::ActionChanged() svx/source/sdr/contact/viewcontact.cxx:197 (discriminator 2) SdrTextObj::NbcSetOutlinerParaObjectForText(std::unique_ptr<OutlinerParaObject, std::default_delete<OutlinerParaObject> >, SdrText*) svx/source/svdraw/svdotext.cxx:1379 sdr::properties::TextProperties::ItemSetChanged(SfxItemSet const&) /usr/include/c++/10/bits/unique_ptr.h:360 sdr::properties::RectangleProperties::ItemSetChanged(SfxItemSet const&) svx/source/sdr/properties/rectangleproperties.cxx:54 Change-Id: I82de3e849cef33d207c8fd5e1c225de78d5f8705 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126562 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-12-09sw: remove an unused includeMiklos Vajna
Change-Id: Ib7be7fac788e06ee885d0eca9c082b145c889ef9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126552 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-08tdf#146108 Calc slow to change cell focus..Noel Grandin
in a document with a big background image Revert "tdf#136058: remove some caching" This reverts commit 57c40329a2b469813a1f357de355a37c8e3077ae. And add some comments for future would-be optimisers. Change-Id: Ie8686edc38dcdbe7d9e78599c1a259aab68278a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-08use the cached object rangeNoel Grandin
rather then recalculating it Change-Id: Ia7338799a283e65d1575fce937f0600e1bd58bb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126479 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-08remove some unnecessary copyingNoel Grandin
the method returns a const& Change-Id: I2b031b930c6a1280d25eab2d6a659102d2e28972 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126478 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-08used cache value in ViewObjectContact::getPrimitive2DSequenceNoel Grandin
I'm not sure why we don't rely on this, it seems pretty obvious, we even has an explicit flush method to invalidate it. This takes the load time of a spreadsheet with a large chart from 40s to 20s. Change-Id: I731246abb5e0c118116b70a0386b652798555503 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126477 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-07tdf#48622, tdf#145828 use correct default for border line widthArmin Le Grand (Allotropia)
Use correct default to create the intended 0.75pt cell border using the border formatting tool in the standard toolbar Change-Id: I8e95a7ab888cdc1b04929fd41753e550b96f3de4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126484 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-12-07improve loplugin:cow_wrapperNoel Grandin
to find my previous attempt at this, which only obscured the problem <noelgrandin> I'm such an idiot <noelgrandin> I changed a whole bunch of code to avoid calling const methods on a non-const object <noelgrandin> from p->foo() to std::as_const(*p).foo() <noelgrandin> can you spot the mistake? <bubli> Is this a job interview question? :D <vmiklos> noelgrandin: you did the opposite, now you always call const member functions, while you wanted to always call non-const member functions? <noelgrandin> more like a "why didn't the smart people on this channel tell me I was an idiot" :-) <noelgrandin> in this case, we have o3tl::cow_wrapper, which overrides operator* and operator-> <vmiklos> ah, and by the time you would add/remove the const, cow_wrapper already did the expensive task of copying based on const/non-const <noelgrandin> exactly <thorsten> heh Change-Id: I5366e6a87c414b862668b61e6adfbccfdd9d3b04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-07lock model while building chartNoel Grandin
reduces the amount of broadcasting we do Change-Id: I29ebabfcd255a96381d75b2b013f4a1abfb8ee08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-07loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I231195c36d620254cbcd2f4d7bbb9044f7887fe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126413 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-06Revert "lose the caching in ViewObjectContact" because it breaks...Noel Grandin
bitmap caching. Added some notes for future would-be optimizers. This reverts commit 7f02cb80ac2075b65ee1adee4e29d1d5c4819424. Change-Id: I39c41ea95d23d4a65edd3cef46a5d86fab48a044 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126425 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2021-12-06skip some intermediate results in tryToGetChartContentAsPrimitive2DSequenceNoel Grandin
Change-Id: Idf3179c97fe40da1ff41100fc7e7a0b80ee1ca73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126403 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-06only collect hitstack if we actually need itNoel Grandin
Change-Id: I95f04b05c431f0009c5a843626c397e1dbc3f39e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126402 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-05cid#1494630 in the end bMirrored -> SetMirrorFlags(BmpMirrorFlags::Horizontal)Caolán McNamara
no matter whan else Change-Id: I0b645f787f294a3ba21a4e4dad4da37e7baaa4c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126389 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-05cid#1494630 #5 rearrange to demo Logically dead codeCaolán McNamara
Change-Id: I96a8cde9c8886c2d962ff1053607810bc457cb88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-05cid#1494630 #4 rearrange to demo Logically dead codeCaolán McNamara
Change-Id: I3d7efa59ecaf21a582644594f26a1d2116d1965c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-05cid#1494630 Logically dead codeCaolán McNamara
Change-Id: I02022ee4a0524accbe33fd2da3dc971f434b0d83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126386 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-05cid#1494630 #3 rearrange to demo Logically dead codeCaolán McNamara
Change-Id: I263ce873a2a308a1a986fd09310b691d9c6525fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-05cid#1494630 #2 rearrange to demo Logically dead codeCaolán McNamara
Change-Id: Ie94429f2d8c8c05780c53b223b7d5bf20d63a522 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-05cid#1494630 #1 rearrange to demo Logically dead codeCaolán McNamara
Change-Id: Ia5be7432f6972135bcb792f29221f75eff8f66dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-05use visitor in ViewObjectContact::createPrimitive2DSequenceNoel Grandin
to reduce intermediate object creation Change-Id: I03d34d15e88f82027f865868aca08503e38fd6ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126372 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-05improve ViewContactOfGraphic::createViewIndependentPrimitive2DSequenceNoel Grandin
no need to create a temporary intermediate container Change-Id: Iaa87011ff007c313a2b223eb95133b5cb626b468 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126371 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-05improve ImpConvertContainedTextToSdrPathObjsNoel Grandin
no need to create a temporary container Change-Id: I60eceec1800ff57c0a600c2b049c157d94aef3b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-04use OMultiTypeInterfaceContainerHelperVar3 in PropertyChangeNotifierNoel Grandin
Change-Id: I861bb71702a56997ce5b28bca7750dba6a11f9c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-04use visitor in getViewIndependentPrimitive2DContainerNoel Grandin
to reduce intermediate temporary data creation Change-Id: I3f13b0e02c1fa374e8d70768ae47c7f6da254462 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126322 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-04rename Primitive2DDecompositionVisitor methodsNoel Grandin
from "append" to "visit" The current naming comes from when I created this class as replacement for passing Primitive2DContainer around and the naming was meant to reduce code churn. But now that I'm using it more, the naming is an impediment to understanding the code. Change-Id: I4ee0156c7ffb534eac64f1c05eac6b8c67c25ab9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-03tdf#129629 sw UI: Find/replace - stop popping open MORE sectionJustin Luth
This was a regression from LO 6.1, where it would always show the "more" options if one of them was enabled. That might be fine for the dialog initialization (and that is how I implemented it) but even that is a bit much. Perhaps it should be a search option that is remembered while the application is running. Is that what pSearchOptions holds? Anyway, this much I can easily figure out. Someone who knows more about these things can enhance it further if they want. Change-Id: I8288bea514840f4ea06deb00a3603aa9568a75b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126226 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
generated by cgit (git 2.34.1) at 2025-01-30 17:31:43 +0000