summaryrefslogtreecommitdiff
path: root/svx/source
AgeCommit message (Collapse)Author
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-16add GetSelectEntryData to ListBox and ComboBoxNoel Grandin
to reduce code clutter like pLbSelect->GetEntryData(pLbSelect->GetSelectEntryPos()) since this is a fairly frequent operation. Change-Id: I41daf30fdeda2442ad1ac829e12f553233bae184 Reviewed-on: https://gerrit.libreoffice.org/14472 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-14Typo: avalaible->availableJulien Nabet
Change-Id: I8976671fa0c1c090c0af1030e3ef8df3f3701b60
2015-02-14related tdf#89004 move to std:set instead of std::vectorUrsache Vladimir
Conflicts: sc/source/core/data/document10.cxx sw/source/core/doc/docfmt.cxx Change-Id: I1312f476607ea3a78b162a7e59323b0a142f6629
2015-02-13set edit selection only if necessaryEike Rathke
No visible effect, just that it's unnecessary in other cases. Change-Id: I4f40dbaea5ea647347f7e20f8e233837f7dbd8cb
2015-02-13tdf#60910 don't lose fontwork objectsDavid Tardon
This reverts commit 0685b2e73e48adb84cd01355d45551ab478ebcd5.
2015-02-13Resolves: tdf#81429 select corresponding listbox entry if not currentEike Rathke
Change-Id: Ib475a43601ee22d33677ac45cd6ef9dba7e7c431
2015-02-12Fix null pointer dereferenceStephan Bergmann
...when FindTextToolbarController instance is immediately disposed after creation (as will happen in to-be-updated CppunitTest_services). Change-Id: I459f2b2ac3eecc728b45e8493c3f8988a6c121a1
2015-02-12DBG_ASSERT->SAL_WARNCaolán McNamara
Change-Id: I77646432f38cf65f487ff2f81c333be7a626be39
2015-02-12fdo#39468 translated german commentsDaniel Sikeler
also translated some error messages Change-Id: I22ef6b6cc01ba310d1ca694c7fcbf0d968a2fdf8 Reviewed-on: https://gerrit.libreoffice.org/14432 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-10rearrange this a little, no logic changeCaolán McNamara
Change-Id: Ia5dd68ab8b7e4fe93caf0e79a27922abf02b97b6
2015-02-09fdo#39468 translated german commentsDaniel Sikeler
also tranlated some error messages Change-Id: Ia5035c7c2f5379a0b419fc5514a288368e687c83 Reviewed-on: https://gerrit.libreoffice.org/14382 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-09tdf#47577 Zoom slider should only react to full clickRodolfo Ribeiro Gomes
Change-Id: If859754c956a634a96066ac407b70d6dd2759d53 Signed-off-by: Rodolfo Ribeiro Gomes <libo@rodolfo.eng.br> Reviewed-on: https://gerrit.libreoffice.org/14265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I1ffc6af694367f0ff70b7598c093203f1f68882c
2015-02-05convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara
and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-02-05push this windows build along a bit furtherCaolán McNamara
Change-Id: Id22ba872865bd8136c65c73152097805e696a695
2015-02-05cppcheck: Returning/dereferencing 'pEntry' after it is deallocated / releasedJulien Nabet
Change-Id: If96b66d5bbfcf4426bb602909599cd36e1f3c994
2015-02-05yet yet yet yet yet yet yet another 'Locale' ambiguous symbolEike Rathke
Change-Id: Ic6b813b3f826300d3b59b7105690ab611bb4bd44
2015-02-05yet yet yet yet yet yet another Windows build 'Locale' ambiguous symbolEike Rathke
Change-Id: I910c37a19c1f627ec0c92dcb044db92e9e24c25e
2015-02-05callcatcher: update unused codeCaolán McNamara
Change-Id: I540d192a361938cd4dca811e7170d762841662ee
2015-02-03callcatcher: shave off some moreCaolán McNamara
Change-Id: I8ed7028f865bd4a6425859ab3b57ed8e928a78e4
2015-02-02callcatcher: remove some unused methodsCaolán McNamara
Change-Id: Id3ca991e9ede13512a39865496429aabb7e71088
2015-02-01loplugin:unreffunStephan Bergmann
Change-Id: I25213abc84c3e512fa620aa7c08e0c2e1bc0159a
2015-01-30coverity#1267684 Uncaught exceptionCaolán McNamara
Change-Id: Ie444d89108087c39ad429743e76c383f640c8751
2015-01-30ensure the default export filter is really availableDavid Tardon
Change-Id: Ie9b8a25d8d33c6211c43277f4d3b4cdbd79f5783
2015-01-30remove copypastaDavid Tardon
Change-Id: If3e33ee0a24e8a4850b2242ab3806d8dc57ddf09
2015-01-30tdf#85195 only check export formats for default formatDavid Tardon
What good would would a pre-selected export filter format to me if I cannot save into it? Change-Id: I9e5d06cec5ffa0ba325b8bfcfadc4fd55d39017a
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-29use a less ugly string to double conversion, tdf#88740 follow-upEike Rathke
And check string length before accessing characters.. Change-Id: Iac3c2bf2f67f0cc7fc106515a875512771676e01
2015-01-29tdf#78854 do not crash when undoing layout changeDavid Tardon
It turns out that the ordinal number adjustment that was added for fdo#34548 is no longer necessary. Change-Id: I2c491a008500b6a269b6f05a2a72f5aa70edecb2
2015-01-28tdf#88740 fix sidebar angle rotation i18nAndras Timar
Change-Id: I30355f3aaf77b1952e21050e3593e575571d7aaa
2015-01-27tdf#82524: Mismatch of ValueSet and metric field valuesKatarina Behrens
Regression from commit ab50bc9d4a72193c1fefcbf0652938995094bc41 which adds space separator between value and unit. As metric fields now output values with separator, LineWidthValueSet items must be adjusted accordingly, otherwise they'll never match Change-Id: I55778c9c0cc36d968a061e5e35b6db3f2a159977
2015-01-27Lock SolarMutex around fmFormShell::DetermineForms callsStephan Bergmann
At least in JunitTest_forms_unoapi there are calls via URP of SfxShell::UIFeatureChanged FmFormShell::DetermineForms FmXFormShell::elementInserted cppu::OInterfaceContainerHelper::NotifySingleListener<...>::operator() cppu::OInterfaceContainerHelper::forEach<...> cppu::OInterfaceContainerHelper::notifyEach<...> frm::OInterfaceContainer::implInsert frm::OInterfaceContainer::insertByName frm::OFormsCollection::insertByName ... where SfxShell::UIFeatureChanged does an svtools::AsynchronLink::Call, and there are notorious crashes during JunitTest_forms_unoapi in vcl::Window::ImplRemoveDel Application::RemoveUserEvent svtools::AsynchronLink::~AsynchronLink SfxShell_Impl::~SfxShell_Impl SfxShell::~SfxShell FmFomrShell::~FmFormShell ... and the naive hope is that the former's unlocked operations cause some corruption that make the latter operate on a dangling AsynchronLink::_nEventId. (As always, the question is at which level to lock the solar mutex; frm::OFormsCollection et al appear to be properly mutex'ed, FmXFormShell appears to be virtually un-mutex'ed, except for some smelly m_aInvalidationSafety and m_aAsyncSafety, and FmFormShell and SfxShell appear to run under the assumption that the solar mutex is always locked. So stick the guards into FmXFormShell--- which is the only place calling DetermineForms---under the assumption that that is the most likely place needing general mutex clean-up in the future, and thus bears the highest chance the potentially becoming redundant guards will be noticed again.) Change-Id: Iad0f4bd9af2bf62330e26ac50edd170f470e79c4
2015-01-26coverity#1266476 silence Dereference null return valueCaolán McNamara
Change-Id: I1085d6df3af1198e0fc087da4058f705f13e2f61
2015-01-26coverity#1266440 Unchecked return valueCaolán McNamara
Change-Id: I84a9c08e539c98408d49b2f4276fb547d2deefd7
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-24Typo: syncro->synchroJulien Nabet
Change-Id: I0a377f3686e0f8d8f576aacbee49a392b039d3a5
2015-01-24coverity#1265796 Dereference null return valueCaolán McNamara
Change-Id: I779dacdb7fb18ba8148e932b4dc684d08f824cbe
2015-01-24coverity#1265799 Dereference null return valueCaolán McNamara
Change-Id: I7f1838b55d7b526327efb0562f3ad1ab5a1778a1
2015-01-22On init of DbCellControl, load value from ModelLionel Elie Mamane
This fixes a regression introduced by "fdo#88551 no need to update content from field when activating grid cell" that when switching from design mode to normal mode before one moved row at least once, the current cell (inevitably of the first row) was always displayed empty. Before, the update was done by the activation event (which was too often), so now we need to do it once at initialisation. Not sure if using updateFromModel instead of UpdateFromField makes a difference. Hope not. Else need to change that. Change-Id: I878dea0f91b370a4f83c3c1a3ed185a51ac9f0b7
2015-01-22fdo#88551 no need to update content from field when activating grid cellLionel Elie Mamane
It is already loaded correctly, and reloading leads to bogus TextChanged event. Change-Id: I9ad384ce60bbfd477199a1c9fb81e8e201a5162b Reviewed-on: https://gerrit.libreoffice.org/14096 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-01-21callcatcher: update unused codeCaolán McNamara
Change-Id: I225cbb3a4a66a8f20bec91c4770ad78e72b663b1
2015-01-20Some more loplugin:cstylecast: svxStephan Bergmann
Change-Id: I5eb4e1cae38decb293ea11f7cd4bfda0bad3afcb
2015-01-19Resolves: fdo#88417 Dropdown for ruler settings should show radio buttonsCaolán McNamara
This reverts commit 9995222d1141b326197a387cc7897b3971ce9e9a and additionally converts the ruler settings to radio buttons and not checkboxes Conflicts: vcl/source/control/tabctrl.cxx Change-Id: Ie0eac5f07729447942065b7f415398165fbf067c
2015-01-19initializeControlModel needs parent to be setLionel Elie Mamane
And thus it seems it expects to be called *after* insertion. Change-Id: I752dcd84c76c7beba75cd564162def5eaee7de4c
2015-01-19argh damnitMichael Stahl
Change-Id: I639d82ace116a09218cd71c62ac9e37efd6d957d
2015-01-19svx: ExternalToolEdit: don't terminate if SystemShellExecute throwsMichael Stahl
Change-Id: Ia527a2c9467e2ab097cf688164f4176a52fa1d36
2015-01-19svx: ExternalToolEdit: check that temp file is actually createdMichael Stahl
Change-Id: I03e49493c549561b4dc806f1e191a73d06733cff
2015-01-19Mistake in choice of FM_PROPJulien Nabet
Change-Id: Idb23bdefaf4abcbf4f7493c0dfea2abe84948023 Reviewed-on: https://gerrit.libreoffice.org/13982 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-01-19Fix typo code Resouce->ResourceAndrea Gelmini
Change-Id: I6e68c13e4513c2f8cc38e237646db7dffc88fe3b Reviewed-on: https://gerrit.libreoffice.org/13986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-03-25 03:36:30 +0000