summaryrefslogtreecommitdiff
path: root/svx/source
AgeCommit message (Collapse)Author
2023-01-31tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroektagoel12
Also change some range based for Change-Id: I2e17feaba7a6b219aa0c9126c5046cf3bdf855d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145988 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-01-31Some simplification after 743dd1d3c1142c1c99b0844cc26dd0be91a1de40Mike Kaganski
MapMode ctor taking origin and scales sets mbSimple to false, so avoid calling it when these are the defaults. Some calculations become unneeded when the fraction is (1, 1). Change-Id: I19a98ad2cac0a66b9bd7b72620180addb3f7fec4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146375 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-31svx: Refactor (sdr) views to access the SdrModel by referenceTomaž Vajngerl
In SdrPaintView (and subclasses) the mpModel variable is always the same as the input (reference) model, so there is no need for that extra variable. Change the strange and confusing var. name mrSdrModelFromSdrView (the input reference to SdrModel) to just mrModel and use that in GetModel(). Change the GetModel() to return a reference instead of a pointer and reactor the code to accomodate the change. This gets rid of many nullptr checks for the pointer that the GetModel() returns and makes the code more simple is some cases. Change-Id: I18351a417fd82f49262a83de036ec1420a65399c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146373 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-31SdrModel: we never set scale fraction to anything else than 1/1Tomaž Vajngerl
This removes the scale fraction on SdrModel - SetScaleFraction and the m_aObjUnit instance variable, as it is never set to anything else than 1/1 (and don't see it usefult to set it to anything else than this). Change-Id: I990d20f110b3be00e6770b68e39df212f9c576be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146348 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-30loplugin:virtualdeadNoel Grandin
GetPDFAnchorStructureElementId was added in commit 6e5d59c2ca696, but was unused even there Change-Id: Id0624cac2854f5406ca93a4c495632fc3c1d0e74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-30tdf#152726 Pasting Selection to Sheet as BMP Image, button test is largerNoel Grandin
regression from commit 720e4258ab5f00287098ff945a184bfb43911841 Author: Noel Grandin <noel@peralex.com> Date: Fri Aug 20 11:30:35 2021 +0200 use Primitive2DDecompositionVisitor in ViewObjectContact (tdf#105575) Revert the relevant piece, no idea what the underlying problem is. I suspect something is being tricksy and using settings from the current OutputDevice even though the point of the drawinglayer getPrimitive2DSequenceHierarchy is supposedly to be independant of that. Change-Id: I3026ff2ba5ce3751a4e4ebdf15954aae548493c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146352 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-30tdf#150534 reduce allocation in SdrFrameBorderPrimitive2DNoel Grandin
Change-Id: Ib55ce7882e87823cca95e00cb5ae990213d1e766 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-30tdf#150534 use unordered_set for checking of lines already crossedNoel Grandin
Change-Id: Ib864f9e8b7a3a2e6c4db5f2eec5333dc74bf9f6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146334 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-29svx: add prefix m to aPgOrg and rename to aPageOriginTomaž Vajngerl
Change-Id: I1df0c61aca724748680017472cde64832742eb97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146304 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-28Use ImplInheritanceHelper in SvxRectCtlChildAccessibleContextStephan Bergmann
Change-Id: I1e8fd8a9457925af7278e8006e7ad331f612b3ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146285 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-28Use ImplInheritanceHelper in SvxRectCtlAccessibleContextStephan Bergmann
Change-Id: I864a1c2571ce8642626d77b726f2fa6dfbdadf2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146284 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-28Use ImplInheritanceHelper in SvxPixelCtlAccessibleChildStephan Bergmann
Change-Id: I09d7004d6cf268831725435c5e634dedfa385a7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146283 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-28Use ImplInheritanceHelper in SvxPixelCtlAccessibleStephan Bergmann
Change-Id: I9509bfcbcc015876cba1c17e84e4de5e28de3cf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146282 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-28OAccessibleHelper_Base_2 is unusedStephan Bergmann
...ever since 374599f8c26713905a310673d2b429083321186a "weld SvxCharacterMap dialog" Change-Id: I955a399756c2802295168e07dfdfe30f1515a64c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146281 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-28Use ImplInheritanceHelper in SvxShowCharSetItemAccStephan Bergmann
Change-Id: I0baaac510afcbae5a8a9fa5886daa8b4f83145e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146280 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-28Use ImplInheritanceHelper in SvxShowCharSetAccStephan Bergmann
Change-Id: I9009b6168c66a1b340a34aaf804e097bfe614d21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146279 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-28Use ImplInheritanceHelper in AccFrameSelectorChildStephan Bergmann
Change-Id: Idab295d97650b158c34f0a11be79c932540e7526 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146278 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-28Use ImplInheritanceHelper in AccFrameSelectorStephan Bergmann
Change-Id: Iff6dc76c4fdc105127cde23ae478011da6ff6483 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146277 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-27Remove support for AIXStephan Bergmann
As discussed in the mailing list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2023-January/089808.html> "Plan to remove dead C++ UNO bridge implementations (bridges/source/cpp_uno/*)", the bridge implementation at bridges/source/cpp_uno/gcc3_aix_powerpc is apparently dead and should thus be removed. However, that was the only bridge implementation for AIX, which implies that support for the AIX platform as a whole is dead and should thus be removed. Change-Id: I96de3f7f97d4fd770ff78256f0ea435383688be9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146057 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-27move Theme class to own file inside docmodelTomaž Vajngerl
Also move Theme from svx to model namespace so it is consistent with other classes in docmodel. Theme header also includes ThemeSupplementalFont, ThemeFont, FontScheme classes that are used by the Theme and were also moved to docmodel. These may be moved to its own file in the future when they are used in more places. Change-Id: Ic409bea8e5298adc2b039b529c4f7b01cf64f03e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146221 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-27move ColorSet class to own file inside docmodelTomaž Vajngerl
Also move ColorSet from svx to model namespace so it is consistent with other classes in docmodel. Change-Id: Iacbdbdf5ece4015c628a0e45adf6a732b2d27777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146220 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-27use ThemeColorChanger also in svx, when changing theme for SdrPageTomaž Vajngerl
This refactors the code in the Theme class to remove code that is responsible for changing the color for the SdrPage and adds an implementation of IThemeColorChanger - svx::ThemeColorChanger, that is performing the same task from now on. The svx::ThemeColorChanger is also partially used in Writer by sw::ThemeColorChanger, when it needs to change the colors in the common (Sdr) objects. Change-Id: I39cfa278d31bdd802a5bf36eeaf6d472c8013dba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146173 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-26ofz#54906 TimeoutCaolán McNamara
Change-Id: I87a59723566c561cf84f5b5fb74bd8cf30801d16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146217 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-25Use ImplInheritanceHelper in OAccessibleSelectionHelperStephan Bergmann
(Explicitly deleting the special member functions is needed to avoid MSVC > include\cppuhelper/implbase.hxx(152): error C2280: 'comphelper::OAccessibleComponentHelper::OAccessibleComponentHelper(comphelper::OAccessibleComponentHelper &&)': attempting to reference a deleted function > include\comphelper/accessiblecomponenthelper.hxx(191): note: see declaration of 'comphelper::OAccessibleComponentHelper::OAccessibleComponentHelper' > include\comphelper/accessibleselectionhelper.hxx(120): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::star::accessibility::XAccessibleSelection>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::star::accessibility::XAccessibleSelection>>(cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::star::accessibility::XAccessibleSelection> &&)' being compiled > include\comphelper/accessibleselectionhelper.hxx(120): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::star::accessibility::XAccessibleSelection>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::star::accessibility::XAccessibleSelection>>(cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::star::accessibility::XAccessibleSelection> &&)' being compiled > include\cppuhelper/implbase.hxx(151): error C2248: 'comphelper::OAccessibleComponentHelper::OAccessibleComponentHelper': cannot access private member declared in class 'comphelper::OAccessibleComponentHelper' > include\comphelper/accessiblecomponenthelper.hxx(191): note: see declaration of 'comphelper::OAccessibleComponentHelper::OAccessibleComponentHelper' > include\comphelper/accessiblecomponenthelper.hxx(185): note: see declaration of 'comphelper::OAccessibleComponentHelper' ) Change-Id: I2414d9f777de42b62c33492a90299aa9a9d53699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-23tdf#153154: m_xDataTypeLB is still in useXisco Fauli
Regression from 2e7f77d3fe01e36222d5ad84c18d7d7537092972 "loplugin:unusedfields" Change-Id: Ic9435ee9417f812281ad75039d4ef88f508bad62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145999 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-20Fix TableColumn/-Row queryAggregationStephan Bergmann
The base FastPropertySet uses WeakAggImplHelper3, so (for better or worse) derives from XAggregation, but SbaXGridControl failed to properly implement the XAggregation protocol. Change-Id: I31378f13256b1fa20775890b206f455d782ea864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145868 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-20Base CellRange on WeakImplHelperStephan Bergmann
...rather than on the deprecated WeakAggImplHelper1. It was found that that class was implementing queryInterface in a way that is incompatible with the XAggregation protocol inherited via WeakAggImplHelper1. It looks like no code actually made use of the XAggregation offered by this class, so the easiest fix for this queryInterface implementation appears to switch from WeakAggImplHelper1 to WeakImplHelper (thereby dropping XAggregation, and thus rendering the existing queryInterface implementation OK). Change-Id: I2352f5a57f2e23e6c7d512ef4d850844149269c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145867 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-20Hide fill Attribute widget if fill style is noneGülşah Köse
When Fill style is none we can not use fill attribute element. So It is better to hide. Change-Id: I88d5e49448040b3afa18fbf66377d254716e7415 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145817 Tested-by: Jenkins Tested-by: Pedro Silva <pedro.silva@collabora.com> Reviewed-by: Pedro Silva <pedro.silva@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-20tdf#148000 impress: Handle linebreaks on fontwork.Attila Szűcs
Split text lines in a paragraph, right before polygons are created for rendering, so eol will brake line in fontwork just like eop. Change-Id: Ie9e6764f9f91c2e19afd43dc9a212bd18c41c99d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145425 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-19Fix SvxFmDrawPage et al getTypesStephan Bergmann
The implementation of SxvFmDrawPage::getTypes was presumably forgotten when e97beb270fd1a5121cdb69ffafd12ea04100e290 "NTEGRATION: CWS xmlperf02" changed SvxFmDrawPage from supporting XFormsSupplier to supporting XFormsSupplier2 (which derives from XFormsSupplier). And SwFmDrawPage uses ImplInheritanceHelper to derivefrom SvxFmDrawPage, so there should be no need to implement SwFmDrawPage::getTypes manually (and wrongly, at that, in that it included the types of SvxFmDrawPage twice, once directly via SvxFmDrawPage::getTypes(), and once indirectly via SwFmDrawPage_Base::getTypes()). Change-Id: I8c467f5a20e1f44396378abe9199851e646f6947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145772 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-18tdf#153088 format cells example text black on dark backgroundCaolán McNamara
with application colors, scheme: LibreOffice Dark enabled Change-Id: I465c97bf21b66c0122b59296d0c114bf115910ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145758 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-18XUnoTunnel->dynamic_cast in FmXFilterCellNoel Grandin
Change-Id: I7e875a9445fd24370d491315cb6a8aa42951f642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145702 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-18XUnoTunnel->dynamic_cast in ExplicitValueProviderNoel Grandin
Change-Id: I72b85a18d0a754f81a136fd79e56789aa926f425 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-16cid#1519046 Uninitialized scalar variableCaolán McNamara
bogus, but earlier return makes things easier anyway Change-Id: Id6c0a72b0ec9bbae061cc1f883b383fbef88e771 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145538 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-15Typo in "code"Andrea Gelmini
Not sure about this... Change-Id: I8aebfdf48dc7dc2bdbce180fa2f1bd3305489a24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145516 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-14svx: avoid divide by zero in SvxRuler::UpdateTabs()Xisco Fauli
Prevent lDefTabDist from ending up in a zero state. See https://crashreport.libreoffice.org/stats/signature/SvxRuler::UpdateTabs() Change-Id: I9335f3be12de5db4f4f0c3f434057d91f96733ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145457 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-14ThemeDialog added which allows to change the theme used by the doc.Tomaž Vajngerl
ThemeDialog is a common dialog that can be used to select the theme used by the document. Currently it only implements colors but in the future also the fonts and formats (for shapes) will be adde. The IThemeColorChanger interface is used by the dialog to change the actual color values inside the document. For the writer the existing ThemeColorChanger is now implementing the interface. The dialog is accessible in Writer at Format -> Theme... in the main menu. Change-Id: I23c7dc9668cdc5427f36d604a76c433d6dbef497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145264 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-14sw: rework ThemePanel, theme color ValueSet drawing as custom drawTomaž Vajngerl
Rework the ThemePanel to only work with theme colors, as fonts are uing an old mock implemntation of themes. To do this properly it is needed to remove the implementation for now. The theme colors entries were rendered as a bitmap and then shown in the ValueSet. This has the problem that it doesn't look sharp on a HiDPI screen, so replace that with a ThemeColorValueSet, which uses custom draw to render the theme color entries directly. The ThemeColorValueSet was added to th svx component as it will be used in other components as well. Change-Id: I1a727ef4cf4be4e215db57ac33f571f43aaddc15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145087 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-14svx: add UX defined theme color setsTomaž Vajngerl
Change-Id: I82cbe16fcfaa8367dacda7ff977e18b0ed39ec2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145086 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-14svx: add resolveColor that resolves the color for input themeTomaž Vajngerl
resolveColor added to ColorSet resolves the color for the input ThemeColor, which contains the index for the color in the ColorSet and applies all the additional tranformations defined in the ThemeColor. Change-Id: I5c6d53d5e1d2c61bdb22b0e58c034ec91fbeb2d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145085 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-14svx: change ColorSet add method to use ThemeColorTyp enumTomaž Vajngerl
Change-Id: I2034a7e915d41c6b55c8344d44be4f6a60e8287e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145072 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-13support theme color for lines + oox support + testsTomaž Vajngerl
Extended XLineColor to handle model::ThemeColor which then maps to the newly added LineColorThemeData property. Extended oox import and export to map the scheme color elements to and from ThemeColor. Added a new test to check the theme line color in impress shapes. Change-Id: I23ecc18c88b5b47608c9110f5681f189d02e2f36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145071 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-13tdf#153000: file types MSO_SPT=25 to 31 are wrongly renderedJulien Nabet
Description and analysis with MS ref + code pointer + solution here: https://bugs.documentfoundation.org/show_bug.cgi?id=153000#c0 all this thanks to Regina. Change-Id: I63a66e075bc67e3c7d833756026933b3447d0cd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145491 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-13XUnoTunnel->dynamic_cast in VCLXDeviceNoel Grandin
Change-Id: I9fa06600d3b9a2172a1818f89a3b9c06d65c8c54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145467 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13introduce {Char,Fill}ColorThemeReference which uses XThemeColorTomaž Vajngerl
Adds a unified UNO property for theme colors *ColorTheme (CharColorTheme and FillColorTheme) which uses XThemeColor, that replaces the properties *Theme, *TintOrShade, *LumOff, *LumMod. The properties are still present for backwards compatibility and to keep ODF support working in tests as that needs a bigger change. Reactor the code and tests to accomodate for this change. Change-Id: If7983decb4ba528b49fe7b5968aa9efc696a9efc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144783 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-12introduce docmodel comp., model::ThemeColor, use it in SvxColorItemTomaž Vajngerl
Added a new component docmodel, that has the document model types, which only depend on other basic components. This is needed so the types can be used in every relevant component - xmloff, oox, svx, editeng,... Introduces model::ThemeColor, which is a class used to store the theme color data, including transformations (svx::Transformation). For UNO use XThemeColor is added, and the implementation UnoThemeColor which wraps svx::ThemeColor, so it can be tranported around. Reactor all the code and tests to accomodate for this change. Change-Id: I7ce6752cdfaf5e4d3b8e4d90314afa469dd65cfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144847 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-12comphelper::OCommonAccessibleComponent's XAggregation is apparently unusedStephan Bergmann
It had been using WeakAggComponentImplHelper2 ever since 2f79d5f4794ec7f076bb290702b4c9c0afb2a6c8 "initial checkin - helper for implementing an XAccessibleContext", but all the classes that derive from it (comphelper::OAccessibleComponentHelper, comphelper::OAccessibleExtendedComponentHelper, and classes that in turn derive from those) implement queryInterface (in a way not just forwarding to the base class queryInterface, as would be required for classes implementing XAggregation) rather than queryAggregation, so aggregation was broken and any delegator would be ignored when calling queryInterface on one of the derived classes. Also, without this commit but instead with a local > --- a/include/comphelper/accessiblecomponenthelper.hxx > +++ b/include/comphelper/accessiblecomponenthelper.hxx > @@ -49,6 +49,7 @@ namespace comphelper > :public ::cppu::BaseMutex > ,public OCommonAccessibleComponent_Base > { > + void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); } > friend class OContextEntryGuard; > private: > css::uno::WeakReference< css::accessibility::XAccessible > m_aCreator; // the XAccessible which created our XAccessibleContext on all of Linux, macOS, and Windows: `make check` still succeeded, and running the resulting LibreOffice with the system in some assistive technology narration mode produced audio, all without hitting that injected assert that should have fired if the XAggregation mechanism had been used after all. Change-Id: I47045824d0762a5f3de150a11576694621b163b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145330 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-12drop internal support for 1-bit imagesNoel Grandin
on modern hardware, these are less efficient than regular alpha channels. Also, this greatly simplies the range of stuff that vcl needs to deal with, which will make the upcoming transparency->alpha patch easier to deal with. Enhance vcl::CreateFromData to convert incoming 1-bit data to 8-bit image. Change-Id: I35829da750029fe373d0d2911a669d10bab6ad23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-12Revert "tdf#56258 svx SetOutline: convert to toggle"Justin Luth
This reverts 7.6 commit a9b666b6b839735919923d8911f7e1efe0eb87b0. This causes too many unexpected things for the user. The biggest problem is that it does not join the previous list like the other numbering does. I suppose I could fix that by first calling a UNO command that joins/turns on numbering. However, that is a bit more dangerous with outline, since it modifies spacing / numbering on all levels, and joining can unexpected skip empty paragraphs etc. So best to just always treat the button as a dropdown to indicate to the user that they are applying an outline change. For the present I decided to leave the lighted-up aspect in place, so show that the outline is in effect. In terms of removing the list, which was the main reason for the change in the first place, there are several workarounds. The user has the option to go to "more choices" and remove, or select an all-1s choice and then remove that. Using the bullets button also is an easy option since it seems less restricted than numbering. The overall risk is no different from before, except that it is easier to make those kinds of levels now that the outline button is always available on the toolbar. Change-Id: I64e13f203ae65b2d2b28560ba747ca99d1456578 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145240 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-11svx typo: RelplaceNumRule -> ReplaceNumRuleJustin Luth
Change-Id: Ic11fcf35a7b1a6fb15a4046300639622095ed823 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145241 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
generated by cgit (git 2.34.1) at 2025-02-03 11:38:36 +0000