summaryrefslogtreecommitdiff
path: root/svx/source
AgeCommit message (Collapse)Author
2014-08-14Go even further in the scope reduction, we are 100% sure mpClone is NULL.Jan Holesovsky
Change-Id: Id5facbc817ecc0b89689dcba30672a6538e70945
2014-08-14Massive scope level reduction by early bail-out.Kohei Yoshida
Change-Id: Ie620208f02bf74844f9b7cb904f9c5abbb10ca07
2014-08-14Aligh this correctly...Kohei Yoshida
Also use 4-char tab space etc. Change-Id: I5ca007f58a588823ce9961af154cd97c25dd6f9b
2014-08-14Scope reduction by early bailout.Kohei Yoshida
Change-Id: If66f732265505a97990cf6c75ff53797a1d91b7a
2014-08-13WaE: C4245: signed/unsigned mismatchTor Lillqvist
Change-Id: I070123efc658484a54800743cdd447a1cd2f89d3
2014-08-12Consistency around SdrOnOffItem in svx/sxcaitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I1a88c73c8e4c764a6beadb8bb54910d868a12d93
2014-08-12Fix apparent SdrCaptionAngleItem vs. SdrCaptionFixedAngleItem mismatchStephan Bergmann
...though it was like that ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import" Change-Id: Ib3efe7bf7a559ede52966f4763a9f9e748b6ba6a
2014-08-11RID_SVX_MDLG_DOCRECOVERY_BROKEN conversion to .uiSzymon Kłos
Change-Id: Ic3ed2c73e255c99b48f4dab5ea434c75313ec93d Reviewed-on: https://gerrit.libreoffice.org/10865 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-11callcatcher: update unused codeCaolán McNamara
lots of ResID stuff going away now Change-Id: Iad8524e201cd3072db71da9e5ee1c244ed337967
2014-08-10Typo: delet=>deleteJulien Nabet
Change-Id: Ic0f4757fbd416bd7157b414b84a68b2541bc5b34
2014-08-08Cleanup OUStrings in CustomShapesJoren De Cuyper
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, removing stray left-over sSecondLightDirection declaration Change-Id: I5c7f5c956b70adad953b52be3d456775b0f5fbc1
2014-08-07coverity#735867 Dereference after null checkCaolán McNamara
Change-Id: I6dce94b0f6ad68e9e748b258cd511119201245b9
2014-08-07coverity#982278 Resource leak in objectCaolán McNamara
Change-Id: I0d0cf666ac8ecd55b4d3ba783b1e17670d6eb566
2014-08-07Consistency around SdrMetricItem in svx/sxmlhitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I65c36bde166c5f78db8c76364fd057017982fed6
2014-08-07Consistency around SdrYesNoItem in svx/sxmsuitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I25002e5b6043baa8c93b180a03f475bea5906e4f
2014-08-06Consistency around SdrMetricItem in svx/sxelditm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." (SdrEdgeLine1DeltaItem::Clone had been recently---and in retrospect needlessly ---introduced in 596ec6f52fe3a8d56d5c20df568633cfbcadc74d "Missing SdrEdgeLine1DeltaItem::Clone override" before 3efa3ad7b6de78c291f49858e50e6bedbd6a2173 "SdrEdgreLine*DeltaItem::Put/QueryValue are same as underlying" revealed that SdrEdgeLine1DeltaItem was a needless derivation of SdrMetricItem.) Change-Id: I154d32d46a7c01c792aa4e812cf576d4d749e0c9
2014-08-06SdrEdgreLine*DeltaItem::Put/QueryValue are same as underlyingStephan Bergmann
...CntInt32Item::Put/QueryValue Change-Id: I21602be0f4ba9d9e34a379a86d524b05976b0c8f
2014-08-06Missing SdrEdgeLine1DeltaItem::Clone overrideStephan Bergmann
Change-Id: Id0fde0a76fbcb63c13c943a0caec0d715886f039
2014-08-06Consistency around SdrOnOffItem in svx/sdasitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Icdeff7f37901f99158bb00de5e912c181bf3e688
2014-08-06remove some more unused resource idsThomas Arnhold
Change-Id: Ife159630b7e68e8e346619853b8285f46dcf275b
2014-08-06resource ids: defined twice but never usedThomas Arnhold
Change-Id: Icd6028d2b84db106351084936d00b44ad73f2592
2014-08-05Let GetObjectItemPool return a referenceStephan Bergmann
Change-Id: Ibbcfa3452afcf88dbb6050765e081a1be2381334
2014-08-05Fine to let GetObjectItemPool return just SfxItemPool*Stephan Bergmann
Change-Id: Id461dea979c394add57cbc4b1a50bc1a4c183d1b
2014-08-05Consistency around SdrOnOffItem in svx/sdshitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Id712c222034ef807ea2d7bc459e78882e948aca6
2014-08-04Consistency around SdrOnOffItem in svx/sdtagitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I6d8b3709d6d55bd6958d38f262141c43779dfdcc
2014-08-04prevent memory leakMarkus Mohrhard
Found by Lsan. Returning this or a heap allocated object asks for trouble. Let the caller handle it and return null instead of this. Change-Id: I7586e103bef5a8c2727adfe214b052d6962d4467 Reviewed-on: https://gerrit.libreoffice.org/10716 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-04suppress legacy locales, fdo#44112 relatedEike Rathke
With MsLangId::isLegacy() locales can be suppressed in language lists and are not offered unless actually used at the current position of the document. Language attribution now handles adding a language/locale to the list on the fly. For example, Serbian (Latin or Cyrillic) for "Serbia and Montenegro" are legacy locales, the confederation doesn't exist anymore. A further candidate would be pap-AN as the Netherlands Antilles ceased to exist, see fdo#44112. Suppressing "Serbian Cyrillic (Serbia and Montenegro)" also has the nice benefit of narrowing the language list box width a little ... Change-Id: Id05cce328622465016901524b759369c18bc4dbd
2014-08-04Consistency around SdrMetricItem in svx/sdtditm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Ib0234883d441be668700df5ccd0e855973dc5426
2014-08-01typo: more then -> more thanTakeshi Abe
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-07-31Consistency around SdrMetricItemStephan Bergmann
...where some instances of SDRATTR_TEXT_MINFRAMEHEIGHT etc. where SdrMetricItem while others where of trivial derived classes SdrTextMinFrameHeightItem etc., that appear to only existed for better-named constructors. Change-Id: If0af79fbb803275ed09fc7b950868c5de7d61615
2014-07-31typoStephan Bergmann
Change-Id: Ic8795d05f66b45bd43e3444f0f368a2e6352aa2c
2014-07-31cleanup usage of MapUnit enumNoel Grandin
some places were using the wrong enum constant, and some places were unnnecessarily converting to sal_Int16 Change-Id: I754993533c840cd33106820d99af2dc951f26a80
2014-07-31fix some dodgy FieldUnit conversionsNoel Grandin
the FieldUnit enum was being converted in some dodgy ways and in some places the MapUnit enum values were being used. Change-Id: Ic9aacb84058d1c14c3a4a79ef6676082df9a7270
2014-07-29drop use of SFX_ITEM_PRESENTATION_NONENoel Grandin
since none of the call sites specify it Change-Id: I9c15f0e042e21f6f78560c1962a533112d588c90
2014-07-29simplify return argument of SfxPoolItem::GetPresentationNoel Grandin
since all two of the actual call-sites only care about whether it is a valid presentation or not, not what kind of presentation it is. Change-Id: I75717c88878d37b2897741b0c833ff283b3fee59
2014-07-26Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'Matteo Casalin
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-25rhbz#1121254 reload font list from shell on changeDavid Tardon
Change-Id: Ief88373c210b3b6f65c1df5b31870aca561095bb
2014-07-25coverity#1209371 Division or modulo by float zeroCaolán McNamara
Change-Id: I8834b81b71746daaf97f7b62d09421d5165fa707
2014-07-23convert SfxItemState constants to a proper enumNoel Grandin
and while we're at it - use the enum type all over the place instead of passing around sal_uInt16 - don't use bitwise logic on enum values - use enum values instead of numeric constants Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-23simplify SfxItemPool::GetPresentationNoel Grandin
drop the ePresentation parameter, since all 4 of the callsites use SFX_ITEM_PRESENTATION_COMPLETE as the parameter value, and just inline the value into the method. Change-Id: I42c8eae82837c9f9d4edc886d7c760f57b129125
2014-07-22callcatcher: update unused codeCaolán McNamara
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-22fdo#76754 Speed up registration of new listeners to SfxBroadcasterTobias Lippert
Also change behavior for the GetListenerCount() method which now returns the count of listeners. The previous behavior is available in method GetSizeOfVector(). Change-Id: I5b03fa55a309f4ff5aea5e8830c137786fc07e89 Reviewed-on: https://gerrit.libreoffice.org/10344 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-07-20vcl consitent use of long for corrdinateNorbert Thiebaud
most of length in vcl are calculated in 'long' but array of X position tend to be in sal_Int32. As a prep work to be able to support 'double' as the base type of Device Coordinate, harmonize the use of 'long' for non-float coordinate. Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-19XFillStyle -> css::drawing::FillStyleMiklos Vajna
Change-Id: I6b2fabd72fd34f4ac1b3a18f386c90794bc39ce4
2014-07-18coverity#1215318 Uncaught exceptionCaolán McNamara
Change-Id: I784198cacba86fe1778e49ceebe574b9cbd6888b
2014-07-18coverity#1226494 Uninitialized pointer fieldCaolán McNamara
Change-Id: I88d0414ea6188e807aa347dce4567821e0b7c6f3
2014-07-18CharBackColor advertised in unoshap2.cxxmatteocam
Reviewed on: https://gerrit.libreoffice.org/10272 Change-Id: I696c152f9c053b745ab753a8899cc447eba8d1f8
2014-07-18inline unnecessary typedefNoel Grandin
Change-Id: Ie33e6b9038d6c18482c2ba7aa47f62d23973ab08
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-16Convert RID_OFADLG_OPTIONS_TREE to .uiPalenik Mihály
Conflicts: cui/source/inc/treeopt.hxx cui/source/options/treeopt.cxx Change-Id: I971c7760e7252321aeca8a4f403515562a9057bb Reviewed-on: https://gerrit.libreoffice.org/10323 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>