summaryrefslogtreecommitdiff
path: root/svx/uiconfig
AgeCommit message (Collapse)Author
2021-12-20Add graphic size checker for the preferred document DPITomaž Vajngerl
This change adds a graphic size checker, which checks all the images in the document, if they largely differ (outside of 50% and 110% of the image size) from the set preferred image DPI document setting. For all images that don't fall under this bounds, list them in the dialog and offer the posibility to select/goto the image and pop-up the properties dialog for the image to change its size. Change-Id: I06efce77c291fdb6ec3864d72c2f4d15dba9c42b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127094 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-11-19gtk3: default to an explicit constrain-to for PopoversCaolán McNamara
with the intent to do the same replacement with GtkWindow under X11 for gtk3 that we do in MenuButtons for the popover with direct popovers when the constraint is GTK_POPOVER_CONSTRAINT_NONE Change-Id: I629c30b44a9e362ba0d924bb229930b5f0dc7ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125540 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-16Related tdf#139031: add missing colonsIlmari Lauhakangas
Reporter mentioned a bunch of missing colons across the UI. Change-Id: I278d0ad7073fb399c979f0fc52adc306f51ae49d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125147 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-11-15add a rule to enforce always-show-image of True if an image is usedCaolán McNamara
If not set, then gtk3 will show the image if there is no text, but only the text if there's an image. For simplicity sake just enforce it as true if an image is referenced. Change-Id: Id4bb9140ba83e7e07e0d8ec5e3c29aece49b9087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-15Resolves: tdf#140250 don't share adjustments between differerent spinbuttonsCaolán McNamara
Change-Id: Ib684c746ff3176cf45ea9364efc12f2d6dde1f70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-05set placeholder imageCaolán McNamara
Change-Id: I9f20c7cc6aeb37609160808eac96cb23b5f6c36e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124760 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-05prepopulate numberingwindow.ui with a placeholder imageCaolán McNamara
Change-Id: Ic30ab5a8400fffbe62ce368279066e706a59d0e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124747 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-05add use-underline to labelCaolán McNamara
Change-Id: Ibf532754664c36e8d97fad41227bebf9b80d956a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124743 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-05resave with latest gladeCaolán McNamara
Change-Id: I2175c3e6b4e7ab1ff2d34b03aaeedda072ecd695 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124742 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31uniformly allow focus into GtkToolbarCaolán McNamara
Change-Id: I110daf882d9196cf7552e43a157ba4ae73fd670b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31gtk[3 vs 4]: remove can-focus from GtkToolButtonCaolán McNamara
so tab-cycling inside sidebar panel toolbars works as wanted It needs to be false for gtk3 and true for gtk4, leaving it unspecified gets a desired working default. Change-Id: I34869d5dcffc814f62ec2b717108f90c395a067b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-28center the content of the underline controlCaolán McNamara
Change-Id: If93af6e031bd108903d9528a43bd7e06fcd8340e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-28gtk[3 vs 4]: remove can-focus entirely from toolbarpopover.uiCaolán McNamara
so tab-cycling inside sidebar popovers work as wanted In gtk3 a can-focus of True means that tab-cycling doesn't work correctly as the container is seen as a candidate itself In gtk4 a can-focus of False means that focus cannot enter any child of it. So it needs to be false for gtk3 and true for gtk4, leaving it unspecified gets a desired working default. Change-Id: I423094657854ed02bc28496dfc9a30efa1e945da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124338 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-27tdf#145296 better fix to launch dialog when active radiobutton is clickedCaolán McNamara
this basically reverts commit 312a32f6b6c83c5747b617249d794fc87ffd8b9b tdf#145296 use a 'clickable' widget for custom spacing commit 592235d64d6f9638a61865712ca385ec58d688c4 tdf#145296 use a 'clickable' widget for custom depth and uses a mouse-release workaround to detect the case of clicking on an already active radiobutton which gives a result basically indistinguishable from the pre 7.2 experience Change-Id: Ic7ac6fa20843466b1d0c77586e25f4aabf814328 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124285 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26Related: tdf#145296 we have spacing images we can reuse hereCaolán McNamara
Change-Id: Id511f8b272f1b1460f9c6c6d5c2ed835780ee806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124166 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26tdf#145296 use a 'clickable' widget for custom spacingCaolán McNamara
Change-Id: I7c0b609a074a68dcc7ca4f6a775743e836a6caa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26tdf#145296 use a 'clickable' widget for custom depthCaolán McNamara
Change-Id: Ifb64e1bef2a0b216f97fe112115a997973201268 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124164 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-25resave with latest gladeCaolán McNamara
to normalize the property names and grid row/col comments. Taking care not to lose the non-standard explicitly empty labels for the GtkMenuButtons Change-Id: I015560f8b7eaa814e0540fbfbff9cfcb920b44b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-25Resolves: tdf#145297 assert on Docking3DEffects launchCaolán McNamara
(git show -w is your friend on commits like this) Change-Id: Ie3a11986f98d196b6134fdc69e76a627e87d137b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124161 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-19gtk4: resave textunderlinecontrol.ui with latest gladeCaolán McNamara
to move unparented GtkImages to the top so they are where the gtk3to4 conversion can easily find them during parse so decide whether GtkPicture or GtkImage is the right choice. Change-Id: I03f95befcd347c0fa77b617aa9125a6708b0090c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16add use-underline to spacing control labelsCaolán McNamara
set all entries to use the same icon-size Change-Id: Ibb949a039175ce2b93323bace7102a5f32aecfd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16resave with latest gladeCaolán McNamara
Change-Id: I0fae7cd556a6158787e139b0b419e6a7ead18658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123675 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16gtk4: focus can only enter popover if its parent widget can-focusCaolán McNamara
even though the popover is a separate toplevel window. Change-Id: I2ff799f0070b2233953af9e96c6eafeadb58b2cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-15resave with latest gladeCaolán McNamara
Change-Id: Ifbbb1e253996fdfd74ea792926b7eb9a22a5bd1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123673 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-15gtk4: focus can only enter popover if its parent widget can-focusCaolán McNamara
even though the popover is a separate toplevel window. just add can-focus for this one example first Change-Id: I6b4b2942cdf2ed4b25b3a07d36f96c72ffc6d825 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123671 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-15gtk4: gtk4 needs to have all parent widgets can-focus to allow focus into childCaolán McNamara
Change-Id: Ibb8be00ffe256f744787342b1aa748a6ac580b2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123670 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-15resave with latest gladeCaolán McNamara
only formatting changes intended Change-Id: Ifa00973dcc342e8d2adef4edb941e690384c8986 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123669 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-15let (Without) use-underlineCaolán McNamara
Change-Id: Idd5b5dc3cfadfc7e6de116c9403e214a6fb474ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123668 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08gtk4: set draw-as-radio as true for GtkRadioMenuItemsCaolán McNamara
Change-Id: I1a49a3f44f46ed57e80fa54af0e2b6466b2a9b4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123261 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08add 'destructive-action' to the yes of delete header/footer messageboxesCaolán McNamara
Change-Id: If4d22caac6d1c6ce12b22e0f3d4395f349539e36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123254 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15Fix some assorted mistakes in translatable stringsAdolfo Jayme Barrientos
Thanks Mihail Balabanov, Olivier Hallot and Tuomas Hietala for your keen eyes. Change-Id: Ibceeae6d82e39079c02140ac99729be1a1ab0407
2021-08-26tdf#139660 one of the group needs to be activeCaolán McNamara
in this case using ToolButtons instead of ToggleToolButtons will work ok Change-Id: I806a8fc409ae346dd6734be13d69c4b171e54c08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121121 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-23tdf#143919: Calc: add diagonal borders in Toolbar>BordersBayram Çiçek
In "Table toolbar > Borders" tab; - Borders UI column size increased to 5 - diagonal left border icon added to 5th place - diagonal right border icon added to 10th place - criss-cross border icon added to 15th place - added diagonal left and diagonal right borders feature - implemented removing diagonal borders when set "no border" - added criss-cross line feature - added a unit test for diagonal borders Change-Id: I2dd7ab797b1a191eb650cc6340ee57d39e45a1ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118951 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2021-08-20Convert AreaTransparencyGradientPopup to WeldToolbarPopupSzymon Kłos
Change-Id: I3cbb17de9953281e884f6c1b2984bc4865a56227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118471 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120700 Tested-by: Jenkins
2021-08-18jsdialog: dont use popular id for glow colorSzymon Kłos
to avoid confusing it on updates Change-Id: I2b19dc41a17e070ac1c8869d478c3b0b09a54223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118692 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120614 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-27Added the feature to store VCL test results as a zip filehomeboy445
The results can now be downloaded as a zip file, which would consist of the test log and all the resultant bitmap images produced by the tests compressed as png stored in the user directory folder. Change-Id: I8a6098a7454a621bbb9cafa7b6f2cafaa5503522 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117937 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-27jsdialog: hide adv search options on mobileSzymon Kłos
Change-Id: Ide206d602992c49a3a54c8635d97a1ce43cc216e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116912 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119524 Tested-by: Jenkins
2021-07-15resave with latest gladeCaolán McNamara
Change-Id: I76a4d8f77b39563d1f7c0a1b0387b69764437ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118975 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-15tdf#143355: fix crash with .uno:FontWorkJulien Nabet
with gen rendering part of bt: 2 0x00007fbfb39f440f in __assert_fail_base (fmt=0x7fbfb3b5d128 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7fbfac2531b0 "!w || dynamic_cast<T*>(w)", file=0x7fbfac2531ca "/home/julien/lo/libreoffice/include/vcl/builder.hxx", line=438, function=<optimized out>) at assert.c:92 3 0x00007fbfb3a03662 in __GI___assert_fail (assertion=0x7fbfac2531b0 "!w || dynamic_cast<T*>(w)", file=0x7fbfac2531ca "/home/julien/lo/libreoffice/include/vcl/builder.hxx", line=438, function=0x7fbfac3ad73e "T *VclBuilder::get(const rtl::OString &) [T = VclBox]") at assert.c:101 4 0x00007fbfabb27ace in VclBuilder::get<VclBox>(rtl::OString const&) (this=0x6e07e70, sID="DockingFontwork") at include/vcl/builder.hxx:438 5 0x00007fbfabb065e5 in SalInstanceBuilder::weld_box(rtl::OString const&) (this=0x6ce97c0, id="DockingFontwork") at vcl/source/app/salvtables.cxx:6811 6 0x00007fbfb07d3fe9 in SfxDockingWindow::SfxDockingWindow(SfxBindings*, SfxChildWindow*, vcl::Window*, rtl::OString const&, rtl::OUString const&) (this= 0x6e37c90, vtt=0x7fbfafd55730 <VTT for SvxFontWorkDialog+8>, pBindinx=0x34f62b0, pCW=0x6e39c00, pParent=0x34f6f40, rID="DockingFontwork", rUIXMLDescription="svx/ui/dockingfontwork.ui") at sfx2/source/dialog/dockwin.cxx:774 7 0x00007fbfaf7c3be8 in SvxFontWorkDialog::SvxFontWorkDialog(SfxBindings*, SfxChildWindow*, vcl::Window*) (this=0x6e37c90, pBindinx=0x34f62b0, pCW=0x6e39c00, _pParent=0x34f6f40) at svx/source/dialog/fontwork.cxx:179 8 0x00007fbfaf7c728c in VclPtrInstance<SvxFontWorkDialog>::VclPtrInstance<SfxBindings*&, SvxFontWorkChildWindow*, vcl::Window*&>(SfxBindings*&, SvxFontWorkChildWindow*&&, vcl::Window*&) (this=0x7ffc6e31bf70, arg=@0x7ffc6e31bf78: 0x34f62b0, arg=@0x7ffc6e31bf68: 0x6e39c00, arg=@0x7ffc6e31bf80: 0x34f6f40) at include/vcl/vclptr.hxx:279 9 0x00007fbfaf7c1dcc in SvxFontWorkChildWindow::SvxFontWorkChildWindow(vcl::Window*, unsigned short, SfxBindings*, SfxChildWinInfo*) (this=0x6e39c00, _pParent=0x34f6f40, nId=10256, pBindings=0x34f62b0, pInfo=0x7ffc6e31c230) at svx/source/dialog/fontwork.cxx:169 See full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=173585 with gtk3 rendering, no crash but: (soffice:33916): GLib-GObject-WARNING **: 20:40:33.018: invalid cast from 'GtkGrid' to 'GtkBox' put grid into a toplevel box (git show -w to see minimal diff) Change-Id: I05f9a295cd839f782467b85d6bafd652a405b14d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118953 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-08Related: tdf#143153 these are GtkBox properties not GtkGrid onesCaolán McNamara
nothing to do with the crash though Change-Id: If7645a904de9147d20f548017bf5390fc57af6cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118641 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-02add use-underline to color picker buttonCaolán McNamara
Change-Id: Ice9d2a155c4237b30134bd8faf7931ec980829e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118316 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-18tdf#141311: Rotation spinbox in sidebar used to have 2 decimal placesKatarina Behrens
regression from weld-ing (c85fcc6e1994eb8e079aaca85066ab4d67149c15) Change-Id: Iad0725fd4542ecdddb65092846dbf9d103016d9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117408 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2021-06-16xalign of 0.5 is already the defaultCaolán McNamara
so no need to make it explicit Change-Id: I933fd914a3a7c408b836a85fee7acb39e731990f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117320 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15editengine-columns: add sidebar property panelMike Kaganski
Change-Id: I90aefc10f9ddddeb64a65799480777bc4287abae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117107 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-14only one of the radiobuttons in a group should be activeCaolán McNamara
Change-Id: I0475bdd0633b54a644e205628577fac18a3af974 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14if active is set group shouldn't be setCaolán McNamara
Change-Id: I26db5a96f176df7bd2ef6ef83c40150856845383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117141 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-10Add extended tips to document classification dialogOlivier Hallot
Change-Id: I41ffe5c66e56ec7add2d4fcbb129ae2e3ff13b20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116915 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-02uniformly remove label-fill from GtkExpandersCaolán McNamara
Change-Id: Ife68cef7eeab0010c4d233c81e3bee808c2c1c28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116615 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02resave with latest gladeCaolán McNamara
Change-Id: Ia69d4feb059ece2068d0229887749e258bcacf70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116608 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26add privacy URL to crashreport dialog & updatecheck tab in optionsChristian Lohmaier
Change-Id: I35cda87c35876469bf581be223bc608e29f07b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116105 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>