summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-01-23lok: ui: more files to increase the 'step-increment'Henry Castro
property to 5. In mobile view, touch spin button should increment by 5 Change-Id: Ib3c8966443d053ab0588fa0c124f0daae31b7ed8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86844 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86854 Tested-by: Henry Castro <hcastro@collabora.com>
2020-01-23Remove redundant redefinition of RULER_TAB_RTLStephan Bergmann
...which is already defined (with the same value) in include/svx/ruler.hxx (which is unconditionally included here). (This conditional definition had been introduced with 80204d8fcf35c14168a75765360eb61977653162 "MWS_SRX644: migrate branch mws_srx644 -> HEAD", for reasons that are likely lost to history by now.) Change-Id: Ib9293d4077ca07e0253c584ba8d91ec4d683f509 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87280 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-23loplugin:unusedmethodsNoel Grandin
Change-Id: Ic2212a502bbd42217934884f4fce49f6f8d4765c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-23weld SvxFontWorkDialogCaolán McNamara
Change-Id: If9da7ad6a834d22f1bcab8d41ce7fe1f80168946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84774 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-23loplugin:unusedfieldsNoel Grandin
Change-Id: I59a63e81cf317094ad60a88d3cdd20fc426c93b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87235 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22flush out unused MapModesCaolán McNamara
Change-Id: I691143162bf9a26171f3ede3bded34c7fb985244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87207 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-22rework line style to be a wide toolbar buttonCaolán McNamara
involves converting SvxLineStyleToolBoxControl to a PopupWindowController because chart is doing interesting things in its panel there needs to be a non-standard way to report/detect the selected line style, which is then reused to disable/enable the arrows when none is selected/deselected in non-chart sidebars SvxLineBox becomes a toolbar dropdown instead of a combobox itemwindow linectrl.cxx split into linewidthctrl.cxx and linewidthctrl because SvxLineBox is now needed in svxcore Change-Id: Icf0ef5e612b894a43d389af8a2908138c2e9c580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87164 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21Sidebar position and size updateandreas kainz
Change-Id: I8a5a6f088f6b4dffd051ee577999d1d1eeff8a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87163 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-21Revert "Related: tdf#130035 let SvxLineEndWindow have a menubutton parent"Caolán McNamara
This reverts commit 08e633d777f1d2cf11a93ccb55f231d084f3220c. Reason for revert: unnecessary if we use the toolbar in the sidebar without bringing any menubutton into it Change-Id: I8392d01415af2f5e60aa70abe52e4809f52621fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21Resolves: tdf#130035 reuse toolbar for arrow styles in sidebarCaolán McNamara
Change-Id: I8fdbf97a2e3f535767f0163a87c99ead8a3198cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21drop unneeded includesCaolán McNamara
Change-Id: I0da7be0983f0dba87dbb3b8f335e27b0305d88fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87108 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21weld EmptyPanelCaolán McNamara
Change-Id: I17306b33f145c3b24a88a797c1a2133b19884f4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87121 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21remove duplicate arrow heads in listCaolán McNamara
Change-Id: If8769c0ce3ff0d438e5e4768d75d2dd8a32dbf57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87129 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21Related: tdf#130035 let SvxLineEndWindow have a menubutton parentCaolán McNamara
Change-Id: Id658dc0ac88d98ade67bdeb233eca6c912a3b253 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87133 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21make gallery listview seem faster to populateCaolán McNamara
Change-Id: I25b692c9594d73be9d81ff12df6b61a44c5a8256 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87107 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21arrow list is scrolledCaolán McNamara
Change-Id: I8d4a814e9bdba5dff248b73d2dd4b4e6b363ea1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87130 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21Related: tdf#130035 weld SvxLineEndWindowCaolán McNamara
Change-Id: Ib766ef431620eeeb65dec5ace57f2f4bd8fbd384 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87128 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21weld gallery panelCaolán McNamara
Change-Id: I4aebb3f90e9943044d106a507972c39434988f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21Drop empty eventhandler files from svx/Gabor Kelemen
Change-Id: I42e33999cbfc5a39bd79f2711c2df7ad13d14f1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86945 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-20tdf#129488 Fix Font size control enabled stateJim Raykowski
Set the enabled state of toolbox that contains the font size control to that of the font size control This patch was inspired by the code used to set the enabled state of the font name control in SvxFontNameToolBoxControl::statusChanged Change-Id: I50b7852e3cbb4c552fe8b38e7e6529b75e404ae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86040 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-18Sidebar text panel spacing updateandreas kainz
Change-Id: I7d4a26a9cb165ca862cbea14668bc4dc9c7e8d19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87019 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-18Sidebar list small updateandreas kainz
Change-Id: Ie8e4508f6fd0f3f54f4f01456eff6d980235338f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87021 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-18Removed executable permission on fileAndrea Gelmini
Change-Id: Ia16ee2f0c5e3b3293fdc6c1cf2ba4145e752fb11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86999 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-17Resolves: tdf#130045 dial control frame not hidden along with the controlCaolán McNamara
Change-Id: Idcdf3d748849fbe1ba1a6cce278373e349ba1e5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86967 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17limit table spinbuttons width for sidebarCaolán McNamara
to the same width as the paragraph sidebar spinbuttons Change-Id: I980545b4186b25cb5ada473095ece8c77f99420a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86992 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17show degree symbol in DialControl linked spinbuttonsCaolán McNamara
Change-Id: I792755f043109173606a78e947d5dc01f78c6849 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86982 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17drop unused GALLERY_USE_CLIPBOARD undefCaolán McNamara
Change-Id: Ic06d08d9316b079e89081de75fbb550e73c276cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17tdf#98584 Correct import draw:transform values skewY and matrixRegina Henschel
Covers tdf#98583 and tdf#98565 too. TRBaseGeomety (API) uses for skewX the same angle orientation as written to file. But that results in mathematically wrong matrices. Change sign where needed. Vertical shearing is converted and written to file by LO as sequence rotation * shear horizontal * scale. Same should happen on reading. Because LO does not write skewY itself, I have used the angle orientation, that was used in OOo1.1.5 and that is used in Scribus 1.5.4. Import generates a transformation matrix from the draw:transform attribute. That is a mathematically correct matrix. It is applied to the shape via TRSetBaseGeometry. But that uses a wrong sign in the shear angle. Therefore conversion of mathematical matrix to TRBaseGeometry matrix is needed. The draw:transform attribute can generate a scaling, which needs to be applied on top of the scaling made from svg:width and svg:height. Such happens on import of skewY() and might happen with matrix(). SdrPathObject puts scaling form svg:width and svg:height directly into the coordinates of its points. It had ignored any additional scaling. I have add a part to detect and apply it. Change-Id: I7636b9feec432cf403e7c6ef8dbd6a769793d144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86244 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-01-17Sidebarpossize update for smaler height and better sizingandreas kainz
Change-Id: Ib26994ad706343c7d94e18644937e66e185b0678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86948 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17weld SvxFrameWindow_ImplCaolán McNamara
which makes .uno:SetBorderStyle in sidebartableedit work again Change-Id: I51faa21530171a47ee78863ddb312e1d9996326c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17don't ping-pong trying to get the perfect size for this widgetCaolán McNamara
Change-Id: I5a0358c9898b3d71666ec7b019b41e6508b3a748 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17tdf#42949 Fix IWYU warnings in svx/source/[a-e]*/*cxx and svx/qa/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I68110cdc5cff99a3bc15184c04ae309412511f9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86633 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-17flush out unused Font objectsCaolán McNamara
Change-Id: Ifd6379b2cb6e5945ff509be8dc61c61bd70724c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17lok: don't render shape selection overlays in lok mode.Michael Meeks
These are rendered client-side, doing it twice is a bug; also rendering of dashed-lines via drawinglayer decomposition is extraordinarily slow, so avoid it. Change-Id: I821f14699abd6bc9e7a6759c81edded2f792677d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86934 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-17Sidebarparagraph update for smaler height and better sizingandreas kainz
Change-Id: I7fa3fe8f8156107f21a7cc7cbc86a32bbbe67549 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86949 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-16fix a crash in welded color toolbar menuCaolán McNamara
Change-Id: I7d11dfddc627e96710a6a16136292abefacc3ab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16always show icon in none/auto buttonsCaolán McNamara
Change-Id: I567c48c6e775a7ea2aa558253ba6ee35d2638e53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86930 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16focus something inside the gradient popupCaolán McNamara
Change-Id: I81f859a4e1fbb3c0a305683193556397167b70cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86917 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16drop some unneeded includesCaolán McNamara
Change-Id: I9d3a086d1d256f21da537bc96499243abd861090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86887 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16rename a createPopupWindow so we can remove 'using createPopupWindow'Caolán McNamara
Change-Id: I6e24d3f796b4b958513166ba2fd9e63239729375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86886 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15no remaining CreatePopupWindow returns non-nullCaolán McNamara
Change-Id: Ie342bd24222f622997d8dc2cda51ecb908fdb047 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86843 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15rework SvxUndoRedoControl to be a PopupWindowControllerCaolán McNamara
Change-Id: I78b4e03c76bc3aa8479013ae157a9e1316dcfecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15tdf#42949 Fix IWYU warnings in svx/source/*/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I2c846dba43bec95b2ef2739ee9c0940880f51c1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86621 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-15tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMesut Çifci
Change-Id: Ice7c0ecc8ee05a5c3b0af458ceeee8191bdde322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86752 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-15tweak GetBitmap methods in BitmapExNoel Grandin
so we return a const& for the normal case, just like other methods, which reduces copying. This revealed that CreateDisplayBitmap in Bitmap can be const. Change-Id: I9f9b9ff0c52d7e95eaae62af152218be8847dd63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15rework SvxColumnsToolBoxControl to be a PopupWindowControllerCaolán McNamara
and weld it, convert it and TableWindow to use two CustomWidgetController for the content widgets. Change the ColumnsWindow from an auto-grow width element to something with a fixed width and add a spinbutton to handle the overflow cases that don't fit in the fixed width Change-Id: I046a21dfd2a7c23828c4e2945b42c30db362b049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86812 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15lok: ui: increase the 'step-increment' property to 5Henry Castro
Change-Id: I1090a9f6435619f095ca22ef401c5e1bc9741d06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86820 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-01-15external: update pdfium to 4021Miklos Vajna
Change-Id: I1c3280e811bf65641bf559e3f01bc62e609548f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86811 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-15Sidebar expandable fixandreas kainz
Change-Id: Ie6398eeec89112caa9f27b278c4f267049c8b436 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86817 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15clang-tidy modernize-concat-nested-namespace in svxNoel Grandin
Change-Id: I8a00f2823aa956afb995ee68c9f995bf08ad5239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86824 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>