summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2022-05-17elide some OUString allocation and re-arrange GetCustomShapeEngineNoel Grandin
so we check if we have a shape before we try to do any work Change-Id: I9496e6fd38d7d7f312226791b942190c56e9d34e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134398 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-16tdf#149049 give media object a name when createdJim Raykowski
so it is shown in the Navigator Change-Id: Ia4e9c847a1a8cfbaa3465f1472d4b899f4bde3fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134334 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-05-14Fix typoAndrea Gelmini
Change-Id: If7581fbc808b985cbf6d81a2e66571ddc465f16e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134320 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14skip some SetResizeProtect work during constructionNoel Grandin
unnecessary to do all the work of firing ActionChanged etc at this stage Change-Id: I20aad96e16d7a1ae5176e868d3699080aa0bf6a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134304 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-13Advanced Diagram support: Secure Redo, evtl. flush Redo-StackArmin Le Grand (Allotropia)
Change-Id: Iade4ea85289377774e51671f1e9848c19d757633 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134245 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-05-13add SvStream::ReadLine(OStringBuffer... to reduce OString allocationNoel Grandin
and use it where possible Change-Id: I3efc7a642f73661ce606c917c0323ba9948521c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134265 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-11tdf#121740 just remove OLE_Objects limit for non-32-bit-WindowsNoel Grandin
shaves 5% off load time Change-Id: I1893180124ebe86babff1776d77a696ef1e4a190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134202 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-11tdf#149023 set property immediately on changeCaolán McNamara
and not in an idle which may be triggered on losing focus and arrive when a new shape is selected Change-Id: I7cec8f1c9bf864cdb30516dece1ef9d6b689a94e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-11Advanced Diagram support: UNDO/REDO support for Diagram DataModelArmin Le Grand (Allotropia)
Added support for UNDO/REDO for changes in Diagram ModelData. This is currenly applied/used in the DiagramDialog for it's Add/Remove actions (also supports Cancel of that dialog 1st time ever). But it is defined more general to add/support manipulating actions like clone/change_text etc. Also the UI/dialog at he end will not be/stay modal, so this is a test implemenation how to use it. It uses an extract/apply mechanism to get/set the Diagram ModelData at/for the UNDO action. That may be expanded as needed for additional data in he future. It may also be considered to modify the Connection/Point ModelData to shared_ptr internally completely to avoid copying these at all. OTOH it is not that much data to handle at all. Change-Id: I4702ed908b79a476177fe66c0e3284898c6adda5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134118 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-05-11avoid some OUString construction on some hot pathsNoel Grandin
Change-Id: I098b017d22b7a4502998a0901ddcfca08a57ee43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-10tdf#148519 correction to vertical "to frame" mapping for object positionSeth Chaiklin
The mapping for the anchor to frame was incorrect, possibly inherited from OOo. (Thanks to Regina Henschel for identifying this problem.) This patch changes the mapping and reverts 2c19246a4090df14e8f97c35c7770b25c1974232, which had attempted to correct the problem of what options were shown in the UI for Vertical Position for objects that are anchored "to frame". Change-Id: I30c35475a38824ebc1f926bf63542d19bdf008d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133871 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-05-10Fix stack-use-after-scopeStephan Bergmann
...during CppunitTest_chart2_export, > [_RUN_____] testStrict::Load_Verify_Reload_Verify [...] > ==20402==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7f220d8280d0 at pc 0x7f21a71c55cb bp 0x7ffc70fff650 sp 0x7ffc70fff648 > READ of size 8 at 0x7f220d8280d0 thread T0 > #0 0x7f21a71c55ca in sdr::contact::ViewObjectContact::getPrimitive2DSequence(sdr::contact::DisplayInfo const&) const /svx/source/sdr/contact/viewobjectcontact.cxx:361:22 > #1 0x7f21a71c440f in sdr::contact::ViewObjectContact::getObjectRange() const /svx/source/sdr/contact/viewobjectcontact.cxx:199:78 > #2 0x7f21a71c33f7 in sdr::contact::ViewObjectContact::~ViewObjectContact() /svx/source/sdr/contact/viewobjectcontact.cxx:165:9 > #3 0x7f21a71d0af8 in sdr::contact::ViewObjectContactOfSdrObj::~ViewObjectContactOfSdrObj() /svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx:51:1 > #4 0x7f21a70b6d08 in sdr::contact::ViewObjectContactOfGroup::~ViewObjectContactOfGroup() /svx/source/sdr/contact/viewobjectcontactofgroup.cxx:40:9 > #5 0x7f21a70b6d58 in sdr::contact::ViewObjectContactOfGroup::~ViewObjectContactOfGroup() /svx/source/sdr/contact/viewobjectcontactofgroup.cxx:39:9 > #6 0x7f21a71315e1 in sdr::contact::ObjectContact::~ObjectContact() /svx/source/sdr/contact/objectcontact.cxx:68:9 > #7 0x7f21a71e7108 in sdr::contact::ObjectContactPainter::~ObjectContactPainter() /svx/source/sdr/contact/objectcontactofobjlistpainter.cxx:43:1 > #8 0x7f21a71e77fc in sdr::contact::ObjectContactOfObjListPainter::~ObjectContactOfObjListPainter() /svx/source/sdr/contact/objectcontactofobjlistpainter.cxx:69:1 > #9 0x7f21a89793c1 in (anonymous namespace)::GraphicExporter::GetGraphic((anonymous namespace)::ExportSettings const&, Graphic&, bool) /svx/source/unodraw/UnoGraphicExporter.cxx:959:13 [...] > Address 0x7f220d8280d0 is located in stack of thread T0 at offset 4304 in frame > #0 0x7f21a896d04f in (anonymous namespace)::GraphicExporter::GetGraphic((anonymous namespace)::ExportSettings const&, Graphic&, bool) /svx/source/unodraw/UnoGraphicExporter.cxx:592 > > This frame has 89 object(s): [...] > [4304, 4320) 'aCheckVisibilityRedirector' (line 955) <== Memory access at offset 4304 is inside this variable (<https://ci.libreoffice.org/job/lo_ubsan/2394/>), presumably since db6c5c7f9dddd81a8f18a74d6051555680837adc "svx: calculate object range before using it" Change-Id: I77d56be1ca6bf16a0f5aa65cc1130547ae2fbf04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134103 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-09svx: calculate object range before using itPranam Lashkari
Change-Id: I01f0176542e9d6f36a2f7bbc870a9e337705a5a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133454 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit b604f17732b0b31d69781f812357d34f3da7175d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133486 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2022-05-07tdf#107765: Check the updated language and apply it to the cell.Kohei Yoshida
During the normal spell-checking in Calc, the user may change the language on the string segment with a spelling error, which is supposed to be applied back to that segment in the cell, but was not. This change should fix it. In case the new language is applied to the entire cell string, we will set the new lanuage to the cell as a cell attribute and keep the string as a simple string. Otherwise, the new language gets applied to the edit engine string. This commit also changes the return value of EditEngine::GetLanguage() to include the string span information in addition to the language value. Change-Id: I713ec7aefe571f721321cd8ea687f616ab4dd61a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133966 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2022-05-06avoid some ref-countingNoel Grandin
Change-Id: I11465f139044bc75085d1bb9a5f207889356ee58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133961 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-06svx: move SvxTableShape into own file and externalizeTomaž Vajngerl
Change-Id: I0c4b37ebafa56ed50286bdcec1f2a8d5e1362f8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133918 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-05-05tdf#148707 implicit moveTo on all not only on firstRegina Henschel
The current solution checks implicit moveTo only on the first arc in a sequence of arcs. The patch moves it into the loop, so that the implicit moveTo is done for each command in a sequence. Change-Id: I400fa8fc96d7377ede55296c71e7a82ce891cc24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133896 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-05-05loplugin:unusedvariableplusNoel Grandin
Change-Id: Id93086be1224b6f6bf0bdaa1d50b4f289099027e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133876 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05tdf#148818 Fix missing text in boxes with empty first paragraphHossein
Text was lost from the text boxes with empty first paragraph. The problem was happening when there was 2 paragraphs in a text box, in which the first paragraph was completely empty. The regression was introduced in cf2449aac0141711a7610d67f7c50cd108e12443 because of the bad handling of the paragraphs, and only looking at the size of the text of the first paragraph. This is fixed by looking at mpOutliner->GetEditEngine().GetTextLen(i) for all i=1..k where k=min(2,mpOutliner->GetParagraphCount()). I have negated the condition to provide a better explanation of what the condition should be. Change-Id: Id5d8787df5111c734760afdd98a6fbe832047f32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133527 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-05-05use more o3tl::getTokenNoel Grandin
found by inspecting call sites of OUString::getToken Change-Id: I4269c7476c7aa46fac39528227e350568f0eb34a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05tdf#148921 Smartart: Incorrect Text positionNoel Grandin
Revert commit b6fe3b13206eee0543ded37c3a1566add284e6da. no need to have two weak references to SdrObject in SvxShape Change-Id: Ie29d0002fd86226eb7634f621b43e7cb8dfc8aa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133833 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05sd theme: add ODP import/export for shape fill color effectsMiklos Vajna
Map a themed color with effects to: <style:graphic-properties draw:fill-color="..." loext:fill-theme-color="..." loext:fill-color-lum-mod="..." loext:fill-color-lum-off="..."> Change-Id: I18d8ddf8d6050ef468a8d67a9e797a576f682e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133843 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-05-03Just use Any ctor instead of makeAny in svxStephan Bergmann
Change-Id: I59b1b3f817a9028f132456ea5094f38f88674d00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133768 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-03Don't add empty labels to fontwork's icon viewMike Kaganski
This allows to center the icon in the respective entry, not having whitespace in the bottom Change-Id: Ib148df6911f020f8d4efca4f6a80a65b7f95945f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133720 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-05-03add o3tl::equalsAsciiNoel Grandin
Change-Id: I042b8dcadbf7581de325c161763fe35aecde5ca2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-01ofz#47111 TimeoutCaolán McNamara
Change-Id: Ic50978f5189ea2079d8cc2b5d0803ef4baf4ea4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133665 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-01use more string_view in variousNoel Grandin
found by examining uses of OUString::copy() for likely places Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-30tdf#148519 change positioning option "Margin" -> "Entire frame"Seth Chaiklin
A label for Vertical positioning, when an object is anchored "to frame" was mislabeled as "Margin" (for Shape). Change it to "Entire frame", which is also used for positioning Images. Change-Id: Ia001c22b5bdf2c74611948d23afa9566aab4078c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133290 Tested-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-04-30new loplugin:stringviewdangleNoel Grandin
to find places where string_view is pointing into a temporary String Change-Id: Ib530b36f441e95d83d8f687d40a97516a0806721 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133656 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-30tdf#148782 Left/Right frame border -> Left/Right of frame text areaSeth Chaiklin
Label was incorrect in Position dialog. Replaced with more accurate version. Change-Id: I5041e047ba52aa5df8628a3ca3491a39cdf27622 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133594 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-04-29fix regression in linked bitmap importNoel Grandin
from commit 0527778df5f1ace8731043d070cf54b7b8648545 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Aug 21 13:19:36 2020 +0200 use fastparser for fill styles spotted dodgy code while doing other work Change-Id: I339e8fbdb9df4d5f17ded76de199a3282f7c2d6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133621 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-29use more string_view in INetURLObjectNoel Grandin
Change-Id: I4462f7cf4740fa4d1b129d76a0775f4250f41bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-29tdf#148714 connect first and second arc with arcToRegina Henschel
The curved*Arrows start with two arcs, which should be connected by a line. The used commands are double V and double B respectively. Both have an implicit moveTo, so that there should be no line between. Other applications show the shapes correctly without line. But because of bug 148714 LO shows a connecting line so that the error was not earlier detected. The patch changes the segment definition so that for the second command the variant with implicit lineTo is used. This does not change rendering in LO but makes other applications rendering the shapes like LO. Change-Id: I4f799f89497e52b1a7e00d8e5345a66ce21c00a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133586 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-04-28tdf#148593 Rename two Horizontal "to" position options for Shape/ImageSeth Chaiklin
Left page border -> Left of page text area Right page border -> Right of page text area The CSS box model is the underlying idea here, where LO uses "page text area" for what is called "content area" in the box model. https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Model/Introduction_to_the_CSS_box_model The reference to "border" in the options was incorrect. The renamed controls refer to the regions to the left (and right) of the page text area. These regions can be used for horizontal positioning of shapes and images. Change-Id: I2ea8c682da8fb34b04496b3629819bf5201e86e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133403 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-04-28use more string_view in tools::SvGlobalNameNoel Grandin
Change-Id: I814744d250d6ce0ec7049daf215a506adb4f1ac5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133548 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-28sd theme: add PPTX import for shape fill color effectsMiklos Vajna
This is always direct formatting, so FillProperties::pushToPropMap() always has the needed info at hand. Change-Id: I3317b618e0e8bb7688d0f0fbfe4546e2e8b4e947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133525 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-27[ Edit Chart ] -> [ Edit Object ]Mike Kaganski
This button was introduced in commit 376cd2ceaeedd12a8050c5acd142cd9b9d5e731a Author Muhammet Kara <muhammet.kara@collabora.com> Date Wed Nov 20 15:30:01 2019 +0300 Add Edit Chart button for online's mobile view It is shown for any kind of OLE object, including Math. So make its text more neutral. Possibly it could make sense to construct the name from the OLE object's proper name in a follow-up. Change-Id: Ied2e9b10db3bcbfab4328a1f65f812cd52f85004 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133426 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-04-26add o3tl::toUInt32Noel Grandin
Change-Id: I07f11bf12fbe1d1c2d812fa0965d6e632e1e1aba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133437 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-26ofz#46901 TimeoutCaolán McNamara
Change-Id: I458ddb6ee4d7023f60c8d1c26699bbd74502ddc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133375 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-26Translatable string improvements I push so they don’t rot in my local cloneAdolfo Jayme Barrientos
Change-Id: Ic057769718790ced80daf24510d27aad49e3341b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132975 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-23tdf#148591 rename two Vertical positioning regionsSeth Chaiklin
Page text area top --> Above page text area Page text area bottom --> Below page text area Change-Id: I3a63ec09e6a3dfbd51385139ea89454bd1792a8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133288 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-22Fix typo in codeAndrea Gelmini
Change-Id: I289162ed8adf93139bbc69e8f5f4a1444dd52199 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133231 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-04-22sd theme: add rendering for shape fill color effectsMiklos Vajna
Only the no-effects variant was working previously. Change-Id: I50811a4c49d19dc801f0d1c841cbbdb2fae1ad60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133297 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-21tdf#55058 tdf#143875 EMF+ Fix display of dashed lines and line jointsBartosz Kosiorek
With previous implementation, empty spaces between dashes were too long. Additionally line joints were not working correctly, after EMF+ reworking: tdf#111486 This commit fixes all these issues and additionally it is covering it with tests. Change-Id: I9404e566d2d7d3405ab817268ad9b1f538c200eb Change-Id: I523f92a928ab592ff175d0d01c1ad1a3bc22e324 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133207 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2022-04-20tdf#148669: do not try to transform tail to unit rectangleMike Kaganski
... just to transform it back when it's used. The problem was that the transform had zero vertical scale; thus it couldn't be inverted. The unchanged matrix was used both in the SdrCaptionPrimitive2D constructor, and in its create2DDecomposition, thus scaling the X coordinate up twice. The result, which depends on the original value of X, was huge for comments attached to cells with large column numbers. Trying to convert such coordinate from pixels to logic units exceeded 64-bit integer range. Avoiding the transformations back and forth is possible, because the transform is constant in the object. This also avoids unneeded overhead. There is an open question why there was a need in the calculations for the XLSX file. The problem doesn't happen with ODS, so likely there is a calculation of the draw page size in some circumstances that may be avoided. Change-Id: Iccbe77936ec1078daf6b05b0b2d44a6fa3536c4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133217 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-04-20loplugin:passstuffbyrefNoel Grandin
Change-Id: I336fd329b577b6fa141265d8bc7ce67784bd7306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133210 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-20tdf#148501 color shades only for filled PolyPolygonsRegina Henschel
For shading parts of a shape not of Type 'ooxml-*', ColorData is used, introduced about 2005. For 'mso_spt*' shapes they are set directly, for others they are encoded as 'col-********' into the Type value. During OOo time two changes were made, resulting in the bugs, that colors are assigned to wrong segments and that shadings are too dark. More details are in the bug report. With this patch the colors are assigned to the correct segments again. The too dark colors are visible in our preset shapes 'Octagon Bevel'. The shape 'Diamond Bevel' with corrected color assignment is also affected. Both need new ColorData. Since it is important for Libreoffice to have good compatibility with OOXML, I have decided to use only the four shading values available in OOXML. In the long run, these shapes should be replaced by ones that contain the shading information inside the <enhanced-path> element. Change-Id: I4b8323c45bf702fc371d6e6c82dd9102d0fd9929 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133132 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-20Advanced Diagram support: Use better association Model<->XShapeArmin Le Grand (Allotropia)
To have a more direct and more reliable association between the XShape/oox::Shape and the model data svx::diagram::Point I added optional usage of the Model-UUID for that at the oox::Shape. Also added a 'fake' UUID to work with the BackgroundShape's attributes. Changed all preserve/rescue code to work based on that. Also cleanups/comments and preparations of some flags in the Diagram ModelData to steer behaviour on re-ceration. Change-Id: Ie30effdff34dcdbbc79a766de09157b2a3bd97d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133168 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-04-19tdf#148313 Basic IDE crashing while resizing dialogNoel Grandin
Change-Id: Ic68b78f26626f346f3ef8b54a584de64165d9eb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-17ofz#46782 TimeoutCaolán McNamara
Change-Id: I14129770c7fc8505c8060d79fa8bb9683a688a68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133107 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-21 21:45:41 +0000