summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2017-05-04convert EVAnchorMode enum to scoped enumJochen Nitschke
change values to match position in definition to their meaning Change-Id: Ia96e0c7e0c70c847dea518ef871608516542d3cb Reviewed-on: https://gerrit.libreoffice.org/37186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04loplugin:checkunusedparams in svx(part1)Noel Grandin
Change-Id: Ie98ec3be5ece2579feca050563c5ab7776ad6a7e Reviewed-on: https://gerrit.libreoffice.org/37227 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-03svx: SdrObjEditView::SdrEndTextEdit() must be called after SdrBeginTextEdit()Michael Stahl
... to prevent disasters with managing the UndoManager, so assert that. Change-Id: Id577ea465e21e3d358b3ff0bb36de0af34e0b69d
2017-05-03svx: SdrObjEditView is not the owner of mpOldTextEditUndoManagerMichael Stahl
In all of sc, sd, sw, the UndoManager returned by getSdrUndoManagerForEnhancedTextEdit() is owned by the application and SdrObjEditView should leave its grubby paws off of it. Change-Id: I7be3d336e0aaf4905323c1e99ff0643b3844f295
2017-05-03remove empty commentsNoel Grandin
found with: git ls-files | xargs grep -Pzl '/\*\* (\*|\s| )*\*/' Change-Id: I1f47bcb94d5a7b290a6c622c6941195fbb578597 Reviewed-on: https://gerrit.libreoffice.org/37159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02untranslated strings are just stringsCaolán McNamara
removes starmaths InsertCommand in favour of InsertCommandText Change-Id: I5659adcaa28e5b5861d1a1cc5d2afa84009490f6 Reviewed-on: https://gerrit.libreoffice.org/37113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-02loplugin:checkunusedparams in editengNoel Grandin
Change-Id: I2b770d40ac2339cd2b04a765a6d970675d2ea1c1 Reviewed-on: https://gerrit.libreoffice.org/37133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02create SfxGroupId based on o3tl::strong_intNoel Grandin
Change-Id: Iaccf16f29b6f4b1a2c712d1e5e2bd0fa4fdb5e71 Reviewed-on: https://gerrit.libreoffice.org/37108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-01unnecessary PairedList macroNoel Grandin
Change-Id: I54a6478522f03706b5d2d10b58857a3de2876ca8 Reviewed-on: https://gerrit.libreoffice.org/37118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-01Remove SlotType sdi propertyMaxim Monastirsky
sdi files have two ways to specify the type of a slot: (a) Put it at the beginning of the first line (b) Using the SlotType property Where (b) have higher priority, and (a) is actually ignored for "method slots" (i.e. the ones that have parameter parentheses, even empty, and therefore get the SfxSlotMode::METHOD flag), which is very confusing. The goal here is to make exclusive use of (a) for all kinds of slots, and eventually remove the SlotType support code from svidl (in a follow-up commit). Change-Id: Ib6654d34e2f8aa8ebd0bd3c41aa2a86e30e9a634
2017-05-01Return values of sdi "method slots" were unusedMaxim Monastirsky
Also expand nested methods. Only diff in workdir/SdiTarget is for SID_STYLE_WATERCAN from sw/sdi/_basesh.sdi which changed the .uno name from WatercanStyleModeOnOff to StyleWatercanMode, to match the name in sfx2/sdi/sfx.sdi (it was forced by svidl to have the same name). Change-Id: Iaeac9f4f10a36cb0b3afe3de2b6def8cd90edc6d
2017-04-29Avoid warning about FlushCustomShapeUnoApiObjectsJulien Nabet
See http://nabble.documentfoundation.org/Unknown-FlushCustomShapeUnoApiObjects-property-xmloff-svx-td4212940.html Change-Id: Ia82beb75015d09c847268c2f696b79fd8c395a29 Reviewed-on: https://gerrit.libreoffice.org/37012 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-04-29tdf#107505: Impress - crash with two people co-editing one slideTamás Zolnai
Deleting outliner view removes the pointed Cursor (pTECursorMerker). Change-Id: Iac17386d1d02bf52bd5322073e49da05c6e89d9b Reviewed-on: https://gerrit.libreoffice.org/37085 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-04-28loplugin:salunicodeliteral: svxStephan Bergmann
Change-Id: Ida6122d53ed5debc4da6b1649f61607df852af23
2017-04-28move builder attributes from OString to OUStringCaolán McNamara
Change-Id: I235188c9a086337b104e600f31a1c81deeca6c17 Reviewed-on: https://gerrit.libreoffice.org/37076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27tdf#39468 cleanup source code commentsdennisroczek
* translate German source code comments * remove ascii art * remove bogus source Code comments * remove old StarOffice/Sun internal bug tracker references Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451 Reviewed-on: https://gerrit.libreoffice.org/36005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27Translate German comments (rest of svx/ except svx/source/form/)Johnny_M
Change-Id: Ib0fccc41c71902861f450c6184f57be2c5da0811 Reviewed-on: https://gerrit.libreoffice.org/36804 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-27remove svx bitmaps from .src filesCaolán McNamara
Change-Id: Ie3795870484648e62dea483f9976af31cd1be167 Reviewed-on: https://gerrit.libreoffice.org/37006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26Change "check amout" -> "checksum"Olivier Hallot
Unit #126486444 Change-Id: Id40b26a022b21f379677de41b55603fff7cd862a Reviewed-on: https://gerrit.libreoffice.org/36823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-04-26clang-tidy readability-simplify-boolean-expr in svxNoel Grandin
Change-Id: I5190e453edd9fc2eda57f730834567e8e214ff16 Reviewed-on: https://gerrit.libreoffice.org/36931 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-26remove dead "chained editeng recursive overflow" codeNoel Grandin
been this way since original commit in commit 5b04c453cc03c0d2c6067625242f07deb8f78ba0 Author: matteocam <matteo.campanelli@gmail.com> Date: Mon Sep 7 12:44:37 2015 +0200 chained editeng: Change EndTextEdit behavior to support recursive overflow Change-Id: Id71db878b80457683f49349170e85bbabbd753f6 Reviewed-on: https://gerrit.libreoffice.org/36940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-26use strong_int for LanguageTypeNoel Grandin
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25Translate German comments in svx/source/fmcomp/Johnny_M
Change-Id: I7676188ecf8f344bc57297a1d834781047aae4b2 Reviewed-on: https://gerrit.libreoffice.org/36577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25make __RSC a builtin define for the RSC compilerNoel Grandin
instead of randomly defining it in only some of .src files Change-Id: Ifec3920740723d248400f451d717b5288c421b8d Reviewed-on: https://gerrit.libreoffice.org/36832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25lok: When we actually have the OutputDevice, prefer that.Jan Holesovsky
Writer invalidation functionality depends on this actually. Change-Id: I0933c56ff3999a09118112ccf49bf00062c42444 Reviewed-on: https://gerrit.libreoffice.org/36914 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/36915 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-04-24OUStrings: constify and avoid temporariesMatteo Casalin
Change-Id: I9d75924b414f21dacad2d72908c1e4e3af291672
2017-04-24Remove code commented-out since 2003-11-24Matteo Casalin
Change-Id: Iad2fb481969a1cc9cfd3e687b94ac99796466926
2017-04-23Replace GetImage with CommandInfoProvider::GetImageForCommandMaxim Monastirsky
And move ToolBoxButtonSize->ImageType mapping code to a common place. Change-Id: If158f4b6f2750054fcf64491c2941706e7d3a329
2017-04-23SID_FM_CONFIG isn't executableMaxim Monastirsky
It's only used to host a toolbox controller nowadays, and has no defined execute method in the sdi file. Change-Id: I20717d25190bb15b8ecff9d3a9038b05dac86b14
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21restore copy/paste menu entriesCaolán McNamara
Change-Id: Ie1dab6857dd6efdb816a11997ef32f0cc3497047
2017-04-21Fix an apparent copy/paste errorAdolfo Jayme Barrientos
Change-Id: Icc327dba2fe73c171d49811ee8d4d35a333f3178
2017-04-21tdf#103872 Localize "Export as image" window titleGabor Kelemen
In Calc select Export as image from the local menu of a chart to see this Change-Id: I9753f4750bd619f161c52f9e067290743ad2f2ec Reviewed-on: https://gerrit.libreoffice.org/36758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20Translate German comments (leftovers in svx/source/inc/, etc.)Johnny_M
Translated leftovers in: - svx/source/inc/ which slipped through on the commit 324adfcc2c3aa5d3590a38fadca2af7cd9125b47 (and a correction of "ist" to "list" in an unrelated comment) - svx/source/form/formcontroller.cxx which slipped through on the commit ea8f69e4a8ca8c3912aacb9838d7c5bb20b47f46 Change-Id: Ida5b3d0e685558bc2d8facba02fa80ae9e92eab3 Reviewed-on: https://gerrit.libreoffice.org/36648 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-19basic message is enough hereCaolán McNamara
Change-Id: Ifcd79abe8641894be836642586c65180cbaad8aa Reviewed-on: https://gerrit.libreoffice.org/36681 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-19remove freshly unused menu support from src filesCaolán McNamara
Change-Id: I038711a0c4d440d452d5b2ae1bfcba5c9305815b Reviewed-on: https://gerrit.libreoffice.org/36646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-19use union instead of void*Noel Grandin
vaguely more readable and typesafe Change-Id: I15e98034fb288756415913eff73bcaba4f2c0b9d Reviewed-on: https://gerrit.libreoffice.org/36659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-18remove sfx2/sfxcommands.hCaolán McNamara
Change-Id: Ic131adc90f2891497623441dd94da2d3401a93e5
2017-04-18remove extra entriesCaolán McNamara
Change-Id: I199f38cb7cc1c26c352b00c226aa041223848252
2017-04-18LOK - Calc: commit 92716ab follow-upMarco Cecchetti
This patch is a follow-up for commit: 92716ab (Images are not painted below row 1000). There is no need to set the origin to (0,0) when checking the view range / object range overlapping. Change-Id: Id9fe9364155edd5a50c2d60ab08dd0bdcd1f568a Reviewed-on: https://gerrit.libreoffice.org/36586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-04-18Translate German comments in svx/source/inc/Johnny_M
Change-Id: I7eef0061245460fa0b570eea36d4e415c4c6d716
2017-04-18convert filter menu to .uiCaolán McNamara
Change-Id: Iad9eeeedbd2b6c98861db367a68e3f5506cbd246
2017-04-18Translate German comments in svx/source/form/formcontroller.cxxJohnny_M
Change-Id: I5cfa09c08bad574269cf56ec7a57a57cd465c2d9 Reviewed-on: https://gerrit.libreoffice.org/36616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-18convert RID_FMSHELL_CONVERSIONMENU menu to .uiCaolán McNamara
Change-Id: I6b38611063690a4038862f3a2810dd3c695b62d2
2017-04-17make it possible to show crashreport error messageMarkus Mohrhard
This will allow us to show a warning that a specific version is not supported anymore and that people should update. Change-Id: Ie7f4e4c49efa9ed91725bf3a0512663b3b14178c Reviewed-on: https://gerrit.libreoffice.org/36589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>