summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2015-08-06tdf#92725 FormattedField: when model value is NULL, force empty display stringLionel Elie Mamane
as opposed to implicitly keeping whatever unrelated string was there before. Change-Id: Ifaf1b41e951e97f209ecb617b32ec4f7522b1d08 Reviewed-on: https://gerrit.libreoffice.org/17297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-08-06ListBox in grid: properly set selection on change from modelLionel Elie Mamane
In particular when changing row. 1) Teach DbCellControl about "SelectedItems" as known value property. 2) Fix DbListBox::updateFromModel to actually use the SelectedItems it reads from the model, as opposed to throwing it away. Change-Id: I7074c13b3d271bf2362aa059378aa857682a040b Reviewed-on: https://gerrit.libreoffice.org/17298 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-08-06svx, sd, sw: GetPoolDefaultItem() can actually return nullptrMichael Stahl
...if you call ResetPoolDefaultItem() first. Crash found by Varun Dhall. Change-Id: I409484c172fb5843270aee2425844076a008b4df (cherry picked from commit bcb1f81668d9b6a6d807ae32d60ccfce0b36ceb5) Reviewed-on: https://gerrit.libreoffice.org/17320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-08-06tdf#92600: Restore ability to apply font settings to controlsKatarina Behrens
SmShowSymbol handles font/fg/bg settings by itself, so make ApplySettings noop there. This partially reverts commit b010e4074e5d5ee3a3905f1351f04efafe937c2a Reviewed-on: https://gerrit.libreoffice.org/17288 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 94ceda8b2fea37587424b664e17fa9ee8b01e158) squashed commit from László Németh <laszlo.nemeth@collabora.com> tdf#92600 fix missing font preview in character set widget The previous fix for tdf#92600 (missing bold text in dialogs) brought back the regression in the special character set widget: the characters show always the default font of the Control class instead of the chosen font, see in the Insert->Special Character... dialog window of Writer. Change-Id: Ib5074684ef1277d9b9b4646bd73dce4cbff3943e 2bdc2300f481dd680877f84ea2a717b9e749c64c Reviewed-on: https://gerrit.libreoffice.org/17303 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-06tdf#92571: add mime types for several image file formatsCarlos Luque
The new mime types were added the followings: - eps -> image/x-eps - wmf -> image/x-wmf - bmp -> image/bmp - pct -> image/x-pct These new mime types are written in the attribute "media-type" of each image in the file "manifest.xml" Change-Id: I16edb625e331d3f917c6e8929df004191e317acc Reviewed-on: https://gerrit.libreoffice.org/17123 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 4d84153e22bdda33b23deb4c32afcace4c1264f7) svx: this was supposed to be "image/x-eps" Change-Id: Ieb9d7f23a0ef1e4546c488a678dbfde085156216 (cherry picked from commit 5351f621d5eb599757af95213c4b391c0f34df2e) Signed-off-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-08-06Resolves: tdf#63955 clip 19km long line to some sane limitCaolán McNamara
Change-Id: If9757a5fa2bb93b56b9cf9f566972f687a4a3a45 Reviewed-on: https://gerrit.libreoffice.org/17036 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d1046e7c3f66e5f3384ee1ef534ef28346702fc6) refactor ensuring polygon has at least a line in it just split that out into a standalone function, no logic change Change-Id: I061d5d716b3fc2a9fb6385e7fb249ce300752130 (cherry picked from commit 83b3349bb94d4c48db4da8fe5f8fdb9b19e633b9) Reviewed-on: https://gerrit.libreoffice.org/17073 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-06tdf#92645 svx rendercontext: fix missing paint on shape text editingMiklos Vajna
Change-Id: Icb70805969ccf55bd85fb38c03cf70c1e0b16554 (cherry picked from commit 40ade8d04380083e383d6a6e50e5c254fcde2b2f)
2015-08-06SdrPaintView::AddWindowToPaintView: take a vcl::Window, tooMiklos Vajna
Change-Id: Iedb296732c0819a1d6cdc1c59b3f1718e2cd6d38 (cherry picked from commit 9a11e59e5699c5eb0854355d3dd3848bc895545c)
2015-08-06SdrPaintWindow: optionally take a vcl::Window, tooMiklos Vajna
Change-Id: Ibf6c0cc2e6dc8fe6979632f6acb1b065984cd73f (cherry picked from commit 78c73f42c8079ed6d37784e68da5170c86a68616)
2015-08-06Related: tdf#92645 svx rendercontext: avoid direct paint on ending text editMiklos Vajna
If the Paint() is ~immediate after Invalidate() (which is the case since the main loop has priorities), it makes no sense to perform any kind of direct paint right after an Invalidate(). With this, we no longer hit the is_double_buffered_window() assert when returning to editing Writer text after editing draw shape text. Change-Id: I3b80ca08aa71d247fc0561133f907aef34de4001 (cherry picked from commit b05ff2cc713601730393123f6daa95e41df3b6ea)
2015-08-06Limit the font preview text length.Ashod Nakashian
When text is selected, the preview text is the first TEXT_WIDTH (80) characters of the selection rounded up to the next word. However when no word boundary is found, the preview text is as long as the selection, which causes the preview to be less than usable in some extreme cases. This patch is to limit the preview text length when no word boundary is found, thereby always resulting in predictable behavior. Change-Id: I8a21638d601714db956b9b160664dfe1e5e49a4a Reviewed-on: https://gerrit.libreoffice.org/16855 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c3c6bf235af32781e83d4fed2867a16bfeafa659) Signed-off-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-08-06tdf#92241 fix crashes and rendering of symbol set previewsLászló Németh
Change-Id: I43397f2b0caa31c334f87acf11fc96df2e051ad8 Reviewed-on: https://gerrit.libreoffice.org/16744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-08-06fix deselect of textbox on slides with images in underlying masterCaolán McNamara
The original work of tdf#55430 tries to select an object under another one on the second click, but these images are unselectable so this fails. Red Hat has a whole new shiny bunch of templates which have such images in their masters. Check if the object is selectable before continuing Change-Id: I182abaf50e8bb1084c5819dc9e1ffd8b386a9e93 (cherry picked from commit abbe4f9d64073d77c4be93b7c89c03d0651bacef)
2015-08-06SdrPaintWindow: no own buffer for rendercontext-enabled vcl::WindowsMiklos Vajna
The buffered overlay manager paints using a timer, which is problematic if the given vcl::Window already supports double-buffering itself, so always use direct (to the rendercontext) painting in that case. Change-Id: I93144c02814fd511f333224ab058374c7da369f0 (cherry picked from commit 25ade7450ce41a46094d63123eabdf32bd68c918)
2015-08-06Resolves: tdf#92275 impress grinds to a halt constant swapping imagesCaolán McNamara
This reverts commit 6c84442f99de109b585d3ba8964deb8dcf261c0f. "tdf#87820 Images not displayed properly in Calc" and replaces it with an alternative solution Change-Id: Iecb560d43767f0e41e442a307eefcdcecb7589ef (cherry picked from commit 2d196d0ee26b3840e56ec6537066a3b4a2f08691)
2015-08-06rendercontext: Mass fix of using the wrong size.Jan Holesovsky
In the paints, we must use the size of the Window for the computations, not of the RenderContext - the RenderContext can be much bigger than the Window in the double-buffering case. Fixes for example the list boxes, and many others. Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6 Reviewed-on: https://gerrit.libreoffice.org/16421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-08-06fix tabpage renderingLászló Németh
Change-Id: I2448787c306a8a4ba531c0560e0435fefadb4dc8 Reviewed-on: https://gerrit.libreoffice.org/16379 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-08-06rendercontext: Fix crash with double-buffering in the Styles combo box.Jan Holesovsky
Decouple the actual window from rendercontext in UserDrawEvent. Change-Id: Ic440c4e7f59fcffb7800c578146e8eb528cbb7b4
2015-08-06Avoid overflowing SetSizePixel computationStephan Bergmann
...near the end of SetupEntry, which appears to not be needed here Change-Id: Ia273df8a22d26974572d8e9be8de2a27936ee496
2015-08-06Simplify GetSize().Height() -> GetHeight()Stephan Bergmann
Change-Id: I8541eb13d82d887ef589a0545d36db88e47932e7
2015-08-06Fix: could not convert [...] ‘const char*’ to ‘const rtl::OUString’Tor Lillqvist
Change-Id: Ib94c9f5eed0da67e846705f5c2c233c10583c791 (cherry picked from commit a44b770b59d322083cac6ac22cef20ce17a89e6d) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-08-06Some missing SolarMutexGuard around VclPtr acquire/releaseStephan Bergmann
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so apparently rely on the SolarMutex being locked whenever they are called. Fixed those places that caused "make check" to fail for me when temporarily adding DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is that a class fails to ensure the SolarMutex is locked around the destruction of non-null VclPtr members.) Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5 (cherry picked from commit 8e1ad966262932516b3368d9b5c44becb29524d4) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-08-06tdf#73071: Styles tab addition to the sidebar for writerRishabh Kumar
Addition of .uno:StyleApply , .uno:StyleUpdateByExample and .uno:StyleNewByExample uno commands to the sidebar Change-Id: Iab6f1fb465066fce523fd376038a059189f1b842 Reviewed-on: https://gerrit.libreoffice.org/16279 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> (cherry picked from commit e436f31147c7eb75908a8750b0e4053c2efdca5b) Reviewed-on: https://gerrit.libreoffice.org/16306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-06tdf#88290 Adapt the numbering popup to more than 8 itemsMaxim Monastirsky
The items count of NumberingTypeMgr is limited by 8, but some languages have more items, so remove that limitation. Also fix the behavior of the 10th item. The old sidebar popup had a "None" item, whose id was 10 (defined by DEFAULT_NONE from include/svx/nbdtmg.hxx), and that causes now the 10th item to behave as on/off toggle. Since we don't have a "None" item anymore, get rid of that behavior completely. Change-Id: I5546ca637f9951cc093a7bbf8fda11dc35341d4e (cherry picked from commit 71b35212265bb93b10ca35ab964a36e6b6cc552b)
2015-08-06Related: tdf#87651 Swap buttons and align to the rightMaxim Monastirsky
Change-Id: I74d799f10d4a1d88256c683f913b8c639d2694c1 (cherry picked from commit 4331aa3cbab9ea7505e1d31ac674ee8ca5d9c314)
2015-08-06tdf#87651 Add outline buttons to impress sidebarMaxim Monastirsky
Change-Id: Id3cf58660bfcaf7424d027773894ce6888df788a (cherry picked from commit ef530d397b021a9606bb3b3abe8c2290a1d94c59)
2015-08-06tdf#91944 Fix inc/dec indent buttons in impressMaxim Monastirsky
Regression from ed6b7d972bf1aee323947f22c6b5de430db4a9a5. These buttons are implemented inside the sidebar, so just changing command names in the ui file won't work. Also, following the decision to use indent buttons across all modules, there is no need for 2 separate toolboxes anymore. Change-Id: Id9af0cd10fd0517be86b9793c187cd6508029732 Reviewed-on: https://gerrit.libreoffice.org/16199 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit a861a234b0f5f39b06fd6180655182c167c3a94d)
2015-08-06tdf#91727 - Unwind non-dispatch of idle handlers.Michael Meeks
This clobbers the functionality from commit: 06d731428ef6cf93c7333e8228bfb6088853b52f make idle timers actually activate only when idle Since now all rendering and re-sizing is done in idle handlers it does effectively the opposite of what was intended. A better solution would allow special-casing the processing of just rendering, re-sizing and window management to spin for eg. progress bar rendering. Also add helpful debugging labels to the idle & timeouts. Also cleanup the Idle vs. Scheduler handling. Also ensure that starting an Idle triggers a mainloop wakeup. Also add a unit test. Change-Id: Ifb0756714378fdb790be599b93c7a3ac1f9209e6
2015-08-06Resolves: tdf#92082 crash on closing color bar after redocking itCaolán McNamara
Change-Id: I015306a37abeaef17830ceab0f39cb2f3a98155c (cherry picked from commit 14aa5c58b8529f81c6ca12a18cbb77f63e27ba62)
2015-08-06tdf#90063 Avoid duplicated attribute names in RID_ATTR_NAMESZolnai Tamás
It causes trouble to localiztation tools and also makes hard to distinguish these items on the UI. e.g. Edit -> Find & Replace -> Other options -> Attributes. (cherry picked from commit dd79dbedd6c7f889f5e39f146a1927d235bc8a59) Change-Id: Ie7a17e02947200a570b5e6209c8a99d1883a6860
2015-08-06tdf#88295: Don't export transparent background colour as whiteKatarina Behrens
The fix is twofold: 1. retrieve transparency from colour in SvxBackgroundColorItem (add QueryValue, PutValue methods, use additional memberID to retrieve alpha channel as a bool property) 2. add CharBackTransparent bool property to Draw [text] shapes Change-Id: I6e14b81cc82f6b4d7fdd4756ff2e4f75e9270361
2015-08-06Setting Maximum Value for Transparency spin button in area sidebar tabRishabh Kumar
Change-Id: Idb1c5051de5ddb0501b8d1440f8abe62074296bc Reviewed-on: https://gerrit.libreoffice.org/16144 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-08-06add (and call before dtor) Commit to SvtSearchOptionsCaolán McNamara
i.e. follow up to commit 465359c35fcd8c30a2bedd3d0beb07c0c1c36cba Author: Michael Stahl <mstahl@redhat.com> Date: Wed Mar 11 16:39:24 2015 +0100 do not call virtual Commit() from dtors of utl::ConfigItem subclasses ~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not invoking its subclasses' ImplCommit() but its own. to avoid assert in SvtSearchOptions dtor Change-Id: I0eaf93450e1daddb81a9463f2c1df48a334dfb22 (cherry picked from commit 8d5a2116bc198f51ee394ca48c48f04ef4ba1658)
2015-08-06tdf#91840: Default to transparent text backgroundKatarina Behrens
(+ label the button) Change-Id: Ie2268d2a6ea0ceb1e8dd9e696db3b9ae613552a1 Reviewed-on: https://gerrit.libreoffice.org/16092 Reviewed-by: Philippe Jung <phil.jung@free.fr> Tested-by: Philippe Jung <phil.jung@free.fr>
2015-08-06Typo: Gourand → GouraudValter Mura
Change-Id: I6c5d4f97bce8f5b29d979e2508e691948e9399fb (cherry picked from commit 346dd51f1b861fc1228fa974c6815f66c5884998)
2015-08-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-06tdf#91702 - fix stack-based MessBox allocation.Michael Meeks
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-06Fix indent button icons in impress/draw sidebarYousuf Philips
Change-Id: Ib21c2489e1ff420e651e50a2731dfd3f16c9cef8 Reviewed-on: https://gerrit.libreoffice.org/16028 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit ed6b7d972bf1aee323947f22c6b5de430db4a9a5) Reviewed-on: https://gerrit.libreoffice.org/16037 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-08-06tdf#88276: toolbar|sidebar button for text background colourKatarina Behrens
Change-Id: I547a562384d30b95b744673feb284ccbcf50a614 Reviewed-on: https://gerrit.libreoffice.org/16030 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Philippe Jung <phil.jung@free.fr> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-08-06dispose SfxControllerItem objects correctlyLászló Németh
Change-Id: Id5f80e06e5609b4e85f3d6db7bc37aabe6ef0dac Reviewed-on: https://gerrit.libreoffice.org/15976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-01Partially revert "svx, canvas, desktop: gb_OBJCXXFLAGS are not needed at all"Andras Timar
This reverts commit 601d7d38628bf93218fba15249c4654ae24e7396. desktop and svx need these flags in case of OS X sandboxing Change-Id: Ib811aa53bc2d71839961cdcea0dd4836ebdbc38c
2015-06-15sdr tiled rendering: stop animation timer's taskHenry Castro
Change-Id: Ia7281c853454e283150bba3c79aa9579363c7ca3
2015-05-29convert WINDOW_POSSIZE constants to scoped enumNoel Grandin
Change-Id: Id85137ffc7309a66b04132d588d289db136117b9 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert WINDOW constants for GetWindow() methods to scoped enumNoel Grandin
Change-Id: I0c7c6d095732704eb4ab48f1277a0592b1c7fa33 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert constants in include/vcl/settings.hxx to scoped enumsNoel Grandin
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3 Reviewed-on: https://gerrit.libreoffice.org/15828 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert POINTER constants to scoped enumNoel Grandin
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-28tdf#91653 Give this command a saner nameAdolfo Jayme Barrientos
Change-Id: I0cd1d51d1e16019c87e0c615c046a553eb5dc138 (cherry picked from commit ef2e135cfb8f107a154aaab9b54f2dfca0edf6a0)
2015-05-28Rewrite all calls like Dialog(params).Execute()Philippe Jung
Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-28Resolves tdf#67712 form controls and draw objectsHenry Castro
anchored to cell but changes position after reopening Also included tdf#68797 "FILEOPEN lost position of lines anchored to cell". It was marked as duplicate but the step to reproduce are different. Conflicts: sc/qa/unit/subsequent_filters-test.cxx Conflicts: sc/qa/unit/subsequent_export-test.cxx Reviewed-on: https://gerrit.libreoffice.org/15523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 487880b6882ec01c1b4679eae60bec484272a86b) Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: Ia1c4010f118749256077a0ecad6ca16b867d22f7
2015-05-27Fix accidental mis-uses of VclPtr address-of operatorStephan Bergmann
Change-Id: I3a82423378d3198a25f90ddfbf42af55d85c96fb (cherry picked from commit 668408fa1c69eaf0f0a37f24e2ec8b4a38fe3db7, w/o the accidentally included sw/htmlexport-swobjects.patch)
generated by cgit (git 2.34.1) at 2024-07-12 01:18:13 +0000