summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2014-08-06Consistency around SdrMetricItem in svx/sxelditm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." (SdrEdgeLine1DeltaItem::Clone had been recently---and in retrospect needlessly ---introduced in 596ec6f52fe3a8d56d5c20df568633cfbcadc74d "Missing SdrEdgeLine1DeltaItem::Clone override" before 3efa3ad7b6de78c291f49858e50e6bedbd6a2173 "SdrEdgreLine*DeltaItem::Put/QueryValue are same as underlying" revealed that SdrEdgeLine1DeltaItem was a needless derivation of SdrMetricItem.) Change-Id: I154d32d46a7c01c792aa4e812cf576d4d749e0c9
2014-08-06SdrEdgreLine*DeltaItem::Put/QueryValue are same as underlyingStephan Bergmann
...CntInt32Item::Put/QueryValue Change-Id: I21602be0f4ba9d9e34a379a86d524b05976b0c8f
2014-08-06Missing SdrEdgeLine1DeltaItem::Clone overrideStephan Bergmann
Change-Id: Id0fde0a76fbcb63c13c943a0caec0d715886f039
2014-08-06Consistency around SdrOnOffItem in svx/sdasitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Icdeff7f37901f99158bb00de5e912c181bf3e688
2014-08-06remove some more unused resource idsThomas Arnhold
Change-Id: Ife159630b7e68e8e346619853b8285f46dcf275b
2014-08-06resource ids: defined twice but never usedThomas Arnhold
Change-Id: Icd6028d2b84db106351084936d00b44ad73f2592
2014-08-05Let GetObjectItemPool return a referenceStephan Bergmann
Change-Id: Ibbcfa3452afcf88dbb6050765e081a1be2381334
2014-08-05sidebar: don't stretch icons verticallyMaxim Monastirsky
fix a regression in master. Change-Id: I0fd0980225bdfd43cba884f145bcc7ebb8c05d85
2014-08-05Fine to let GetObjectItemPool return just SfxItemPool*Stephan Bergmann
Change-Id: Id461dea979c394add57cbc4b1a50bc1a4c183d1b
2014-08-05Consistency around SdrOnOffItem in svx/sdshitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Id712c222034ef807ea2d7bc459e78882e948aca6
2014-08-04Consistency around SdrOnOffItem in svx/sdtagitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I6d8b3709d6d55bd6958d38f262141c43779dfdcc
2014-08-04prevent memory leakMarkus Mohrhard
Found by Lsan. Returning this or a heap allocated object asks for trouble. Let the caller handle it and return null instead of this. Change-Id: I7586e103bef5a8c2727adfe214b052d6962d4467 Reviewed-on: https://gerrit.libreoffice.org/10716 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-04suppress legacy locales, fdo#44112 relatedEike Rathke
With MsLangId::isLegacy() locales can be suppressed in language lists and are not offered unless actually used at the current position of the document. Language attribution now handles adding a language/locale to the list on the fly. For example, Serbian (Latin or Cyrillic) for "Serbia and Montenegro" are legacy locales, the confederation doesn't exist anymore. A further candidate would be pap-AN as the Netherlands Antilles ceased to exist, see fdo#44112. Suppressing "Serbian Cyrillic (Serbia and Montenegro)" also has the nice benefit of narrowing the language list box width a little ... Change-Id: Id05cce328622465016901524b759369c18bc4dbd
2014-08-04Consistency around SdrMetricItem in svx/sdtditm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Ib0234883d441be668700df5ccd0e855973dc5426
2014-08-01typo: more then -> more thanTakeshi Abe
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-07-31Consistency around SdrMetricItemStephan Bergmann
...where some instances of SDRATTR_TEXT_MINFRAMEHEIGHT etc. where SdrMetricItem while others where of trivial derived classes SdrTextMinFrameHeightItem etc., that appear to only existed for better-named constructors. Change-Id: If0af79fbb803275ed09fc7b950868c5de7d61615
2014-07-31typoStephan Bergmann
Change-Id: Ic8795d05f66b45bd43e3444f0f368a2e6352aa2c
2014-07-31cleanup usage of MapUnit enumNoel Grandin
some places were using the wrong enum constant, and some places were unnnecessarily converting to sal_Int16 Change-Id: I754993533c840cd33106820d99af2dc951f26a80
2014-07-31fix some dodgy FieldUnit conversionsNoel Grandin
the FieldUnit enum was being converted in some dodgy ways and in some places the MapUnit enum values were being used. Change-Id: Ic9aacb84058d1c14c3a4a79ef6676082df9a7270
2014-07-29drop use of SFX_ITEM_PRESENTATION_NONENoel Grandin
since none of the call sites specify it Change-Id: I9c15f0e042e21f6f78560c1962a533112d588c90
2014-07-29simplify return argument of SfxPoolItem::GetPresentationNoel Grandin
since all two of the actual call-sites only care about whether it is a valid presentation or not, not what kind of presentation it is. Change-Id: I75717c88878d37b2897741b0c833ff283b3fee59
2014-07-26Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'Matteo Casalin
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-25rhbz#1121254 reload font list from shell on changeDavid Tardon
Change-Id: Ief88373c210b3b6f65c1df5b31870aca561095bb
2014-07-25coverity#1209371 Division or modulo by float zeroCaolán McNamara
Change-Id: I8834b81b71746daaf97f7b62d09421d5165fa707
2014-07-23convert SfxItemState constants to a proper enumNoel Grandin
and while we're at it - use the enum type all over the place instead of passing around sal_uInt16 - don't use bitwise logic on enum values - use enum values instead of numeric constants Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-23simplify SfxItemPool::GetPresentationNoel Grandin
drop the ePresentation parameter, since all 4 of the callsites use SFX_ITEM_PRESENTATION_COMPLETE as the parameter value, and just inline the value into the method. Change-Id: I42c8eae82837c9f9d4edc886d7c760f57b129125
2014-07-22callcatcher: update unused codeCaolán McNamara
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-22fdo#76754 Speed up registration of new listeners to SfxBroadcasterTobias Lippert
Also change behavior for the GetListenerCount() method which now returns the count of listeners. The previous behavior is available in method GetSizeOfVector(). Change-Id: I5b03fa55a309f4ff5aea5e8830c137786fc07e89 Reviewed-on: https://gerrit.libreoffice.org/10344 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-07-20vcl consitent use of long for corrdinateNorbert Thiebaud
most of length in vcl are calculated in 'long' but array of X position tend to be in sal_Int32. As a prep work to be able to support 'double' as the base type of Device Coordinate, harmonize the use of 'long' for non-float coordinate. Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-19XFillStyle -> css::drawing::FillStyleMiklos Vajna
Change-Id: I6b2fabd72fd34f4ac1b3a18f386c90794bc39ce4
2014-07-18coverity#1215318 Uncaught exceptionCaolán McNamara
Change-Id: I784198cacba86fe1778e49ceebe574b9cbd6888b
2014-07-18coverity#1226494 Uninitialized pointer fieldCaolán McNamara
Change-Id: I88d0414ea6188e807aa347dce4567821e0b7c6f3
2014-07-18CharBackColor advertised in unoshap2.cxxmatteocam
Reviewed on: https://gerrit.libreoffice.org/10272 Change-Id: I696c152f9c053b745ab753a8899cc447eba8d1f8
2014-07-18inline unnecessary typedefNoel Grandin
Change-Id: Ie33e6b9038d6c18482c2ba7aa47f62d23973ab08
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-16Convert RID_OFADLG_OPTIONS_TREE to .uiPalenik Mihály
Conflicts: cui/source/inc/treeopt.hxx cui/source/options/treeopt.cxx Change-Id: I971c7760e7252321aeca8a4f403515562a9057bb Reviewed-on: https://gerrit.libreoffice.org/10323 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-16coverity#707280 Uncaught exceptionCaolán McNamara
Change-Id: I764f6472903e6aebef55af1e96c4941e8429d18f
2014-07-15Related: fdo#80633 we can retain cached size for visibility changeCaolán McNamara
we still need to invalidate the layout of our parents, but we can keep the cached optimal size Change-Id: I8e77366bd61ff45d34f9d411c7f501a3a9ccbd4e
2014-07-14Related cp#1000084: Make this work for other apps too and set proper defaultMatúš Kukan
Extend d98c817cc71e62a2beecc7142062f9ef33a7149b and fix default. Change-Id: I79ad35bd5ad6fbd6e7d260864d4bf40fafb6b604
2014-07-11bnc#883684: Better fix for this.Kohei Yoshida
Instead of making all chart objects exempt from unloading, check each OLE object on whether or not it already has its persistent storage created. If not, don't unload it else it would have nothing to load back from once unloaded. Change-Id: I2312e86c9376d3699ef4aa1e0cf2f4c04f706c1e
2014-07-11new loplugin: externalandnotdefinedNoel Grandin
Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11drop unused helpidsCaolán McNamara
Change-Id: Ie684da5922d9f645495a1965b9462d0ae2de2342
2014-07-11RID_SVX_XFORMS_TABPAGES conversion to .uiSzymon Kłos
Change-Id: I0f3647e95b2150eb8753aa333eeb492fee76bd2a Reviewed-on: https://gerrit.libreoffice.org/10192 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-11Clean up usage of 'this' and constness.Matúš Kukan
Change-Id: I35085bebdec47598a5f927924b429b02b44c0e65
2014-07-11Allow to move only callout handle with shift key (cp#1000084)Matúš Kukan
When line callout was used, you couldn't move the point next to the rectangle. Now it's possible with shift key pressed. Change-Id: I70565e4e3f80daf0e1007031ef7d49036fb0e26b
2014-07-10Move the rest of the members to the impl class.Kohei Yoshida
Change-Id: I80186a617c751420954b27e070559cc8487c7fd9
2014-07-10Move "prog name" (whatever it is) to the impl class.Kohei Yoshida
Change-Id: Ifa4f2f2f923d4800cf5fd540631204492ace1936
2014-07-10pGraphicObject -> mpGraphicObjectKohei Yoshida
Change-Id: I8b396ff1018fb54eecd44624a11bc2e405bb7f84
2014-07-10Move Graphic member to the impl class.Kohei Yoshida
Change-Id: Iee58a6c9b7081a2aa00f6f050574a5827840286b
2014-07-10Head cleanup - use forward declarations.Kohei Yoshida
Change-Id: Icc4fa0acad77d61200eb77cc70e21866590b658e