summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-08-15remove constructor with plain Bitmap from Graphic, use BitmapExTomaž Vajngerl
Change-Id: Ie429a10a8f54c6779d437ee4bc75a5ea0c427848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100727 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-14loplugin:simplifybool moreNoel Grandin
look for expressions like !(a && !b) which can be expanded out Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14tdf#135550 FmXListBoxCell does need to implement XListBox after allCaolán McNamara
regression since... commit 0677d46bcc56c1f6c27b9331662990b38fd452d6 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed May 20 15:22:56 2020 +0100 FmXListBoxCell doesn't need to implement css::awt::XListBox It seems just addItemListener/removeItemListener are needed, stub the rest to make sense just for single-selection mode and avoid the return of the apparently unused multi-selection complexity Change-Id: I46a32bdd23d44273da37cc21cfa45de907674f31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100746 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-14tdf#135550 make XListBox Item status changed event work againCaolán McNamara
Change-Id: I9a5fe6a097c5d06e3ac3ab6c4c77cbe082d1a17d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-14inline some use-once typedefsNoel Grandin
Change-Id: Ifefdb1ad20d09e257064171e458b2eb33065f5de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100733 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14rename xmlnmspe -> xmlnamespaceNoel Grandin
Change-Id: I8fdf9833dede6f4c9ba4bbb76b9ab9b6b419f155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100722 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14rename nmspmap.hxx -> namespacemap.hxxNoel Grandin
we're not in DOS anymore, Dorothy Change-Id: I79926e0d694163940ba7ebf20419724dd0a486f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100721 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-13Remove some unused includesMiklos Vajna
Change-Id: Iea6b931b1f2328886354f70ad81a3e07367db717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100669 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-13use OUStringLiteral in SfxItemPropertyMapEntryNoel Grandin
Change-Id: I4f05b6a35010e661ea77f3e4b83302d2ec74d227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100405 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-13loplugin:stringstatic also look for local staticsNoel Grandin
Add some API to O*StringLiteral, to make it easier to use in some places that were using O*String Change-Id: I1fb93bd47ac2065c9220d509aad3f4320326d99e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100270 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-13Merge toolbar popup classesMaxim Monastirsky
Now that all popups are welded. Change-Id: I5ad8a4eb6b9512ea9dd075b56d0ae6ee201fff19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100597 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-08-12SvTreeListBox can move into toolkit headers nowCaolán McNamara
Change-Id: I6b3b6ef1530a192f4b6bf87aa9688687063683ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-12use InterimDBTreeListBoxCaolán McNamara
Change-Id: I2f345f1a4fd6c7a4dc7be831f85a9f728ee477ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100496 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-11tdf#135442 min supported version of gtk3 is 3.18 not 3.20Caolán McNamara
Change-Id: Iaa2eefbe08fad3a7dd6eff98bf5fb513053a263d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-11lok: state updates for vertical alignmentSzymon Kłos
Change-Id: I6767904e3d3366e1316c932555b979a26e77b8c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99998 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100459 Tested-by: Jenkins
2020-08-08loplugin:unusedmethodsNoel Grandin
Change-Id: I58819edd0965ff52c3fc6c20d84bc5951a79bbe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100381 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-07Fix typosAndrea Gelmini
Change-Id: Ic28a1cdc779af9438555acd3bf85312e5e244fe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100336 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-07move comment to the start so xgettext uses the right onesCaolán McNamara
Change-Id: I0601cbcdd9b4441dc937fadf7287d0133fe35a3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100309 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-07drop unneeded forward declaresCaolán McNamara
Change-Id: I32c8f5fd73249bdd7a233801f6a23b280b8df50c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100305 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-07Set Ellipsize for proper viewing of properties in InspectorShivam Kumar Singh
Add ... at the end of long properties Change-Id: I7ab9eba4c4dab10446d66dcd99d677fa70a455d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100046 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-08-06loplugin:flatten in svx/sdrNoel Grandin
Change-Id: I553d01dc51515930fc7f96fe44d19ed14416e6f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-06loplugin:flatten in svx/tbxctrlsNoel Grandin
Change-Id: I5feee3afce13d774175c69766a6eb3a2db507de8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100235 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-06loplugin:flatten in svxNoel Grandin
Change-Id: I31f33a5f693d5fdb8282181c5bd7f31971efe784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-06loplugin:flatten in svx/svdrawNoel Grandin
Change-Id: I8379e5ebaee2090d2b4dbd05d55b55000915cd7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-06loplugin:flatten in svxNoel Grandin
Change-Id: If6154c1d464558c616a3593ed74fa6606458c9ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100230 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-06loplugin:flatten in svx/accessibilityNoel Grandin
Change-Id: Id2c82625fc5cf0d139ea77489578bfce7abc3fa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100206 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-05tdf#135438 Paragraph styles preview in sidebar are clippedCaolán McNamara
since... commit fe9a13dc0e6d1384416c2a2343223b33925fc925 Author: Caolán McNamara <caolanm@redhat.com> Date: Sun Apr 26 15:43:25 2020 +0100 weld SfxTemplatePanelControl getRenderSize used to be called after recalculate and before render to change maSizePixel Change-Id: Ifc1b6b0b3399c7de61d5f4d46f8346d13e72a4d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100178 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-05tdf#135344 Resolved Inspector scroll bar issuesShivam Kumar Singh
Change-Id: Ifd1b494c2302e8d21cc87296fc8222ffa2c75faa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100010 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04loplugin:unusedmethodsNoel Grandin
Change-Id: I5fa2bbeff17a9933ff55afb0c3544d025d096a63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-04simplify svx::frame::StyleNoel Grandin
no need to use shared_ptr here, this class is not doing copy-on-write. Change-Id: I4e921bfc789cc5989d98b5f9ab7074eb7d5ac33e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03tdf#42949 Fix IWYU warnings in include/[t-x]*/*hxxGabor Kelemen
Recheck after 7-0 branchoff Also drop the now unused file include/vcl/field.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9e54c82f50d1e02a0f99858939cac999fc66f7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-03Remove pointless checkMaxim Monastirsky
This check was originally introduced by me for a few toolbar controllers (save, underline, currency), as an attempt to reuse the same controllers also for non-split buttons (see tdf#98745 and tdf#101672). But since then it was copy-pasted to other places where it probably makes no sense. Change-Id: I7af2a3f5864ced88c91f330e87f32046d0c21383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99960 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-08-03Fix radio buttons in context menus for non-gtk3Maxim Monastirsky
The vcl implementation expects menu item attributes to be set on the sub menu they appear in, not on the parent menu. Change-Id: I7d6553126ed1dd5c1434529342b776aee01409a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99954 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-08-03fix build with (system-)cppunit 1.14.0Rene Engelhard
by #include <unotest/bootstrapfixturebase.hxx> so that CPPUNIT_TEST_FIXTURE is defined Change-Id: Iacbfb2f513df6e7eb7ca04f7900cd4e6b3fd69c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99963 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-02tdf#135121 don't fill the rectangle in the transparent case at allCaolán McNamara
leave the area untouched Change-Id: Icf195d383271b92f6523f8c6b6bc3b87fcae00be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-02Removed duplicated includeAndrea Gelmini
Change-Id: I3decadf858fd6d107efd6ac78e1b56f7195b4e91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99776 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2020-07-31weld FilterNavigatorCaolán McNamara
Change-Id: Ic75f3cf3e7e1f3ec3964256642c1359a99f5cc77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-31svx:Move functions from GalleryTheme that belong to GalleryObjectCollectionAditya
Move 3 functions from ImplGetObjectURL(sal_uInt32 nPos), ImplGetObjectURL(const INetURLObject& rURL) and ImplGetObjectPos(const GalleryObject* pObj) to GalleryObjectCollection as they deal with the m_aObjectList directly, and rename them respectively. Change-Id: I1e02b345d706c57db8801441fc955af9157cf565 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99789 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-31svx: Refactor GalleryTheme's insertFileOrDirURL functionAditya
Change-Id: I8784022851e3481d94a1b23c72e59dedf739e507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99479 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-30Resolves: tdf#134831 reorg to expand inspector to fit full panel sizeCaolán McNamara
Change-Id: I73e37dff01d67f04ea5a2a82e4083ffd5bd46440 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99774 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-07-30terminate XDesktop properly in unit testsNoel Grandin
So that the UNO constructor work can continue - where we need the desktop to be disposed properly so that all UNO constructors objects have their dispose() called, and they can clean up their global state. We detect this case by changing a SAL_WARN to an assert in Desktop::disposing() (*) in ~ScTabViewShell, don't call EnterHandler, because that tries to create EditEngine's and other stuff, which crashes (*) Need a fake singleton so that the servicemanager calls dispose() on the AnalysAddIn and we can clear the global variable there. Change-Id: Id13b51e17afc16fcbbc65d64281cdf847e4a58cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99640 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30svx: GalleryObjectCollection shared class and related refactoring workAditya
Add GalleryObjectCollection, a shared class primarily owned by GalleryTheme which contains object list to be used by GalleryTheme and GalleryBinaryEngine. Refactor ImplCreateUniqueURL, InsertGraphic() Implement comphelper::GraphicMimeTypeHelper::GetExtensionForConvertDataFormat() Refactor Actualize(), implement updateSvDrawObject(), updateTheme() Move ImplCreateSvDrawStorage into constructor instead of calling in directly. Change-Id: I6a8c552268628b4e192f45112ac9e8789c6e1609 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99035 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-29update DbFilterField to use the new replacement controlsCaolán McNamara
Change-Id: I5b138a776ebbad9e5f7a50f3f44ab56fa283cba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99719 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29center the filter checkbox like the normal oneCaolán McNamara
Change-Id: I7954430640fe9788c650f5fe7b103426731204cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29use 0 as the limit-less caseCaolán McNamara
since... commit 9ebe58f0437bbb5714e629bd22e004ac895086d6 Change-Id: I001567bb7beb0a51d55c75fe36761f4c964348e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99711 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29move SetReadOnly into ControlBase as SetEditableReadOnlyCaolán McNamara
and cast to that instead of "Edit" and override the Editable controls impls to do something suitable when called Change-Id: I24cc02b603e9551df4e3eb39f6cb4839883db777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99709 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29dynamic_cast followed by static_castCaolán McNamara
Change-Id: I63cb568b21f0f645849b39685966d28d16760594 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99706 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29use a EditControl nowCaolán McNamara
Change-Id: I011770676c91ea7cc83dc215ae92fa37c816e200 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29Fix typoAndrea Gelmini
Change-Id: Ia723bc6d16a9102f24e17176edce440fbc646bd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99638 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-29tdf#115753 fix table border missing when there are merged cellsnd101
Remove code that ignores merged cells. Change-Id: I907220e9ffc9d18561171efd7d6b39d14a8341fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93836 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-21 10:40:13 +0000