summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2015-07-16loplugin:unusedmethods sfx2Noel Grandin
Change-Id: I98c455d89f76fbcacf74929a4e8775b4da697f62 Reviewed-on: https://gerrit.libreoffice.org/17069 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15svx, sd, sw: GetPoolDefaultItem() can actually return nullptrMichael Stahl
...if you call ResetPoolDefaultItem() first. Crash found by Varun Dhall. Change-Id: I409484c172fb5843270aee2425844076a008b4df
2015-07-15Resolves: tdf#63955 clip 19km long line to some sane limitCaolán McNamara
Change-Id: If9757a5fa2bb93b56b9cf9f566972f687a4a3a45 Reviewed-on: https://gerrit.libreoffice.org/17036 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-15refactor ensuring polygon has at least a line in itCaolán McNamara
just split that out into a standalone function, no logic change Change-Id: I061d5d716b3fc2a9fb6385e7fb249ce300752130
2015-07-15Convert filters button to the generic controllerMaxim Monastirsky
Change-Id: I6d3c76c0aafe0ad77b597a2cb8331e6f8219e2d2
2015-07-15Convert optimize table button to the generic controllerMaxim Monastirsky
Change-Id: I6b9089daaa2bb7d0dfc1072296fc51401e5fc88a
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13Introduce generic sub toolbar controllerMaxim Monastirsky
Currently many toolbar controllers are basically doing the same thing - show some docked toolbar. So the idea here is to have one generic controller that will handle all these cases in a unified way. It will get the name of the toolbar that it's supposed to show from the configuration, based on the command it was registered for. Right now it can handle both simple (i.e. with DROPDOWNONLY bits) and split (i.e. with DROPDOWN bits) scenarios, where for split kind it replaces the function (and the image) of the main part of the button, with the last selected function, for easy reusing. A button is considered to be a split one, if the name of the initial default command was passed along with the sub toolbar name, otherwise it will be a simple button. The core change is in framework/. Other parts are a usage example, in form of converting the custom shapes buttons to this new controller. Change-Id: I087cc58c3db1889ca69a26546d4f00fe07e2a58d Reviewed-on: https://gerrit.libreoffice.org/16967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-13editeng: make Link<> usage typedNoel Grandin
Change-Id: Iec36c7e4f4fbc2ee2ee25d4d0c8488340ba7d8c4 Reviewed-on: https://gerrit.libreoffice.org/16968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13editeng, convert to typed Link<>Noel Grandin
and remove SvxBrushItem::SetDoneLink since the field it sets is unused.wq Change-Id: Ide95a295fa8004f1ddab5e560f01d36d36658a72 Reviewed-on: https://gerrit.libreoffice.org/16943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-12coverity#1311655 Uninitialized scalar fieldCaolán McNamara
Change-Id: I377bca31f33398754ff48e15ffa29d43fc584f3b
2015-07-10vcl: remove boost/signal2/signal.hpp from headerMichael Stahl
The most relevant signal member function appears to be connect(), so let's create a wrapper function for that now, without the more esoteric ordering features for now. Move the signal member itself to a new pImpl. The benefits are worth it: preprocessor input reduced by 2.8GB, that's 9% of the total (excluding system headers which are not counted because they don't generate dependencies). Change-Id: I0aaeda51a5630a348bb12c81a83f67afbd508a14
2015-07-10Add an a11y action for items in the Special Characters dialogMatthew J. Francis
Change-Id: I53fef3f151f66be775655ceef623a7d564c66f1a Reviewed-on: https://gerrit.libreoffice.org/16771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matthew Francis <mjay.francis@gmail.com>
2015-07-09tdf#92645 svx rendercontext: fix missing paint on shape text editingMiklos Vajna
Change-Id: Icb70805969ccf55bd85fb38c03cf70c1e0b16554
2015-07-09SdrPaintView::AddWindowToPaintView: take a vcl::Window, tooMiklos Vajna
Change-Id: Iedb296732c0819a1d6cdc1c59b3f1718e2cd6d38
2015-07-09SdrPaintWindow: optionally take a vcl::Window, tooMiklos Vajna
Change-Id: Ibf6c0cc2e6dc8fe6979632f6acb1b065984cd73f
2015-07-09Related: tdf#92645 svx rendercontext: avoid direct paint on ending text editMiklos Vajna
If the Paint() is ~immediate after Invalidate() (which is the case since the main loop has priorities), it makes no sense to perform any kind of direct paint right after an Invalidate(). With this, we no longer hit the is_double_buffered_window() assert when returning to editing Writer text after editing draw shape text. Change-Id: I3b80ca08aa71d247fc0561133f907aef34de4001
2015-07-08Avoid loplugin:staticmethods in non-debug buildStephan Bergmann
Change-Id: I41cf1baa9899a4c8af3382b0c7c047348bf3498e
2015-07-08various warningsStephan Bergmann
Change-Id: Id3a56d628088f19424bd6e0c8bf23b0ac6c64d25
2015-07-08tdf#87702: Addition of Shadow sidebar tabRishabh Kumar
Change-Id: I75b368c0a8088926c765dbc46c6a4ce7c9d8b9f0 Reviewed-on: https://gerrit.libreoffice.org/16375 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-08Limit the font preview text length.Ashod Nakashian
When text is selected, the preview text is the first TEXT_WIDTH (80) characters of the selection rounded up to the next word. However when no word boundary is found, the preview text is as long as the selection, which causes the preview to be less than usable in some extreme cases. This patch is to limit the preview text length when no word boundary is found, thereby always resulting in predictable behavior. Change-Id: I8a21638d601714db956b9b160664dfe1e5e49a4a Reviewed-on: https://gerrit.libreoffice.org/16855 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-08Fix typosAndrea Gelmini
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-07spelling dialog always leaked hereCaolán McNamara
Change-Id: I00c96bbfe7106a09c0a8aa09f3209537bc3d2b07
2015-07-07Fix some misspellingsTor Lillqvist
Change-Id: Iff2303650e1dcfc56064907a28df1c4c452eac56
2015-07-07Replace GetAppData(SHL_SVD) with an rtl::StaticStephan Bergmann
Change-Id: Ie1ccffe5461475a0425891861f825aeea149e876
2015-07-06tdf#83541 Redraw the last used color after theme changeMaxim Monastirsky
That's not what XSubToolbarController was originally designed for, probably, but it has more in common than otherwise. A split button offers a dropdown with some functions, and the main part of that button updates with the last selection, to easily re-apply it. This is based on the change made in commit dd69bde36a4ee4636933a80c0291486593a37670, so that updateImage method is called once an icon refreshing is requested. Change-Id: I6bd15638665f917ed7060886cd7835cdcd1a34f9
2015-07-06improve the returnbyref lopluginNoel Grandin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb Reviewed-on: https://gerrit.libreoffice.org/16731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06remove some unnecessary typedefs around uno::ReferenceNoel Grandin
Not very useful these days, since we have the css:: prefix to reduce verbosity. Found with a search like: git grep -nP 'typedef .*uno::Reference.*<.*>\s+\w+;' | grep -v 'std::' Change-Id: I16f41c53837ec5c613545ae45df38b0daddcbadd Reviewed-on: https://gerrit.libreoffice.org/16730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-05Convert NUM_PAGETYPE_ to a scoped enumMaxim Monastirsky
Change-Id: Iddc194a0d8f77e307c05bd3dfef1fc30568173c1
2015-07-05SfxToolBoxControl::GetPopupWindowType seems unused, kill itMaxim Monastirsky
together with SfxPopupWindowType enum. Change-Id: Ia0b2388b34c96bb044f1bfcc7e89b33ac37d5f95 Reviewed-on: https://gerrit.libreoffice.org/16766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-04coverity#1309261 Unchecked dynamic_castCaolán McNamara
Change-Id: Idea3a9f3465387680b814dc53ed4c0b13265f9f6
2015-07-04coverity#1309266 Uncaught exceptionCaolán McNamara
Change-Id: Ic13df34772a448f654924ca6076cb5bc92ea3883
2015-07-04Fix typosAndrea Gelmini
Change-Id: Ic6415423f46aaee7ba90239a617c318cf92ae222 Reviewed-on: https://gerrit.libreoffice.org/16711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-03tdf#92241 fix crashes and rendering of symbol set previewsLászló Németh
Change-Id: I43397f2b0caa31c334f87acf11fc96df2e051ad8
2015-07-03fix deselect of textbox on slides with images in underlying masterCaolán McNamara
The original work of tdf#55430 tries to select an object under another one on the second click, but these images are unselectable so this fails. Red Hat has a whole new shiny bunch of templates which have such images in their masters. Check if the object is selectable before continuing Change-Id: I182abaf50e8bb1084c5819dc9e1ffd8b386a9e93
2015-07-02some other coverity thingsCaolán McNamara
Change-Id: I89ffd2b918f8707cde1b1d015c1ad35ef484b69c
2015-07-02stray printfCaolán McNamara
Change-Id: I27ca497bcfbb0e3ed82066fd1c953b39763a2e99
2015-07-02coverity#1309051 Uncaught exceptionCaolán McNamara
Change-Id: Ia1ae16d9560c1eac294e29445e71dcee49ed16ce
2015-07-01tdf#86179 inc/dec font is missing in some shellsMaxim Monastirsky
Mostly in Calc, but also for the SwAnnotationShell. Also replace the current code in SwDrawTextShell with a call to EditView::ChangeFontSize. The latter is able to handle text with different sizes out of the box. Change-Id: I4b55da579ea51683140bce0544e481606d7e5f3e Reviewed-on: https://gerrit.libreoffice.org/16658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-01SdrPaintWindow: no own buffer for rendercontext-enabled vcl::WindowsMiklos Vajna
The buffered overlay manager paints using a timer, which is problematic if the given vcl::Window already supports double-buffering itself, so always use direct (to the rendercontext) painting in that case. Change-Id: I93144c02814fd511f333224ab058374c7da369f0
2015-07-01svx: linystyle -> linestyleMiklos Vajna
Change-Id: I08c60396d66a15ee94c7010753540c4e7fb3a0db
2015-06-30Fix typosAndrea Gelmini
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-30remove some unnecessary typedefs to pointerNoel Grandin
that were really not helping make the code any clearer. Found with a search git grep -P 'typedef\s+\w+\s*\*\s*\w+\;' and manual inspection Change-Id: I6a5c031e9e060ad3623a7586ec8a8cc4fe6252e9
2015-06-29tdf#84381: Improved sidebar selection analyser for Calc and Draw/ImpressRishabh Kumar
Disables the area tab when a line is selected Change-Id: Ib02a68fb548a7cc10f9af7e0d1b6191119f18915 Reviewed-on: https://gerrit.libreoffice.org/16165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-06-29Resolves: tdf#92275 impress grinds to a halt constant swapping imagesCaolán McNamara
This reverts commit 6c84442f99de109b585d3ba8964deb8dcf261c0f. "tdf#87820 Images not displayed properly in Calc" and replaces it with an alternative solution Change-Id: Iecb560d43767f0e41e442a307eefcdcecb7589ef
2015-06-29coverity#1308463 Uncaught exceptionCaolán McNamara
Change-Id: If0308eb0068951af425cb691672b915decc384a2
2015-06-29Hiding the line style label in sidebarRishabh Kumar
Fixes the cropped controls. Change-Id: I08d59ccd40e745148f9f6a4d5f61e507697b3ce8 Reviewed-on: https://gerrit.libreoffice.org/16436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-06-29Partially revert "svx, canvas, desktop: gb_OBJCXXFLAGS are not needed at all"Andras Timar
This reverts commit 601d7d38628bf93218fba15249c4654ae24e7396. desktop and svx need these flags in case of OS X sandboxing Change-Id: Ib811aa53bc2d71839961cdcea0dd4836ebdbc38c
2015-06-29coverity#1308571 Uncaught exceptionCaolán McNamara
Change-Id: Ib844cbd5c5d7be28e4ee2922caf06fb43c7b8a46
2015-06-29Revert "return and use std::vector from OInterfaceContainerHelper"Noel Grandin
This reverts commit e57314f61f67b093510c5a8a8f34a62126ba8734.
generated by cgit (git 2.34.1) at 2025-03-13 11:27:50 +0000