summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2017-06-01Fix typosAndrea Gelmini
Change-Id: Ic7fbd750321e4cfde1cfb0e04ffb545bb1f66d9c Reviewed-on: https://gerrit.libreoffice.org/37921 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-31disambiguate dual use of toolbar idsCaolán McNamara
for toolbar title string resource and identifier (for config) Change-Id: I2657c3cbb586a62d8075db7cb43cc064b2030f28 Reviewed-on: https://gerrit.libreoffice.org/38274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-31clang-tidy readability-redundant-control-flowNoel Grandin
Change-Id: I832f7ef0f1bd55e365db7e49823fe8bc30390c04 Reviewed-on: https://gerrit.libreoffice.org/38215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30Related: tdf#107961 ensure notifyhdl is unset after disposeCaolán McNamara
Change-Id: I69790c8d3cfffc09ee6d6c165e17823223c5058a Reviewed-on: https://gerrit.libreoffice.org/38205 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-30remove duplicate 'using namespace'Jochen Nitschke
Change-Id: I7f8828f677cfb588135ff75c03ffb75895773440 Reviewed-on: https://gerrit.libreoffice.org/38201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30Fix quotingStephan Bergmann
...broken with 020e1bff16a7bb5f401a2547d211807acd7db0fb "tdf#105204: ShellCheck nitpicks for gengal.sh" Change-Id: I5e7cd0b29be7840f0af44a028eb1c56ac7ffb33b
2017-05-30Restrict loplugin:redundantcast to "real" castsStephan Bergmann
Change-Id: Ifc9de898e5c9a084cbfd739625c679185c3a1534
2017-05-30missing resourcesCaolán McNamara
since commit 17e872c3fa87bb596ec8b263b7a2e692b927dcef Date: Fri Mar 17 13:11:27 2017 +0200 remove unused defines from HRC files in svx(1) because SdrRectObj::TakeObjNameSingul adds some numbers to ids to find other ones Change-Id: I9d0bd3686f4a60b7436950f8e80def9cc3586d9c
2017-05-30missing resourcesCaolán McNamara
since commit 17e872c3fa87bb596ec8b263b7a2e692b927dcef Date: Fri Mar 17 13:11:27 2017 +0200 remove unused defines from HRC files in svx(1) because SdrRectObj::TakeObjNamePlural adds some numbers to ids to find other ones Change-Id: I9d0bd3686f4a60b7436950f8e80def9cc3586d9c
2017-05-30teach redundantcast plugin about functional castsNoel Grandin
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-28aAttr is now (more obviously) unusedCaolán McNamara
Change-Id: Icf646cbb10921cc8673e22c7028e896c1c4aa036
2017-05-28coverity#704341 Logically dead codeCaolán McNamara
Change-Id: I1986daab3ec6576ac1b7d65f5944bbf21cd450b3
2017-05-28remove unnecessary use of OString::getStrNoel Grandin
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-26coverity#1409894 Dereference after null checkCaolán McNamara
Change-Id: If475a0415c9faf98c978576743dbfdaa79d16d3f
2017-05-25loplugin:constantparamNoel Grandin
add the results files so I can just see the diff in future Change-Id: Ia20a1aa6418be95ed620719cde340c00b7b053e1 Reviewed-on: https://gerrit.libreoffice.org/37988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-24tdf#107008 Pass char style names to NBOTypeMgrBaseMaxim Monastirsky
Change-Id: I26db31b8f9db968aa33b92a4abe917ac20cd5844 Reviewed-on: https://gerrit.libreoffice.org/37963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-23tdf#107731 New default red and yellow for font and highlight colorYousuf Philips
Change-Id: Ide81a7a3fce963a13b5c65861f566878ccb15676 Reviewed-on: https://gerrit.libreoffice.org/37884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-23enhance useuniqueptr lopluginNoel Grandin
teach it to look for the following sequence in a destructor: delete m_pfoo; m_pfoo = nullptr; Change-Id: Icd6271a63a024e32b53cc9e599f8f59952160380 Reviewed-on: https://gerrit.libreoffice.org/37900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-22Fix the from-German translation of "UNO binding"Johnny_M
As noted in the comment in https://gerrit.libreoffice.org/#/c/37839/3/forms/source/component/EventThread.hxx, this improves translation of "UNO-Anbindung" to the computing-specific term of "UNO binding" instead of "UNO connection". (All occurrences are translations, most of them by me.) Change-Id: I84daf94a0248e53010a569b1d3140c4394adce54 Reviewed-on: https://gerrit.libreoffice.org/37917 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-22Resolves: tdf#107981 SID_FM_CTL_PROPERTIES colorbox needs a 'default' entryCaolán McNamara
we don't need MakeHexStr either, the colorbox will do that on its own Change-Id: Ifad523092c0f15cd51d0d829790c0cec1c96bb53 Reviewed-on: https://gerrit.libreoffice.org/37898 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-20tdf#105204: ShellCheck nitpicks for gengal.shYeliz Taneroğlu
Use $(STATEMENT) instead of legacy `STATEMENT`. Double quote to prevent globbing and word splitting. Double quote array expansions to avoid re-splitting elements. Change-Id: I7fac5d187597aa37920754ed53be7bcc83603cee Reviewed-on: https://gerrit.libreoffice.org/37549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-20cleanup unused css/script/ includesJochen Nitschke
but keep exception includes in headers for now Change-Id: I826828675a2d14b906e57068cbced2e790e12bce Reviewed-on: https://gerrit.libreoffice.org/37846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-19loplugin:stringcopy: svxStephan Bergmann
Change-Id: Ic1874b2bfe28149deab3e6903ef7d7dac77cfc4b
2017-05-19make string translation loading more uniformCaolán McNamara
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19loplugin:unusedfieldsNoel Grandin
make it a little smarter in dealing with fields that are smart pointers Change-Id: I44072105170882dc29fb19558f1065cffc7e5f11 Reviewed-on: https://gerrit.libreoffice.org/37751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-18Remove parentheses around some comparisonsStephan Bergmann
...where Clang would otherwise start to emit -Wparentheses-equality as soon as the order of arguments were switched by loplugin:comparisonwithconstant Change-Id: If064c2c6e2f81478154395137138b71f2d1c6534
2017-05-18tdf#100072 zero height of shape's path was causing geometry errorsVasily Melenchuk
DOCX custom geometry shape's path width and height are now used independently for scaling calculations. Change-Id: I368dd4dc065b8f122c4eb2911261e45047f03c70 Reviewed-on: https://gerrit.libreoffice.org/37639 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-05-16tdf#107298 Rename Snap Position to Constrain ObjectsIlmari Lauhakangas
Change-Id: Ic4fe262051e8202b8e11c7378d0c37d06bb1c931 Reviewed-on: https://gerrit.libreoffice.org/37654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-15tdf#107845 string resource ids effectively ended up in the gallery formatCaolán McNamara
which is a problem since... commit 34f7e618ddd3399d9e7f3998e25545256255d02d Date: Sun Apr 30 17:01:32 2017 +0100 untranslated strings are just strings and recover GALLERY_THEME_HTMLBUTTONS and GALLERY_THEME_DUMMY5 from commit 2d3a9c51055a285a2ac8d45e3ef31d248362589b Date: Mon Jul 2 21:02:19 2012 +0200 hrc cleanup: Remove unused defines Change-Id: I3fa45e4550295b94a6ab0acf9bcd0b25db73e689 Change-Id: Idae2c00f43e2062544f3de22e586bb163864bc03
2017-05-14fix gdi resource leak (svx/compressgraphicdialog)Julien Nabet
Change-Id: Iea6e481384cee4d7e2ff6787c64d3048ba9c9d65 Reviewed-on: https://gerrit.libreoffice.org/37587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-14fix gdi resource leak with unreleased virtual deviceMarkus Mohrhard
Change-Id: I1fd8c76a206cfc940e3d646e4025618785985e52 Reviewed-on: https://gerrit.libreoffice.org/37583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-13tdf#101885: fix crash in AccFrameSelectorJulien Nabet
Deal with no parent case 0x00007ffff5e98240 in vcl::Window::GetChildCount() const () 0 0x00007ffff5e98240 in vcl::Window::GetChildCount() const () 1 0x00007ffff54f2d1f in svx::a11y::AccFrameSelector::getAccessibleIndexInParent() () See https://bugs.documentfoundation.org/attachment.cgi?id=127141 Change-Id: I795dc4c083d743466b5605d3dcc8f9fca8674c43 Reviewed-on: https://gerrit.libreoffice.org/37575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-12Translate German comments (rest of svx/)Johnny_M
Additionally to comments, this translates dbg. assertion strings. Change-Id: Ia35b2a7336f2b5b30da36445274b1ea726f71f39 Reviewed-on: https://gerrit.libreoffice.org/37559 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-05-12fix bug in ColorNameMap constructorNoel Grandin
introduce by commit 9ffb86c7e93c1633866ed89f0749831fd7f31a35 Author: Noel Grandin <noel@peralex.com> Date: Wed Mar 27 10:41:40 2013 +0200 fdo#46808, convert drawing::ColorTable to new style Change-Id: I5e91b41caa6e7e43ff0f261a22b027c8574b669a Reviewed-on: https://gerrit.libreoffice.org/37532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12remove unused uno::Reference varsNoel Grandin
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12convert SdrLayerId to strong_intNoel Grandin
Also - rename SetOfByte to SdrLayerIDSet - add asserts in SdrLayerAdmin::GetUniqueLayerID so that we don't allocate overlapping SdrLayerID values - add a new constant SDRLAYERPOS_NOTFOUND to be returned from SdrLayerAdmin::GetLayerPos Change-Id: I3bb3489f9338e3d02c4040bcbd811744699941c8 Reviewed-on: https://gerrit.libreoffice.org/37467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-11Delete code commented out since 2006Gabor Kelemen
See commit 8b77e2790c206439762cdde3343f64e87bfe0d16 Change-Id: I5f9d4a566377f8e7a59f12b138cc612e710efbdf Reviewed-on: https://gerrit.libreoffice.org/37356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-11Fix typosAndrea Gelmini
Change-Id: I204178ed4cf0fd3f43043cf1dfde85bb27002fee Reviewed-on: https://gerrit.libreoffice.org/37498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-11tdf#107258 Create show/hide all comments toggle button.Gulsah Kose
Created new show/hide all comments button for calc by ShowAnnotations command. Unifyied writer, calc and impress's ShowAnnotations slot. Change-Id: I27149d09ee1763b84258c5e0c890a9628c8874c0 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/36697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-11tdf#107706 fix crash when closing Calc documentNoel Grandin
regression from commit e8b49f09074fe184374bee5062715357427ae044 "new loplugin: useuniqueptr: vcl" Change-Id: I07ac157a02aa82b1ddbb741797fea093772f93f1 Reviewed-on: https://gerrit.libreoffice.org/37470 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-11remove some unnecessary temporary OUStringsNoel Grandin
found with: git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02 Reviewed-on: https://gerrit.libreoffice.org/37463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09tdf#39468 translate German comments, removing redundant onesThomas Beck
Translated remaining German comments in svx/source/form/fmview.cxx Change-Id: I6e71bc1dc1ab1c0b87ec0a3d727cffe2237e9a59 Reviewed-on: https://gerrit.libreoffice.org/37381 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-05-09Translate German comments in svx/source/form/fmsrcimp.cxxJohnny_M
Additionally to comments, this translates dbg. assertion strings. Change-Id: Ie8a421fe225cd5a368c30b4511d9a7ebd26f296a Reviewed-on: https://gerrit.libreoffice.org/37343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09make loplugin constantparam smarter about string paramsNoel Grandin
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294 Reviewed-on: https://gerrit.libreoffice.org/37426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09Translate German comments in svx/source/form/fmshimp.cxxJohnny_M
Additionally to comments, this translates dbg. assertion strings. Change-Id: I7bfe582fb34243b491a8c5f075beeb234555fe06 Reviewed-on: https://gerrit.libreoffice.org/37316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-08cleanup tools/debug.hxx includesJochen Nitschke
with command > git grep -l tools/debug.hxx | xargs grep -L DBG_ | xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d' don't change files in includes/ and */pch Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08 Reviewed-on: https://gerrit.libreoffice.org/37349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07drop unnecessary GraphicObjectCaolán McNamara
Change-Id: Iadc741260b3c9f16248c817530b1630b22c626ee
2017-05-07convert to use std::unique_ptrCaolán McNamara
Change-Id: If675a1d506d30ea05c3b2113d114f416b2947466
generated by cgit (git 2.34.1) at 2024-08-15 22:14:43 +0000