summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2018-09-06rename back now originals are fully replacedCaolán McNamara
Change-Id: I1911055f9bf6bd636561209cadfb1dbf5650affa Reviewed-on: https://gerrit.libreoffice.org/60057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06weld SwColumnPage and SwColumnDialogCaolán McNamara
Change-Id: Ia649785047db2551044b4d765881309f83b5c838 Reviewed-on: https://gerrit.libreoffice.org/60044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06tdf#108351 - Default list of paragraph styles in drop down menuheiko tietze
Sort order adjusted Change-Id: I09109ac4aa21d8fa77da5c5930682dcf7a4f542a Reviewed-on: https://gerrit.libreoffice.org/60020 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-09-06tdf#91837: fix deinitializeControls (forms)Julien Nabet
m_bControlsInitialized wasn't ever resetted to false Change-Id: I9f7bd6504ccaa0a41c9cb075c1ba33436f0f97dc Reviewed-on: https://gerrit.libreoffice.org/60059 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-09-05weld SvxBorderTabPageCaolán McNamara
Change-Id: I33f12f160ac5fea14c9a53c3846c6d31c7fd0084 Reviewed-on: https://gerrit.libreoffice.org/59954 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-05default focus colorset on popover gaining focusCaolán McNamara
Change-Id: Icb731c4c9544d754bb3ad88ecf15ffc04f216294 Reviewed-on: https://gerrit.libreoffice.org/60006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-05loplugin:useuniqueptr in svxNoel Grandin
Change-Id: Iba9ceb0b86b175ef599f4de7b06bf0dccc2ba997 Reviewed-on: https://gerrit.libreoffice.org/60005 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-05loplugin:useuniqueptr in ViewObjectContactOfPageObjNoel Grandin
Change-Id: I4f7af7bb8da2b4bfb27ab7cf748677fc3fa6fdbc Reviewed-on: https://gerrit.libreoffice.org/60004 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-05clang-tidy performance-inefficient-vector-operationNoel Grandin
Change-Id: Iebcaea7b08c5284946d83b6b6b9ed26b218025d4 Reviewed-on: https://gerrit.libreoffice.org/59992 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-05pdfium: replace FPDFTextObj_CountChars/GetTextProcessed patches with backportMiklos Vajna
Change-Id: I9c198ff0cd31de064fcc4a3bb0ed92066f38e4c5 Reviewed-on: https://gerrit.libreoffice.org/60007 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-04tdf#118967 Batch all a11y notificationsPaul Trojahn
Currently all a11y notifications get send out immediately, which often ends up formatting the document before it is ready. With the current EnterBlockNotifications()/LeaveBlockNotifications() system it is difficult to find all places that need blocking and any change in the a11y code might require additional blocking in unpredictable places. By queueing all notifications by default and only sending them out when the document is ready, we can make sure that it can't be corrupted. Change-Id: I9599c7b57eb5b8f8f0575de57fcc8bab171f78ff Reviewed-on: https://gerrit.libreoffice.org/58703 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03weld SvxAreaTabPageCaolán McNamara
which itself has 5 sub tab pages Change-Id: If71e91248b5771af4845ad6dba997ac4c7841b5d Reviewed-on: https://gerrit.libreoffice.org/56112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-03pass SdrUndoAction around by std::unique_ptrNoel Grandin
convert the LINK we use here to std::function, since LINK does not currently handle std::unique_ptr Change-Id: I9df80352e612445e5f5ca513d7d4196d65589778 Reviewed-on: https://gerrit.libreoffice.org/59804 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-01tdf#119611 Use generic SetAll() in SdrPageView ctor.Regina Henschel
The LayerAdmin has invalid values in case of charts. In consequence a bitfield with only zeros was generated, meaning all is invisible and not printable. Change-Id: I59d341ac8742f81b5f9afb28dc9add459a01525f Reviewed-on: https://gerrit.libreoffice.org/59895 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-08-31Fix syntaxJulien Nabet
Change-Id: I21cca2e5cd81ee58a59fda077ed40ba02d9f1df3 Reviewed-on: https://gerrit.libreoffice.org/59844 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-08-30weld SvxHeaderPage/SvxHeaderPageCaolán McNamara
Change-Id: I86f14a38c32baf46ccb5674005192fea2665719d Reviewed-on: https://gerrit.libreoffice.org/59801 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-30rename GetMarkedObjModel to CreateMarkedObjModelNoel Grandin
and return std::unique_ptr Not that it helps much, the ownership quickly becomes complex once it hits the TransferableHelper. Change-Id: I3c6bd72072e092b71b32e4105fe859fdcea956af Reviewed-on: https://gerrit.libreoffice.org/59777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30findreplacedialog: Set a11y role of hint text to staticSamuel Thibault
Since this is not a label for another widget, but some text that screen readers should speak. Change-Id: Iddc2840e60c8a55caf2e6581831024e2658e084e Reviewed-on: https://gerrit.libreoffice.org/59668 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-29match preview buffer device mapmode and pixel sizeCaolán McNamara
Change-Id: Ie5ac758b788357e1d54ea3dc5abd233ff9e4abf0 Reviewed-on: https://gerrit.libreoffice.org/59762 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29Replace find_if with proper quantifier algorithmsArkadiy Illarionov
Change-Id: Icc820a47ac891c358883f9c01224f676c58fdd11 Reviewed-on: https://gerrit.libreoffice.org/59744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29loplugin:constantparam (3)Noel Grandin
Change-Id: Ifc47bb8e096c9a8563021b2fcb44199577740746 Reviewed-on: https://gerrit.libreoffice.org/59747 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29remove 1 pixel white band in XRectPreviewCaolán McNamara
Change-Id: I3089f9305b8142e2c78405a4f9ae6a2066e90cfa Reviewed-on: https://gerrit.libreoffice.org/59725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29loplugin:constantparam (1)Noel Grandin
Change-Id: I25077e391ecca1b678062d261a83d88daadf0a58 Reviewed-on: https://gerrit.libreoffice.org/59701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29pdfium: replace FPDFTextObj_GetFontName() patch with backportMiklos Vajna
Change-Id: I36d86e7ccca66b09f2f49e401d77deb52fbf742a Reviewed-on: https://gerrit.libreoffice.org/59738 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-28tdf#119122 first (5%) pattern initially drawn with too many black cellsCaolán McNamara
pattern of area tab, pattern subtab of e.g. format page and in the pattern editor the 5% style is shown wrong, clicking ona different pattern and then back may make it draw correct a problem since... commit 6fbb6d80fe6203ff6f84ee85ca625b6e60bf5bae Date: Fri Feb 16 16:13:38 2018 +0200 use std::array in createHistorical8x8FromArray to make the assumption about the size of the array obvious in the code. Change-Id: I882384a13dedc7a14b63b3b8a9b764a4367b7cc6 Reviewed-on: https://gerrit.libreoffice.org/59724 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-27tdf#119531: use correct conversion directionMike Kaganski
Regression from commit 8c48d69f06ddb3cb6c807a1e7db62dddb9778ded Change-Id: I302a210ab6c502e3938487ee02a08fc334cd3289 Reviewed-on: https://gerrit.libreoffice.org/59666 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-27tdf#101242 Support draw:display and draw:protect attributes of ODFRegina Henschel
LibreOffice writes the properties visible, printable and locked of layers into items in the subfile settings.xml and handles them as properties of the view. ODF handles them as property of the layer. To become more ODF conform as a first step these properties are now read and written. They are used to initialize the view in case they are missing in settings.xml, which is the case for foreign documents. The ODF properties are written in addition to the items in settings.xml, so that older versions will notice no difference with such documents. SdModelTestBase is changed to handle odg as Draw document. Change-Id: I190ecc51fc6ee91ec4b96d06bb216ce517bdfcfe Reviewed-on: https://gerrit.libreoffice.org/59269 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-08-27rename ENABLE_HEADLESS option to DISABLE_GUINoel Grandin
since it has nothing to do with the headless command line option, so use the name it has in the configure.ac file Change-Id: Ibf0615ed02695d6e48a797f5632e4f417c010c70 Reviewed-on: https://gerrit.libreoffice.org/59611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24pass DelFormats around using std::vectorNoel Grandin
instead of an array and a separate count Change-Id: Ia12a549da7e35092da2db35f8b2b9fc6a9e9c2be Reviewed-on: https://gerrit.libreoffice.org/59506 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24tdf#119236 Dimension dialog for Writer and CalcMaxim Monastirsky
Change-Id: Ifbc6c8959afcedac0fd9ec7a3f5e2cca63c11eda Reviewed-on: https://gerrit.libreoffice.org/59484 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-22new loplugin:conststringfieldNoel Grandin
Look for const string fields which can be static, and mostly convert them to OUStringLiteral And add a getLength() method to OUStringLiteral to make the transition easier. Remove dead code in XclExpRoot::GenerateDefaultEncryptionData, default password is never empty. Change-Id: Iae75514d9dbb87289fd5b016222f640abe755091 Reviewed-on: https://gerrit.libreoffice.org/59204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-21tdf#119282 Area tab, Pattern color changeNoel Grandin
regression from commit ccd316d1cb310734848bd20244f509024b549b8c use VirtualDevice in createHistorical8x8FromArray Move the code inside vcl so we don't need to expose BitmapWriteAccess. I tried to detect this thing by counting the number of independent colors in the bitmap, but that didn't work. It is used from more than one place, and appears to be very determined that it needs a 2-color palette to work properly. Change-Id: Id11dd9ea78e5e522a6083d6a799e801cac81fd5b Reviewed-on: https://gerrit.libreoffice.org/59331 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-08-21loplugin:useuniqueptr in FmXGridCellNoel Grandin
Change-Id: I4783b59f5fe83354fb47d081a60a81c9cebfac71 Reviewed-on: https://gerrit.libreoffice.org/59354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-21loplugin:useuniqueptr in GalleryThemeCacheEntryNoel Grandin
Change-Id: Ib9f3e604ca889a938cd41dbf3f59dfa7131fe4da Reviewed-on: https://gerrit.libreoffice.org/59352 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-20Simplify containers iterations, tdf#96099 follow-upArkadiy Illarionov
Use range-based loop or replace with std::any_of, std::find and std::find_if where applicable. Change-Id: I2f80788c49d56094c29b102eb96a7a7c079567c6 Reviewed-on: https://gerrit.libreoffice.org/59143 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-20return weld widgets by std::unique_ptr from builderNoel Grandin
Change-Id: I20c007b13dae2d1155034711ad1ad48bfdfd0ba8 Reviewed-on: https://gerrit.libreoffice.org/59288 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-17tdf#105998: Enhanced fix for MetafileToBitmap at better placeArmin Le Grand
Change-Id: I220bdbe196a68ef2df25885dceee70e15b760410 Reviewed-on: https://gerrit.libreoffice.org/59220 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-08-17Consolidate: basegfx::clamp -> o3tl::clampStephan Bergmann
Change-Id: Iffd8b0a19d4479b6c70dc834c6f64499e87e01b1 Reviewed-on: https://gerrit.libreoffice.org/59265 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-16tdf#114427 improve fix, wedo need to free it regardlessCaolán McNamara
Change-Id: I7c35bcd839d7b7b2e8a9ce83f732e14b68ca58eb Reviewed-on: https://gerrit.libreoffice.org/59172 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-16tdf#119284 bg for automatic not set while editingCaolán McNamara
refactor and reuse fdo#35779 solution for this case Change-Id: I0631cd2560aa2acc2310f95b5c4dea36a2845a58 Reviewed-on: https://gerrit.libreoffice.org/59165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-16tdf#116350 Better text layout for big shapesSzymon Kłos
Added some horizontal padding - for bigger shapes and vertical adjustment for multi-line labels. Change-Id: I665b238b0d08a499cd846952d831fe449f72f575 Reviewed-on: https://gerrit.libreoffice.org/58975 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-16return std::unique_ptr from CreateOverlayObjectNoel Grandin
Change-Id: Ib4e8849cd82ee0374228405209a33554310579d7 Reviewed-on: https://gerrit.libreoffice.org/59115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-15ofz#9821 Indirect-leakCaolán McNamara
Change-Id: I7b4f1a487c49048b7796dba982c5c1d2163cce46 Reviewed-on: https://gerrit.libreoffice.org/59068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-15loplugin:useuniqueptr in disposeOutlinerNoel Grandin
Change-Id: I038d98a4d4b3dd2a73afd8ddb4c4a7396e52267f Reviewed-on: https://gerrit.libreoffice.org/59012 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-15loplugin:useuniqueptr in GalleryThemeNoel Grandin
Change-Id: I6c709b9c38f24af37b355f85e5957790eb20a326 Reviewed-on: https://gerrit.libreoffice.org/59022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-15loplugin:useuniqueptr in OverlayObjectListNoel Grandin
Change-Id: I641d93e54504c27bcc49bae8edf6286c0a9a471f Reviewed-on: https://gerrit.libreoffice.org/59024 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-15loplugin:useuniqueptr pass SgaObject around by std::unique_ptrNoel Grandin
Change-Id: I88ef5de94f83cd8f7a7d2a60b072cc23bd147b27 Reviewed-on: https://gerrit.libreoffice.org/59009 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-15Resolves: tdf#114427 crash when basic used to dispose shapeCaolán McNamara
Change-Id: Ia078a0f4262fbe18b6cf463dbff33df1d4fd0a95 Reviewed-on: https://gerrit.libreoffice.org/59036 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-15pdfium: replace FPDFFormObj_GetSubObject() with backportMiklos Vajna
Change-Id: If5fc2fb328320f6cad608bebbc704ced3d69cee8 Reviewed-on: https://gerrit.libreoffice.org/59006 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-14tdf#119245 Set a parent for OParameterDialogMaxim Monastirsky
Change-Id: I5a7f4b43027a72f049e12c06cd583c6545b028f5 Reviewed-on: https://gerrit.libreoffice.org/58952 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>