summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2018-12-21tdf#119180 Use 100th_mm in UNO API implementationArmin Le Grand
Since SvxShape::GetBitmap is UNO API implementation the results have to be in 100th_mm, that is how UNO API is defined. Adapted Bitmap creation common case to do so using primitve embedding if source is not 100_th_mm. Also added a shortcut if object in question already is a SdrGrafObj and contains a Bitmap. Needed to update the checksum of a graphic for testN777345. Change-Id: I995100406a262e2872597dc64e943271e92eb4cb Reviewed-on: https://gerrit.libreoffice.org/65505 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit df57d50e00820d59b2b7104b6e59883405d0f183) Reviewed-on: https://gerrit.libreoffice.org/65523 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-21Resolves: tdf#120885 Crash on choosing 'more styles'Caolán McNamara
switching to the sidebar destroys the control currently active, just post the event to happen on the next event loop Change-Id: I3e9b629821fa43d8f29e419e72f66ed46d72fdbb Reviewed-on: https://gerrit.libreoffice.org/65542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19tdf#122127 Crash in FORM EDIT using drag drop to move control in dataformNoel Grandin
regression from commit 2629aac31142449312f77c5843ea209cc810acb4 Date: Tue Oct 23 09:47:10 2018 +0200 clang-tidy performance-unnecessary-copy-init in svx Change-Id: I4210c328145d062d8b72f09dcff3280e11c6bc36 Reviewed-on: https://gerrit.libreoffice.org/65394 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7d8bce646d53d77405b45a50fc6e889ccd0c10e9) Reviewed-on: https://gerrit.libreoffice.org/65399 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-12-17tdf#121638 , Different angle shown between sidebar & size and position dialogSumit Chauhan
Bug solved , Changed the nTmp = 360+nTmp ,if nTmp <0. Change-Id: I855e634540c55ab91e8bbe5824014d304d87c8e9 Reviewed-on: https://gerrit.libreoffice.org/65211 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> (cherry picked from commit 294c38229a37604fe2d0d82a6ebc7bcd086963f4) Reviewed-on: https://gerrit.libreoffice.org/65224 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-12-10Resolves: tdf#121946 first time draw uses gray bgCaolán McNamara
Change-Id: Ia0491eebe8fa7ea2c2377ca96c758c681da5470a Reviewed-on: https://gerrit.libreoffice.org/64876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-10Resolves: tdf#121520 duplicate languages in dropdownCaolán McNamara
Change-Id: I5bbde305bf06ac1f754f24eb93e89cb3d9cf6058 Reviewed-on: https://gerrit.libreoffice.org/64869 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-07tdf#121022 Do change parent of SdrObj earlyArmin Le Grand
Need to change parent of an SdrObject in the according SdrObjList methods before calling InsertedStateChange - that one relies on asking for the parent of the SdrObject Change-Id: I8c4d39190cafe889b27975941d72afca870e2ce5 Reviewed-on: https://gerrit.libreoffice.org/64608 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit b38f856f234f364199d306226875471ed589b764) Reviewed-on: https://gerrit.libreoffice.org/64706 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-05tdf#120527 svx GraphicObjectShape: handle XBitmap for GraphicURLMiklos Vajna
This restores compatibility for API users who called getByName() on the bitmap table and expected that the result can be set as a value for the GraphicURL property. The case is similar to the Writer images, which was handled in commit 587803ba46055d43b5b108be744fdde17aeabc7c (sw TextGraphicObject: handle XBitmap for GraphicURL, 2018-08-08) already. Change-Id: I3740a68989b306425d0d6c4d4e350ac163cb4170 Reviewed-on: https://gerrit.libreoffice.org/64069 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit e30f3e76a9350e2b027d99bba5a46aa0a0ff8256) Reviewed-on: https://gerrit.libreoffice.org/64427
2018-12-04weld OfaAutoCorrDlgCaolán McNamara
Change-Id: Iba217a2998de57bf963872f9b8c1cf38694eb935 Reviewed-on: https://gerrit.libreoffice.org/64507 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-30tdf#93005, tdf#100611, remove the incomplete ODC export featureMarkus Mohrhard
Change-Id: I96a3882cd412ea5d993971df7e20b1fd8da73642 Reviewed-on: https://gerrit.libreoffice.org/64283 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit d543e8dfd3d8ae718e29304a155e1cf70d08325d) Reviewed-on: https://gerrit.libreoffice.org/64311
2018-11-29weld ActualizeProgressCaolán McNamara
Change-Id: I35c486ac2dcf9818e331816f554a5c414bdb2386 Reviewed-on: https://gerrit.libreoffice.org/64221 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-29weld GalleryThemePropertiesCaolán McNamara
Change-Id: I88fbb9ab03f0026ffe0c5fe79ab0a386160738a1 Reviewed-on: https://gerrit.libreoffice.org/64220 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-29weld GalleryFilesPageCaolán McNamara
Change-Id: I5fa399144fb12bb19c3b88bf99f99dad6a64e052 Reviewed-on: https://gerrit.libreoffice.org/64211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25weld SfxMacroAssignDlgCaolán McNamara
Change-Id: I80045f1d1ca189fc490dc88b3471d68782df6f1c Reviewed-on: https://gerrit.libreoffice.org/63988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23tdf#114836, only set changed SfxItemSet propertiesMarkus Mohrhard
By always setting all existing properties again the calls started to differ between XMultiPropertySet::setPropertyValues and XPropertySet::setPropertyValue. This patch reduces the changes in the called methods. We can not avoid slight differences but at least the risk is minimized that something is unexpectedly changed. Change-Id: I5866db7be2829e6aba930f620f45db655df4e3f7 Reviewed-on: https://gerrit.libreoffice.org/63854 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 80cf278d365a2d357c70b8c28947c91fa97e7a99) Reviewed-on: https://gerrit.libreoffice.org/63856 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23tdf#118764 Pos&Size and Shadow panels tab stop fixesJim Raykowski
Change-Id: Id6ee2eed8ee96b901be8172cccc9b50e01877e3b Reviewed-on: https://gerrit.libreoffice.org/63844 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23weld SwFramePageCaolán McNamara
Change-Id: I12f868611860867df26bd29474aa19189c2b9a96 Reviewed-on: https://gerrit.libreoffice.org/63842 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22weld SwCondCollPageCaolán McNamara
and put back original SvTreeListBox a11y factory use Change-Id: I4ad8ce29d8fed6ec5d44e9a1d641919a89226b79 Reviewed-on: https://gerrit.libreoffice.org/63501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 47897fdd936d9b6e9ac8cb6110c79352ab080df7) Reviewed-on: https://gerrit.libreoffice.org/63770
2018-11-22tdf#42949 Fix IWYU warnings in include/vcl/[B-E]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iabe571aa8f00492902c499094bea8365a3e17fca Reviewed-on: https://gerrit.libreoffice.org/63623 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 40710c488de3e4eef585c5a5276c9a0943d36f2e) Reviewed-on: https://gerrit.libreoffice.org/63769 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22tdf#42949 Fix IWYU warnings in include/vcl/[ab]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If18c80fc64e55d797953e24e40e5d5e62bd9c625 Reviewed-on: https://gerrit.libreoffice.org/63453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 492ea7e08571e466e37f870b7642a79df55c2e92) Reviewed-on: https://gerrit.libreoffice.org/63768 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22Resolves: tdf#121531 impossible to change angle/rotation by text inputCaolán McNamara
Change-Id: Ic5fb01ac088cc777534e7986001defb61bc6ee60 Reviewed-on: https://gerrit.libreoffice.org/63734 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21tdf#121540 crash deleting a form from form navigatorNoel Grandin
regression from commit eec9f6c8b928de38dd9e683f46bfab00f3243048 Date: Mon Jun 4 15:01:43 2018 +0200 loplugin:useuniqueptr in FmEntryDataList and rename the method to make the it's operation clearer Reviewed-on: https://gerrit.libreoffice.org/63694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2edc8c53433be4423d7b009c9f60ed732d554816) Change-Id: Ife366f02c3d8907c397345d825ef7d1721d8930c Reviewed-on: https://gerrit.libreoffice.org/63704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-20Simplify color status handlingMaxim Monastirsky
(cherry picked from commit eb5b353b523ec4d7d6588e2fae5b8b4117bfc2b1) Rename BorderColorStatus to ColorStatus (cherry picked from commit 57f33bfd0c69a4568d1d5840391ab9901d4f4f66) Change-Id: I9335fa2ab94f69853b45f070499d7e18aac458c3 Reviewed-on: https://gerrit.libreoffice.org/63607 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-11-19tdf#121232 set a size request that will result in a 0 m_nXGap by defaultCaolán McNamara
Change-Id: I25ce389bd46beff2dd9b0507581736f2f9511383 Reviewed-on: https://gerrit.libreoffice.org/63575 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19weld TreeViewCaolán McNamara
a) use GtkTreeStores for GtkTreeViews b) ironically can't store GtkTreeStore contents in .ui apparently c) set show_expanders for all non-trees and unconverted cases d) on-demand subtrees Change-Id: I3c1036a222daba2c129b1a22ffeb3fe35005ae31 Reviewed-on: https://gerrit.libreoffice.org/63558 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19tdf#121267 Handle missing diagonal bordersMaxim Monastirsky
Regression of 9125a4f3f63a7f49fd307908c181e999120063e0 ("Use FeatureStateEvent directly for status updates"). Change-Id: I57856c5707fffcf84f95afa9ef80a394b550c56f Reviewed-on: https://gerrit.libreoffice.org/63497 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit f162066d9df814086c92fa008c563ffc08daaf98) Reviewed-on: https://gerrit.libreoffice.org/63551 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-17Adapt to C++2a char_tStephan Bergmann
u8 literals incompatibly change their type (as implemented by recent Clang trunk) Change-Id: Ia4f7b91f5d86656a056303d2754981ab2093a739 Reviewed-on: https://gerrit.libreoffice.org/63494 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-16loplugin:buriedassign in sd..writerfilterNoel Grandin
Change-Id: I954c12d9e1c493be6ac8c7b15076077b5bff5b74 Reviewed-on: https://gerrit.libreoffice.org/62811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16Revert "tdf#115639: Align right/center with trailing spaces the same"Tamás Zolnai
.. as MS PowerPoint" This reverts commit 1da3a3cb74a415a76fa547ef0c8f61780e260e7f. It was a bad solution for the problem. Change-Id: I6f6fecb7c74a884fbfb04c6e7204eb8bf347a272 Reviewed-on: https://gerrit.libreoffice.org/63473 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-16tdf#121305 Increase accuracy of custom shape circleRegina Henschel
The old implementation has used 4 segments and a questionable control point distance. The patch changes this to use the common implementation in basegfx. The method in basegfx is extended to allow to set the start quarter, so that the custom shape circle can get the same start quarter as it has before. The method descriptions in basegfx are adapted to the current implementation. Change-Id: I3a40f81827227ee0037d336bdf3c1ec6fdd64b4b Reviewed-on: https://gerrit.libreoffice.org/63366 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-11-15loplugin:staticmethods in vclNoel Grandin
Change-Id: I00333677db711761510a35dfae5ce70d61fb9491 Reviewed-on: https://gerrit.libreoffice.org/63397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-15loplugin:staticmethods in svxNoel Grandin
Change-Id: I94df3aa40fa79877ccebf1ed8709bd7cc47748d9 Reviewed-on: https://gerrit.libreoffice.org/63398 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-14move fmtfieldCaolán McNamara
Change-Id: Ic3f4388ea2ca92d9e97d4a9e066eea07c7de79e5 Reviewed-on: https://gerrit.libreoffice.org/63363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-14tdf#42949 Fix IWYU warnings in include/svl/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ide75232858599c275e023c2300201090acd22307 Reviewed-on: https://gerrit.libreoffice.org/63237 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-13loplugin:singlevalfields in svxNoel Grandin
Change-Id: I94d21bb868c54638b843c6abaab370a05ec3471e Reviewed-on: https://gerrit.libreoffice.org/63317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-12Fix typosAndrea Gelmini
Change-Id: Ibb94b2b16afbcca84dd55ae51fde6fd27afede3a Reviewed-on: https://gerrit.libreoffice.org/63297 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-12svx: prefix members of SdrEditViewMiklos Vajna
Change-Id: I3e27d8444c5a152ee39b9e2cc12b9df707f092b8 Reviewed-on: https://gerrit.libreoffice.org/63281 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-11-12tdf#118764 Tab stop fixes for Area and Line panelsJim Raykowski
Change-Id: Ib29701a44ab42806951a5b2ad6b63aabda4abfba Reviewed-on: https://gerrit.libreoffice.org/63262 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-11-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I1027242192dfd2be4918094d59f2a8f8c8fec041 Reviewed-on: https://gerrit.libreoffice.org/63266 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-11tdf#120703 PVS: remove non-functional checkMike Kaganski
V547 Expression is always false. Probably the '||' operator should be used here. Was like that since commit df64bd535f01aa264dc4b0c7abfdaeff299fb482. Trying to fix it by restoring the intended logic (|| instead of && to disallow setting stylesheets for Para or Page) breaks several tests in CppunitTest_sd_import_tests; apparently the code relies on these families getting stylesheets. So just drop the non-functional (always false) condition. Change-Id: Ia547c089ba0ed4ae879ede89043aa737e4409a75 Reviewed-on: https://gerrit.libreoffice.org/63234 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-10clang-tidy: (WIP) bugprone-too-small-loop-variable findings 2Tamás Zolnai
Change-Id: I1ddf3fe0e5fad265ae14712a23469b684253079d Reviewed-on: https://gerrit.libreoffice.org/63241 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-10Avoid getTokenCount() to check for single tokenMatteo Casalin
Change-Id: Ic72837cbb345a26faf3fd7cbf8739ddb6dc76cf9
2018-11-10tdf#121287 Use correct markers on tail of legacy calloutRegina Henschel
A legacy callout from toolbar 'Text', not a custom shape, is a rectangle with an additional tail. Currently only the end of the tail is dragable. The error was, that all points of the tail had got markers and that the markers had got a wrong point reference. Change-Id: I900b1294aaeefc0f46547c6db009a3c750955460 Reviewed-on: https://gerrit.libreoffice.org/63120 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-11-10tdf#121271 Use correct handles for arc in 'Edit Point' modeRegina Henschel
Full circle and ellipse have eight handles, all other legacy circle kinds have two additional handles for to modify start and end angle. The error was, that the loop was not adapted at its start, but at its end, and the values 8 and 10 were interchanged. Change-Id: I13204382a21f1b7900f0eafa18960e401e5a0c9d Reviewed-on: https://gerrit.libreoffice.org/63103 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-11-10tdf#121258 Use correct kind of handles for legacy rectangleRegina Henschel
Text box and rectangle have the same kind and number of handles in 'Edit Point' mode. Only that a text box has an additional handle for its blinking frame. The error was, that this special one was not skipped for a rectangle. Change-Id: Iae7af3eb196e61e32ecd5a39ba0ec553bbdaaa48 Reviewed-on: https://gerrit.libreoffice.org/63070 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-11-10tdf120965 Simplify SdrPathObj::AddToHdlList()Regina Henschel
A polygon consists of line segments without controls and curve segments with two controls. Where two segments meet, can only be 'line to line', 'line to curve' or 'curve to curve'. So for a handle which marks a meeting point of two segments, there are 0 or 1 control before and 0 or 1 control after. Thus a loop is not needed and makes the code harder to read. Therefore I have removed the loop. Change-Id: I48bcdbdf028542e08b3f5ed3f66907f2993e26bd Reviewed-on: https://gerrit.libreoffice.org/63036 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-11-10tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I0b3c407331bfa1fa0c5003250d327d4f26de3643 Reviewed-on: https://gerrit.libreoffice.org/63235 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-10Replace deprecated boost::optional::reset(val) with operator =Mike Kaganski
Change-Id: I7340a561e0df0c781fd834388deb4b9f83800f9b Reviewed-on: https://gerrit.libreoffice.org/63221 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-10Make sidebar paragraph panel outline toolbox focusableJim Raykowski
Change-Id: Id538fc081ea563f2c257c061812263ae33c7af52 Reviewed-on: https://gerrit.libreoffice.org/62971 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-11-09tdf#121116: don't adapt start/end widths if they are set explicitlyMike Kaganski
after commit b8fe3f84a60ea73aed9748844aee80441eb0fc7d Related: #i122121# moved automatic StartEnd adaption to svx Change-Id: Ic4639834ffa55d110f232fbad5f140a8e76df3e9 Reviewed-on: https://gerrit.libreoffice.org/63071 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-08-17 14:39:10 +0000