summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2018-09-23loplugin:unusedmethodsNoel Grandin
Change-Id: I9dac9260af9955dc4a66b34c33265c6e36094322 Reviewed-on: https://gerrit.libreoffice.org/60911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-22ofz#10610 Direct-leakCaolán McNamara
Change-Id: If7cd5e7157419c5d3b3a7ff834613e7f6489047c Reviewed-on: https://gerrit.libreoffice.org/60900 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22weld AlignmentTabPageCaolán McNamara
Change-Id: I253a01b053efe836b0657f9a711cecd060b6782b Reviewed-on: https://gerrit.libreoffice.org/60883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22tdf#117721 draw ui: add .uno::SetOptimalRowHeightJustin Luth
Optimal row height: Adjusts the height of the selected rows to fit the content, causing the table to shrink. This really is SetMinimalRowHeight, but until minimize is also added, it is the most desirable optimization. Change-Id: I90717b2752027404a85fd5eb01c68279996598ca Reviewed-on: https://gerrit.libreoffice.org/60129 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-09-21tdf#117721 draw ui: add .uno::SetOptimalColumnWidthJustin Luth
Optimize column width: Adjusts the width of the selected columns to fit the content, without changing the width of the table. Any leftover space is distributed proportionately, with thin columns growing slightly, and wide columns growing much wider. The implementation and results are different from how Writer does it, but tables themselves are also very different in Draw. So I don't think it needs to be handled identically. Writer's implementation is really "minimalColumnWidth" anyway. Change-Id: Ia10cfa9822d7eef3c4909a82c21535aa6668b143 Reviewed-on: https://gerrit.libreoffice.org/60078 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-21simplify PlusHdl logicNoel Grandin
like we did with the AddToHdlList stuff, all the client code cares about is fetching the entire list Change-Id: Id3cefa5f316a3f979a276c64f9125943d0981842 Reviewed-on: https://gerrit.libreoffice.org/60813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-21coverity#1439599 Uninitialized pointer fieldCaolán McNamara
Change-Id: I083e9e01e26f294064104a4682c50a9bfc7fa09c Reviewed-on: https://gerrit.libreoffice.org/60848 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-21tdf#67248 Use localized layer name only for display in UIRegina Henschel
The internal management of layers was based on localized layer names. So it could happen, that a custom layer name was a standard layer name (which includes special handling) in one local and not in the other. The patch changes the implementation to use the same real layer names as in file, and use localized standard layer names only for display in the UI. Removes no longer needed RestoreLayerName() Removes convertToInternalName(), ersatz convertToLocalizedName() Removes no longer needed convertToExternalName() Includes fix for tdf#119956 in addition Change-Id: Iaedb73e4017e728f7ca3b0dc4aa7bb7f0e6ce6da Reviewed-on: https://gerrit.libreoffice.org/60507 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-09-21remove SdrObject::GetHdl in favour of AddToHdlListNoel Grandin
the code already says that using GetHdl is inefficient, and client code should be using AddToHdlList, so just drop the bad one Change-Id: I88c43154c8cc0988127b9292e4cda28917f54eb9 Reviewed-on: https://gerrit.libreoffice.org/60792 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-20weld SvxDistributeDialogCaolán McNamara
Change-Id: I15ee19d825800fc99150292e04dbe4ff239589ba Reviewed-on: https://gerrit.libreoffice.org/60829 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20weld CropDialogCaolán McNamara
Change-Id: Ia63a7e0831328e4ddd329fd2ba042515cf38e414 Reviewed-on: https://gerrit.libreoffice.org/60817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20rename ParaPrevWindow back to SvxParaPrevWindowCaolán McNamara
Change-Id: I3dc51ed38509a588003137bf295f005b031c20c3 Reviewed-on: https://gerrit.libreoffice.org/60777 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20drop unused SvxParaPrevWindowCaolán McNamara
Change-Id: Ie217864bc9a5d8dd08d75a651b0826a07b9f1ed9 Reviewed-on: https://gerrit.libreoffice.org/60776 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19rename RectCtl back to SvxRectCtlCaolán McNamara
Change-Id: I4adde35b198d45fed09d837de5c1370d2a879f4b Reviewed-on: https://gerrit.libreoffice.org/60715 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19drop newly unused SvxRectCtlCaolán McNamara
Change-Id: I41fc4f53bedb4d5504aed39bd4d3052e2084fa6d Reviewed-on: https://gerrit.libreoffice.org/60714 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld GraphicFilterSmoothCaolán McNamara
Change-Id: I9f92b49bff105965c13e5977ef39788c6684da29 Reviewed-on: https://gerrit.libreoffice.org/60711 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld GraphicFilterPosterCaolán McNamara
Change-Id: I1e8af81267fdadc725eee8ac28e4dcf038cc50d9 Reviewed-on: https://gerrit.libreoffice.org/60710 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld GraphicFilterMosaicCaolán McNamara
Change-Id: I2bd52c8a998ecfc168b4fd0cecf79e49c12604eb Reviewed-on: https://gerrit.libreoffice.org/60709 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld GraphicFilterSolarizeCaolán McNamara
Change-Id: If729ea1688e9dc15372a59d75c972ee37511f76e Reviewed-on: https://gerrit.libreoffice.org/60680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld GraphicFilterEmbossCaolán McNamara
Change-Id: Ic3c816ddd7d5df9c5ced14600fffd6ca59f0096e Reviewed-on: https://gerrit.libreoffice.org/60594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Ibe152c3d57cac2084ab83443ff163bd05223653f
2018-09-18weld TextControlCharAttribDialog and TextControlParaAttribDialogCaolán McNamara
Change-Id: Id90967c9be1a56535aac3900a0cc2555ed8f9600 Reviewed-on: https://gerrit.libreoffice.org/60583 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-18loplugin:unusedmethodsNoel Grandin
Change-Id: I5f63ac44654ed3fc658e72e0d1148a5a22decc47 Reviewed-on: https://gerrit.libreoffice.org/60662 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-18weld SvxMeasurePageCaolán McNamara
Change-Id: I08f177d74aff278c62f76e32a1401ff24f249c57 Reviewed-on: https://gerrit.libreoffice.org/60589 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17In ::SetStyleSheet implementations call parent firstArmin Le Grand
This will guarantee SfxItemSet existence Change-Id: Ia969b5391c7b20d3a2bbba4376a16fcaadccb9d4 Reviewed-on: https://gerrit.libreoffice.org/60563 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-09-17weld SvxSearchFormatDialogCaolán McNamara
Change-Id: Iefe6c616dc5f6bd525ed9708785846626f43c9b6 Reviewed-on: https://gerrit.libreoffice.org/60579 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17rename to weld::ComboBox are they are not text only nowCaolán McNamara
Change-Id: Ice26d1fd2ad97a6959c6916fef428777efea9c2d Reviewed-on: https://gerrit.libreoffice.org/60500 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17add image support to weld::ComboBoxTextCaolán McNamara
Change-Id: Ie7f00ed4aef5318a525a526d0377bb7952bdd5a0 Reviewed-on: https://gerrit.libreoffice.org/60499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17New loplugin:externalStephan Bergmann
...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-16tdf#118203 Avoid endless recussion in MeasureObjectArmin Le Grand
Change-Id: I1e6fff80e7b6d36830f61387cc5245fc54877d95 Reviewed-on: https://gerrit.libreoffice.org/60546 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-09-15if its empty don't set it to empty stringCaolán McNamara
Change-Id: I14e2461141332677c029877f6ab082b6f5dd2010 Reviewed-on: https://gerrit.libreoffice.org/60524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-15coverity#1439337 uninitialized scalar fieldCaolán McNamara
Change-Id: Ie5d3ae790b0155ce0cc36c347f32e390c2097768 Reviewed-on: https://gerrit.libreoffice.org/60523 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-15Micro-optim in FormController::approveRowChangeJulien Nabet
TODO says: "in case of binary fields, this "getString" below is extremely expensive" In this case, swap the terms of the if to hope to gain a little. Change-Id: I4ef7b3bf5a9cbe49f7d56462d02ab274cbfd0025 Reviewed-on: https://gerrit.libreoffice.org/60509 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-09-14weld SvxCharNamePageCaolán McNamara
Change-Id: Ia54a5ac4fe4a11b7c03508c336193bb52c616e7f
2018-09-13tdf#42949 Fix IWYU warnings in include/ucbhelper/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I7bfeef47abaf94cfb355db95c0fdb928ce36c0a6 Reviewed-on: https://gerrit.libreoffice.org/60232 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-12tdf#70759 Clear formatting should set "Standard" text styleSamuel Mehrbrodt
not "Text body" Change-Id: I994682b156dd4d8d6301baf6ca077cd072412b25 Reviewed-on: https://gerrit.libreoffice.org/60381 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-12loplugin:unusedmethodsNoel Grandin
Change-Id: I0f96c41ab61bd4bfaf6c36d78d0a2ca768da0032 Reviewed-on: https://gerrit.libreoffice.org/60314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-12tdf#119392 write bitfield in <draw:layer-set> orderRegina Henschel
The view uses the SdrLayerIDSet bitfield in layer ID order. But file format knows no layer IDs and on loading the bitfield is interpreted in the layer order given by <draw:layer-set> element. Therefore reorder the bits on saving according <draw:layer-set>, which is order in SdrLayerAdmin. Change-Id: Id349dc7f42338e35ca8cc3b6409d061213b01691 Reviewed-on: https://gerrit.libreoffice.org/60178 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-09-11loplugin:unusedfieldsNoel Grandin
Change-Id: Ic7871f3a40668ba73aa0f0067a45455920d55890 Reviewed-on: https://gerrit.libreoffice.org/60313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:simplifyconstruct in svtools..svxNoel Grandin
Change-Id: Ia20fac7cec01ac658a903f8b001807b2e72dbf3e Reviewed-on: https://gerrit.libreoffice.org/60316 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:unusedmethodsNoel Grandin
Change-Id: I34009aabf0befb346470b5c0d96ad8fc476b7c4e Reviewed-on: https://gerrit.libreoffice.org/60300 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11weld SvxBitmapPickTabPageCaolán McNamara
Change-Id: I4c5fd94356f3640b150ef9fec48a166457f3b70b Reviewed-on: https://gerrit.libreoffice.org/60266 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-11loplugin:constantparamNoel Grandin
Change-Id: Ia11bf93768d5f722b7fe62df15f24809cb7e7f04 Reviewed-on: https://gerrit.libreoffice.org/60280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11clang-tidy bugprone-copy-constructor-initNoel Grandin
Change-Id: Idd435b3a4d081f6d3af26ff8add69ad4af50db57 warning: calling a base constructor other than the copy constructor Reviewed-on: https://gerrit.libreoffice.org/60239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-10tdf#119777 min target is 3.18, not 3.20Caolán McNamara
Change-Id: I9d0ff68729df01f1d9dc9bb953be10ea44ce58df Reviewed-on: https://gerrit.libreoffice.org/60270 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10a11y: Fix multiple instances of duplicate mnemonicsKatarina Behrens
Change-Id: I0ffe2a7c6b8102aa977af16232ce930541a8b816 Reviewed-on: https://gerrit.libreoffice.org/60246 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-10weld SvxBulletPickTabPageCaolán McNamara
Change-Id: I0b3e48cc63984208c8e4a090d6630dd5325d776e Reviewed-on: https://gerrit.libreoffice.org/60257 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10No more need for extra local variablesStephan Bergmann
...after 453fde35bb838febf73bfda0bd981ee270c9b12e "BitmapFilter::execute can be const". This reverts the call-site changes of bce47223099bb3349d96af9d6b1fe88bcdd539df "clang-tidy bugprone-use-after-move in BitmapFilter::Filter" again. Change-Id: I5ce4eb7ddce90fb779ddfb1c5864fd4785708175 Reviewed-on: https://gerrit.libreoffice.org/60255 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-10clang-tidy bugprone-virtual-near-miss in RecoveryDialogNoel Grandin
warning: method 'svx::DocRecovery::RecoveryDialog::execute' has a similar name and the same signature as virtual method 'Dialog::Execute'; did you mean to override it? Change-Id: I42eadd96069ff23c44fedc76d800161767313e77 Reviewed-on: https://gerrit.libreoffice.org/60240 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-10tdf#42949 Fix IWYU warnings in include/cppuhelper/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45 Reviewed-on: https://gerrit.libreoffice.org/59297 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-01 12:38:08 +0000