summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2016-03-15vcl: move graph.[hx]xx to graphic.[hc]xxChris Sherlock
It's IMO a bit confusing to see a "graph" header that doesn't strictly deal with graphs, but graphics. Backporting to 5.1 series to allow for easier backporting of other potential hotfixes. Change-Id: Ic37c6cd78e23d05939486f98667144c4453bb0a3 Reviewed-on: https://gerrit.libreoffice.org/22949 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-03-09Use rtl::math::isNan()Fabio Buso
isnan() not found causes compilation error System: Archlinux (Kernel Version 4.4) - GCC 5.3.0 Change-Id: Id0bb4555428896678437e8abf228f1c208f1e7a0 Reviewed-on: https://gerrit.libreoffice.org/22695 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/22917 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-02tdf#96922 Suppress EditView PageVisuailsation in GraphicExporterArmin Le Grand
PageBackground is due to old constraints in exporters not completely hindered when IsPageVisible() is already set for signalling that all EditView-specific Page visualisations should be suppressed. As long as these exporters are not adapted, use the setting of SetPagePaintingAllowed() which consequently achieves this. Change-Id: I2222a799533f763b54b2210a46c24aa8ae92d7a2 Reviewed-on: https://gerrit.libreoffice.org/22837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit f3ff67d3c3047de3ad43f8bb3f805d82eaef0479) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2016-02-03tdf#91762: Check wether the row and the cell have text...Xisco Fauli
... in order to set the row's min height Regression from 4f2c8194f485b1527fb4f4dfe23ce804937f1f9c After this commit, the row's min height was set based only on the cells containing text in the row, but the problem appeared when the row didn't have any cell with text. Change logic to check wether there's text in the cell and in the row. Now, height in SdImportTest::testRowHeight() is 507 instead of 508 but I can't figure it out why. However, I believe there's no harm in change the test from 508 to 507 as, visually speaking, the difference can't be distinguish. Change-Id: I0b3a14c34eaeaa8e77227860ca290fb79a0302ce Reviewed-on: https://gerrit.libreoffice.org/21692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit 13d4398820ded5914f635757865e258db2db2b57) Reviewed-on: https://gerrit.libreoffice.org/22008 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-02-02Make Position and Size sidebar tab visible when a line is selectedRishabh
Regression bug introduced by - https://gerrit.libreoffice.org/#/c/16165/ and removal of obsolete writer code. Change-Id: I8ab2e0c04b5c90fafdb43f34899053df7bd7fb4e Reviewed-on: https://gerrit.libreoffice.org/21739 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 8fb5502b25f0ca0e97e3eb07b68d89d21ee3d0ec) Reviewed-on: https://gerrit.libreoffice.org/21851 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-28Resolves: tdf#96580 Sequence::get doesn't return the start of the dataCaolán McNamara
it returns the start of the underlying uno_Sequence commit 78c83032b266fbb6fc20ddca86df80affaff7c24 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Sep 30 09:40:16 2015 +0100 maSvgDataArray only populates a uno::Sequence, so use that instead Change-Id: I335d5ee70e95e1a3b204d34f6df4cb62f3fb3cad (cherry picked from commit ab60f6cb0f46cb71172e4248ed40e212f6ebb4da) Change-Id: I8d2c07fec039e58d3644e4ab5eb074ee215f075e
2016-01-26Resolves: tdf#97276 don't clip out line if the underlying page size is unknownCaolán McNamara
Change-Id: I77d88d8020e9ac26bd6b7277e6d8afefed5e3ee7 (cherry picked from commit ad99c633908f7c70d06812ebfb4e0696666f0158)
2016-01-21tdf#96685 - set initial focus of accessible editeng objectsJustin Luth
signalIMDeleteSurrounding searches for the focused accessible object. Since newly created accessible objects were not inheriting the focus setting of their peer, the search returned nothing until some event triggered the focus to be adjusted. Change-Id: I92f980b4bbe741d8ce9196165eff51059c807a2b Reviewed-on: https://gerrit.libreoffice.org/21002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 3b14cdf7386f41395d1b089c3b9dde7d4429cf38) Reviewed-on: https://gerrit.libreoffice.org/21562 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-01-12tdf#97075 - don't render sdr overlays before we paint.Michael Meeks
Change-Id: I0b22af14c7dd684c25cfee26e8c12b95b40479ee Reviewed-on: https://gerrit.libreoffice.org/21406 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-11tdf#96482 Revert "tdf#94069 call setVisible when setDesignMode is called"Lionel Elie Mamane
This reverts commit a7816853bad55ada597092c16ba9a0a761e067d0. tdf#94069 (freeze) has been corrected differently in libreoffice-5-1 anyway. Change-Id: I901b16f2f1fe0cf0fd6b44c41f3dd47db88041f7 Reviewed-on: https://gerrit.libreoffice.org/21344 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-01-07tdf#96708: don't modify document while copying to clipboardMike Kaganski
I.e., don't try to create auto-layout for clipboard pages which don't contain one; don't resize objects to text. Also, don't invalidate items that are equal to defaults, because explicitly set items are not the same as absent items: pasting an object without an item makes the property to inherit new target's default, while when the item is present, the default doesn't apply. Also, don't consider selected state of the page while stringifying - this makes selected page string to differ from not-selected clipboard page. Change-Id: I172e03e1a8c428e5fcae3a116cc9ad8de79f1a87 Reviewed-on: https://gerrit.libreoffice.org/20871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 3b4059dc53ec764be5423517363223043d6dbfad) Reviewed-on: https://gerrit.libreoffice.org/21104
2015-12-31findbar: This must be a copy'n'paste error.Jan Holesovsky
Change-Id: Iecff49f04e4b68f071d63217943891a31a610aeb
2015-12-15svx: set BaseURL from SvxOle2Shape::createObject()Michael Stahl
This is used from oox chart import code, cf. oox::drawingml::Shape::finalizeXShape(). Change-Id: I7b2097f8d5740a590a6473797ab9436453fbf580 (cherry picked from commit 75a200f371d12ddaf5b82af10c8d4675babcdb5e)
2015-12-15fix missing BaseURL when loading embedded objectsMichael Stahl
When the object is edited in the UI, the m_xClient is set to a SfxInPlaceClient and the DocumentBaseURL is retrieved from it. But if the object is not edited, it will be loaded during export via the API and without a m_xClient; in this case the DocumentBaseURL must have been set previously to be available during import. There appears to be no way to get the URL of the document via the API while it is being imported; SfxBaseModel's m_sURL is unfortunately only initialized from SfxObjectShell::FinishedLoading(). During ODF import, the SvXMLEmbeddedObjectHelper creates the embedded object, so let's make it pass in the parent's BaseURL. The "DefaultParentBaseURL" parameter already exists but was unused previously. Change-Id: I3d1ed29b3a2c0e77ec606a1d09f7bc07e7860733 (cherry picked from commit b0fc09daf1086423a9bd457d9a2c043e7ff41451)
2015-12-14tdf#96206: Avoid scaling objects while copying to clipboardMike Kaganski
... to prevent duplicating masters on slide copy-paste. Also fixed a 10-year copy-paste error (pRefPage wasn't replaced with pNPage). Fixed argument evaluation order issue (aStream.GetEndOfData() depends on Flush() but doesn't call it, so will return incorrect result if called before aStream.GetBuffer()). Replaced compare of hashes with results of stringify(), because it removes useless overhead (hashes are calculated from stringify() anyway, and are not cached anywhere). Removed Flush() called from SvMemoryStream::GetBuffer(), because it calls GetData(), which calls Flush() itself. Thanks to Andras Timar for unit test framework. Change-Id: Ia46d4e9a017fc628d424949a9d229045a249a4ca Reviewed-on: https://gerrit.libreoffice.org/20367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 6381fe554aec600d13d0359903216811d644dd36) Reviewed-on: https://gerrit.libreoffice.org/20694 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-08Related: tdf#71622 compress more gfx in odf streamsThorsten Behrens
Except for jpeg and png, most natively-stored image fileformats compress rather well with zlib. adding a number of vector and pixel formats. Change-Id: I97407a98f620520b0d11552911d2339bf004dc5b Reviewed-on: https://gerrit.libreoffice.org/20461 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit ad0edc184792f3aa3f72e8d4ec8b76c3d1bf8479) Reviewed-on: https://gerrit.libreoffice.org/20467 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-11-25tdf#76825 Add padding between style render and context buttonYousuf Philips
Change-Id: I2d1185d433be0fbb57a59e0609ab0f505248a348 Reviewed-on: https://gerrit.libreoffice.org/19210 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit d65d9c546125ab999d645a921731170d60fa14ee) Reviewed-on: https://gerrit.libreoffice.org/20170
2015-11-25loplugin:unusedfields in include/svxNoel Grandin
Change-Id: I946c64d103f3666e5bbff16d95a5c8e65a3750dc
2015-11-25loplugin:unusedfields in include/sfx2/Noel Grandin
Change-Id: I3eb27ed10e82ee56b33866ac576c1b1f8c9756b9
2015-11-24crashtesting: ooo72999-1.ods NaNs found in light directionCaolán McNamara
and NaN != NaN so busted logic propogates, drop invalid directions on initial read Change-Id: Ic76c714666df14d37a4c68f43b817327675bd0e0
2015-11-24tdf#95970: Don't loose mirroring in SdrTextObj::TRSetBaseGeometryMike Kaganski
Currently, negative scaling (mirroring) is lost in SdrTextObj::NbcSetSnapRect, when rect is justified. This patch cares for this. Possibly it's better to make these changes directly in SdrTextObj::NbcSetSnapRect? Change-Id: I353ff01626e15b398de95e28eae78572991dfdc3 Reviewed-on: https://gerrit.libreoffice.org/20109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2015-11-23crashtesting: fdo30583-1 hits the Clone ugly tree all the way downCaolán McNamara
Change-Id: I091c3a61a28275e090975016908e3b25c7506fba
2015-11-23VirtualDevices either match another device depth, or are 1 bitCaolán McNamara
cairo can therefore always render to a svp virtual device with need for a fallback Change-Id: I5d03ae541820389e26f7448444444be009fb28a4
2015-11-23establish that Virtual Devices either match Physical Device depth or ...Caolán McNamara
are 1 or (rarely) 8 bit and lock that down. Change-Id: I3d946ebef34ffb71c5adea7aa420af50e9584e05
2015-11-23loplugin:unusedfields in svx/Noel Grandin
Change-Id: Ia6531b1ff8882ad06084f11dd10e2b1fe3c8cf24
2015-11-23SvxSmartTagsControl: Do not leak sub menusMaxim Monastirsky
And while on it, move other things to smart pointers as well. Change-Id: I8b234b8a9fe60e0ca82bb08e48f6b7db94cbcd4d
2015-11-21tdf#95963: Add required Clone functions for ImpressJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=95963 for more details Change-Id: Ia3fbf4db8d5b968e86007f7e9d6694d5e096f214 Reviewed-on: https://gerrit.libreoffice.org/20107 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-11-20add mapKeysToSequence/mapValuesToSequence methods to comphelperNoel Grandin
and use them Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec Reviewed-on: https://gerrit.libreoffice.org/20055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-19use comphelper::containerToSequenceNoel Grandin
in chart2, we remove a local equivalent of the method Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
2015-11-18svx: SdrLayerNameItem etc. missing Clone overridesMichael Stahl
Change-Id: I26ca8070d9c9607a475267ef8780f9013dfd4dcf
2015-11-18svx: SdrEdgeNode1HorzDistItem etc. missing Clone overridesMichael Stahl
Change-Id: I2bc2de3c3a71dd54e432905c129a3dbd5395f6ab
2015-11-18Revert "Flip buttons: Make the tooltip an uno command property"Samuel Mehrbrodt
The text should be in the extended tooltips, not in the default ones. This reverts commit 0e41564b2fa5192ef1e8ec5e51ad3c04dfa52afd.
2015-11-17No point to link against pure UNO component library fwkMatúš Kukan
Change-Id: I44d979180e53a7251547cebd60cf05c8322b2b83 Reviewed-on: https://gerrit.libreoffice.org/20028 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-11-17loplugin:unnecessaryvirtualNoel Grandin
update the plugin with lessons learned from the mergeclasses plugin and re-run it Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711 Reviewed-on: https://gerrit.libreoffice.org/20015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I5779c639c480d5a2fbefd47942a662ff7ca4a9f5
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-16Cleanup: Consolidate the different ways to get command labels/tooltipsSamuel Mehrbrodt
Change-Id: Ieab809a3122c9d592894b84ec2e68195a4e02dde
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
replaced using: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9 Reviewed-on: https://gerrit.libreoffice.org/19969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-14tdf#95403 Add Outline buttonMaxim Monastirsky
Change-Id: I0d5187ed34539a05ab9f2ffdfb89118df0aa3511 Reviewed-on: https://gerrit.libreoffice.org/19964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-11-15Fix license headerMaxim Monastirsky
This is an original file created by me. Not sure how I missed the wrong header. Change-Id: Ic56d66b1b10aa83dee835925dbf2e9a6d6a130ab
2015-11-13tdf#86886 Shortcut keys missing in undo and redo tooltipsSamuel Mehrbrodt
Change-Id: I8df003bdad4430a174815ce51197b997717ef379
2015-11-13svx: loplugin:badstaticsMichael Stahl
Change-Id: Ief31d8153fdbf91cdd29df5ac7801bd88a98542e
2015-11-13svx: rename static variableMichael Stahl
Change-Id: I98246395bb0de7444864ce35d1cbdd4711b5bfeb
2015-11-13Flip buttons: Make the tooltip an uno command propertySamuel Mehrbrodt
Change-Id: I3d6984b3b51e7eb2affa7fafebf8b745e60b3f20
2015-11-12tdf#95551 - fix image map crash.Michael Meeks
Remove listener we add, and don't crash on callback for disposed dialog. Change-Id: Ia6a1bddd212cb28a0331469e8e87324346d02841
2015-11-12Sidebar: Make the flip buttons available for Images in Writer alsoSamuel Mehrbrodt
And reduce copypasta Change-Id: I140bb8ad68bc35ba41c272cc4eb89b4a2d209a45
2015-11-12tdf#90357 create correct undo actionArmin Le Grand
when merging in pages from another model the already cloned page references a masterpage from the old model. To not create an undo action that falsely reflects that, remove the masterpage from the page first. This reflects better what happens in this state, setting the masterpage for this page the first time. Change-Id: I0288268cb0963ddc2e8446661ffd30a94a0744d2