summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2018-02-07loplugin:useuniqueptr in SdrOutlinerCacheNoel Grandin
Change-Id: Ie34f1bd9e46bf767ec2e1918c2b88cf289f4b410 Reviewed-on: https://gerrit.libreoffice.org/49330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-07use scanline when reading pixel dataNoel Grandin
extracts code from the innermost part of fairly hot loops And add a GetIndexFromData method to make the call sites a little easier to read. Change-Id: I4ce5c5a687ecdb6982562a0aafce8513d86f9107 Reviewed-on: https://gerrit.libreoffice.org/49337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-07loplugin:useuniqueptr in TextChainFlowNoel Grandin
Change-Id: Iad96df43c9c7ae6d5fd4f3aa9c2c5c721711da30 Reviewed-on: https://gerrit.libreoffice.org/49331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-07loplugin:useuniqueptr in SdrUndoObjSetTextNoel Grandin
Change-Id: Idd1eb8263d679efed0f0be88fb05963fe44f8668 Reviewed-on: https://gerrit.libreoffice.org/49328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-07loplugin:useuniqueptr in SdrTextNoel Grandin
Change-Id: I23cc319707132c28725acdb8be0bea275025b9e5 Reviewed-on: https://gerrit.libreoffice.org/49332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-07loplugin:useuniqueptr in SdrUndoGeoObjNoel Grandin
Change-Id: I8b48642a3a6ab4d94c1b58f8dae3589e703612b1 Reviewed-on: https://gerrit.libreoffice.org/49329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06ofz#5949 Integer-overflowCaolán McNamara
Change-Id: Ib1d39e6c80a579752aedd1ca0b41595192cfbbfc Reviewed-on: https://gerrit.libreoffice.org/49303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-06simplify ImpXPolygonNoel Grandin
just use a std::vector<std::pair<Point,PolyFlags>> Change-Id: I85de832af9095a33bda1620781c3b231a345e07c Reviewed-on: https://gerrit.libreoffice.org/49275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06loplugin:useuniqueptr in SdrTextObjNoel Grandin
Change-Id: I48f52056dcf17a568266be49f7422fa05be974db Reviewed-on: https://gerrit.libreoffice.org/49274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06loplugin:useuniqueptr in OLEObjCacheNoel Grandin
Change-Id: Ie16963e2b3b9d85d5640f03daa487dbe231af4a1 Reviewed-on: https://gerrit.libreoffice.org/49272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06loplugin:useuniqueptr in SdrEdgeObjNoel Grandin
Change-Id: I457520760d182fdd4f89cb7c7a4ea2c0e514e0c4 Reviewed-on: https://gerrit.libreoffice.org/49273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06loplugin:useuniqueptr in SdrObjPlusDataNoel Grandin
Change-Id: Iae857bcc98a3bfeaab9632651c8a1157a1520a51 Reviewed-on: https://gerrit.libreoffice.org/49268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06loplugin:useuniqueptr in SdrCreateViewNoel Grandin
Change-Id: Id9e52550264d2c1e0a838ff792f2257fddb64701 Reviewed-on: https://gerrit.libreoffice.org/49269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06convert SetPixel->SetPixelOnDataNoel Grandin
by extracting out the Y scanline computation from the innermost loop. Inspired by commit 078d01c1b6cb9bbd80aeadc49a71cc817413164c. Change-Id: Ic3c1827c01ed3aec629975749a551c7a68ae4a5e Reviewed-on: https://gerrit.libreoffice.org/48926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06clean up some include guard terminatorsNoel Grandin
found with git grep -n -A10 '#endif // INCLUDED' | grep -v endif | grep -v vim | grep -v -- '--' Change-Id: I7ae67cd7c1313e76f059fb8e6afb723caca8a6d7 Reviewed-on: https://gerrit.libreoffice.org/49244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05use unique_ptr to store GraphicObject for SdrGrafObjTomaž Vajngerl
Change-Id: I578156cd96e1e1400e93e96ace8a38759e3d1b2c Reviewed-on: https://gerrit.libreoffice.org/49221 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-05loplugin:useuniqueptr in E3DModifySceneSnapRectUpdaterNoel Grandin
Change-Id: Ied2cdfa314f86ff3a25cecd5c13c03d3428966f0 Reviewed-on: https://gerrit.libreoffice.org/49207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05ofz#4949 Integer-overflowCaolán McNamara
Change-Id: Ib8928108c987989ab849e8d7e1a85078f6d93050 Reviewed-on: https://gerrit.libreoffice.org/49216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-05vcl: remove BitmapColor Color() operatorChris Sherlock
BitmapColor has a Color() operator. However, this is confusing and tends to hide that the two classes aren't the same. I have converted this to GetColor(). Change-Id: I0be2dcb3fc420e7be9c8d04330e7a3fe69a5412a Reviewed-on: https://gerrit.libreoffice.org/48245 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-05loplugin:useuniqueptr in ViewObjectContactNoel Grandin
Change-Id: I69721e71f5351276d43d04107058eeb14d4925aa Reviewed-on: https://gerrit.libreoffice.org/49213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in MasterPageDescriptorNoel Grandin
Change-Id: I54d46aeec5f74ccf088ea33d03fd1d8a2009d43f Reviewed-on: https://gerrit.libreoffice.org/49211 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in E3dDepthNeighbourNoel Grandin
Change-Id: I14be7edea88e980c065db25a0195a84dad087e93 Reviewed-on: https://gerrit.libreoffice.org/49210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in ObjectContactNoel Grandin
Change-Id: I89104fe93bbb2db4ca7c092784583eac6fbdda08 Reviewed-on: https://gerrit.libreoffice.org/49209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in GalleryNoel Grandin
Change-Id: Ia12805bff0403fe260786360233be677ef91f710 Reviewed-on: https://gerrit.libreoffice.org/49208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-03more TypedWhichId in SfxShell and SfxTabDialogNoel Grandin
and remove some unnecessary local copies of pool items Change-Id: Ifdac8d84658fd4b803267038592d7da370e23a0d Reviewed-on: https://gerrit.libreoffice.org/49138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-03use more TypedWhichId in SdrObject::GetObjectItemNoel Grandin
Change-Id: Iacaffa4bfcca2b594d962985fb9fc93712c4464c Reviewed-on: https://gerrit.libreoffice.org/49137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02use TypedWhichId in BaseProperties::GetItemNoel Grandin
Change-Id: Ic359d33d92928f5baa89cd98debe1a6a9d6a52f3 Reviewed-on: https://gerrit.libreoffice.org/49128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01Fix typosAndrea Gelmini
Change-Id: Id9d4f277ec684f4baaa9f16000da1b208d745e03 Reviewed-on: https://gerrit.libreoffice.org/49099 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-01tdf#42949 Remove unneeded helpids.h headers (2/3)Gabor Kelemen
A side effect of the .ui migration is that we use a lot less HIDs in the code. A lot of files still contain helpids.h includes even if no actual HID is referenced. This cleans up directories r* - svx*. Found with: git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_ | grep :0$ Change-Id: I81bdb80161b0207f5df651eb17c58caef44250d3 Reviewed-on: https://gerrit.libreoffice.org/46869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-01split out SFX_METRIC_ITEM into separate fieldNoel Grandin
instead of overloading the nMemberId field and thus fix various places that were effectively setting the METRIC flag and causing a warning in SvxUnoConvertToMM And fix bug in sw/source/core/unocore/unomap.cxx where the PropertyAttribute::READONLY was in the wrong place, ever since commit 84a3db80b4fd66c6854b3135b5f69b61fd828e62 Date: Mon Sep 18 23:08:29 2000 +0000 initial import Change-Id: Ifc2bf56709f19aea75300b2fda62ce551efc26af Reviewed-on: https://gerrit.libreoffice.org/48950 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01Change bitmap table to store XBitmap instead of GraphicObject URLTomaž Vajngerl
As we want to get rid of GraphicObject URLs for the more robust image life-cycle handling, it was necessary to change the way bitmap table stores and handles images, so that they always store a Graphic object (wrapped in UNO object that provides the XGraphic and XBitmap interface). In addition this changes loading and saving from ODF (xmloff) and OOXML (oox) filters so they don't depend on GraphicObject URL anymore, but load or save directly to / from XGraphic or XBitmap. Change-Id: I2b88e10056e7d6c920249d59188f86b1a5a32d21 Reviewed-on: https://gerrit.libreoffice.org/49074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-01add XGraphicStorageHandler interfaceTomaž Vajngerl
This is a XGraphicObjectResolver (future) replacement as it will not be needed anymore. All resolving from URL to URL will be replaced by loading, saving and serialization of XGraphic objects (when appropriate), which is covered by this interface and implementation by XmlGraphicHelper - the same that implements the XGraphicObjectResolver. Change-Id: I227634e443ce336218c2a2effaf34f9ef3576382 Reviewed-on: https://gerrit.libreoffice.org/49073 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-01Fix typosAndrea Gelmini
Change-Id: I455efa82de60b764a500e1cc092ae08e800ec824 Reviewed-on: https://gerrit.libreoffice.org/49068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-30Use for-range loop for SdrMarkList::ClearJulien Nabet
instead of calling n times GetMark Change-Id: I5a00fd039d42b45dd491d8927dc1e44fe559ce3a Reviewed-on: https://gerrit.libreoffice.org/48886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-30Fix typoAndrea Gelmini
Change-Id: I8204875e480356cdb5ce7bc26996884eb1f4c131 Reviewed-on: https://gerrit.libreoffice.org/48859 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-29ofz: solveCrossovers performance is abysmal on large polygonsCaolán McNamara
just give up on it for fuzzing purposes Change-Id: I8d91fa547d83bc2f28454812280b0a7054e05b62 Reviewed-on: https://gerrit.libreoffice.org/48835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-29Fix typosAndrea Gelmini
Change-Id: I67ea0d54a06f1280ccdbc1ce65b940d78df701b3 Reviewed-on: https://gerrit.libreoffice.org/48827 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-29Translate German variable namesJohnny_M
Korr -> Corr in SVX Change-Id: I51311013024557aca1b4b3f660e6c5cef31f3f1b Reviewed-on: https://gerrit.libreoffice.org/48783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-29BorderlineFix: Corrected wrong indexing in Array initializationArmin Le Grand
Change-Id: I4222ef1c82620a05cea9f6db1a0664196cfb3bd4
2018-01-29BorderlineFix: Use svx::frame::Array tooling in Draw/ImpressArmin Le Grand
For creating the needed BorderPrimitives for TableCells for the Tables used in Draw/Impress, adapt the ViewContactOfTableObj doing this to use svx::frame::Array tooling now. This will correct the error for not taking the neighboured connects for merged cells into account and unify one more space to the same tooling. Change-Id: I2e6f732985e9b963359f156628bd29ddfec1a80c
2018-01-29BorderlineFix: Corrected Draw/Impress TableStyle accessesArmin Le Grand
In Draw/Impress the indices for accessing the correct neighbouring TableStyles were wrong and thus created wrong visualizations, corrected that. Change-Id: Iebc5f294adb62fa4c6358e2f8c27d29cc3163fbc
2018-01-29BorderlineFix: Fixed visual updates when scrollingArmin Le Grand
For Cells with DoubleLine the connections to perpendicular DoubleLine-Styles may have to be displayed in a Cell which is 'around' the orig cell in a Cell-Border of one. To represent that and to avoid repaint errors when scrolling in, the preparation of Primitives has to take accordingly more neighbour cells into account. Tested this change with the usages in Calc, UI (Dialogs) and Calc exports Print/PrintPreview/PDF. This does not affect Tables in Writer and/or Draw/Impress. Change-Id: I3bcc68cdf7b4fc1825a87a9773892c359421024e
2018-01-29BorderlineFix: Corrected handling for 'rotated' CellBordersArmin Le Grand
CellBorders can be rotated (including their Text) and need special visualization that is based on an own sheared/rotated coordinate system. Currently only possible for single cells (not merged ones) and needs to handle all borders (also bottom-right directly in the rotated cell, not in the neighboured ones to have the geometry, plus avoiding these in the non-rotated neighbour cells. Also corrected adding CellRotation data to svx::frame::Array in calc using SetCellRotations() which now gets called in the ScOutputData constructor to ensure it gets called in all places where it is used. Change-Id: I47bdfc29ba5ca76bbc07d98cb64733f867b1ee20
2018-01-29BorderlineFix: Avoid BorderLines to be too prolongedArmin Le Grand
For MergedCells there was an effect that the BorderLines were painted too far in PrintPreview/Print/PDF visualization, found reason and changed. Checked (hopefully) all usages, looks good. Change-Id: I0acf8dcb20548a98533f3ab317ac72c0d0f0a947
2018-01-29BorderlineFix: Corrected missing borders in printArmin Le Grand
In Print/PDF/PrintPreview border lines were missing, this happened for merged cells. It has to do with access to the involved Styles and/or 'Clip' set (to avoid creating everything). Thus a 'mixed' usage of cell and merged-cell stuff was needed. As it turns out support for this is already there, need to use it. Change-Id: Ic16085b97eef5c79a4501279432f43491bca350e
2018-01-29BorderlineFix: Need to redesign Borderline paint for CalcArmin Le Grand
To fix some errors, need to change svx::frame::Array conversion to Primitives, especially regarding handling of merged cells. These make problems in the currtent form where the full extended merged cell tries to be converted. This is bad for cropped stuff and also wrong for double-line stuff attaching to a merged cell. The solution is to handle cells single and merge created primitives which is more expensive but will work. This will involve special handling for X-Ed (crossed) and 'roated' Cells. Also need to be very careful since all this is used in the meantime for all visualizations of Tables in multiple apps/situations. Change-Id: If0652a3ba97a6f27dd5d782ea22b1514303f3710
2018-01-28Remove redundant checksStephan Bergmann
...that date back to a909acb7009acadffa53e74ea05ddb88803490f1 "#98735# Refactored unoedit/unoedacc.cxx", before SvxTextForwarder::GetParaBounds was changed from sal_uInt16 to sal_Int32 with 2af1f5691e8d64afd5246d245d7876b5a2cd5cd8 "resolved fdo#35756 import more than 64k HTML table cells" Change-Id: Ia92dcf1fb6742779e5fd51ed3ba8f0db565f8965 Reviewed-on: https://gerrit.libreoffice.org/48715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-28make SvxTableController constructor take SdrTableObjNoel Grandin
since the only call site already effectively checks that, simplify the constructor code accordingly Change-Id: I29e5283d529a988693972d85cfa8196ba2906220 Reviewed-on: https://gerrit.libreoffice.org/48651 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-28make RECT_EMPTY purely an implementation detailNoel Grandin
and make outside code use the IsEmpty/SetEmpty methods Change-Id: I4821d1bdceb99bb6a837a85ff2131003f9a160a5 Reviewed-on: https://gerrit.libreoffice.org/48584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-27improve subtyping when dealing with tools::WeakReferenceNoel Grandin
tweak the templating to make it easier to declare a WeakReference that points to a subclass for a weak-capable class. Which lets us declare some fields with more specific types, and dump a lot of unnecessary casting. And make WeakBase be inherited from virtually, so we don't end up with weird states where two weak refernces could point to two different parts of the same object. Change-Id: I3213ea27e087038457b0761b5171c7bce96e71f3 Reviewed-on: https://gerrit.libreoffice.org/48650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-27 07:38:47 +0000