summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2017-10-24loplugin:finalclasses in svxNoel Grandin
Change-Id: I74296e2185902498cd569ecde83905f718a41e84 Reviewed-on: https://gerrit.libreoffice.org/43715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: svxStephan Bergmann
Change-Id: I4057fe05983fb2b63b592ffd325894c12b9cb5b2
2017-10-23tdf#96505 Get rid of cargo cult long integer literalsudareechk
Removed 0L, 1L and 2L Change-Id: Icb38de1cdd8e1215a86118b0c8af993025fd790e Reviewed-on: https://gerrit.libreoffice.org/42567 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-10-23tdf#105000, related tdf#87538: Make new color names translatableGabor Kelemen
Make the new color names of the Tango palette translatable These were added in 494cdeda9700ee1fcbfbed1b22f7436927bd6c72 Change-Id: Ie81dd42e011bcc36884c3c4c31ac65d83bfe6e31 Reviewed-on: https://gerrit.libreoffice.org/41614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-22TSCP: support abbreviated classification namesAshod Nakashian
Change-Id: Ib7edc491d2f8a69c48f1515ba29d79e09c88c3b7 Reviewed-on: https://gerrit.libreoffice.org/43627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-21loplugin:redundantcast handle dynamic_castNoel Grandin
Change-Id: I7855c76e820efce96778b1c19ec71dffcc4b4abb Reviewed-on: https://gerrit.libreoffice.org/43621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-21tdf#105000, related tdf#87538: Make new color names translatableGabor Kelemen
Make the new color names of the Standard palette translatable These were added in 78869ad9d4c904e665529befe5181ea5121fba1d Change-Id: Iccc43cc4ef44c8ca587b6df2b08c6e1b45e4b118 Reviewed-on: https://gerrit.libreoffice.org/41330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-20Fix typosAndrea Gelmini
Change-Id: Ia61b174eb48e0cb80d4b7d404d3b815537ba7cb1 Reviewed-on: https://gerrit.libreoffice.org/43615 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-20RotGrfFlyFrame: Added interactive rotation modeArmin Le Grand
The FlyFrames containing a graphic now support an interactive rotation mode. Added a rotation icon to the Toolbar close to right/left 90degree rotation. When activated, works as similar to draw object mode as possible. Shear and move of the rotation center is deactivated since not supported. It uses as much of the existing interaction stuff as possible. Change-Id: Ia1a4e5c064d8576b114c3fcf3a96ccb42c9372bb
2017-10-20RotGrfFlyFrame: Implemented Handle Update on rotation changeArmin Le Grand
WIth rotaiton being allowed the handle visualisation may be dependent on this, so it is necessary to refresh their visualisation on rotation chnage, e.g. for crop handles Change-Id: I218e326894999381fc4058b7eba432491a0cf23b
2017-10-20RotGrfFlyFrame: Encapsulated matrix decomposesArmin Le Grand
Change-Id: I432766970ef06c7d85a0056d3f24280cf2acd47d
2017-10-20RotGrfFlyFrame: Adapt Crop functionality to rotated GraphicArmin Le Grand
The FlyFrame which may contain a Graphic needs working Crop, interactive and in core. Adapted this to work with now possible rotation, changed common code in svx which has to handle cases for Draw/Impress/Calc and Writer differently. Tried to use as much in common as possible. Additionally furter adaptions to rotation itself. Change-Id: Ia961e9490e2627c74220b186116f5aa4fcabca78
2017-10-20RotGrfFlyFrame: Initial adaptionsArmin Le Grand
To allow free rotation of Graphic FlyFrames in Writer, several adaptions are necessary. This change takes care of all needed changes to internally support a freely definable rotation angle for that case. Save/Load round trip is working, the graphic does no longer get modified and added in 90-degree-changed state to the object, the original will be preserved. Support for needed slot in core/ui is implemented. Rotation can be applied from Menus/Toolbars in the known 90/180 degree steps. Added a slot/Button/command to reset rotation in these cases. Added support in Sidebar to rotate using the rotation wheel and/or numeric field. These fields and support added to Image TabPage, too, fully functional. Missing now is a solution for displaying the rotated Graphic. For now, it just gets rotated, but this will not be the final state of this change. Change-Id: I6f3b85ebb5be2b4ad3311c536d54f27a37a494e7 RotGrfFlyFrame: Linux build adaptions Change-Id: I365287ecd6525b1972e8436d61332f7121d88649
2017-10-20tdf#97630 xmloff: ODF extended draw:fit-to-size messMichael Stahl
The plan: 1. As Regina points out, there is already (in ODF 1.2, but not ODF 1.1) a style:shrink-to-fit attribute for shapes, so use this to represent the AUTOFIT value. The fallback from AUTOFIT to draw:fit-to-size="true" was a stupid idea anyway, probably "false" is less annoying in practice. There are 2 different shapes that implement TextFitToSize property: a) text shapes already interpret ALLLINES and PROPORTIONAL exactly the same b) fontwork custom shapes interpret ALLLINES but do nothing for PROPORTIONAL As Regina points out, there is no shape that needs to distinguish between ALLLINES and PROPORTIONAL, so we do a minor behavioral API CHANGE and from now on interpret PROPORTIONAL as ALLLINES on fontwork custom shapes. This obviates the need to distinguish the values in ODF and so we don't need a new attribute, just use draw:fit-to-size="true" for both. On import, use MID_FLAG_MERGE_PROPERTY to combine the 2 attributes into one value. 2. Restrict the export of draw:fit-to-size to only the standard values "true"/"false". This implements step 1, the step 2 will be done in the future when most users have the import of the style:shrink-to-fit. Change-Id: I4a378aa110fdb82db7a99a839d7ff207248a73e7 Reviewed-on: https://gerrit.libreoffice.org/43521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-19use std::unique_ptr in SvxUnoPropertyMapProviderNoel Grandin
Change-Id: I774718e74bdf2e022a01188a05c8928813ad653f Reviewed-on: https://gerrit.libreoffice.org/43524 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-19Fix typosAndrea Gelmini
Change-Id: I101357736813bfd47fb15d347fd2c0a33133de56 Reviewed-on: https://gerrit.libreoffice.org/43506 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-19tdf#112817 Fix the sidebar underline dropdownMaxim Monastirsky
Regression of commit 03041e0f8d8385847c2e77fcaf08c1d33cad938f ("tdf#112817 editeng,svx: fix SvxUnderlineItem/SvxOverlineItem SDI") Change-Id: I68a19a47c5e9511b5d8ce0d6c312c814490bc044
2017-10-18Resolves: tdf#113214 change back to previous entry after 'more' is dispatcherCaolán McNamara
Change-Id: Ic5bd5f9182e47c6dfdab8fcd6399ffc482a4fb6a Reviewed-on: https://gerrit.libreoffice.org/43512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18return early on failureCaolán McNamara
Change-Id: Id96ba954d3056cf982701090cf84ab4b1793b40b Reviewed-on: https://gerrit.libreoffice.org/43489 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18potential deref of empty xStateSetCaolán McNamara
Change-Id: I83d876b0d966b18cdf85249b7e856e4e4f4dec27 Reviewed-on: https://gerrit.libreoffice.org/43488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18Resolves: tdf#109282: a11y crash in use after disposeCaolán McNamara
calc, chart in tab 3 with a11y enabled, select chart switch to tab 1, crash cause mpParent has been deleted, IsDisposed is correctly set, but shape accesses parent anyway Change-Id: I6f57a798bfcc82eebb883291cec54e157ff5187b Reviewed-on: https://gerrit.libreoffice.org/43487 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18svx: remove pointless duplicate SdrFitToSizeTypeMichael Stahl
Change-Id: I7a59ecfdb8d09ecbc0b760003dbc453ac5646d1c
2017-10-17turn implicit container explicit in buildable notebooksCaolán McNamara
as in interim measure for SfxTabDialogs we throw away the TabPage if its not suitable for reuse Change-Id: Ic5776ca3d2a8cb6bf41f33df01b211f81c62a842 Reviewed-on: https://gerrit.libreoffice.org/43134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-17use rtl::Reference in SvXMLEmbeddedObjectHelperNoel Grandin
instead of manual ref counting Change-Id: I6b88b72dd28183feca46fc04841a2e8f19e5c47a Reviewed-on: https://gerrit.libreoffice.org/43421 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-16Move svx include files to common include directoryStephan Bergmann
...that are included from various source directories. Change done in preparation of loplugin:includeform. Change-Id: I9191e80aa721c376f17219e4d10eb83929e38e14
2017-10-16use rtl::Reference for SvXMLGraphicHelperNoel Grandin
Change-Id: I0052b29660fb6157f7e98c4e124f030ba439d304 Reviewed-on: https://gerrit.libreoffice.org/43417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-16Replace list by deque in AccessibleTextEventQueue (svx)Julien Nabet
Change-Id: I9bbe0fe0536b06e28af9c3c2be4df0cd7bf3f72a Reviewed-on: https://gerrit.libreoffice.org/43380 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-14Replace list by vector in unogaltheme (svx)Julien Nabet
Change-Id: I6172c5aae60efe929554589147e49a2cf036633b Reviewed-on: https://gerrit.libreoffice.org/43379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-09svx, implement HAVE_FEATURE_AVMEDIAjan Iversen
iOS does not support avmedia, therefore HAVE_FEATURE_AVMEDIA is set, however not all sources test for it. Change-Id: I351d36769f82289e6b7fa61b3509aa1f34458989
2017-10-08tdf#106642 Wide color buttons are only for the sidebarMaxim Monastirsky
Change-Id: I3c75495b0f450ccf0eb8f9de715c7c7befc7bbe6 Reviewed-on: https://gerrit.libreoffice.org/43238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-10-08Remove some old workaroundMaxim Monastirsky
Can't reproduce the original problem anymore, and in the meantime the sidebar color button code was totally replaced with a SvxColorToolBoxControl based solution (see tdf#84844). So no evidence we still need this special handling of COL_BLACK. Change-Id: I9ab5e65e6ea1dc599ba850cfcaae62c73947159a Reviewed-on: https://gerrit.libreoffice.org/43237 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-10-06use more rtl::Reference in SdrLightEmbeddedClient_ImplNoel Grandin
instead of manual ref counting Change-Id: Ia07d5411c45d24934a619016cd8dbfb1fac6cc4b Reviewed-on: https://gerrit.libreoffice.org/43204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-06use rtl::Reference in SvXMLEmbeddedObjectHelperNoel Grandin
instead of manual ref-counting Change-Id: I559ebb3871dd3dd4a160bd83a259e36dd2f7b4d6 Reviewed-on: https://gerrit.libreoffice.org/43200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-05tdf#112817 editeng,svx: fix SvxUnderlineItem/SvxOverlineItem SDIMichael Stahl
This was asserting because the superclass SvxTextLineItem was instantiated instead of the specific subclasses. Change-Id: If26847b8fa96dbf00062ba8372fe58e58c786782
2017-10-05loplugin:mergerclass merge FillAttrLB with SvxFillAttrBoxNoel Grandin
Change-Id: I5dfa7689eb219548bde7ce181a0a453c84b0f066 Reviewed-on: https://gerrit.libreoffice.org/43136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-05clang-tidy modernize-use-equals-default in svxJochen Nitschke
SfxPoolItem has a copy constructor and its copy assignment operator is deleted. Derived classes have a implicit defined copy constructor too, if all members are copy constructible. This patch removes default-able copy constructors and destructors on such items. Also removing copy constructors of pool item members SvxClipboardFormatItem_Impl and SvxColumnItem. Change-Id: Ic0f39c992d1fd7b667cb56134fd7c953681a3131 Reviewed-on: https://gerrit.libreoffice.org/43143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-04simplify memory management in ImpXPolyPolygonNoel Grandin
just use a std::vector<XPolygon> Change-Id: I1adb801faa8341e0759a86fd209a530b8f5c5a1c Reviewed-on: https://gerrit.libreoffice.org/43086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-04drop WB_SDRMODE in favour of explicit methodNoel Grandin
was the only style being used on the class anyhow, and there was already a field for it Change-Id: Icdbc9f312851e0476a8b1d21fd4dc9c8166d4e08 Reviewed-on: https://gerrit.libreoffice.org/43085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-04convert SDR_TRISTATE to TriStateNoel Grandin
Change-Id: Iac440d313006d01667e433bea97925ccaa9282da Reviewed-on: https://gerrit.libreoffice.org/43084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03svx: Simplify SdrGluePointList with std::unique_ptrTakeshi Abe
This also inlines SdrGluePointList::GetObject(). Change-Id: I70052a5e94b3451f5a00e1185e6dee59e5537184 Reviewed-on: https://gerrit.libreoffice.org/43059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03new loplugin:blockblockNoel Grandin
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-01tdf#39468 Translate German comments (leftovers)Johnny_M
Change-Id: I9952c560547b0668d8216edba1486638fa41e553 Reviewed-on: https://gerrit.libreoffice.org/42990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-01simplify some OUString compareTo callsMuhammet Kara
to either startsWith or == or != Change-Id: I595dd9d89d32134827980c4ba10f88584430137d Reviewed-on: https://gerrit.libreoffice.org/42988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-01Prefer prefix operatorJulien Nabet
Change-Id: I82f3f66bfc675dbc4a5d5b57d8715c3de01d9620 Reviewed-on: https://gerrit.libreoffice.org/42994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-01Wayland: Make various popups work in the overflow toolbarMaxim Monastirsky
Were failing to show, with this warning: Gdk-WARNING **: Tried to map a popup with a non-top most parent Change-Id: Ib68b5fc9b3edb3d25a23b66397c13833a4d080ac Reviewed-on: https://gerrit.libreoffice.org/42936 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-09-30svx: Stop returning unused XPolygonTakeshi Abe
Change-Id: I2cbd98f788a6b68365e094449f8f7e6d5e7426f4 Reviewed-on: https://gerrit.libreoffice.org/42930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-09-29tdf#112727: crash in chart (transparency related)Julien Nabet
There's nothing to rearrange if mpFloatTransparenceItem isn't set 0 0x00007fffefb26748 in NameOrIndex::IsIndex() const (this=0x0) at /home/julien/lo/libreoffice/include/svx/xit.hxx:56 1 0x00007fffefb23140 in XFillGradientItem::GetGradientValue() const (this=0x0) at /home/julien/lo/libreoffice/svx/source/xoutdev/xattr.cxx:2009 2 0x00007ffff0b2c95a in svx::sidebar::AreaTransparencyGradientPopup::InitStatus(XFillFloatTransparenceItem const*) (this=0x55555859a520, pGradientItem=0x0) at /home/julien/lo/libreoffice/svx/source/sidebar/area/AreaTransparencyGradientPopup.cxx:61 3 0x00007ffff0b2cd33 in svx::sidebar::AreaTransparencyGradientPopup::Rearrange(XFillFloatTransparenceItem const*) (this=0x55555859a520, pGradientItem=0x0) at /home/julien/lo/libreoffice/svx/source/sidebar/area/AreaTransparencyGradientPopup.cxx:90 4 0x00007ffff0b262ae in svx::sidebar::AreaPropertyPanelBase::ClickTrGrHdl_Impl(ToolBox*) (this=0x555558485a50, pToolBox=0x5555586ed8c0) at /home/julien/lo/libreoffice/svx/source/sidebar/area/AreaPropertyPanelBase.cxx:1272 5 0x00007ffff0b26207 in svx::sidebar::AreaPropertyPanelBase::LinkStubClickTrGrHdl_Impl(void*, ToolBox*) (instance=0x555558485a50, data=0x5555586ed8c0) at /home/julien/lo/libreoffice/svx/source/sidebar/area/AreaPropertyPanelBase.cxx:1268 Change-Id: I1d2db6b91c888ca3598e0ea04dd0fa0e9fc790a7 Reviewed-on: https://gerrit.libreoffice.org/42925 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-29convert IsEqual/etc methods on ESelection to operatorsNoel Grandin
Change-Id: Ia8424e701b6f22d0536ee7f3bdb0ecaaed94a3b9 Reviewed-on: https://gerrit.libreoffice.org/42904 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-14 05:21:29 +0000