summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2019-08-15tdf#122529 lok - table border position manipulationTomaž Vajngerl
This adds a new LOK callback (LOK_CALLBACK_TABLE_SELECTED) that sends the border positions to the client when the user has the cursor or slelection in a table. In addition this adds a .uno:TableChangeCurrentBorderPosition uno command, which implements changing a specific border in the current table. Border can be either a column or a row border, which is either at the first, middle or last position. Change-Id: Ife7cff14d91ffc84c95c040f0b42319e3d6194b4 Reviewed-on: https://gerrit.libreoffice.org/77365 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-13Fix typosAndrea Gelmini
Change-Id: If99059383039e65aacfc55baec660eb6fde47032 Reviewed-on: https://gerrit.libreoffice.org/77376 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I42f7ec098cb03cdbd4aa54b86f1c0171b317f956 Reviewed-on: https://gerrit.libreoffice.org/77282 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Ieccfec878aeaeacc55841f28c7d67cd2bd08556e Reviewed-on: https://gerrit.libreoffice.org/77284 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Ide33657e227cb165900685af08db40ddda3d8293 Reviewed-on: https://gerrit.libreoffice.org/77283 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Ied6e07ef44e67394338e552566aa58a274204440 Reviewed-on: https://gerrit.libreoffice.org/77281 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typoAndrea Gelmini
"an one" Change-Id: Ic12d139acfdb32aaf0089c60609feaa653fd686b Reviewed-on: https://gerrit.libreoffice.org/77259 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-10tdf#126512 make handle of ooxml-shapes usable in odpRegina Henschel
The error was that handles in OOXML shapes can be used in LibreOffice as long as you work in OOXML format, but not anymore when you convert the file to ODF. Handles in OOXML reference the adjustment values by name, e.g. 'RefX = adj5'. ODF has no way to save this, so this information is lost. The patch reconstructs this information from the shape definition of the preset shape. It gets the preset shape name 'foo' from the shape type 'ooxml-foo'. This means that it only works with our own naming convention. Still, I think it's an improvement for our users. Change-Id: Iebd9f36a5c36356a12c8687e961c7802111cbd85 Reviewed-on: https://gerrit.libreoffice.org/76887 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-08-08Revert "tdf#126741 - fix dash dot dot line style display"Samuel Mehrbrodt
This reverts commit 0b2e052238e87faf5b76fe89ed1e10b20c5a3eaa. Change-Id: Iccb1ed4549e9f8b98ecd1cf769fe583869fa2452 Reviewed-on: https://gerrit.libreoffice.org/77154 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-08tdf#74702: use OutputDevice::GetBackgroundColor()Chris Sherlock
Apply the Liskov substitution principle to OutputDevice::GetBackgroundColor(). This helps in SmTmpDevice::Impl_GetColor() because it no longer needs to know about what type of OutputDevice it is calling to get the background color. This forced a rename of basctl::ModulWindowLayout::GetBackgroundColor() to be GetSyntaxBackgroundColor(), but this is a happy coincidence as it makes the function intent clearer anyway. Change-Id: I11298a63cb01c187f3a8a4a2c9e90eacda6c3e6b Reviewed-on: https://gerrit.libreoffice.org/75521 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-08tdf#126722 Deleted svxcommands.h file and replaced defines by their valuesSzabolcs Toth
Change-Id: I9347add59fcd7c8c4bbd08f6190405ad39131046 Reviewed-on: https://gerrit.libreoffice.org/77143 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-08tdf#119228 Add 'Resolved Comments' option to the View menu.Scott Clarke
Change-Id: Ib4554b77857992959a386c71e99e424579196ded Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk> Reviewed-on: https://gerrit.libreoffice.org/75862 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-07tdf#126741 - fix dash dot dot line style displaynd101
To make it consistent with MS PowerPoint, make the dash dot dot line start with a dash instead of a dot Change-Id: I0491c78001e885c3216841b694745c451303917e Reviewed-on: https://gerrit.libreoffice.org/77079 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-06Move CopyHyperlinkLocation to svxSamuel Mehrbrodt
so that it can be used by other modules too Change-Id: I43d197320f85a3ec06b6b0b832f7bb5647800076 Reviewed-on: https://gerrit.libreoffice.org/77012 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-05Fix typosAndrea Gelmini
Change-Id: I66d48c809b263835016571772ce2ee529c16b8f4 Reviewed-on: https://gerrit.libreoffice.org/76960 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-05SmartArt: store diagram data model in SdrObjectGrzegorz Araminowicz
It will allow modifying loaded diagram and exporting it. This data is used for regenerating diagram instead of parsing xml fragment every time. Also provided an interface for UI that can be extended to show, add and remove nodes from data model. It is stored as SdrObject field because diagram top-level shape is group shape. Item set doesn't exist for them and storing data in child shapes is not possible here because children are removed and recreated on every diagram reload. Change-Id: I84e5ec955f638b254fef9ef9d1731ca7938982b7 Reviewed-on: https://gerrit.libreoffice.org/76121 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-03Fix typosAndrea Gelmini
Change-Id: Iaf2691b60796300f6c3acf56f60dcc526685eeb9 Reviewed-on: https://gerrit.libreoffice.org/76855 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-03Fix typosAndrea Gelmini
Change-Id: I5c95e180681220fc592400435d90e4d46603d41c Reviewed-on: https://gerrit.libreoffice.org/76883 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-01Make QR Code callable in calc and writerShubham Goyal
Change-Id: I73793100478c34a7721821cec1f8ccec0174d20c Reviewed-on: https://gerrit.libreoffice.org/74598 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): svxStephan Bergmann
Change-Id: Idbdee862f96a3d9e6baaa7203528a423c017eb80 Reviewed-on: https://gerrit.libreoffice.org/76640 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-30remove newly unused SvxCheckListBoxCaolán McNamara
Change-Id: I6a5f4dfea9fbb34f02c1752140e04d1d0a8a67a7 Reviewed-on: https://gerrit.libreoffice.org/76617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SwCompatibilityOptPageCaolán McNamara
Change-Id: Id66751642a631d033385c3da9ba5cd484ba9dcf6 Reviewed-on: https://gerrit.libreoffice.org/76616 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30tdf#126605: Do not end TextEdit when changing an attributeXisco Fauli
otherwise, pTextEditOutlinerView becomes nullptr in svx/source/svdraw/svdedxv.cxx:2184 Regression from e6c7a018a0cfee395ce2886d41c908a2447ef5cc Change-Id: I9d0645f637dc92b50d01682d119c0db60238e921 Reviewed-on: https://gerrit.libreoffice.org/76606 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-30weld OfaLanguagesTabPageCaolán McNamara
Change-Id: Ib0938f0c9d810c0f851dd0180093aabb4babdc19 Reviewed-on: https://gerrit.libreoffice.org/76594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SwRedlineOptionsTabPageCaolán McNamara
Change-Id: Ic901356d399e8d758747f0fea07d3656fbf89aab Reviewed-on: https://gerrit.libreoffice.org/76559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Fix typoAndrea Gelmini
"an API", to complete: https://gerrit.libreoffice.org/#/c/75984/ Change-Id: I441f89b44a96957ea254823b9f28086fa289cc54 Reviewed-on: https://gerrit.libreoffice.org/76036 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-28loplugin:oncevarNoel Grandin
Change-Id: I3c014f53607a849c743a2fd1aa47d03d5af978fb Reviewed-on: https://gerrit.libreoffice.org/76495 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28Fix typosAndrea Gelmini
Change-Id: I1b3f858cf56f93fc72f1508322c00647e12a4c43 Reviewed-on: https://gerrit.libreoffice.org/76481 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-07-27weld OfaHtmlTabPageCaolán McNamara
Change-Id: I10ee46d19047da9a3e3d8b0f99866568a12aa0f1 Reviewed-on: https://gerrit.libreoffice.org/76471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-25tdf#47807 Invalidate bindings to Undo RedoJim Raykowski
This patch reverts the previous commit made for this and provides a new fix. Change-Id: I487ecf0a7564f1130ef9a42e893e73185701d8c9 Reviewed-on: https://gerrit.libreoffice.org/76287 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-07-25tdf#126537 correct reverse calc for handle in ooxml-parallelogramRegina Henschel
Reverse calculation of handle position of ooxml-parallelogram shape has to follow the x/ss*100000 pattern. Error was, that it was not listed in that section. Change-Id: I846c21fe12c7e64e0c947e32d4b680fba60a5e50 Reviewed-on: https://gerrit.libreoffice.org/76311 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-07-25QRCode Dialog Box featureShubham Goyal
The patch handles the created QR code as a Customized Shape (Graphic Object) Change-Id: I1cee6f0e7fac585de880a9ac34e3bc441a4b7390 Reviewed-on: https://gerrit.libreoffice.org/74167 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-25tdf#47807 Invalidate bindings to Undo RedoJim Raykowski
Change-Id: I71a16e60395003402372202a755b976d37690a27 Reviewed-on: https://gerrit.libreoffice.org/76146 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-07-24Fix typosAndrea Gelmini
Change-Id: Ib778a6598f3797fe871a25b56b7b4b7761889296 Reviewed-on: https://gerrit.libreoffice.org/76269 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24remove unused accessibility::DescriptionGenerator::PropertyType::FillStyleNoel Grandin
Change-Id: I20005ad23088d41262ff988eac2132918db56ab8 Reviewed-on: https://gerrit.libreoffice.org/76236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24cid#1448545 silence Wrapper object use after freeCaolán McNamara
Change-Id: Ia1b3137916ae37ed73ac9923af847aa15978dc86 Reviewed-on: https://gerrit.libreoffice.org/76228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-23dispose() methods should clear their smart pointersNoel Grandin
especiall the ref-counted ones Change-Id: Ib3bb029043b1b923010ef4a47bfc377e1f569da7 Reviewed-on: https://gerrit.libreoffice.org/76102 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-22tdf#118370 Draw: add option to consolidate multiple textObjsJustin Luth
This gives the user a tool to consolidate multiple textboxes into a single textbox. First the user selects a group of textframes, and then runs the consolidate text function. This will REPLACE the marked textframes with a single textbox combining all of the text. The function inspects the text fragments to see if they end in sentence-ending punctuation. If not, then the next textbox's content is appended to it instead of starting a new pargraph. It is the user's responsibility to afterwards fix up paragraphing, and set paragraph properties. The rational for this patch is to simplify making major text changes on PDFs imported into Draw, since each paragraph is currently broken into tiny character-property textbox fragments. Copy/paste from the PDF itself doesn't keep character attributes, so it is hard for a user to re-create the text. This is related to tdf#32249, but as a comment says, a better solution would be to write an entire text-focused PDF import, rather than just pick up the pieces. And I agree, but considering this simple patch took me a couple of weeks of frustration, I'm obviously not the person to do that. And since the bug has been open for 9 years, likely no one else will either. Thus, this pick-up-the-pieces tool to help the end user. This initial patch works only with textFrames, but can easily be adjusted to consolidate other HasText() SdrObjects. However, that tended to produce unexpected results, so everything other than OBJ_TEXT is explicitly excluded. (Thus general shapes with text, callouts, text-along-path etc are ignored.) Change-Id: I68a9a5b187bf320a8e671414c5cb22b07725fd52 Reviewed-on: https://gerrit.libreoffice.org/75043 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-07-21Fix typoAndrea Gelmini
"an OLE", to complete: https://gerrit.libreoffice.org/#/c/75983/ Change-Id: Idd5b9286348b4fa1e3382983c72b010654a1f4c2 Reviewed-on: https://gerrit.libreoffice.org/76038 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-20loplugin:referencecasting in svxNoel Grandin
Change-Id: I2f6bc2467fa7689d186bc2bc45d2071ea0a38e63 Reviewed-on: https://gerrit.libreoffice.org/75998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19cid#1448484 Unchecked return valueCaolán McNamara
Change-Id: I4e06228665c90820e88c72bfe4e462af9a0074e9 Reviewed-on: https://gerrit.libreoffice.org/75897 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448251 Unchecked dynamic_castCaolán McNamara
Change-Id: I96b87d05d6633849d7a32a40e87b9fb4ee48b15d Reviewed-on: https://gerrit.libreoffice.org/75916 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19loplugin:constantparamNoel Grandin
and tweak the plugin to handle a crash seen with clang-9 Change-Id: Ie1ccf80c16a20dbca58e5bd081af13f75cf5ac8f Reviewed-on: https://gerrit.libreoffice.org/75850 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-18svx xml dump: show the SdrObject's properties / item setMiklos Vajna
Shows items usually accessed using GetMergedItemSet(), to help debugging. Change-Id: Id3c20e99c33d5e5762c3b58e2f76ab5686031734 Reviewed-on: https://gerrit.libreoffice.org/75852 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-18tdf#126051 sync MINBODY copies to same valueCaolán McNamara
Change-Id: Id41da7b07dcb25e820e5fd20aed595b1170fa204 Reviewed-on: https://gerrit.libreoffice.org/75807 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448253 Use after freeCaolán McNamara
Change-Id: I83f3ef82faafd31f5a1afca9c5ab3f4040c3552b Reviewed-on: https://gerrit.libreoffice.org/75812 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17Resolves tdf#115087 and tdf#121437 - Improvements to color barHeiko Tietze
Tooltip for parent with hint on left/right click Position of widget right (ideally it would go below the sidebar) Automatic color moved to the bottom to preserve arrangement Change-Id: Ia3cb1c2c7c20dbc6730c7f003c67b0876514c23f Reviewed-on: https://gerrit.libreoffice.org/75749 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-17external: update pdfium to 3849Miklos Vajna
Change-Id: I616f57bd9de72b078500a290bf9ff89c71773f26 Reviewed-on: https://gerrit.libreoffice.org/75736 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-16cid#705480 Dereference null return valueCaolán McNamara
Change-Id: I0ad30d7a2447edbe9d42f0e69470ca850498b798 Reviewed-on: https://gerrit.libreoffice.org/75722 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448424 silence Uninitialized pointer fieldCaolán McNamara
Change-Id: Ie68cb97a092753185cc31c0b590fe75fad79989b Reviewed-on: https://gerrit.libreoffice.org/75668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>