summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2014-11-17cppcheck: Same expression on both sides of '||'Julien Nabet
Change-Id: I89c758366c2140f0033c1006f6a03bbc17ea8096 Reviewed-on: https://gerrit.libreoffice.org/12459 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-17More HIG fixes in filter, svxAdolfo Jayme Barrientos
Change-Id: I74df6b8221b4bb18791ec81af266dd58571c4c8c Reviewed-on: https://gerrit.libreoffice.org/12489 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-17-Werror,-Wunused-variableStephan Bergmann
...since 286e2f5c6ec829bc0987b1be7016699f7ef03e5e "Related fdo#82953: Forget package URL of image after it is loaded" Change-Id: If4cc941353b72f555dee26d158aee7b15b359a9c
2014-11-16Logically dead code related to embedded stream name in SwGrfNode\SdrGrafObjZolnai Tamás
See also: 286e2f5c6ec829bc0987b1be7016699f7ef03e5e Since embedded URL exists until the first swap in these lines are not needed anymore. Change-Id: Ie6bf8efe7808cf42f20f7b4b3f8cb927555c0ea8
2014-11-16Related fdo#82953: Forget package URL of image after it is loadedZolnai Tamás
It causes problems if we handle those imported images differently which are identified by a package URL, so after the first load remove this URL and handle images on the same way as inserted images. Some related bugs: * #i44367# * #i124946# * #i114361# * fdo#73270 The image in the test document has a special ID which is different from that one which is generated by LO internally so after ODF export the new generated image URL is different from the imported one. Change-Id: I4e7d3490674c5f86bec5c7c6e1c975dcafd7c265
2014-11-16vcl: let the ModalDialog ctor take an OUStringMiklos Vajna
Change-Id: I839435338f4acf80c40896b6c86f7ef122f5449d
2014-11-14more catch by referenceCaolán McNamara
Change-Id: I2db9f94a517f814ef0854190e6f1194501070409
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-13Realy->ReallyCaolán McNamara
that's really bugging me Change-Id: Id15bd4dc42748b3cb24eb891741195499c5df9c3
2014-11-13impress tables are not interactively growingCaolán McNamara
the optimization here stops tables growing as their text contents change in editing mode So, just recalculate if the table could grow and its being interactively edited, which leaves the original (dubious ?) load-time optimization in place Change-Id: I894acf47d34ec8b68aaf9076b5a0cb7e29c38a17
2014-11-13table layout cache returns wrong rectangleCaolán McNamara
the layouter can modify its input rectangle to grow it to the necessary size to contain the layout but we're returning the input rectangle when the inputs are the same as the last call, not returning the output rectangle. cache the output rect for a given input and return that so now insert->table in impress and tab so extra cells are added and then select the table and the blue border contains the whole table, not just the first two rows Change-Id: I4f09594d82c1597204afbd059e175af9bf8e2527
2014-11-13fdo#85776 swap increase and decrease indent in sidebarYousuf Philips
Change-Id: I5f6dd2244adecd2dba7e03ff3f620bd4c7657d7b Reviewed-on: https://gerrit.libreoffice.org/12396 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-12coverity#1187642 Unchecked return valueCaolán McNamara
Change-Id: I6b96ef79d0996e5b783d27c4da8e45ddeac5c7ab
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo82708 Add missing tooltips to Writer StatusbarSamuel Mehrbrodt
Change-Id: Ie44b8de69b98ebfa789cc8f9a1d8a60b698fc154 Reviewed-on: https://gerrit.libreoffice.org/12368 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-10fix spelling implemenation -> implementationNoel Grandin
Change-Id: I5ac499df1f4063a80a5d41f60778106a7b96940d
2014-11-10callcatcher: unused codeCaolán McNamara
Change-Id: I2ead5d998c3b1b3cde1222fee6f072bf09ab0021
2014-11-10coverity#1251167 Logically dead codeCaolán McNamara
Change-Id: I8294eaf8109ab5b8bc7972da1e5fa2ba9ad819fb
2014-11-10merge vcllo and vclopenglloMarkus Mohrhard
Change-Id: I419ca67dc1f87dd9ac751aa5a094fecf58136edb
2014-11-09fdo#82707 Unify click behavior in Statusbar (Writer)Samuel Mehrbrodt
Use single click for primary action, right click for context menu Change-Id: Ia707a88b48f4af144588c45d37acea547e77773e
2014-11-09fdo#86050 Let LibreOffice add scrollbars to widgets only when necessaryAdolfo Jayme Barrientos
Change-Id: I1a930a413c071d4d0c8855315dc85339e01b7d9b Reviewed-on: https://gerrit.libreoffice.org/12322 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-09Synchronize bullets listsMaxim Monastirsky
The default bullets list is defined in two more places: svx/source/dialog/svxbmpnumvalueset.cxx cui/source/tabpages/numpages.cxx in both cases there is no separate RTL list. (And since we're using SvxNumValueSet also for the popup, we must sync it, so the shown bullet would be always the applied one.) There is lots of code similarity/duplication in this area (primarily introduced by the sidebar), and I hope to clean this at some point. Change-Id: Ifcc216101ed2f105a40fb483aa1b96a9e93d00e0
2014-11-09Reset prefix and suffix for bulletsMaxim Monastirsky
It seems needed in Impress, when applying a bullet using the popup after a numbering with prefix/suffix was applied. Change-Id: I0faf8149b3564de9b08fb8107d7a639ae41d2133
2014-11-09Try to make MSVC happyMaxim Monastirsky
Change-Id: I064c58608914f3f179695bf6ec5f7e311162a2fa
2014-11-09More cleanupMaxim Monastirsky
Change-Id: I1f900029cb6a0fb389617c153dd187cf63ed2c7b
2014-11-09fdo#85804 Use the new popups in the sidebar tooMaxim Monastirsky
Change-Id: Ib4767eeef1dc6c404bb36068f806c42ccc1086b6
2014-11-09fdo#85804 Introduce bullets and numbering popupsMaxim Monastirsky
Change-Id: I39ea402a3ce3296f55ea127b0139e89954e41252
2014-11-08Unindent.Kohei Yoshida
Change-Id: I98b5a0b91c92e58bae3caa69a4ed35c72dc839dd
2014-11-08coverity#1251168 Logically dead codeCaolán McNamara
Change-Id: I92776d7a96c13b3d0b4c74d2b928320f9182d17f
2014-11-08make line spacing icons point to themes iconsYousuf Philips
Change-Id: Id93fa68fe28359905f1dd55122fb3b4f48e9710e Reviewed-on: https://gerrit.libreoffice.org/12274 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-07coverity#1251176 Uncaught exceptionCaolán McNamara
Change-Id: Ibeedfcb59e3a249c066a9c0f5dd3fcced9beed90
2014-11-07coverity#1251177 Uncaught exceptionCaolán McNamara
Change-Id: Id71b104f8d1c420b3716b093cebad00a7eb3f431
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-07Make SdrGrafObj swapping methods private.Zolnai Tamás
Plus remove some useless call of them. Change the tests accordingly. Change-Id: I47a50b5734d799ac02ee7221c95f82415afb9497
2014-11-07More unused swapping related methods / member of SdrPageZolnai Tamás
Change-Id: I4a979dd09418df4526409d9026d6abb98c6bf954
2014-11-07ForceSwap{In,Out}Objects methods are unused nowZolnai Tamás
They are called only by themselves recuirsively, but not from outside. Change-Id: I1cde392c95bbc60ac7937d0bf3cd4b0fd062568b
2014-11-07SdrUndoDelObj: one more manual swap out callZolnai Tamás
This thing seems a good optimization to me, but it would be good to hide all of this swapping thing inside GraphicObject class, to make our code more robust (e.g. no image loss because of missing manual swap in / swap out call). Auto swapping mechanism will take care of that, anyway. Change-Id: I933dafd95597ffff038dc6aeb0a64fcaa3941bd8
2014-11-07SvxGraphicObject: remove more manual swap out callsZolnai Tamás
Tested with importing large *.rtf and *.docx test documents with lots of images -> auto swapp out works. Change-Id: Ib040edaa89c9bcb966c58b75f0392e6d9f7a165e
2014-11-07Make SetSwapState() an internal methodZolnai Tamás
So we can be sure it is always called when user data changed. Change-Id: If107907afffb85a7a57817f5807847a5c028416c
2014-11-07Fix fdo#84574 - COLOR PICKER: Palette color list should have scrollbarJuergen Funk
Change-Id: Ib927d3e1b1349f9a1b5f575180d217fe31f1f11f Reviewed-on: https://gerrit.libreoffice.org/12296 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-06change nNewStandardDefined to bAdditionalBuiltinEike Rathke
and remove SV_NUMBERFORMATTER_VERSION_ADDITIONAL_I18N_FORMATS Change-Id: I63f341e74a1eb7172dbb024a5cef66435a46e1df
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06Bin unused include files, thanks to Andrea GelminiTor Lillqvist
Change-Id: I848505b1d4ff03779b89a08d4aeefd6ea0ff205b
2014-11-06fdo#84573 COLOR PICKER: Improve keyboard navigationJuergen Funk
Change-Id: Iae9d6b96114732950800c323013f7fbb531053f2 Reviewed-on: https://gerrit.libreoffice.org/12253 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-06Show line spacing in the customization dialogMaxim Monastirsky
Change-Id: I26140cd173de6e11321da814c6b935d84b91ffbf
2014-11-06fdo#85046 change 'List of Changes' to 'Manage Changes' and fix accelerator keyYousuf Philips
Change-Id: Idf1cfa7a41b6d2a7693220672857c5de79be8c4e Reviewed-on: https://gerrit.libreoffice.org/12271 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-05overlayermanagerbuffered: timer to idleLászló Németh
Change-Id: I40d19b20259f2d2dada32467efe4defe3ed4b07c