summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-21Related: fdo#84676 make the undo popup not center under windowsCaolán McNamara
Change-Id: Idef87a0ec74b7da4779a34ec2c18e7243eb328ac
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-21nShearWink -> nShearAngleMiklos Vajna
Change-Id: I122f16783db4025b9335ed82a12f051516d98d4c
2014-10-20fdo#85185 Copy OUString argument to avoid a use after freeMatthew J. Francis
The original OUString is destroyed along with its containing object part way through the call to PaletteManager::PopupColorPicker(), so a copy must be taken Change-Id: I8417ff23a17003e80a4f65e0cf1ad2a8dda5386c Reviewed-on: https://gerrit.libreoffice.org/12031 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-20Related: fdo#84676 set floating undo bits to the same as the color pickersCaolán McNamara
Change-Id: I153d92e94319bd1e7f0d425288f184bd8d13542d
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: If50022b55a558c4124d71acbbe0ef5eb48801d0b
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: Idb6337bed1c32444f9644d54eba5240f09c13ef6
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: I2cb764db97469654f977de63e273874d43745bf8
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: Ia3055b00c20a885dfa0584f864f0e91ccad1e9c9
2014-10-20coverity#735638 Division or modulo by float zeroCaolán McNamara
Change-Id: I2f183bc0bb9c67e3873e13a4bdbc57be9471b8a3
2014-10-20coverity#735639 Division or modulo by float zeroCaolán McNamara
Change-Id: I2ba45c49fb00fdd53b8e388e25df503e82c2332e
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-19-Werror=shadowMiklos Vajna
Change-Id: I940661c947307dc5dea371e5e6f9a9aedbfc904d
2014-10-18convert SV_BMP_ constants to enumNoel Grandin
Change-Id: I46cb7f649fa44d8967e0e7da03583157d2706f05 Reviewed-on: https://gerrit.libreoffice.org/12018 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17Resolves: fdo#62682 crash on second export of svgCaolán McNamara
because the first export has left "dangling" CalcFieldValueHdl Links in Outliners that got created based on the Drawing Outliner while it had a temporary CalcFieldValueHdl installed, and didn't get the old CalcFieldValueHdl installed when the old Drawing Outliner one was re-installed. Change-Id: I064a154ece488c9a4c3467b753451df7e73ae883
2014-10-17coverity#1247643 Uncaught exceptionCaolán McNamara
Change-Id: I0da9140bf1f76a92c95c042c5039f7cfdbde6c34
2014-10-17coverity#1247638 Uncaught exceptionCaolán McNamara
Change-Id: Ibdda31c2a8d8c3314173f381b60800ccfbcc25f7
2014-10-17coverity#1247637 Uncaught exceptionCaolán McNamara
Change-Id: I1e3e47b1473bb4b504e94d06b41d1a86a4004e91
2014-10-17coverity#1247629 Uncaught exceptionCaolán McNamara
Change-Id: Ib0f0555ba5630b225a4a5fbc64394becdeb9f7dd
2014-10-17Consistency around SdrAngleItem in svx/sxciaitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I8e76e4751e50f5952c6dfff9ee10362166bf0523
2014-10-17fdo#62081 Improve wording of style updateYousuf Philips
Change-Id: I2a8b4425fecc33a5507a4c824fff863c10125023 Reviewed-on: https://gerrit.libreoffice.org/12005 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-17coverity#1247617 there is nothing to do if width is 0David Tardon
Change-Id: Iddd877d83d2a3669778282fa8aa9a63dfa850524
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16Related: fdo#84676 try to give floating windows their original stylebitsCaolán McNamara
as they were before becoming .ui components to see if that makes a difference here Change-Id: I1699e19f14b18579f6b8c973d64f069b206b7cb8
2014-10-15coverity#735333 flush out pointless calls to IsRemote and IsOpenCaolán McNamara
etc. Change-Id: I588d4486071b1e31897d4e6468a2c634d6856832
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15loplugin: cstylecastNoel Grandin
Change-Id: I0ccdd2ce18336afea67a3f296b26b2de50f14808
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15Trying to make the Find & Replace dialog a bit more compactAdolfo Jayme Barrientos
Especially with long translations, the removal of homogeneous-width columns make the dialog’s size more manageable. Fixed capitalization, indentation, and made the dialog non-resizable to remove the Maximize button under Compiz/GNOME and the fat border under XP. The expander will still work. Change-Id: I2fb820ac406afe45a3d5339f574c13902ad48753 Reviewed-on: https://gerrit.libreoffice.org/11942 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-15nDrehWink -> nRotationAngleMiklos Vajna
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-14make sure the denominator is not 0David Tardon
Change-Id: Ia618379a8d33048b6716f22ad1e5dcbca0bbf307
2014-10-14make sure the denominator is not 0David Tardon
Change-Id: Ic32e0f354bb290ad77f1d7709bee89858e1889b7
2014-10-14just check if the fraction is < 0David Tardon
Change-Id: I23f631898f29d8285d3da333686da8d3f28a00f8
2014-10-14do not forward-declare templatesDavid Tardon
Change-Id: I3b0a145f70406f0c8a12b6c4b7876c4148f76e93
2014-10-14svx: fix another temp file leak, from SdrMediaObj's glTF modelsMichael Stahl
These need a whole directory, apparently a model may have multiple files. Change-Id: I092c1764ddb1ed30947034f299fbb6882658d21b
2014-10-13oox: refactor embedded media importMichael Stahl
Currently the oox import creates a temp file and leaks it, and there is no way to clean it up afterwards. Unfortunately it turns out that SdrModel has no way to access the imported OOXML storage, so add a really ugly hack to get the embedded media into the SdrMediaObj by setting both MediaURL and PrivateStream properties (currently oox really wants to set the properties in alphabetical order too...) Change-Id: I5a235fbeb08e7bc17faf066de52b94867e9a79a2
2014-10-13coverity#1078470 Unchecked return valueCaolán McNamara
Change-Id: I2dab114efc8c98a17561f1694acf63918e68620d
2014-10-13coverity#1027273 Unchecked return valueCaolán McNamara
Change-Id: I25c6b11fee909559a5f3bac7566fd161851ae14d
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13fdo#82980: Cancel FmXFormView::OnStartControlWizard when breaking creationStephan Bergmann
The problem is that SdrCreateView::EndCreateObj (svx/source/svdraw/svdcrtv.cxx) first calls FmFormObj::EndCreate (svx/source/form/fmobj.cxx) -> FmXFormView::onCreatedFormObject (svx/source/form/fmvwimp.cxx) -> Application::PostUserEvent( LINK( this, FmXFormView, OnStartControlWizard ) ), and only then, upon bPntsEq, calls FmFormObj::BrkCreate (svx/source/form/fmobj.cxx), which does not cancel the posted OnStartControlWizard link. The fix is apparently not perfect, though, as afterwards the text document goes back to text input mode (cursor blinking, mouse pointer has I-beam shape) even though the "List Box" icon is still selected. Change-Id: I3137110a88885b04c8dde5377265b1dee91ed6ac
2014-10-13vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMapChris Sherlock
To do this, I've made FontCharMap a friend class for ImplFontCharMap, and have moved the functions directly into FontCharMap. In this patch, I am attempting to stop the direct use of ImplFontCharMap by anything other than FontCharMap. However, FontCharMap itself requires a refcounter, so we will use FontCharMapPtr to access the font character map. Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9 Reviewed-on: https://gerrit.libreoffice.org/11823 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10UBSan: SfxBoolItem vs. SfxTemplateItem confusionStephan Bergmann
Change-Id: I277481734ae260109a6a9446b0d7769324a40aaf
2014-10-10coverity#1241199 Unchecked dynamic_castCaolán McNamara
Change-Id: I8522084c4b6036d63b144af70bf25312f897ff7d
2014-10-09-Werror,-Wliteral-conversion (implicit conversion from double to long)Stephan Bergmann
Change-Id: I89095491d67c382a0b3280755d723039f48229f1
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09HAS_IA2 is never definedAndras Timar
Change-Id: Ib71e98d1250e6d077c593801993b88c2963459b7
2014-10-09Improve wording on several actionsSamuel Mehrbrodt
* "More Styles" (Styles dropdown) * "More Fields" (Insert field dropdown and menu) * "More Options" (Table dropdown) Change-Id: I593a1d1dd68e666d05a4ac20ae97308ad45ff18e
generated by cgit (git 2.34.1) at 2024-08-14 01:11:12 +0000