summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2014-10-24loplugin: cstylecastNoel Grandin
Change-Id: Ia0f5f0d0efbe4693aba347bff32cd694117251fe
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "-Werror,-Wliteral-conversion (implicit conversion from ↵Jan Holesovsky
double to long)" This reverts commit 8d0f9675021a07261b2182fb3192c26e2263eff8.
2014-10-23Fraction: Revert "do not forward-declare templates"Jan Holesovsky
This reverts commit 091742e86aeb5287f7236f666fee48946ab4c67b.
2014-10-23Fraction: Revert "just check if the fraction is < 0"Jan Holesovsky
This reverts commit 8afab33d161ddd39a3e6094b5daa08b156ef0421.
2014-10-23Fraction: Revert "make sure the denominator is not 0"Jan Holesovsky
This reverts commit e19fb51d89fd8fa747594ba7aa3fdac67262f646.
2014-10-23Fraction: Revert "make sure the denominator is not 0"Jan Holesovsky
This reverts commit a3dc4db870ac3c08c480131ed18d144e42ec18b2.
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23Fraction: Revert "coverity#1247617 there is nothing to do if width is 0"Jan Holesovsky
This reverts commit 6016287fd064568ab4052932b2e6c0ee4a601bbd.
2014-10-22Reduce scopes and add some whitespaces.Kohei Yoshida
Conflicts: svx/source/svdraw/svdotxat.cxx Change-Id: Ie1c94a4c241352c580d2509529919806f01ed6c0
2014-10-22SetObjectItemSet() eventually calls NbcAdjustTextFrameWidthAndHeight().Kohei Yoshida
No need to call this (rather expensive) method twice. Change-Id: I4c0a54acd1da0b8504ae7eb96beda4a8531943c7
2014-10-22AdoptTextMinSize() calls NbcAdjustTextFrameWidthAndHeight() at the end.Kohei Yoshida
No need to call this again in the caller. Change-Id: Ib36853cf5a0720082275e0490b4443cd9e0bd007
2014-10-22Reduce scope level & Annotate the code a bit.Kohei Yoshida
Change-Id: I6ebf849243000920b1c1f7e67d2dc81fcee9e16b
2014-10-22Remove local variables that are no longer used.Kohei Yoshida
Armin removed their uses in 120e469d176026ceb59abbf74d2ad255323cbc9a. Conflicts: svx/source/svdraw/svdotxtr.cxx Change-Id: Id620466929ca3a66dd1c261e81aacd533a44cd76
2014-10-22fdo#84844 Sidebar: Use SvxColorToolBoxControl for paragraph colorMaxim Monastirsky
Change-Id: I0231a52288ca9a8a2a5e5cdb13fdff772b989640
2014-10-22Related: fdo#84844 Support of Sidebar wide buttons in SvxColorToolBoxControlMaxim Monastirsky
The end goal is to convert the Sidebar to use SvxColorToolBoxControl, and get rid of the Sidebar specific color popup, so we don't need to maintain two popups. Change-Id: I42e5bcb611acae25f16dfe9623d19727fc39ea07
2014-10-22callcatcher: update unused codeCaolán McNamara
Change-Id: I96b4d44e44389245f3ccc4a08198676461c6a38b
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-21Related: fdo#84676 make the undo popup not center under windowsCaolán McNamara
Change-Id: Idef87a0ec74b7da4779a34ec2c18e7243eb328ac
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-21nShearWink -> nShearAngleMiklos Vajna
Change-Id: I122f16783db4025b9335ed82a12f051516d98d4c
2014-10-20fdo#85185 Copy OUString argument to avoid a use after freeMatthew J. Francis
The original OUString is destroyed along with its containing object part way through the call to PaletteManager::PopupColorPicker(), so a copy must be taken Change-Id: I8417ff23a17003e80a4f65e0cf1ad2a8dda5386c Reviewed-on: https://gerrit.libreoffice.org/12031 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-20Related: fdo#84676 set floating undo bits to the same as the color pickersCaolán McNamara
Change-Id: I153d92e94319bd1e7f0d425288f184bd8d13542d
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: If50022b55a558c4124d71acbbe0ef5eb48801d0b
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: Idb6337bed1c32444f9644d54eba5240f09c13ef6
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: I2cb764db97469654f977de63e273874d43745bf8
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: Ia3055b00c20a885dfa0584f864f0e91ccad1e9c9
2014-10-20coverity#735638 Division or modulo by float zeroCaolán McNamara
Change-Id: I2f183bc0bb9c67e3873e13a4bdbc57be9471b8a3
2014-10-20coverity#735639 Division or modulo by float zeroCaolán McNamara
Change-Id: I2ba45c49fb00fdd53b8e388e25df503e82c2332e
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-19-Werror=shadowMiklos Vajna
Change-Id: I940661c947307dc5dea371e5e6f9a9aedbfc904d
2014-10-18convert SV_BMP_ constants to enumNoel Grandin
Change-Id: I46cb7f649fa44d8967e0e7da03583157d2706f05 Reviewed-on: https://gerrit.libreoffice.org/12018 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17Resolves: fdo#62682 crash on second export of svgCaolán McNamara
because the first export has left "dangling" CalcFieldValueHdl Links in Outliners that got created based on the Drawing Outliner while it had a temporary CalcFieldValueHdl installed, and didn't get the old CalcFieldValueHdl installed when the old Drawing Outliner one was re-installed. Change-Id: I064a154ece488c9a4c3467b753451df7e73ae883
2014-10-17coverity#1247643 Uncaught exceptionCaolán McNamara
Change-Id: I0da9140bf1f76a92c95c042c5039f7cfdbde6c34
2014-10-17coverity#1247638 Uncaught exceptionCaolán McNamara
Change-Id: Ibdda31c2a8d8c3314173f381b60800ccfbcc25f7
2014-10-17coverity#1247637 Uncaught exceptionCaolán McNamara
Change-Id: I1e3e47b1473bb4b504e94d06b41d1a86a4004e91
2014-10-17coverity#1247629 Uncaught exceptionCaolán McNamara
Change-Id: Ib0f0555ba5630b225a4a5fbc64394becdeb9f7dd
2014-10-17Consistency around SdrAngleItem in svx/sxciaitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I8e76e4751e50f5952c6dfff9ee10362166bf0523
2014-10-17fdo#62081 Improve wording of style updateYousuf Philips
Change-Id: I2a8b4425fecc33a5507a4c824fff863c10125023 Reviewed-on: https://gerrit.libreoffice.org/12005 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-17coverity#1247617 there is nothing to do if width is 0David Tardon
Change-Id: Iddd877d83d2a3669778282fa8aa9a63dfa850524
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16Related: fdo#84676 try to give floating windows their original stylebitsCaolán McNamara
as they were before becoming .ui components to see if that makes a difference here Change-Id: I1699e19f14b18579f6b8c973d64f069b206b7cb8
2014-10-15coverity#735333 flush out pointless calls to IsRemote and IsOpenCaolán McNamara
etc. Change-Id: I588d4486071b1e31897d4e6468a2c634d6856832
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15loplugin: cstylecastNoel Grandin
Change-Id: I0ccdd2ce18336afea67a3f296b26b2de50f14808
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15Trying to make the Find & Replace dialog a bit more compactAdolfo Jayme Barrientos
Especially with long translations, the removal of homogeneous-width columns make the dialog’s size more manageable. Fixed capitalization, indentation, and made the dialog non-resizable to remove the Maximize button under Compiz/GNOME and the fat border under XP. The expander will still work. Change-Id: I2fb820ac406afe45a3d5339f574c13902ad48753 Reviewed-on: https://gerrit.libreoffice.org/11942 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-15nDrehWink -> nRotationAngleMiklos Vajna
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-14make sure the denominator is not 0David Tardon
Change-Id: Ia618379a8d33048b6716f22ad1e5dcbca0bbf307
2014-10-14make sure the denominator is not 0David Tardon
Change-Id: Ic32e0f354bb290ad77f1d7709bee89858e1889b7