summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2017-04-06convert zoom menu to .uiCaolán McNamara
Change-Id: I4163042773f0f38e3372527d0a77a1b370bcafe9
2017-04-06loplugin:singlevalfieldsNoel Grandin
Change-Id: Ia681765aa1da5c80a3dbe91b7376af841a9c9ec1 Reviewed-on: https://gerrit.libreoffice.org/36145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06Revert "tdf#106792: Fix "Geometry" property of changed-to-bezier ↵Stephan Bergmann
SvxShapePolyPolygon" This reverts commit 26909d9de4c6e7165fc8f5d938ee6ef55b87cc5c, see <https://bugs.documentfoundation.org/show_bug.cgi?id=106792#c10> for why this was wrongly addressing symptoms, not the root cause. Work on a proper fix is ongoing.
2017-04-06Fix typosAndrea Gelmini
Change-Id: I9e7f7fa6a8b89304883a843f9fb0b905f5e8a8a4 Reviewed-on: https://gerrit.libreoffice.org/36100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-06loplugin:redundantcast find cstyle double castsNoel Grandin
Change-Id: I5507be190dac781e5cdb545a60acf3d50056c9f8 Reviewed-on: https://gerrit.libreoffice.org/36187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05convert RID_SVXMNU_XMLSECSTATBAR menu to .uiCaolán McNamara
Change-Id: I16ca1543baa14cdc14dbcebd5e6093e6f3029a61
2017-04-05loplugin:redundantcast find c-style bool castsNoel Grandin
Change-Id: I3237b93babc67de12c3771aa84766c2141ca93b2 Reviewed-on: https://gerrit.libreoffice.org/36137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparam part2Noel Grandin
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: https://gerrit.libreoffice.org/36072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparamNoel Grandin
Change-Id: I1996319e5b664dff95f7a9b2346aea6092d333ec Reviewed-on: https://gerrit.libreoffice.org/36070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04Make HangingIndent a commandSzymon Kłos
New command .uno:HangingIndent. Code moved from the sidebar to slots. Change-Id: Ib389f9fb3368409a90cf90ad8b19f1be322fa120 Reviewed-on: https://gerrit.libreoffice.org/35930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-04Notebookbar: Separated paragraph spacing controlsSzymon Kłos
One big paragraph spacing control was splitted to separated widgets. It will be possible to reuse that in the sidebar. Also layout is better because explicit size setting is no longer needed. Change-Id: Ieb200af4a9a6120ae03b22b27da56256aa816193 Reviewed-on: https://gerrit.libreoffice.org/35801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-04Fix group for .uno:EditAnnotationSamuel Mehrbrodt
Change-Id: I3a62e37d866235728abf6b4ad3a5338222d02088 Reviewed-on: https://gerrit.libreoffice.org/36081 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-04coverity#1403732 Mixing enum typesCaolán McNamara
and coverity#1403735 Mixing enum types coverity#1403737 Mixing enum types Change-Id: I278b7d5116d4157e6aa4483d8eef42325e4bc03b
2017-04-02coverity#1403662 Mixing enum typesCaolán McNamara
Change-Id: Ic5e797c65dfc736a9ef0ab14f3ae563216143947 Reviewed-on: https://gerrit.libreoffice.org/36020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-31svx: fix missing namespaceMiklos Vajna
Change-Id: Ibfd783f42b376952442e017537276a00f4dafc8e
2017-03-31lok sc: Don't depend on the OutputDevice existence when invalidating.Jan Holesovsky
We know that the drawinglayer operates in 100th of millimetre, and that we need twips for LOK. Change-Id: I8813f936ab66eaca4d6b9c03341e090d703decb8
2017-03-31can use a reference hereCaolán McNamara
Change-Id: I042baab66ff67d0599cffcbfe2db374eb182ea5b
2017-03-31const these upCaolán McNamara
Change-Id: If79187b8e2624da132ed47f5baf374211cc6e449
2017-03-31Resolves: tdf#106515 use OpenSymbol, not StarSymbol as the default bullet fontCaolán McNamara
For choosing a bullet from a real font it matters while otherwise its a synonym. Of course we have this code duplicated three times. Change-Id: I2428b9a23d997925de3e731b8afe9fb8cf18ed54
2017-03-31use actual UNO enums in svxNoel Grandin
Change-Id: I00f53260667861ca2595892b5605479da3401adb Reviewed-on: https://gerrit.libreoffice.org/35913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30Related: tdf#106080 support a 'none' color in search by formatCaolán McNamara
so we can show the initial no-color selected state differently than the automatic color default color Change-Id: Ib3020e507b1555cb446c2b501f60b67222dc115c Reviewed-on: https://gerrit.libreoffice.org/35863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-29Resolves: tdf#106079 automatic color described as 'white'Caolán McNamara
move RID_SVXSTR_AUTOMATIC from svx to editeng for this Change-Id: Icc3fbb15e627ed54770d11bce7aadf30a0d12aa7
2017-03-29LOK: Calc - images are not painted below row 1000Marco Cecchetti
The problem was not due to some missing tile invalidation: it was at the painting stage. There was no overlap btw the view range and the object range. Now images and shape are painted correctly. There is still problems with control forms and charts. Change-Id: Ib74e3bb79b444df21844086ae666fc206aa48906 Reviewed-on: https://gerrit.libreoffice.org/35215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-03-29split ImportState enum into RtfImportState and HtmlImportStateNoel Grandin
and convert to scoped enum Change-Id: I23e44e78ce96ed5fc19374e3e069e1cdc2166a35 Reviewed-on: https://gerrit.libreoffice.org/35840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29Resolves: tdf#106841 RID_SVXSW_FRAMEPOSITIONS is in wrong orderCaolán McNamara
since... commit 1c48275a28fa3bccdeb6bc12e4f0bcea6c05a81b Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Feb 6 11:51:27 2017 +0000 convert resources containing strings to stringarray resources cause the original defines weren't in numerical order and I missed that Change-Id: Ic81c9bad2432c3ffa49c56812924965017a05220
2017-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29convert EViewType to scoped enumNoel Grandin
Change-Id: I5b10aada64408897a56a5932aa28486d7562d617 Reviewed-on: https://gerrit.libreoffice.org/35822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29nCnt calculation is overwritten anywayCaolán McNamara
Change-Id: Idf2693aaf31fc06e16df4b15766d29f029df896a
2017-03-29expand vis to visible; fix typosdennisroczek
* translate German source code comments * remove bogus surce code comments * remove ascii art * removed old StarOffice/Sun internal bug tracker references * remove left over from commit dcd5dee88e3c1185638b190553bef65c2ef6566f Change-Id: I3c5cce621c43e4a03afb76f4cc5a12065914e5ad Reviewed-on: https://gerrit.libreoffice.org/35404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-29tdf#106792: Fix "Geometry" property of changed-to-bezier SvxShapePolyPolygonStephan Bergmann
After "Convert to Curve" as described in the issue, the shape apparently is still an SvxShapePolyPolygon shape but with getShapeKind() of OBJ_PATHLINE instead of OBJ_PLIN (and same for OBJ_PATHFILL). That causes XMLShapeExport::ImpExportPolygonShape (xmloff/source/draw/shapeexport.cxx) to determine bBezier == true and thus expect the obtained "Geometry" property to be of type css::drawing::PolyPolygonBezierCoords, not merely css::drawing::PointSequenceSequence. Smells like this issue had always been present, and would have caused bad memory access when accessing the non-css::drawing::PolyPolygonBezierCoords object in XMLShapeExport::ImpExportPolygonShape, and only now throws an exception since 0d7c5823124696f80583ac2a5f0e28f329f6f786 "New o3tl::try/doGet to obtain value from Any". Change-Id: Ica31a114e5beac97bac2a1c509eb1a85f8354d5e Reviewed-on: https://gerrit.libreoffice.org/35825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-29loplugin:singlevalfieldsNoel Grandin
Change-Id: I7f05903aaab9b0b274358243d680d0c30694ae61 Reviewed-on: https://gerrit.libreoffice.org/35804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28std::unique_ptr<sal_uInt16[]> -> std::vectorCaolán McNamara
Change-Id: I708e1f24e14bc21f40cf4d5a2d3e6f849b6f7762
2017-03-28remove some more unused SID constants and commandsNoel Grandin
Change-Id: Ibf2bb58ca687c18798328ed86cd549d64f3621b4 Reviewed-on: https://gerrit.libreoffice.org/35792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28tdf#42949: clean up includes in include/svx/[a-c]* with iwyuJorenz Paragas
Change-Id: I7768f4dbe9892c4264cb16eed87497894aa7494e Reviewed-on: https://gerrit.libreoffice.org/26582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28remove enum slot code from sfx2Noel Grandin
since we only used it for the pseudo-slot stuff, which is now gone Change-Id: I72146090e7741d5b71d581fa0b5c6d43c154445a Reviewed-on: https://gerrit.libreoffice.org/35759 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28remove unhandled SID commands from svxNoel Grandin
In this case, also remove those unhandled commands which are present in a *Commands.xcu file, but not in any other kind of .xcu file. Change-Id: I8b42df7357349872e28d3ee60ec2c0505358cff6 Reviewed-on: https://gerrit.libreoffice.org/35648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27ofz#946 NbcAdjustTextFrameWidthAndHeight calling itselfCaolán McNamara
Change-Id: Ibebe76332d25af87841c3b7761a5583347dfbf34 Reviewed-on: https://gerrit.libreoffice.org/35756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-27document mnIndex doesn't changeCaolán McNamara
Change-Id: Ia000682774cee4c58811325f6ab40859502da79f
2017-03-27remove unhandled SID commands in scNoel Grandin
checked to make sure none of the related .uno commands are present in any .xcu files. Change-Id: I026eec90351f525be7417f697debe2444756193b Reviewed-on: https://gerrit.libreoffice.org/35622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-26Kill remaining PseudoSlots usageMaxim Monastirsky
Change-Id: I14a820b7c0baba8d8b17d07715bf17c42c73c8fb TODO: Remove support code from idl and sfx2 modules Reviewed-on: https://gerrit.libreoffice.org/35718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I77cf7fe3a57c031877facf5252b5a900526db48b Reviewed-on: https://gerrit.libreoffice.org/35646 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Make loplugin:loopvartoosmall find more suspicious casesStephan Bergmann
...where the "controlling expression" of any sort of loop contains a sub- expression of the form var < val where the type of var is smaller than that of val. Theoretically, this could turn up lots of false positives, but practically it didn't run into any. Most findings have been cleaned up over the last weeks. There's just a handful remaining places that are hard to clean up, so I flagged them here with (deliberately awkward) sal::static_int_cast for later clean-up. Change-Id: I0f735d46dda15b9b336150095df65cf247e9d6d3 Reviewed-on: https://gerrit.libreoffice.org/35682 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-24convert ViewShellId to o3tl::strong_intNoel Grandin
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23remove unused helpid in SfxShellNoel Grandin
Unused since commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae "update unusedmethods plugin to deal with constructors" where I removed a unused SfxDockingWindow constructor. And in that case, the helpid was only being used to assign the window a UniqueId. Change-Id: I148e424424fcf08449440b83a8600071b39d7a07 Reviewed-on: https://gerrit.libreoffice.org/35554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23Typo: boder->borderJulien Nabet
Change-Id: I46940c5b584f93b478b1dfca9aa66e036fe951c2 Reviewed-on: https://gerrit.libreoffice.org/35547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-22ofz: stack-overflow with infinite parse recursionCaolán McNamara
Change-Id: I4973875797446e146cbda6db84958c9e4962aa8b Reviewed-on: https://gerrit.libreoffice.org/35545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-22Calc: safer life cycle handling for OutputDevice in SdrPaintWindowMarco Cecchetti
Change-Id: I5469332c4ef98bce8cd9c2caff5bf61dbf102b23 Reviewed-on: https://gerrit.libreoffice.org/33220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-03-22loplugin:redundantcast find redundant c-style enum castsNoel Grandin
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349 Reviewed-on: https://gerrit.libreoffice.org/35467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>