summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2018-03-13SDI: don't #define/#undef names of actual classes for slot headersMike Kaganski
Visual Studio 2015/2017 cannot handle that correctly, and emits a lot of intellisense errors. So, just prepend the define with "ShellClass_" Change-Id: I473ceb7e0a88e114b92e6342fd4ae63015cafd3e Reviewed-on: https://gerrit.libreoffice.org/51135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in svdibrow Change-Id: I3a3a87fdba179ad927226097c53c4f07d36095e8 Reviewed-on: https://gerrit.libreoffice.org/51033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in svdedtv2 Change-Id: Iae43ec7ccd0a220b0296780bafecd5b4d232c3d5 Reviewed-on: https://gerrit.libreoffice.org/51032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13tdf#114552 Convert anchor toggle to anchor menuSamuel Mehrbrodt
Since we now have three, not two anchor types. Change-Id: I9654de574a9d546d2191093cba9c192fac3cd3d7 Reviewed-on: https://gerrit.libreoffice.org/50987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-13tdf#114622 Add Numbering in Arabic-Indic numeralsSuhail Alkowaileet
Fix all comments Change-Id: Ib11662de5cac3b073114ab4425e8f45a0c04c8c8 Reviewed-on: https://gerrit.libreoffice.org/47058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-12loplugin:redundantfcast look for redundant copies in return statementsNoel Grandin
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008 Reviewed-on: https://gerrit.libreoffice.org/50996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-11weld color pickerCaolán McNamara
Change-Id: I487b9a0cc13b2b60a0f1e28667773b5d3b5c66cc Reviewed-on: https://gerrit.libreoffice.org/51001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-11Move (and rename) graphic stuff from svtools to vclTomaž Vajngerl
This is preparing to change how GraphicManager works where it won't base itself around GraphicObject anymore but Graphic. No functional or cosmetic change was made to the classes, only changes that were needed because of the move and rename. The only thing that wasn't moved is the GraphicRenderer as it is not needed in vcl for now (but makes sense to move it in the future to keep graphic stuff together). grfmgr was renamed to GraphicObject as the GraphicManager will be changed a lot and most likely moved out, so the name grfmgr won't make any sense anymore. All the UNO implementations were renamed with a prefix Uno and used the same name as the class name. This is made to be more specific which are the Uno objects (for example graphic.cxx contained the implementation of XGraphic, which is similar to graph.cxx contains Graphic). Change-Id: I54a2fa6c7e997469aaa7770db05244adb9f64137 Reviewed-on: https://gerrit.libreoffice.org/51068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-11svx: convert XBitmap directly to XGraphicTomaž Vajngerl
Change-Id: If2bd8419d9073625f0392f59f671d70193bf990c Reviewed-on: https://gerrit.libreoffice.org/51048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-10xmloff: embedded objects can still use GraphicObject URLTomaž Vajngerl
The embedded graphic object don't seem to use the uniqueID of a graphic object, but seem to have the same URL prefix. Let's leave this in for now. Change-Id: I48d9ad2c3b1eca745911f03221988c46c0fdb8d2 Reviewed-on: https://gerrit.libreoffice.org/51041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-10remove references to {Header,Footer,Para}GraphicURLTomaž Vajngerl
Change-Id: I559f25ee99f7b8b49545390479cbb06d3c601d3c Reviewed-on: https://gerrit.libreoffice.org/50982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09Remove unused HIDsGabor Kelemen
These were no longer used in the code. This should help me in identifying obsolete and missing HIDs in helpcontent. Found by this somewhat sophisticated method: for mod in $(find -name helpids.h) ; do echo $mod; for i in $(grep ^#define "$mod" | cut -d " " -f2 ) ; do if [ $(git grep -c "$i" $(echo "$mod" | cut -d "/" -f 2 ) | wc -l) -eq 1 ] ; then echo "$i"; fi ; done done Change-Id: Iaf8179322419ce51175bc5a42fedec0add8c5241 Reviewed-on: https://gerrit.libreoffice.org/50680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-03-09svx, compile error with !HAVE_FEATURE_DESKTOPjan Iversen
solved unused parameter referer in case of !HAVE_FEATURE_DESKTOP Change-Id: I64e2707ad87822ba784ed40c45801c6d101e6386
2018-03-09give color picker explicit parentCaolán McNamara
Change-Id: I73e9a29abd5d767b31850e9a6b1f2b8d757ee928 Reviewed-on: https://gerrit.libreoffice.org/51000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09inherit welded dialogs from a common ancestorCaolán McNamara
Change-Id: Ifa6c871a134cf89bfba71b1049a115cf7c953c42 Reviewed-on: https://gerrit.libreoffice.org/50936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09-Werror,-Wunused-parameter (Android)Stephan Bergmann
Change-Id: Ib15218f1f3bc2867ca0e8daa50a2d4edad4a9d87
2018-03-09completely remove MID_GRAFURL, replace with MID_BITMAPTomaž Vajngerl
Change-Id: I39b055760320abb2575958d525b4db3185a11d4a Reviewed-on: https://gerrit.libreoffice.org/50990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I0cfa88efe03e8018513e2cce49ab9db63fe976d0
2018-03-09remove MID_GRAPHIC_URL and related mappings, implementationTomaž Vajngerl
Change-Id: I752a2f036791720d12fb04b95f53d4127d605c7e Reviewed-on: https://gerrit.libreoffice.org/50979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09svx: convert "ThumbnailGraphicURL" prop. to "ThumbnailGraphic"Tomaž Vajngerl
Change-Id: Id77768e6ad58c8ed7bd35478a8f0cf78ce4b1feb Reviewed-on: https://gerrit.libreoffice.org/50934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09svx: removing GraphicURL and OWN_ATTR_GRAFURL, fix writerfilterTomaž Vajngerl
Change-Id: I5b84788a324cc68e3c4561e9a7376fcb1cfeeb67 Reviewed-on: https://gerrit.libreoffice.org/50933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-08loplugin:constantparam in svtools..unotoolsNoel Grandin
Change-Id: I6e72fbe44dcb65ee5162448e9a72e6437d56b044 Reviewed-on: https://gerrit.libreoffice.org/50948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08loplugin:constantparam in linguistic..sfx2Noel Grandin
Change-Id: I0e8c506df0beb0b05d9c32723876b11b6577280a Reviewed-on: https://gerrit.libreoffice.org/50938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08loplugin:unusedfieldsNoel Grandin
Change-Id: Id332557cbe7fb42d3d794612f26aa3ac161548d9 Reviewed-on: https://gerrit.libreoffice.org/50902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-07make all the .ui message dialogs explicitly modalCaolán McNamara
Change-Id: I1e197fbec92d5369394f036171af9018afea7f15 Reviewed-on: https://gerrit.libreoffice.org/50910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-07Resolves: tdf#116242 handle negated diacritics correctly and show checkboxEike Rathke
The "ignore diacritics" implementation is not only about CTL, whatever its names suggest. It uses an ICU "NFD; [:M:] Remove; NFC" transliteration that decomposes and removes *any* diacritic. Thus treat it as such and don't hide the checkbox if CTL is not enabled, but more important preset the sensitive values, and handle the UI vs implementation oddity correctly; UI "sensitive" / code "include" means to *not* *ignore*, obtain the proper negated value from the checkbox. Unfortunately the setting is stored in the configuration, so an update will still present the user with an unchecked Diacritics-sensitive box s/he has to enable once. The actual failure (diacritics always ignored) is a fallout from commit d4064927a2e83c974d4ee9538081e8a4fcdb1e34 AuthorDate: Tue Oct 3 10:26:28 2017 -0800 CommitDate: Thu Oct 26 17:24:26 2017 +0200 tdf#111846 Find & Replace: Rename diacritics and kashida options Change-Id: I65f2a23b66370fdfe2d170c17c7736a3b4177192
2018-03-07cache location and mime type when saving a graphic to a storageTomaž Vajngerl
Change-Id: If27a5f617a103da235d6690ea0447d6c64538dea Reviewed-on: https://gerrit.libreoffice.org/50810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-06disambiguate CreateSfxDialogCaolán McNamara
Change-Id: I6a02d7b197c3cc31a4c9b2eec3d5bd786544df3c Reviewed-on: https://gerrit.libreoffice.org/50837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-06use more Color in svxNoel Grandin
Change-Id: I78ea8db0d9c882cdc3813ff4fac0cdce9caf6ad1 Reviewed-on: https://gerrit.libreoffice.org/50801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-06add some color conversion methods to sax::ConverterNoel Grandin
to make the call-sites less verbose Change-Id: Ifddcbb03a454a241bef93f31a8025801b84a66fc Reviewed-on: https://gerrit.libreoffice.org/50578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-06Resolves: tdf#113805 insert special character fails in insert footnote, etc ↵Caolán McNamara
dialog i.e. since commit 710a39414569995bd5a8631a948c939dc73bcef9 Date: Thu May 11 13:27:38 2017 +0530 GSoC: Glyph View and Recent Characters Control in Special Characters dialog Change-Id: Ia55f3fefe7c14327cff2e996ab0038dc52f9b017 it inserts into the document, extend the fix of commit 4020945651b4f3c636980e2103db440b5c55459c Author: Daniel <danielfaleirosilva@gmail.com> Date: Sun Sep 24 17:55:19 2017 -0300 tdf#111739 fix Selecting a custom character as a bullet symbol insertion to do the old thing that existing code depends on if this is not an "insert" dialog, and bubble that setting around from the callers Change-Id: Id8acf16955d0167beffae43e3b201e500ee7a929 Reviewed-on: https://gerrit.libreoffice.org/50781 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05Resolves: tdf#116188 set min version on all .ui files to 3.18Caolán McNamara
which is already the min for the runtime Change-Id: Ifebe099f1f94a36f65a31989689400327a823dcd Reviewed-on: https://gerrit.libreoffice.org/50776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05loplugin:useuniqueptr in SdrObjEditViewNoel Grandin
Horrible things happening in SdrObjEditView::SdrEndTextEdit, I can't tell if it's deliberately leaking there, or just changing ownership in some terribly opaque way. Change-Id: Idcb30f7e3f1b801901f727b151d3e8dd1124fd3f Reviewed-on: https://gerrit.libreoffice.org/50663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05there's already a way to pass around the SfxRequest source frameCaolán McNamara
Change-Id: I790497c3e651890e0971ee334d599a98a7aae7f0 Reviewed-on: https://gerrit.libreoffice.org/50768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05drop sax::tools::*base64 methodsNoel Grandin
and use the underlying comphelper methods rather. This is so that I can break the dependency that tools has on sax, and can add methods that make sax depend on tools. Change-Id: I8a2d6ce2ffc3529a0020710ade6a1748ee5af7d5 Reviewed-on: https://gerrit.libreoffice.org/50767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05Translate German variable and function namesJohnny_M
Akt -> Current in svdibrow Change-Id: I099858e917dcc725cd02c1b99f0fa61d5c769ae1 Reviewed-on: https://gerrit.libreoffice.org/50703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-05Translate German variable namesJohnny_M
Akt -> Current in svdviter Change-Id: If1abc3705514739f856d7a60e70c7b114836b341 Reviewed-on: https://gerrit.libreoffice.org/50668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-05loplugin:useuniqueptr in ImpXPolygonNoel Grandin
Change-Id: I5bb3f0661f5d62527bb5a8d24035c46a6a11e185 Reviewed-on: https://gerrit.libreoffice.org/50691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05loplugin:useuniqueptr in SvXMLGraphicOutputStreamNoel Grandin
Change-Id: I44a5dbb244301181019ad09aebed46b0054c3b4b Reviewed-on: https://gerrit.libreoffice.org/50690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-04Translate German variable namesJohnny_M
Akt -> Current in svdmodel (Including translation fix of a two-line comment, where it was no longer clear that it is one.) Change-Id: I00fba0fddc177b709df227316cdfbf7895a61291 Reviewed-on: https://gerrit.libreoffice.org/50706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-03Translate German variable namesJohnny_M
Akt -> Current in svdcrtv Including a fix of an earlier comment tranlation Change-Id: I23383594bc120440793395031a787021017de2ae Reviewed-on: https://gerrit.libreoffice.org/50667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-02use more Color in HexColorControlNoel Grandin
Change-Id: I889fa9f2a8711e95f24336718e35d11d0945dec1 Reviewed-on: https://gerrit.libreoffice.org/50573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02delete colordata.hxxNoel Grandin
move what we still need into color.hxx Change-Id: Ied7e31eb16468aa334c666b1499a6262f16a6350 Reviewed-on: https://gerrit.libreoffice.org/50561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-01tdf#116001 Incorrect Colors in Chart Wall AreaNoel Grandin
regression from commit b10c7022f1be6e4825269bd5872575b5b53744ef "use RawBitmap in BPixelRasterToBitmapEx" we need to implement alpha support in vcl::bitmap::CreateFromData Change-Id: I68bebbe1dd15e3bb04de312309c1631d6bb7fe2d Reviewed-on: https://gerrit.libreoffice.org/50556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-01make Color::GetRGBColor return Color instead of ColorDataNoel Grandin
Change-Id: I532959a7103c3857510f26ecce2f942d676a233b Reviewed-on: https://gerrit.libreoffice.org/50487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-28drop old tools/gen methods in reportdesign..xmloffNoel Grandin
Change-Id: I398831c526ba51d861557fa6c13c0e2fb44dfbe0 Reviewed-on: https://gerrit.libreoffice.org/50447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-28Translate German comments and debug stringsJohnny_M
Change-Id: Ie2da785cb674e21f042caa5e6d461e3489036003 Reviewed-on: https://gerrit.libreoffice.org/50467 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-28convert COL_ constants to be of type ColorNoel Grandin
Change-Id: I0e25c8950ac26b851ff42f71e1471fcbe4770d48 Reviewed-on: https://gerrit.libreoffice.org/50373 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27remove unused vclunohelper.hxx includesJochen Nitschke
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22 Reviewed-on: https://gerrit.libreoffice.org/50393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27tdf#79546: Make sure temp copy of inserted media file keeps the same extensionTor Lillqvist
Inserting videos into Impress presentations with 'Insert>Audio or Video' did not work at all for me. This helps. It seems that the AVFoundation APIs are sadly rather picky about file name extensions. Why we need to make a temporary copy of the media file (which after all can be rather large) at all, when inserting it in a slide, I don't understand. But I am not going to dig into that now. Change-Id: I43fcfb5bb3ef0a2c0f8979ac3e7c458a84f180a1 Reviewed-on: https://gerrit.libreoffice.org/50390 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>