summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2014-11-26sidebar: Try to fix initial spacing valuesMaxim Monastirsky
Process SID_ATTR_METRIC status before any other, and call SetMax methods before SetValue, so indent values won't be truncated by a wrong max value. Change-Id: I36d8c0cce9561902aa2c4d531740f56c80207012
2014-11-26Cleanup some leftovers from the line spacing popup conversionMaxim Monastirsky
Change-Id: Ia2e35461958ea5d79241fa2231bd7ef164fc378d
2014-11-26Unused includesMaxim Monastirsky
Change-Id: I262b3106bf426a12b2e826eeefd02351e67c7a9b
2014-11-25fdo#85858: svx: fix mouse dragging of table row separators in WriterMichael Stahl
Add a work-around for Writer's usage of LONG_MAX to SvxColumnDescription: on 64-bit platforms the LONG_MAX added in SwView::StateTabWin() for SID_RULER_ROWS will overflow in vcl's LogicToPixel mapping and that causes wrong positioning of the row highlight lines. Probably Writer should use something other than LONG_MAX (no reason why these types need to be bigger than 32-bit anyway) but that needs a bigger cleanup. (regression from 4c60f722afdc0be5c129ce5f5ed6786d09d0051e) Change-Id: I08147462356368d48959a85a85ef7dd8dcae0943
2014-11-25all these ids and their associated resources were unnecessaryCaolán McNamara
Change-Id: I3f538668c9c5f1727b8cf49ab72fd5879e12f156
2014-11-25We now only need one bit of information hereCaolán McNamara
whether there *is* an id, or whether there is not an id. An id of 0 seems to be used as a flag that an interface is some sort of superclass which can be subclassed by something else and have its toolbars etc reused. Convert this to a bool so we don't need an a resource id for each one and just drop the third arg for the normal "final" case and use a different define for the inheritable case Change-Id: I98380f03d73d57bf8cba02d339097e384518abaa
2014-11-25-Werror,-WuninitializedStephan Bergmann
(in SvxGraphCtrlAccessibleContext ctor: base class 'comphelper::OBaseMutex' is uninitialized when used here to access 'comphelper::OBaseMutex::m_aMutex') Change-Id: Ic6791043828b7b9f69c76867e26ee02a5ee66817
2014-11-25-Werror,-WuninitializedStephan Bergmann
(in TableModel ctor: base class 'comphelper::OBaseMutex' is uninitialized when used here to access 'comphelper::OBaseMutex::m_aMutex') Change-Id: I2a54a1123384bdeaee917ad9f1f0047f13c3860f
2014-11-24so these ResIds are only being used for the numerical valueCaolán McNamara
Change-Id: I21c67b56424de59d7231f8420055775cd5f67aae
2014-11-24RID_DEFAULTIMAGELIST_[L]C global fallback now known to be unusedCaolán McNamara
Change-Id: I93e358a9761f8f4fb22310239dbce8f621529eb8
2014-11-24move RID_APPTITLE to desktop where its usedCaolán McNamara
rename the other ones and remove the unused ones Change-Id: I0e636cd5d1799e0f9cb815a4bfa20b16039ecb3f
2014-11-24remove unused defines from app.hrcCaolán McNamara
Change-Id: Ib58c20897a765d81020fc440a48abc4aa966619f
2014-11-24fdo#86622 sidebar: Distorted icons in Graphic sectionMaxim Monastirsky
Similar to: 36f275cb0f19d11151abf85f3c191a2736bd73da 92a0793265c66d289828c0193097b14b7e7e2d0f Regression of: eaa89db886ba49472e22d77cea957a08c1113cd0 Change-Id: I98893989fff9f9893f6b3b52b24a43676fe7c6f7
2014-11-24Do not depend on libxml include in widely included fileStephan Bergmann
...and hope xmTextWriterPtr expanding to struct _xmlTextWriter * is a stable feature of the libxml2 API Change-Id: Ic5076df5a8b33f71c605b3aef737a99ea96b1753
2014-11-24svx: missing libxml2 externalMiklos Vajna
Change-Id: I416e504d1f16530096056ea915dcfdb74f302c4c
2014-11-24Kill unused (debugging) sidebars.Jan Holesovsky
Change-Id: I7d0af9d7c65e2d9d45b32870af495b2cd3eef749 Reviewed-on: https://gerrit.libreoffice.org/13084 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-11-23fdo#85486 - Clean up unnecessary enumerations from xenum.hxxRadu Ioan
Removed XLineStyle Reviewed on: https://gerrit.libreoffice.org/13029 Change-Id: I583575a04988ccf932374e411672ba14a3f3cb2f
2014-11-23loplugin:literaltoboolconversionStephan Bergmann
Change-Id: Ibecd561c1d27e129ad1f481bdb7f8a7bb4d0f8d8
2014-11-23fdo#86546 Open the right tab for more bullets and numberingMaxim Monastirsky
Change-Id: Ib8dda6eab89c92fa9bea98e3570896ea02692585
2014-11-23some localizations (e.g. Slovenian) need more space for translated button textAndras Timar
Change-Id: I407d8d92c9669f606e4f8fbb95a37932f8f14956
2014-11-22fdo#86550 make some strings localizableAndras Timar
Change-Id: Ie3b47e30b22b4bbae86f575ca1c9f3639afd3afd
2014-11-22Make NfCurrencyTable a separate header & forward-declare it in zforlist.hxx.Kohei Yoshida
Change-Id: I17b52c277ab6ec8b15e88729feee0a269b75087d
2014-11-22fdo#86517 make predefined palette names localizableAndras Timar
Change-Id: I3930757c02f9f976fb52cd75c9edab7cf75078c6
2014-11-22fdo#86573: Impress does not show pictures anymoreZolnai Tamás
Regression from: 286e2f5c6ec829bc0987b1be7016699f7ef03e5e Sometimes SdrGrafObj import the image file just as a preview (with low resolution) and late when the real picture is needed it just throws this preview and tries to load the image again. This preview works only with package URL so in this case we should not forget that URL. Plus two other related potential image loss situation: - SetUserData() is called with empty image URL - Image preview is thrown when we actually have no package URL from we can import the image again. Change-Id: Ib21f400eb6d28133e8598e6b201209e5dd1a976f
2014-11-22svx: punish evil-doers who put duplicate properties into custom shapesMichael Stahl
LO 4.3.2.2 is evidently able to export an ODF document that violates XML Well-formedness constraint: Unique Att Spec. <draw:enhanced-geometry draw:mirror-horizontal="false" draw:mirror-vertical="false" svg:viewBox="0 0 21679 2134682997" draw:text-areas="0 0 ?f3 ?f2" draw:mirror-vertical="true" draw:type="ooxml-rect" draw:enhanced-path="M 0 0 L ?f3 0 ?f3 ?f2 0 ?f2 Z N"> Not sure how to reproduce this, but the attributes there are apparently a serialization of SdrCustomShapeGeometryItem's aPropSeq, retrieved from a "CustomShapeGeometry" property, so add some input validation and assertions there. Change-Id: I91151365b507779a4bdc9cce2057d34f2376f005
2014-11-21make glxtest available in salmainMarkus Mohrhard
Change-Id: Ic8bc3f2d5d96506590d35138089ead2eac984314
2014-11-21Resolves: fdo#86466 Wrong background color shown in format table in impressCaolán McNamara
regression from commit 440e2031ce8cffc8dc573e359a330236f9c11dfb bnc#882627: Allow to edit spacing to contents even with no borders visible. which was an attempt to fix regression from commit 9e5342509b302ba1f816f21cc3ad1cb7093982e0 Date: Mon Jun 3 14:22:07 2013 +0200 copy values from the original item set ... because SfxAbstractDialog::GetOutputItemSet() only contains the items that have been _changed_ in the dialog. Now format color shows the expected color, and loading the sample for bnc#882627 and selecting cells and changing the border distance (etc) doesn't cause bulleting and paragraph alignment properties to be stripped away Change-Id: Id414e09faa221d151f393971654b17bbe9f46d81
2014-11-21More fixes after SdrMetricItem changesStephan Bergmann
...like e0c2ea6bde31bd68e1794154b72fddcd40dda7f9 "Consistency around SdrMetricItem in svx/sderitm.hxx," similar to recent c3a9a9542b018f781ee12e6c8c943d4f19641afe "that's not right anyway, using the Distance as a which-id." Should all be found and fixed now with the removal of the unnecessary but harmful default value from the two-argument SdrMetricItem ctor. Change-Id: I6eaeb6633c9a350b18e02d476d2c8794a733cea8
2014-11-20that's not right anyway, using the Distance as a which-idCaolán McNamara
Change-Id: If6422d35b5d7b4b9a3cf9f16c34a1ee977b3085a
2014-11-19Move SdrObjPlusData out of SdrObject's header.Kohei Yoshida
It is only used locally within svx. Change-Id: Iae53de3d1cb2b1f5f2ba5cede2794f08dfef972c
2014-11-19loplugin:unreffunStephan Bergmann
Change-Id: I648b91e1124fcdad16ccd5d619192b72e4c8ec3f
2014-11-19Move SdrObjUserDataList out of the header.Kohei Yoshida
It's only used within SdrObject. This also eliminates the need to include boost's ptr_vector in the header file. Change-Id: I5ba9b424be21c5ee3280364de1d73b0fa3921129
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18show pointer_move arrow when passing over an object boundaryCaolán McNamara
which removes the guessing you have to do when trying to find the edge of a pres_obj in impress after text has been filled in and there is no visible border anymore Change-Id: I470caec90cdeaa681da70f8ec3044c1d6d232a82
2014-11-18fdo#82708 editing statusbar tooltip textsYousuf Philips
Change-Id: I3ac2e46f89d5c1e4decb6d6aaf8487663e904a43 Reviewed-on: https://gerrit.libreoffice.org/12433 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17cppcheck: Same expression on both sides of '||'Julien Nabet
Change-Id: I89c758366c2140f0033c1006f6a03bbc17ea8096 Reviewed-on: https://gerrit.libreoffice.org/12459 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-17More HIG fixes in filter, svxAdolfo Jayme Barrientos
Change-Id: I74df6b8221b4bb18791ec81af266dd58571c4c8c Reviewed-on: https://gerrit.libreoffice.org/12489 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-17-Werror,-Wunused-variableStephan Bergmann
...since 286e2f5c6ec829bc0987b1be7016699f7ef03e5e "Related fdo#82953: Forget package URL of image after it is loaded" Change-Id: If4cc941353b72f555dee26d158aee7b15b359a9c
2014-11-16Logically dead code related to embedded stream name in SwGrfNode\SdrGrafObjZolnai Tamás
See also: 286e2f5c6ec829bc0987b1be7016699f7ef03e5e Since embedded URL exists until the first swap in these lines are not needed anymore. Change-Id: Ie6bf8efe7808cf42f20f7b4b3f8cb927555c0ea8
2014-11-16Related fdo#82953: Forget package URL of image after it is loadedZolnai Tamás
It causes problems if we handle those imported images differently which are identified by a package URL, so after the first load remove this URL and handle images on the same way as inserted images. Some related bugs: * #i44367# * #i124946# * #i114361# * fdo#73270 The image in the test document has a special ID which is different from that one which is generated by LO internally so after ODF export the new generated image URL is different from the imported one. Change-Id: I4e7d3490674c5f86bec5c7c6e1c975dcafd7c265
2014-11-16vcl: let the ModalDialog ctor take an OUStringMiklos Vajna
Change-Id: I839435338f4acf80c40896b6c86f7ef122f5449d
2014-11-14more catch by referenceCaolán McNamara
Change-Id: I2db9f94a517f814ef0854190e6f1194501070409
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-13Realy->ReallyCaolán McNamara
that's really bugging me Change-Id: Id15bd4dc42748b3cb24eb891741195499c5df9c3
2014-11-13impress tables are not interactively growingCaolán McNamara
the optimization here stops tables growing as their text contents change in editing mode So, just recalculate if the table could grow and its being interactively edited, which leaves the original (dubious ?) load-time optimization in place Change-Id: I894acf47d34ec8b68aaf9076b5a0cb7e29c38a17
2014-11-13table layout cache returns wrong rectangleCaolán McNamara
the layouter can modify its input rectangle to grow it to the necessary size to contain the layout but we're returning the input rectangle when the inputs are the same as the last call, not returning the output rectangle. cache the output rect for a given input and return that so now insert->table in impress and tab so extra cells are added and then select the table and the blue border contains the whole table, not just the first two rows Change-Id: I4f09594d82c1597204afbd059e175af9bf8e2527
2014-11-13fdo#85776 swap increase and decrease indent in sidebarYousuf Philips
Change-Id: I5f6dd2244adecd2dba7e03ff3f620bd4c7657d7b Reviewed-on: https://gerrit.libreoffice.org/12396 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-12coverity#1187642 Unchecked return valueCaolán McNamara
Change-Id: I6b96ef79d0996e5b783d27c4da8e45ddeac5c7ab
generated by cgit (git 2.34.1) at 2024-08-13 00:48:59 +0000