summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2018-10-05use more std::unique_ptr in FmFormView::createControlLabelPairNoel Grandin
Change-Id: I36f364739e5a37f9adc0fbad8a49a71947b7318b Reviewed-on: https://gerrit.libreoffice.org/61399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05return std::unique_ptr from SdrText::RemoveOutlinerParaObjectNoel Grandin
Change-Id: Id4833818b48a572b7fa4f3c5d7bba1bf9548a0fe Reviewed-on: https://gerrit.libreoffice.org/61398 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05use more std::unique_ptr in EnhancedCustomShapeEngineNoel Grandin
Change-Id: Ib488b15e55492fb469258bfba59e6475dbdb058f Reviewed-on: https://gerrit.libreoffice.org/61400 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04Reformat this eye-cancer causing messEike Rathke
A mix of clang-format and manual. Change-Id: Ice3d96d1400329fc7386e2d4544c69641658600f
2018-10-04Resolves: tdf#106340 resize dialog when search/replace labels are shown/hiddenCaolán McNamara
Change-Id: I1e20807f613a73c7dbefcb8e331f99d484eb5c04 Reviewed-on: https://gerrit.libreoffice.org/61384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04tdf#120291 Attaching a connector makes draw Draw busy-loopNoel Grandin
regression from commit ffe84f49270e0a8818365ca7d1fd5242abff5562 remove SdrObject::GetHdl in favour of AddToHdlList Change-Id: Idb15b976f6e1fcb6ffeda933ffbec96d59e6f155 Reviewed-on: https://gerrit.libreoffice.org/61370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04Select the current format if multiple instead of first matching format codeEike Rathke
This never worked.. Change-Id: I79b8687dde4faac383121abeda70931d0192b33d Reviewed-on: https://gerrit.libreoffice.org/61290 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-03Related: tdf#120277 inherit from SfxDialogControllerCaolán McNamara
where the dialog originally inherited from SfxModalDialog. Change-Id: Ibe0006de93b0a9f05fb3b6181baf3ba1b4cf04c8 Reviewed-on: https://gerrit.libreoffice.org/61313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03loplugin:unusedmethodsNoel Grandin
Change-Id: I9e583df920657ab401162db79decb192c4f69f90 Reviewed-on: https://gerrit.libreoffice.org/61283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03Related: tdf#119613 tdf#118127 suppress duplicated builtins, rework All catEike Rathke
In number formatter dialog: Some locales may define duplicated formats, specifically date formats, for all builtin formats <50 must be present and default formats may be equal to other formats. Try to suppress duplicated formats, preferring those that are essential (i.e. used as current, default or edit formats). This is done only per category, not in the All category. Example is [en-ZA] English (South Africa) that now has ISO 8601 also as default date+time format, though there only the date+time format is suppressed because for date we want to keep both the locale's default and the fixed ISO format pickable. The All category still listed the since long deprecated old currency formats including the worrying CCC format that follows the current default currency. Eliminate that crap, unless one matches the current format. Also, additional formats defined in locale data and user defined formats were never listed in the All category, do that. Change-Id: I6e6b9bfecc34d51e89930f348f7afbe5e3c41738 Reviewed-on: https://gerrit.libreoffice.org/61275 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-10-03loplugin:unusedfieldsNoel Grandin
Change-Id: I3d2cdd80b542dbdbd29971ef837111191809f081 Reviewed-on: https://gerrit.libreoffice.org/61282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:unusedmethodsNoel Grandin
Change-Id: I7db0c27ff2213210ed4b46ebbadc1a2f74a18257 Reviewed-on: https://gerrit.libreoffice.org/61249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:useuniqueptr in SdrLayerAdminNoel Grandin
Change-Id: I0f9c5b471b6db799b2194096f5d40c8adeb027d7 Reviewed-on: https://gerrit.libreoffice.org/61119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03tdf#120245: Accept to insert empty field with 'not null' database constraintJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=120245#c4 Change-Id: I9ac852a83e0a57c34ef3640bf0fb0e6a3394db63 Reviewed-on: https://gerrit.libreoffice.org/61268 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-02loplugin:useuniqueptr in SdrPageViewNoel Grandin
Change-Id: I85aaf0f28c30055003b48209d15b1b496c234e4b Reviewed-on: https://gerrit.libreoffice.org/61120 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-02rename PresetListBox back to SvxPresetListBoxCaolán McNamara
Change-Id: If65c3a9b529d2173f9795c038c877d4e4423a883 Reviewed-on: https://gerrit.libreoffice.org/61217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02drop unused SvxPresetListBoxCaolán McNamara
Change-Id: I9efd96e42c7c1a7e8f9f08ddf1edf7c74b30c7ca Reviewed-on: https://gerrit.libreoffice.org/61216 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02make all notebooks scrollable and enable_popupCaolán McNamara
Change-Id: I16a6d556ca4c6b3f876dc0c8380d01fe3022209e Reviewed-on: https://gerrit.libreoffice.org/61195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02weld SvxLineTabDialogCaolán McNamara
Change-Id: Icb13a6eb2e8c6f6dbd3cf477051bc0bd682e2e7a Reviewed-on: https://gerrit.libreoffice.org/61193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02loplugin:useuniqueptr in FmParentDataNoel Grandin
Change-Id: Ie6c2c3f10e2ca4037c0607f1faac8f6235ed2eed Reviewed-on: https://gerrit.libreoffice.org/61121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-02Omit deprecated old currency entries for ALL category unless usedEike Rathke
These €0 instead of [$€-407]0 and CCC switching with system instead of [$EUR] They can't even be imported anymore since binfilter is gone, but still could be manually entered. Just don't offer that nonsense. Change-Id: I193eb3a864e192d4d420ac5178bf03296d697761 Reviewed-on: https://gerrit.libreoffice.org/61224 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-01rename PreviewBase back to SvxPreviewBaseCaolán McNamara
Change-Id: I121b169ab1eff090457cfc3a1307e32a4bd3f40a Reviewed-on: https://gerrit.libreoffice.org/61192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-01SvxPreviewBase is now unusedCaolán McNamara
Change-Id: If8b83b277b71307e87e155c544f6e295b1192f75 Reviewed-on: https://gerrit.libreoffice.org/61191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-01rename XLinePreview back to SvxXLinePreviewCaolán McNamara
Change-Id: I833c4ae6e2944b484bb32532c20f5ef09917e712 Reviewed-on: https://gerrit.libreoffice.org/61190 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-01weld SvxLineTabPageCaolán McNamara
Change-Id: I91d7ec8a51ce935db40c57feeeed7b160cf4dad8 Reviewed-on: https://gerrit.libreoffice.org/61172 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-01tdf#118764 Sidebar style panel tab stopsJim Raykowski
Change-Id: I307de58a10ec3a79dcf75b9b1383e951b38a9d93 Reviewed-on: https://gerrit.libreoffice.org/61147 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-30weld SvxLineDefTabPageCaolán McNamara
Change-Id: I7a7f421190c89cec8e1a772015b7544d60b26298 Reviewed-on: https://gerrit.libreoffice.org/61158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30weld SvxLineEndDefTabPageCaolán McNamara
Change-Id: I3e947511bbffae4cd48388b17a8fb9a13d453bab Reviewed-on: https://gerrit.libreoffice.org/61139 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30rename XRectPreview back to SvxXRectPreviewCaolán McNamara
Change-Id: I5d684a651c075104cfb2f2bd73303a2e7f5a7fdd Reviewed-on: https://gerrit.libreoffice.org/61138 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30drop unused SvxXRectPreviewCaolán McNamara
Change-Id: I7e43c0e1e12be40cfecbe6614430e9291efe8c2e Reviewed-on: https://gerrit.libreoffice.org/61137 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-29tdf#120066 Only invalidate SdrModel when SdrObject has SdrPageArmin Le Grand
Change-Id: If32dd85f8d04a3f597b033272ffc2fc0bb73fbad Reviewed-on: https://gerrit.libreoffice.org/61132 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-09-29weld SvxJSearchOptionsDialogCaolán McNamara
Change-Id: I18f2ad69daff376c8f09c7bd1cbc8c1f9079f63e Reviewed-on: https://gerrit.libreoffice.org/61105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28weld SvxConnectionPageCaolán McNamara
Change-Id: I155f0c037f0d1879cec4d0b511d60a276466b1bb Reviewed-on: https://gerrit.libreoffice.org/61077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28svx: pdfium's FPDFImageObj_GetBitmapBgra() is not needed after allMiklos Vajna
Given that we do check for the different formats just below anyway. Thanks Ashod Nakashian for pointing this out! Change-Id: Ie481f6f3fa66ee182668bd6ea7171da2a04cca9d Reviewed-on: https://gerrit.libreoffice.org/61078 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-28drop now unused SvxFontListBoxCaolán McNamara
Change-Id: I1ad6c5b98d7bd75c42e14177c417af6ad4ebbeda Reviewed-on: https://gerrit.libreoffice.org/61016 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28weld ScAttrDlgCaolán McNamara
Change-Id: I11eb9001604a1997a8bfa80a144306ddcb913d93 Reviewed-on: https://gerrit.libreoffice.org/61011 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28weld SvxFormatCellsDialogCaolán McNamara
Change-Id: I236ddc4f58b882e648512a99306440fa88a3aeeb Reviewed-on: https://gerrit.libreoffice.org/61017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28weld SvxNumberFormatTabPageCaolán McNamara
Change-Id: Ia6e6497d5c9b6c47e34e5cb5b3913d25e73c3a69 Reviewed-on: https://gerrit.libreoffice.org/60944 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28loplugin:unusedmethodsNoel Grandin
Change-Id: I5f9ef043d76c55f2c761fd08a2bc1dae66b675c8 Reviewed-on: https://gerrit.libreoffice.org/61073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27Fix typosAndrea Gelmini
Change-Id: Icfe120db02a70d43e4120d1f4cbb2704640d3990 Reviewed-on: https://gerrit.libreoffice.org/59470 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-27loplugin:methodcycles more graph theory for the winNoel Grandin
implemeent a reduction approach, which is good at finding virtual methods that only themselves or their virtual partners. The accessibility GetVisArea stuff is dead since commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 Date: Wed Apr 4 11:23:22 2018 +0200 dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5 Reviewed-on: https://gerrit.libreoffice.org/60912 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25loplugin:useuniqueptr in SdrHdlListNoel Grandin
Change-Id: I83241bd2ed172594704f4b115b584dc39b234086 Reviewed-on: https://gerrit.libreoffice.org/60959 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-24tdf#42949 Fix IWYU warnings in include/comphelper/[a-l]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a Reviewed-on: https://gerrit.libreoffice.org/60837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-24Resolves: tdf#119624 stray image_position bottom for some icons in buttonsCaolán McNamara
icons are off by default so not usually seen Change-Id: I6076fd87250fc4595d279c830e14779147b7857a Reviewed-on: https://gerrit.libreoffice.org/60935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24Scheduler: add per-priority Task listsJan-Marek Glogowski
This way we don't have to search the whole list for a higher priority event, if an immediate Task is found. This probably helps bugs like tdf#119724 and tdf#119428. Change-Id: Ic5685193d1bedb6996cf46f0ee2cba42190ff7cc Reviewed-on: https://gerrit.libreoffice.org/60572 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-23loplugin:unusedmethodsNoel Grandin
Change-Id: I9dac9260af9955dc4a66b34c33265c6e36094322 Reviewed-on: https://gerrit.libreoffice.org/60911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-22ofz#10610 Direct-leakCaolán McNamara
Change-Id: If7cd5e7157419c5d3b3a7ff834613e7f6489047c Reviewed-on: https://gerrit.libreoffice.org/60900 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22weld AlignmentTabPageCaolán McNamara
Change-Id: I253a01b053efe836b0657f9a711cecd060b6782b Reviewed-on: https://gerrit.libreoffice.org/60883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22tdf#117721 draw ui: add .uno::SetOptimalRowHeightJustin Luth
Optimal row height: Adjusts the height of the selected rows to fit the content, causing the table to shrink. This really is SetMinimalRowHeight, but until minimize is also added, it is the most desirable optimization. Change-Id: I90717b2752027404a85fd5eb01c68279996598ca Reviewed-on: https://gerrit.libreoffice.org/60129 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-09-21tdf#117721 draw ui: add .uno::SetOptimalColumnWidthJustin Luth
Optimize column width: Adjusts the width of the selected columns to fit the content, without changing the width of the table. Any leftover space is distributed proportionately, with thin columns growing slightly, and wide columns growing much wider. The implementation and results are different from how Writer does it, but tables themselves are also very different in Draw. So I don't think it needs to be handled identically. Writer's implementation is really "minimalColumnWidth" anyway. Change-Id: Ia10cfa9822d7eef3c4909a82c21535aa6668b143 Reviewed-on: https://gerrit.libreoffice.org/60078 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>