summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14make l10n buildable separatelyBjoern Michaelsen
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/Module_filter.mk
2013-11-14rhbz#887420 Implement "block untrusted referer links" featureStephan Bergmann
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and SvxBrushItem::GetGraphicObject. Checking in additional places will probably be necessary to block /all/ unwanted communication. Also, some places marked /*TODO?*/ currently pass in an empty referer (which is always considered trusted) and will probably need to be adapted. Ideally, Referer URIs would never be empty (and consistently use something like <private:user> for cases where access is explicitly initiated by the user and should never be blocked), but that's a very daunting task, so start small by identifying the places that potentially need blocking and adding appropriate Referer URIs there. Also, Referer information should always be computed as freshly as possible from the context in which an access attempt is made, but, again, always carrying the information from the context all the way to the relevant functions is a very daunting task, so for now store the information upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...). The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already used to track macro execution, and there is one place in SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked by the user) is done that needs the current document's URI as Referer to check execution of macro URIs but needs an empty (or <private:user>, see above) Referer to not block non-macro URIs. Special code has been added there to handle that. Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: I7eab6d628cd2bd7a68a79ff69ba835f37fc67711
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: Icc6ca35623a53449d812e3f09004b926f379c889
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: Ib4a334f1e4b77f1f6e0a0b9a736afaf12b61b1be
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: I6dc5e1b5e4be546a837b959ab03f248140aeafbf
2013-11-14remove unnecessary sal_Unicode casts in SVX moduleNoel Grandin
Change-Id: I5d39af3bda3f1197fd1d706e7ef8d28b58d4851a
2013-11-13expand out the A2S macroNoel Grandin
Which is not doing anything useful anymore. Change-Id: I83422e811d52a77b65655924c07b55dd7229449c
2013-11-12Avoid too wide sidebar when writedirection controls are activatedMaxim Monastirsky
Achieved by placing the nearby controls into the same box. Change-Id: I28d04c8c3c5b5d9989e30d0ca18ef536640fb87a Reviewed-on: https://gerrit.libreoffice.org/6609 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-11SAL_WARN_UNUSED INetURLObjectStephan Bergmann
Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2
2013-11-11convert OUString 0==compareToAscii to equalsAsciiNoel Grandin
Convert code like: 0 == aStr.compareToAscii("XXX") to aStr.equalsAscii("XXX") which is both clearer and faster. Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11remove unnecessary use of OUString constructorNoel Grandin
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-09TypoJulien Nabet
Change-Id: Ifb3b9c7a33b7faccbf7dad1886d953d845de3196
2013-11-08Resolves: #i123616# be more flexible regarding the data type for polygon dataArmin Le Grand
(cherry picked from commit 66c81c1a26d6d09c75c8b8ced44e4a0cf43819ee) Conflicts: svx/source/unodraw/unoshape.cxx Change-Id: I5ebb7b39a083bb6e007853f205bb39d434eb94ad
2013-11-08Make INetURLObject-from-OUString ctor explicitStephan Bergmann
...and clean up call sites. Change-Id: I7219a33652835e82fdc44e9e801a7e62868e4f38
2013-11-08remove unnecessary use of OUString constructor in SVX moduleNoel Grandin
Change-Id: I1506daaa4a3b736ee6bbb00100fca24df8368298
2013-11-08earlier failure in debug modeLionel Elie Mamane
in the case that mpObj.get() is not a SdrOle2Obj* Change-Id: Idff7324242062665c137685096cd82284e24f0d9
2013-11-06Remove #ifdef TIMELOG'ed SAL_INFOsStephan Bergmann
...the code doesn't make much sense that way. Change-Id: I506e37b44924701255431f6d20d4610f7f52287d
2013-11-06Resolves: #i123500# redefined ColorModifiers and ColorModifierStack...Armin Le Grand
redefined GraphicAttr to be expressed as primitives if needed, enhanced render and export quality if graphic is modified using graphic attributes (cherry picked from commit 1e79e8da3f8042f7d7bd94b2c9f03cff7545b05c) Conflicts: basegfx/inc/basegfx/color/bcolor.hxx basegfx/inc/basegfx/color/bcolormodifier.hxx basegfx/source/color/bcolormodifier.cxx drawinglayer/inc/drawinglayer/primitive2d/graphicprimitivehelper2d.hxx drawinglayer/inc/drawinglayer/primitive2d/modifiedcolorprimitive2d.hxx drawinglayer/inc/drawinglayer/primitive3d/modifiedcolorprimitive3d.hxx drawinglayer/source/primitive2d/graphicprimitive2d.cxx drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx drawinglayer/source/primitive2d/modifiedcolorprimitive2d.cxx drawinglayer/source/primitive3d/modifiedcolorprimitive3d.cxx Change-Id: Ief2172efc9cc1b9838de48ec7f536c05573c7dc3
2013-11-06convert xub_StrLen to sal_Int32Noel Grandin
convert for loops using xub_StrLen to use sal_Int32 Change-Id: I5f635ca078966fefe938dbc7e8dea7c8d0d0b554
2013-11-05Resolves: i123564 corrected some aspects when working with bitmaps...Armin Le Grand
with low color depth or small size (cherry picked from commit ba54ce4fc788605fc96235f432b455311faee406) Conflicts: cui/source/tabpages/tpbitmap.cxx Change-Id: I10677414ab7d1904dbb29cd395a0c0334e0faa03
2013-11-05update pchThomas Arnhold
Change-Id: I10f3dbd9513052b3bbe30ddc6523cd231f26ded3
2013-11-05presumably this was intended as include guardThomas Arnhold
remove it, as it's nonsense Change-Id: Id8171b81d42dfd3d391b7c5e6602d9271b6697c7
2013-11-04fdo 70998: Termchange: Graphics->ImageSamuel Mehrbrodt
Change-Id: If451dfb24567157c86bca9a4a8564eb8de231a38 Reviewed-on: https://gerrit.libreoffice.org/6524 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04remove redundant calls to OUString constructorNoel Grandin
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-03cppcheck: reduce scope in ctredlin.cxxJulien Nabet
Change-Id: I7bdbea6bfadf0f2ce5e3ecb4803929797ebf7af2
2013-11-01Some Trivial clean-upStephan Bergmann
Change-Id: Ie48e8f5cbc455ef267ad756d82f8c0efee0ef065
2013-11-01SdrGraphLink::pGrafObj can never be nullStephan Bergmann
Change-Id: Ifeb77e61040accd1f7f7ed31d0340c66fbab39a5
2013-11-01Pass OUString by const &Stephan Bergmann
Change-Id: I6b3d6709eb8e3471aaa6ad7b3bcba3319719218b
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-30fdo#54938: Convert svx to use cppu::supportsServiceMarcos Paulo de Souza
Change-Id: I3ab178924cb1c4240511f08625f244dac54e3913 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-28gbuild: set Package default target to INSTDIRMichael Stahl
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
2013-10-28svx: Package_gengal to INSTDIRMichael Stahl
Change-Id: Iae49265aa16bf6b3e13bf2b645f1cef6b9ce186b
2013-10-28fixincludeguards.sh: svxThomas Arnhold
Change-Id: I885bbc431322ee233f8e67ec2bb5701af909046c
2013-10-28remove some stray using rtl::OUStringThomas Arnhold
Change-Id: I47d84f1b0c758bd390d8a5c1895dbb3548999bb6
2013-10-28remove local css namespace definitionsThomas Arnhold
As we have it globally in sal/types.h those are not necessary. Change-Id: I18bba2c763c4680c4fa7fde4c5158953b5cfad82
2013-10-28windows: warning 4355 is disabled globally in com_MSC_defs.mkThomas Arnhold
So there is no need to do this locally, too. Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
2013-10-26Seems that <vcl/cvtsvm.hxx> is private to VCL, so move it thereTor Lillqvist
Change-Id: I3fd1ac8aaea2e79efcd9e2d4b12347a387d0d28b
2013-10-25fdo#54938: More uses of cppu::supportsServiceMarcos Paulo de Souza
Change-Id: Id6bed78d92eba52283a17ab3ca66e751c225e48d Reviewed-on: https://gerrit.libreoffice.org/6423 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-24fdo#69079 - fix multiple user gallery creations.Michael Meeks
Change-Id: I0539e2708b973b8bea7bd63488277f00201c6c46
2013-10-23fdo#54938: Kill ServiceInfoHelper::supportsService and use cppu's instead.Marcos Paulo de Souza
Change-Id: I1c2d95e4c3fb6242dcb4cdb88cf9733471a3412b Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-23convert code to use OUString::endsWithNoel Grandin
Convert places that call aStr[aStr.getLength()-1] == 'x' to use the shorter form aStr.endsWith("x") Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22vcl: mark more Image constructors as "explicit"Michael Stahl
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
2013-10-22Resolves: fdo#38838 remove UniStringCaolán McNamara
hammer silver nails into coffin and bury in concrete Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
2013-10-21Remove comphelper::ComponentContextStephan Bergmann
Change-Id: Idc5974e5a2ec68e8f1b2312a88fab15092c82788
2013-10-21Check for OUString::copy out-of-bounds argumentsStephan Bergmann
regression introduced with 1287804a89c73e072d57a11ca18988c3e73a77b8 "convert svx/source/gallery/*.cxx from String to OUString" Change-Id: Ia8171f2215253b6db8f7eb1f623a6e0c68dc7b94