summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2014-02-13coverity#708342 Uninitialized pointer fieldCaolán McNamara
Change-Id: I76803ae267c18350d5da6c9e425339cefd0817d7
2014-02-12more SvStream:operator>> conversionNoel Grandin
Convert the template based read_lenPrefixed methods to regular methods. Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019 Reviewed-on: https://gerrit.libreoffice.org/7895 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12convert SvStream::operator>> methods to ReadXXX methodsNoel Grandin
First, I updated the clang rewriter to do the conversion. Then I lightly hand-tweaked the output for the few places where the rewriter messed up, mostly when dealing with calls on "this". Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9 Reviewed-on: https://gerrit.libreoffice.org/7879 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12coverity#1103661 Division or modulo by zeroCaolán McNamara
Change-Id: I1506e4e0b1dccac1e9f3dc3094268eaa89d3f6be
2014-02-12callcatcher: update unused codeCaolán McNamara
Change-Id: Iaaad9302ef8edb47fa95ce8ca608b6f36449521b
2014-02-12sal_Bool->boolNoel Grandin
Change-Id: Ie477a46fae2b8c4deb55435f3769ba74037dd259
2014-02-12sal_Bool->boolNoel Grandin
Change-Id: Iee828ef0f5f4ed0192291c4681fbc8df6e863b7e
2014-02-12cid#705265 missing break in switchNoel Grandin
Change-Id: I1e2b7f0b8484bb872ca0a0d745b97e1927295662
2014-02-12cid#705260 missing break in switchNoel Grandin
Change-Id: I4191520694105e16c1fa5d6cc6af3dd7225f3f5f
2014-02-11Resolves: fdo#74681 group related elements into vertical containersCaolán McNamara
Change-Id: Ie30890a44b5920516809f7df6cc024d9fb6accca
2014-02-11Related: fdo#74681 add tooltips to indentersCaolán McNamara
Change-Id: If19f115c1374236ffc1022062154778157524548
2014-02-11coverity#1027390 Logically dead codeCaolán McNamara
Change-Id: I996cc37bf95e36ca69d1809882e2d6f9a18e9411
2014-02-11coverity#738874 Uninitialized scalar fieldCaolán McNamara
Change-Id: I3874c74141520269b43ee3562cc8511d36a31bbd
2014-02-11coverity#738872 Uninitialized scalar fieldCaolán McNamara
Change-Id: I4086e4a1bb851ada73cd7eb42590e0df4cc1190e
2014-02-11coverity#708919 Use after freeCaolán McNamara
Change-Id: I992369c97d068452d87a9c618875c7abb6c90a41
2014-02-11sal_Bool->boolNoel Grandin
Change-Id: I31fb9d5b49260fd1a8fc1312b01fd5632c97ab2e
2014-02-10Typo: execption -> exceptionJulien Nabet
Change-Id: Ib57e0cc39c27595490e29dec46cc6d33067c34b5
2014-02-10coverity#1169805 Unchecked return valueCaolán McNamara
Change-Id: I3eef47e4debc6cfde1ef881a3d525f5ec0adf431
2014-02-10coverity#735512 Logically dead codeCaolán McNamara
Change-Id: I026bb291d8d0c87ef8166331a7e084fa339052f6
2014-02-10coverity#708829 Unused pointer valueCaolán McNamara
Change-Id: Ia8815974467abb7342707fcd54174857f0a0aef7
2014-02-10the return of callcatcherCaolán McNamara
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-09Typo: I/internaly -> I/internallyJulien Nabet
Change-Id: Ic9056baf58698743492ab57a882341c730ef2f7a
2014-02-08coverity#1169810 Logically dead codeCaolán McNamara
Change-Id: I565b3fc948c66a7b8e9815cf746714f9a2a70267
2014-02-07remove the 4 send crash report tabpagesCaolán McNamara
and other logical consequences of officecfg::Office::Recovery::CrashReporter::Enabled == false because we have this disabled by default since the first LibreOffice release and we have no backend infrastucture to handle the submissions anyway and it's blocking conversion of legacy .src dialogs to .ui format Change-Id: Id5481af3ec970032b3728c0e6cc0c6a52d3ed3dc
2014-02-07sal_Bool -> boolStephan Bergmann
Change-Id: Ifc80202e0865b59931af6e50d3d60f5021f8b52e
2014-02-07set smaller preferred width for sidebar para spinnersCaolán McNamara
i.e. use a size that's big enough for sane values to fit, rather than full range of legal values. Width space is at a premium here. Change-Id: I5d34048690729415deaabec431eb16e43c5b7a0a
2014-02-07sidebar: even more cleanup of text panelMaxim Monastirsky
Contains the following changes: - Kill SvxSBFontNameBox. - Remove ToolboxFontSelectHandler. - Move .uno:Color to a separate toolbox. It allows to remove some hardcoded uno commands from the code, and also solves a redrawing issue. - General cleanup. Change-Id: I6fb797aa95d1a73dca0003ad1a40aee55e27e163 Reviewed-on: https://gerrit.libreoffice.org/7893 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07for ToolBox Optimal Size use contents optimal sizesCaolán McNamara
Change-Id: I614c4fdb6478d1ca8e092dc742886190ec920b7d
2014-02-07coverity#708828 unused pointer valueNoel Grandin
Change-Id: Iba75551684d7ee51865a7063cba7458594e028da
2014-02-07coverity#1132667 Unchecked dynamic_castCaolán McNamara
Change-Id: Ia1e8a041d1eb1770757731554ab4fe007a62c111
2014-02-06typo fixes in commentsAndras Timar
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06Typo: formating -> formattingJulien Nabet
Change-Id: If4aba89909a3ef049a756182c37d8a5d6812ae70
2014-02-05cppcheck: variable reassigned before the old value has been usedJulien Nabet
For more details, see http://nabble.documentfoundation.org/Cppcheck-redundantAssignment-gridcell-cxx-svx-module-td4095032.html Change-Id: I9b74a819a1431f5eada727d14933133fbdf7a47f
2014-02-05fdo#74132: Do not interrupt search in Calc.Matúš Kukan
Extending f25cdaa78d5e7d200fbaf31cce9895bab7c5ee63 "fdo#74132: Do not interrupt search in Writer." for Calc. Change-Id: I3a7e5070300993d2811a79f17cb1b2edb0355c44
2014-02-05SvxSearchDialog: Remove always false bMultiLineEdit.Matúš Kukan
Seems to be at least from 5c4b13d1bea4aedb72677f0317d5334638c03918. 'searchformat' and 'replaceformat' becomes then unused too. Change-Id: Id5276e22478e5f863c12eadd7a7172d80ea685bb
2014-02-05fdo#74132: Do not interrupt search in Writer.Matúš Kukan
Instead of "Do you want to continue at the beginning?" dialog, just inform that we were at the end of the document in new label. Also replace 'Search key not found' dialog with label. Change-Id: I6a140cbad93406b73996f87a6d05fcc5d245fdbf
2014-02-05Remove unfinished code.Matúš Kukan
Change-Id: Iee9e2ff03fc1bce45965148a772c0984a0a9f8d0
2014-02-05transparence->transparencyCaolán McNamara
Change-Id: Ief774a0e02dc1489239b2a0c1fd550a5f6ee66de
2014-02-05Resolves: #i123116# correct spelling errorsJürgen Schmidt
Patch By: Aivaras Stepukonis Review By: jsc (cherry picked from commit a845d71360fc3cd0205d554964c4fd9fe87f0f8a) Conflicts: svx/source/sidebar/area/AreaPropertyPanel.src Change-Id: Ib5158a2e28f1af426cd845ac648bcd4674d496f0
2014-02-05Doxygen warnings correctedChris Sherlock
* Doxygen spits out a lot of warnings about not being able to find match function signatures, etc. This is because in some headers we have a using namespace statement, in others it gets confused between ::Window and Window (!). * Wrong use of tags: + Lots of @seealso - should be @see + Wrong usage of @overload - corrected with the right function signature + HTML tags that doxygen doesn't recognize removed Change-Id: I1c2eed941619b8764dbfcfc5ab38027518cdf261
2014-02-04convert specialised SvStream::operator>> methods to ReadXXX methodsNoel Grandin
as preparation for converting the SvStream::operator>> methods on primitive types Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9 Reviewed-on: https://gerrit.libreoffice.org/7798 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04fix ambiguitiesCaolán McNamara
Change-Id: I4ac7032f1fae25f7a48d819141c1c446dac42e3c
2014-02-04sidebar: more cleanup of text panelMaxim Monastirsky
Change-Id: Iad9b619d599ed13e3d783ca174e7ad5f0053c622 Reviewed-on: https://gerrit.libreoffice.org/7826 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04fdo#39944: Add DOCUMENT_* accessibility UNO rolesJacobo Aragunde Pérez
Added a set of UNO accessibility roles for specific kinds of documents: * DOCUMENT_PRESENTATION for Impress * DOCUMENT_SPREADSHEET for Calc * DOCUMENT_TEXT for Writer The other applications still use the existing DOCUMENT role. These roles translates directly to ATK but in the other toolkits we keep using the same association that DOCUMENT role had. Change-Id: Ibac47527e5effdecb28d2314cde8558cf4fb010a Reviewed-on: https://gerrit.libreoffice.org/7847 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-02-04clean up now that pGraphic ==NULL is an early returnCaolán McNamara
Change-Id: I9d8e03eeb63ab2086fc354f546419b33d7b34411
2014-02-04convert chinese dictionary dialog to .uiCaolán McNamara
Change-Id: I2c239c1e7115d26f7b1dba00b08256b650cc183e
2014-02-03Remove needless SAL_DLLPRIVATE annotationsStephan Bergmann
Change-Id: Icfb27f12627796a05854dfb436b8d4e66c38d5db
2014-02-03fdo#74435: SdrPageView::DrawLayer(): hack to avoid spuriously visible imagesMichael Stahl
In the TestBook2.odt of fdo#73300 it happens that at some particular points when scrolling down, the ViewObjectContactOfPageHierarchy::getPrimitive2DSequenceHierarchy() will determine that > 200 images are visible; most likely this is due to an empty ObjectContactOfPageView::maViewInformation2D::getViewport(). Loading this many images may need more RAM than is available on 32bit platforms. That appears to happen only (but not always) if somehow (not sure how exactly) the rectangle passed to SdrPageView::DrawLayer() and the existing GetRedrawRegion() do not overlap at all. (regression from commit 8af09bf33291df2fb2bfbbd6e42f9bf074fcc4fc) Change-Id: Iafc595241df05204bccec1f2336014fc471b6602
2014-02-03remove GraphicObject::SetSwapStreamHdl() timeout parameterMichael Stahl
Every call to SetSwapStreamHdl uses the same timeout now so move the function that determines that to svtools. Change-Id: Ib7395d43dd132a9e14e7a7862ff2c2279f319536
2014-02-03fdo#73300: sw: GraphicObjects are never swapped outMichael Stahl
In SwNoTxtFrm::PaintPicture() the GraphicObjects are no longer painted via GraphicObject::Draw() any more there is the problem that they are not cached any more in the display cache of the GraphicManager; that used to immediately swap out the Graphic but now they are never swapped out. Since there appears to be no use of the GraphicManager's display cache in the new drawinglayer based rendering path i have no idea how to swap out the Graphic immediately; instead use the same time-out that SdrGrafObj is using already. This timeout is derived from the setting: Tools->Options->LibreOffice->Memory->Graphics cache->"Remove from memory after". (regression from 2e5167528f7566dd9b000e50fc1610b7bf99132a) Change-Id: I0d9b535a82646d9b6635cfb3917f74dcc3ad8720