summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-03-14tdf#130975 replace `rtl::math::isNan` with `std::isnan`.Yukio Siraichi
Change-Id: I5d53e6369d35093445b2efd8936bbf8c6775ff47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90451 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-13Revert "loplugin:constfields in svx"Noel Grandin
This reverts commit 1a6397030381a45f27ab7a2a02e6e6d0f9987c84. Change-Id: Iaa706bb4ea3144ef57ab359b982400abc589b97e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90454 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13tdf#80194 proof search: assert to find proof of code correctness.Justin Luth
I'm sure that these functions need to change because they just seem very wrong. I think these are fall-back, safety sections because usually the nEsc is already converted away from _AUTO_ prior to reaching this point. But this is all just based on code-reading. It would be nice to have proof of this - especially since the values for subscript are unexpected. I would have expected it to use a value comparable to DFLT_ESC_SUB, and not some random/magical -20. (Note: the _AUTO_SUPER historically refered to an absolute 33 and not DFLT_ESC_SUPER until I recently changed that...) Change-Id: I3bef0841f9a20f09994b2372e9a7db5941b29c9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88997 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-03-12tdf#130977 replace `rtl::math::isFinite` with `std::isfinite`.Yukio Siraichi
- make all calls look like `std::isfinite`. - change the comments referring `rtl::math::isFinite`. Change-Id: I0cde9ceb9f20150467b454cddde5e62003cfde1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90234 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-11tdf#89849 editeng: adjust escapement before resetting ProprJustin Luth
THIS IS A LAYOUT REGRESSION FIX FOR SUBSCRIPTS/SUPERSCRIPTS. The position of subscripts and superscripts is a percentage based on the 100% fontsize. When LO 4.1 tricked the font into thinking it was 100%, it failed to adjust the escapement to be relative to the new fake size. In the default case, this meant that the superscript was only raised about half as much as it should have. THIS CHANGE WILL AFFECT EXISTING DOCUMENTS WHERE THE TEXTBOX IS SET TO "AUTOFIT THE TEXT". This will primarily be Impress documents, since many of the templates enable autofit text. As a result of this bug, users creating new documents since 4.1 using autofit-text will have specified highly exaggerated subscript/superscript positioning in order to look nice. This fix will expose the exaggerated percentages and make the document look poor. I don't know how that can be avoided. Nor do I know how to create a unit test for a layout bug. I guess QA's PDF compare tests will suffice for this. A clearly exaggerated unit test is attached to the bug report. The new ability to have a larger-than-100% escapement in LO 6.3 comes in handy here, so that small superscripts can gain a fake escapment big enough to put them in the proper position. Change-Id: I0f8dcff8741eb05d8657235930a4eb684629b9d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89214 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-03-11tdf#114441 Convert use of sal_uLong to sal_uInt32AlanTang
Change-Id: Ia359a33e7cbc25764861b17372df9d1c9dbc0913 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89942 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-11tdf#131265: Fix 'update' icon in 3D Effects dialog meaningJulien Nabet
The effect was reversed Change-Id: I611d12eec88ba213d952df541cec89c0664471cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-11tdf#131261: fix Cannot set "Flat" shading mode in 3D Effects dialogJulien Nabet
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=278f01eadd513608e306ea6b85d52fb115a6dedf author Caolán McNamara <caolanm@redhat.com> 2020-01-23 15:28:08 +0000 committer Caolán McNamara <caolanm@redhat.com> 2020-01-24 15:59:50 +0100 commit 278f01eadd513608e306ea6b85d52fb115a6dedf (patch) tree dc4e9a62dc3753353fd1202a28f84d1599cf3996 parent d52384260c4a8f096945b33b89430398ffa69431 (diff) weld Svx3DWin Change-Id: I7d7d5cb0f40da310103a1c281b381818948257f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90311 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-10tdf#131088 Automatic Control Focus not workingNoel Grandin
regression from commit a361231b1363d072d737e9b1d411b71aa9550d84 Date: Fri May 10 10:13:12 2019 +0200 fix wrong SET/QUERY flags passed to uno::Reference Change-Id: Id0dd46c3d40f8acab980147c4c7f64911bc30d22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-10tdf#125520 create a persist correctly for OLEArmin Le Grand
If the D&D-Start described as in the task is an OLE object we need to create a Persist-object to copy the included EmbeddedObjectContainer Change-Id: Ib8b9677bbc3e6c5b3895abc55e6da5b0a96e33d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90263 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-03-10tdf#42949 Fix IWYU warnings in svx/source/[t-x]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8d8a3e13932b004678b305f9a6883062854f9201 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90140 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-09save/restore the entry text of the fontsize widgetCaolán McNamara
instead of its value, because the min value is 2, but we set empty text to indicate multiple values are selected in the underlying text. Change-Id: If4232b500cd177a264aa5e6ca0537021483db95f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90208 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-09improve loplugin:unusedfieldsNoel Grandin
noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-07clang-format svx with under 5-percent lines of changeMuhammet Kara
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I89062f4846e0ba4de7fbe799a1515665fe4449a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90146 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-06basegfx: B2DTuple replace operator[] with "get" and Axis2D enumTomaž Vajngerl
opertaor[] was used for index access of of x and y variables where 0 is x and 1 is y - similar like access to an array with 2 elements. This comes in handy when you write generic code where the algorithm is the same for x and y, but using index access operator doesn't look clean and is potentially dangerous. We know we only have 2 options (o and 1), but an index access allows for more. A solution to this is to have a normal "get" method, with an enum as parameter (Axis2D), which can only have values X or Y. Change-Id: I3f98d0149214808a336f25599350a78436236827 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90133 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-06tdf#120216 improve svx table performance.Mark Hung
By defining operator== for SdrConnectStyleData and SdrFrameBorderData, and make a deeper comparison instead of the pointer stored shared_ptr in SdrFrameBorderPrimitive2D. The SdrFrameBorderPrimitive2D::operator== always return false before. The response time of clicking a cell and then entering editing mode improved from 4s to 0.5s in my environment. Change-Id: I625d9f69a07f42cac4a6cba45ec9e1c4195b6d58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90120 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06tdf#130928 Area fill update patternandreas kainz
Change-Id: I309cb3ccd5e870c6624b1a5b4838ee05c56538d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89843 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-03-05lok: use "None" string item in the ListBox controlHenry Castro
The string item "- none -" confuse mobile users, it is preferable to use the "None" string Change-Id: Ib9b5716aa796624255fed7fac5413db69e028bb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89839 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-03-05Fix typoAndrea Gelmini
Change-Id: I27f8bf818d130a17f459c86e74df05e9ed3b0d1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90003 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-04tdf#125520 enhance internal OLE cloningArmin Le Grand
For D&D/Copy&Paste te temp SdrModel had no IEmbeddedHelper/Persist, so use the one from the source SDrModel in the temporary one for transfer/cloning. Should be okay, the persist is part of the DocumentModels, handed to the SDrModel for usage and *not* destroyed when SdrModel gets destroyed Change-Id: I46e9e371ef8802d6c1c5bfe761b26651ae6e1f73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89986 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-03-04tdf#131033 consider 20° tilt of 3D in 2D projectionRegina Henschel
Error was, that the default 20° tilt of a newly created 3D scene was not applied to the rectangle for the 2D projection and therefore the projection was not high enough. The used method is the same as used when dragging a scene to tilt it. I don't know whether there exists a simpler way. Change-Id: Ic9745cc17ed520cd9e00b123e235fe0e93100073 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89901 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-03-04tdf#131015 crash using the pipette in Edit Contour dialogNoel Grandin
regression from commit 52fece12345161911da2a531213b7d5541192aad Date: Wed Jan 15 12:43:19 2020 +0200 tweak GetBitmap methods in BitmapEx we end up self-assigning, and with a little bit of optimisation, we can up overwriting parts of the graphic we need to construct the new graphic. Change-Id: Ie7e9ce3f9a69f1fe954079873c206985b81db68a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89954 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-04tdf#131044: 3D Effects dialog should allow to set 1 vertical segmentJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=131044#c0 for a scenario Change-Id: Ie247b6441df91e6831cfa18e66771af5d070dad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89933 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-03tdf#101181 Implement glow effect on shapesTamas Bunth
Glow effect is a color-blurred outline outside of the shape. In ooxml document it is specified with the <a:glow> element. The commit contains the following: - Add support for importing and exporting <a:glow> from ooxml documents. - Assign new properties to XShape which stores glow-related attributes. - A new 2D primitive is introduced in module 'drawinglayer' which is responsible for representing the glow primitive which is to be rendered. + A glow primitive is a clone of the original shape which has been scaled up slightly and a new color has been assigned to it. The radius of the glow effect and the color is defined in the <a:glow> element being imported. - A blur algorithm is introduced in module 'vcl', which is called during rendering the primitive. + The blur algorithm works on a bitmap. + Since the algorithm is CPU-intensive, the result is cached in the processor and it is recalculated only if needed. - Add support for importing and exporting glow effect to ODF format. For that, new attributes of element <style:graphic-properties> has been added: + loext:glow, which can have the values "visible" or "hidden" + loext:glow-radius: which holds the radius of the glow effect in cm. + loext:glow-color: holds the color of the glow effect - Tests have been added to assert properties after pptx import and export. Change-Id: I836aeb5e0f24e2c8d5725834c8c0f98083bc82e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89125 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2020-03-03Resolves: tdf#131041 crash on async border dialogCaolán McNamara
Change-Id: Ia9f5f02a0993c3b28ca5fecef3ce6333ba85806b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89823 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02tdf#42949 Fix IWYU warnings in svx/source/s*/*cxxGabor Kelemen
Except for already done svx/source/sdr/ Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I1c4b34cf42aa9faa2f7de36fe1602059460c6c1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89656 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-29tdf#130988 add y-axis up<->down in create 3D objRegina Henschel
Creating the matrix aLatheMat uses a coordinate system with y-axis pointing up, but aPolyPoly2D and ctor of E3dLatheObj uses y-axis pointing down. Converting was missing. The error was inherited from OOo2. Change-Id: Id5b2f769b8f940bd0028d0386d7ce8b80bf17b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89730 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-02-28use the container size as the optimal size when availableCaolán McNamara
to avoid getting the size set on the native adaptor via GtkSalObject::SetPosSize which matters for the calc navigator expand/shrink case Change-Id: I181fee56debe591999c29eead7ee057113078319 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-28weld calc navigatorCaolán McNamara
note: non-standard dnd via parent so the treeview triggers the dnd but doesn't itself strictly speaking drive the dnd, see copying a range from the navigator where the calc main edit window shows the outline where the copy of the range from the calc main window will go Change-Id: Ideecbe779e3d9bb5b392357a93ec25f625180ba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-28Fix typoAndrea Gelmini
Change-Id: Idfaa34e8bc1b293d4856415cfeb5a822cdaaa114 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89653 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-27remove duplicate tokens from xmloffNoel Grandin
Which causes trouble when converting stuff to use FastParser APIs. I see we used to use dummy entries to avoid perfhash complaining, which is fine for exporting, but doesn't work when we use these constants for fast-parser importing, because the imported element/attribute ends up mapped to what looks like the "wrong" constant. So let's just make the constants match their textual representation. Change-Id: I173d4b1e5fedede18375a6f7c15b1f36a48e4063 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89627 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27tdf#130768 Make tiled writer paint reuse decomposesArmin Le Grand
See more info in comment 23 of task. Roughly it's about correcting a helper that led to destroying the View and thus the OC and thus the whole primitive buffering - what was expensive, for the case where decompositions were expensive Change-Id: Ic661ae810083a35812eaa923b439b3856b34b9ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89640 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-27loplugin:constantparamNoel Grandin
Change-Id: I62a0b760e49e38a4565eebf272492159047dda5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89613 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-26tdf#130952 crash launching bullets and numbering from sidebar more... dropdownCaolán McNamara
Change-Id: I242c7281a891a8e52d9fa4e5ee2d20ba56d62fdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89528 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-26tdf#129532 tdf#98839 fixes for mirror of custom shapesRegina Henschel
tdf#98839 In case a sheared custom shape was mirrored, the shear angle in draw:transform had a wrong sign in the saved file. tdf#129532 Mirroring given in draw:transform in file or via macro was wrongly applied. Errors: 1)Mirroring from draw:transform attribute had overwritten already existing mirroring in the enhanced-geometry. 2)Mirroring from draw:transform attribute was set in enhanced- geometry attributes but not really applied. Change-Id: Ifa52f3606b5a33e6492a02d6e19c883d28752da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85670 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-25SVG export: try to reuse original bitmap data for JPG and PNG bitmapsMiklos Vajna
This has a number of benefits: 1) For a sample JPG photo, the SVG output is now 4,9MB, not 20MB. 2) Even the first export to SVG is fast, see commit 570be56b37e4ff105649e604ff4c8a6c368e2e79 (svx: cache PNG export of graphic shapes, 2020-02-25) for exact numbers. 3) Allow using less memory as the SdrGrafObj doesn't have to store a PNG result till the document is closed. We still require matching checksums, so in case anything problematic happens with the bitmap (grayscale filter applied, etc), then the optimization is meant to not help, but still produces correct output. Change-Id: Id3bc359a8dcc4c4d12d3b66ffb512cfa71939a26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89419 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-25tdf#42949 Fix IWYU warnings in svx/source/sdr/*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I332729acbf2f5b5b24b6907dad09c5c5ded94f40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89290 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-25svx: cache PNG export of graphic shapesMiklos Vajna
One scenario where this is useful is: manipulate a JPEG photo in Online's Impress, e.g. resize it multiple times. Each time we generate an SVG preview of the shape, which includes the PNG export of the bitmap itself. This helps with a desktop CPU: debug:9976:9974: SVGFilter::filter finished in 3422 ms debug:9976:9974: SVGFilter::filter finished in 176 ms But it is meant to help on mobile, too, where writing such a bitmap as PNG takes 16-17 seconds without this. (This works because SVG writes the original bitmap, even if it's scaled. If that invariant will be broken in the future, we still emit correct output, but then the cache will be less useful.) Change-Id: I7204b04efeeb42c6eec67f04dfdb8a4ed50443a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89377 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-24Fix typoAndrea Gelmini
Change-Id: I49b314270eb81bfaac709ad210d1c94743d95d4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89366 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-24tdf#42949 Fix IWYU warnings in svx/source/[f-m]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I103c5c7f1a74e8c3a021a91c7a96ebc87cb19efd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89263 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-22Factor out FillEListWithOneFormat_Impl()Eike Rathke
... from almost identical FillEListWithFormats_Impl(). Change-Id: Id0443b40a2acfdfee24426fa0672f711889f3e2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89286 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-22Resolves: tdf#130563 Add predefined 4-digit year date+time formatEike Rathke
Add a predefined NF_DATETIME_SYS_DDMMYYYY_HHMM format code with formatindex="50" to all locale data files, which shifts all reserved area internally generated built-in formats up by one. Reserved area was filled already so that boundary has to be increased as well. Add some flexibility for future additions by setting the new boundary to 65, free first format index to be used by additional locale data formats is 66 now. Adapt all locales to the new boundary. The existing predefined NF_DATETIME_SYSTEM_SHORT_HHMM format code with formatindex="46" mostly was and is used with 2-digit years (stemming back from the old binary format and Excel compatibility), some locales that don't use 2-digit years at all already defined it to 4-digit years. Keep those but move the default="true" attribute (if so) to the new "50" format. Modify populating the format list such that resulting duplicates will be suppressed there as well. Also try to match the new format in ODF import if a long year was requested with date+time. Finally set the new format as default for all *_IT locales. In future changing the default date+time format to 4-digit year is just a matter of moving the default="true" attribute to the new format. Change-Id: Ib16aa9fda0e71b2d03f78e3dd013785de03cd288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89265 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-22Fix typoTamas Bunth
Change-Id: I4308e9957368845059d837a3ace79b5c78b7db51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89124 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-21tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesCanberk TURAN
I fixed if-conditons in UnoGraphicExporter.cxx and I deleted extra slash character at start of zcodec.cxx file. Change-Id: I464e7b0dcbfe835d04c5031bfbd6e46bccbb1216 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87470 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-21loplugin:unusedmethodsNoel Grandin
Change-Id: I2194158d555958f0192d8d6c18e4c093608b8fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20Fix buildSzymon Kłos
Change-Id: Ia38f9a66c5743b524e84887e5dc23535710f2db6
2020-02-20Move Boost.Spirit usage away from legacy namespaceAdam Majer
Remove BOOST_SPIRIT_USE_OLD_NAMESPACE defines and move all usage of Boost.Spirit to boost::spirit::classic namespace. Change-Id: I7dc5bed4d1b51f4a0bd1a4ae40c2024222127ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89079 Tested-by: Jenkins Reviewed-by: Tomáš Chvátal <tchvatal@suse.com>
2020-02-20sidebar: provide indent field boxes with useful id for hiding on mobile.Michael Meeks
Change-Id: I45feb65dbc48810f27e4f7151de46bafcb54af00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89128 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-19sw table cell borders: add optional Word-compatible border collapsingMiklos Vajna
We always compared border width and other aspects only after that, Word works with border weight according to their implementer notes. So extend svx::frame::Style to be able to collapse borders using weights and opt in for that from sw/ in case a compat mode (which is related to tables, off by default and is set by the DOC/DOCX import) is set. Change-Id: I1f682789302c88a0d326c6c0263ad3007441cb24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89052 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-24 13:30:35 +0000