summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2017-01-25Fix typo in comments: relativ -> relativeTakeshi Abe
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09 Reviewed-on: https://gerrit.libreoffice.org/33488 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-24coverity#1399021 Unchecked dynamic_castCaolán McNamara
Change-Id: I3befc9be20f8d414ec786f1a94f1f85ce94fb44b
2017-01-24teach unusedvariablecheck plugin about SfxPoolItem subclassesNoel Grandin
which can all be treated as SAL_WARN_UNUSED The eehtml.cxx change probably fixes some CJK/CTL bug somewhere Change-Id: I6852129540f316075aee907971ac19418d71dd9a
2017-01-24use range based loopsJochen Nitschke
Change-Id: I8144aa147883120cfbeacddaff0bcec486f84be2 Reviewed-on: https://gerrit.libreoffice.org/33449 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24Fix typo in comments: absolut -> absoluteTakeshi Abe
Change-Id: I8aab9004001a9a2ddd54b4c73857b6f9c5b51515 Reviewed-on: https://gerrit.libreoffice.org/33486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23tdf#102142 : disable paragraph spacing icons in the print preview modeSzymon Kłos
Change-Id: Ia75581ae6fe2942d8c28892f38abda2dd425f33b Reviewed-on: https://gerrit.libreoffice.org/33474 Reviewed-by: Szymon Kłos <eszkadev@gmail.com> Tested-by: Szymon Kłos <eszkadev@gmail.com>
2017-01-23pass ownership by pointerJochen Nitschke
to show the intend of the code. assert on invalid objects. remove useless OSL_ENSURE. make sure list of owning pointers can't be copied. Change-Id: I3cccf8ea87585ec9fe62921203a4d12e617ce15c Reviewed-on: https://gerrit.libreoffice.org/33393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-23move defines to only userJochen Nitschke
Change-Id: I337cc5d58386d9fb018b5343ad76e6f8e8e61405 Reviewed-on: https://gerrit.libreoffice.org/33448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23Revert "used std::map in SfxItemSet"Noel Grandin
This reverts commit 2757ee9fe610e253e4ccc37423fa420004d0f388. Besides causing a performance regression, I now notice that there is code in SW that relies on iterating over two different SfxItemSet's in parallel, and assumes that missing items are returned as nullptr, which is not the case for my std::map based change. Change-Id: I2b1110350fe4c4b74e5508558e9661ef1e1a103e
2017-01-23use rtl::Reference in FrameSelectorImplNoel Grandin
instead of storing both raw pointers and uno::References Change-Id: I7a9a436b0d14d4dcaa696713973b86232c8470c0
2017-01-23use rtl::Reference in SvxShowCharSetVirtualAccNoel Grandin
instead of both raw pointer and uno::Reference Change-Id: Ib2ca24f24a7c4f0645daefcea3e8bf44c205a85f
2017-01-23use rtl::Reference in SvxShowCharSetItemNoel Grandin
instead of raw pointer and uno::Reference Change-Id: I92eb7f5a2e710eade580af71b157b3d1eee7b79f
2017-01-23use rtl::Reference in SvxPixelCtlNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: Ie9de5664452545a2a529f753e314aa4678c166fb
2017-01-23use rtl::Reference in SvxShowCharSetNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: I71c9cc4cc643d4b73a34b74c803378da75fd8de0
2017-01-23use rtl::Reference in QuitGuardNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: Ib70bf9508210b2a58dd65437c6cbe8f4f5b343fc
2017-01-23tdf#105266 Make LIGHTEN and DARKEN follow MS specificationRegina Henschel
Enhanced geometry of custom shapes has got commands for LIGHTEN and DARKEN of subpaths. MS specifies, that LIGHTEN is a blending with white and DARKEN is a blending with black. This patch adapts the calcuation accordingly. Change-Id: Ie46f1a1a2210c209c3fac34a7a58758b72eb276c Reviewed-on: https://gerrit.libreoffice.org/33337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-23use rtl::Reference in FmFormModelImplDataNoel Grandin
instead of manual acquire/release Change-Id: I925b45bcc2f09e09330ae8c79f3f40b81ae120ed
2017-01-23use rtl::Reference in OLocalExchangeHelperNoel Grandin
instead of manual acquire/release Change-Id: I40035df2995b71d868fc4d1f08a20b5fa4546fc9
2017-01-23use tools::SvRef in ImpSdrObjTextLinkUserDataNoel Grandin
since the field is SvRefBase-derived Change-Id: Ie84c48daf93e3805b2db240a497a8496779fe750
2017-01-21coverity#1399021 Unchecked dynamic_castCaolán McNamara
Change-Id: I2b43a918f8f01bbe075c2edd8ca963e13588903c
2017-01-21coverity#704840 Explicit null dereferencedCaolán McNamara
Change-Id: Icf3dd9f6c34062b4bc43634b15d210ccf60f8ab9
2017-01-20warn about unused ImagesCaolán McNamara
Change-Id: I5502b28411282354019af51a09c860099c652006 Reviewed-on: https://gerrit.libreoffice.org/33348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-19Dispose unused submenuMaxim Monastirsky
Open Writer, Insert > Form Control > Table Control, draw it, cancel the wizard. Now right click on the table header -> crash. (can't be tested with gtk/gtk3 vclplug, because GtkSalMenu holds reference to the menu). Probably this crashreport: http://crashreport.libreoffice.org/stats/crash_details/ 0bfabafd-3ba4-4c07-8479-399dea07c006 Change-Id: I6588b1e0b5ad4537a4eb98f6a343d0e92264329f
2017-01-19New loplugin:dynexcspec: Add @throws documentation, svxStephan Bergmann
Change-Id: I0e827554a18622e19aec5f81c40da52664783f69
2017-01-19svx: load BitmapEx resources instead of Image onesCaolán McNamara
Change-Id: Id23523170f757361f3fc3d8a18b6db827f45d109
2017-01-19drop unused image idsCaolán McNamara
Change-Id: I433613a7c850ecf888be48153f81cca3f093b789
2017-01-19use rtl::Reference in SdrOle2ObjImplNoel Grandin
instead of manual acquire/release Change-Id: I7110073e9ada8c034295133468c38754e9b55b69
2017-01-17remove SunStudio hacksMichael Stahl
There is no "SOLARIS compiler". Change-Id: Idcfaee36307b1a4112f7fd6702c5f0e528f812c8
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-17manage SvxPropertySetInfoPool.mpInfos with rtl::ReferenceNoel Grandin
instead of with manual acquire() Change-Id: I9fac619730df6a070c5f0d887ecf9249bd7d65a6
2017-01-17coverity#1398817 Unintended sign extensionCaolán McNamara
and coverity#1398818 Unintended sign extension Change-Id: Id8eaffa6e19dd36dc59d7d63fabb398aefdcf433
2017-01-17used std::map in SfxItemSetNoel Grandin
instead of naked array SfxItemIter ended up needing to take copies of stuff because various code likes to iterate over the items and delete items inside the loop. The gdb pretty printer is no longer quite as pretty as it was before, but it still prints useful info. Change-Id: I59b07ea42f6b1c74798a15402970b9dbd8233dbe
2017-01-17tdf#103574 Imagemap dialog lacks on confirmation buttonAbhilash Singh
Change-Id: I95af2542fdb29efabd2d671597837c79e6336f37 Reviewed-on: https://gerrit.libreoffice.org/32925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-17Typo: charakter->characterJulien Nabet
Change-Id: Ie925c3f15fc00cbc16f1b73d5e61be4d6fe9b8ec Reviewed-on: https://gerrit.libreoffice.org/33191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-16tdf#105017 Crash when click a "New Theme..." in Gallery on detached SideBarNoel Grandin
caused by VclPtr fixes which meant instead of the dialog staying in an always-zero ref-count state, it went up to a ref-count of 1, then down to zero, which triggered a delete before the dialog had finished displaying. And revert my fix in commit 0c1cd678f71e519f5a4e623d93442e046485005a which just worked around the underlying problem Change-Id: Icb35535dd06a2d1db1016d00d106760847d87430
2017-01-16SafeModeDialog: restart in normal mode instead of quittingKatarina Behrens
Change-Id: I546629656ada6c7a8a15b4dc77a042e1f1106924 Reviewed-on: https://gerrit.libreoffice.org/33059 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-16new loplugin: useuniqueptr: svxNoel Grandin
Change-Id: I0eb3d43d7bcfc491df16a72997a0720a6aec2c5c Reviewed-on: https://gerrit.libreoffice.org/32959 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-14coverity#1398583 Dereference after null checkCaolán McNamara
and coverity#1398580 Dereference after null check Change-Id: Ib02a05d97c2ee2824eb1e8ad7fa97022fd573879
2017-01-14coverity#1398585 Uncaught exceptionCaolán McNamara
and coverity#1398587 Uncaught exception coverity#1398588 Uncaught exception coverity#1398589 Uncaught exception coverity#1398590 Uncaught exception coverity#1398592 Uncaught exception Change-Id: I603fc492df9215e0d67419640afc3d6a2af28c10
2017-01-13new loplugin: useuniqueptr: vclNoel Grandin
Change-Id: Idcbc8655108ff57c06c33bbcabd652387bf3c4ec Reviewed-on: https://gerrit.libreoffice.org/32948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-12Resolves: tdf#101187 colossal page width wraps around if doubledCaolán McNamara
when trying to generate a reasonable upper bound clipping region Change-Id: I53f8ea1bd6c52c88284e1f41369f83492d078b5d
2017-01-12silence coverity#1371305 Missing move assignment operatorCaolán McNamara
Change-Id: I761e07d1583262d83074addbff4ca67b01640387
2017-01-12SafeModeDialog: set correct initial checkbox stateKatarina Behrens
Change-Id: I3aa45ae4b02afd2ea8e1a5a427eb6f0f17219430 Reviewed-on: https://gerrit.libreoffice.org/32967 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-11SvxFontNameBox_Impl was not disposedMaxim Monastirsky
This is visible after toolbar customization, when the old font box stays visible. Turns out that currently the toolbox controller is supposed to own the item window, not the toolbox. Regression of: commit 970a66f8c919ea0524f216f40d21b3e2a8c88ccc Author: Maxim Monastirsky <momonasmon@gmail.com> Date: Sun Oct 16 01:27:10 2016 +0300 Use UNO registration for font name toolbox control Change-Id: I29a1f06d97c9a981507ff62889e2d7fc6ac9d688 Reviewed-on: https://gerrit.libreoffice.org/32943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-11using the other ctor can shrink this codeCaolán McNamara
Change-Id: Ied607a78c9aaec3cb0ee9dc0e2938c69a62d031e
2017-01-11make XOBitmap uncopyableCaolán McNamara
Change-Id: I9c28434e8923451ddb1af4fa3c63917db206f47a Reviewed-on: https://gerrit.libreoffice.org/32940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-10New loplugin:conststringvar: svxStephan Bergmann
Change-Id: I440b34fca4b084e0702bbc9a7b836bfd39258bfe
2017-01-09replace C-style casts with const_castJochen Nitschke
Change-Id: Ica6522b4bfe2aa4517469e89cabe5d4d057cb6b7 Reviewed-on: https://gerrit.libreoffice.org/32657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
generated by cgit (git 2.34.1) at 2025-02-25 04:00:32 +0000