summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2021-03-09Make sal/config.h the first in pchMike Kaganski
By convention, it should be the first include in C/CXX files; so use of pch should not break that. Change-Id: Ic329c5f39e8f48ad1778724368e262e48972342b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112123 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-08SvxDrawPage::sort() is missing a mutex guardMichael Stahl
Change-Id: Ief291c7a7b866c0cf2533bddd8d1b69a55cd3a99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112028 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-08Don't insert fontwork outside viewSzymon Kłos
Change-Id: Ib518cc6c70e2595cc191cd353b628729fd220de7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109665 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112151 Tested-by: Jenkins
2021-03-08tdf#140796: Wrong English string for U+2060 characterJulien Nabet
Rename "No-width No ~Break" to "Word ~Joiner" + replace pattern "ZWNBSP" variable names by "WJ" Change-Id: I95a874a9d2d20a30d2c4c3add6041adbe72d872c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112055 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-08clean up some more dynamic/static castingNoel
using a hacked version of the staticdynamic plugin and some judgement Change-Id: I5e6668b19320025e419f84bebceade4239577729 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-07ref-count SdrPageNoel
which simplifies ownership handling, particularly with regard to undo/redo Change-Id: Ie8f300ebfdae6db3c06f78a87e35a07497d6b825 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-07loplugin:staticdynamic now with extra saltNoel
because it wasn't quite there yet - now checks for casts with and without const, because const doesn't really matter here. Change-Id: I319025b2095a803fcaad2a7a696d2730b7fd2f81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-07tdf#140051 SI property values like "Bold" are now localisableshivam-51
This patch now allows "Bold", "Italic" and "Normal" to be localisable. Change-Id: Icd8102ce84db9a3c68ab69f5f9eadf0cf04755b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110475 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-03-06update pchesJulien Nabet
Change-Id: Id892e426343746df2f01f4cdc5f470351bdb6a12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112099 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-06Styles preview: use listener to trigger updateSzymon Kłos
Do not render all styles on every selection change. Use listener to detect styles modification. Change-Id: I6d41acd7acad160d1477281d2b3d473233def4d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111833 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112013 Tested-by: Jenkins
2021-03-06loplugin:staticdynamic look for static after dynamicNoel
Change-Id: Ic3066d9a9441e369370cc6aa0fbffb9a321bc928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111985 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-06drop StyleSettings::GetColorValueSetMaximumRowCountNoel Grandin
pull it into the only place it is used. Change-Id: I5923f1599e033d893cebea606138c53ab2cd02fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-06use weld::WaitObjectCaolán McNamara
Change-Id: I726429b1af2b27310153c069b350ee18c7dea47c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112033 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04SidebarPanelBase is always created with a PanelLayoutCaolán McNamara
Change-Id: I825452fbd56435edcc0a2ffb7abe0f834bf10fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111976 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04explicitly name static methodCaolán McNamara
Change-Id: I691c7dc21d87f58d11263d0556991df8731b97d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111933 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04Related tdf#140762 Add texts for "Border style" toolbar itemMichael Weghorn
Make 'GetLineStyleName' a static method of 'SvtLineListBox' and use it to retrieve and set the names for the items used in the "Border Style" dropdown button in Calc's formatting toolbar. This ensures that the corresponding names are available as tooltips and for screen readers. Change-Id: I6b775e1bcd62deefd8a8a6a778dcee426bf3a1f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111905 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-03-04tdf#140762 Set texts for items in "Borders" dropdown buttonMichael Weghorn
Associate textual descriptions with the images for the items in the "Borders" dropdown button in Calc's formatting toolbar. This e.g. makes them show up as tooltips when hovering over the images with the mouse and makes them accessible to screen readers (e.g. Orca with the gtk3 VCL plugin now says those texts instead of just saying "item 1", "item 2",...). This also adds the strings for the items where no corresponding ones exist yet. Change-Id: I02ce8abfa4aa59e06ca1ab45aff0685a19c323f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111871 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-03-04Fix crash while moving handle when shape text is activemert
Change-Id: Ie21398917bc204245837215f1eade78e11c61890 Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111726 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111740 Tested-by: Jenkins
2021-03-03update pchesCaolán McNamara
Change-Id: Ide49c48738ecd537d4eb69390d22807561d3b4e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-03drop unneeded forward declareCaolán McNamara
Change-Id: I0d786e8f37e893d91b1dd527476c7242e0e29950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111816 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-03loplugin:loopvartoosmall (clang-cl)Stephan Bergmann
"loop index type 'unsigned long' is narrower than length type 'std::vector<std::pair<rtl::OUString, rtl::OUString>>::size_type' (aka 'unsigned long long')" Change-Id: I715cb27367c957bebe218371d3813758e4988759 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111809 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-03Fix chart sub element rectangle and handle positionsmert
Change-Id: I486b542ae0bb4a987c98d92c1866895eafcf620c Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111440 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111516 Tested-by: Jenkins
2021-03-02Convert MapModeUnits If necessary.mert
Connecting to a glue point or handle callback messages contain points which may need a unit conversion depending on the module Change-Id: Icc0b2bc5981bb7d135efd38e60ac06fe12a70480 Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111193 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111513 Tested-by: Jenkins
2021-03-01loplugin:refcounting in svxNoel
Change-Id: I87b1d0684e6e8921b222f76a13a36706c0eb8c87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111750 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-01Fix connectors cannot select a glue pointmert
Change-Id: I6b6d2dad27910ac6d5de43e9d0992e3565f5be5e Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111024 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111511 Tested-by: Jenkins
2021-03-01Exclude table selection from handle messagemert
Change-Id: Ic079c2d59040c8b6d714af3932d5294c2060edc0 Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110548 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111510 Tested-by: Jenkins
2021-03-01Added .uno:MoveShapeHandle uno commandmert
This is now only available for Draw/Presentation It will allow interactive dragging/resizing operations via the command. Later it will be implemented for other modules too. Change-Id: Iaed7d25cf4035591083e779c13a6f0227a3b564f Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110041 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111508 Tested-by: Jenkins
2021-03-01tdf#116136 don't show statusbar selection mode control tooltipJim Raykowski
in print preview. This patch also sets the control image disabled when in print preview. Change-Id: I497af2a50621ed6611a31f9b17b682caa82fa260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111294 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-02-27Fix typosAndrea Gelmini
Change-Id: I4188e0bcc4089db3060179b7b1c085218fce92f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111649 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-27flatten XOutBitmap::WriteGraphic a littleNoel
Change-Id: I91f456673ff54649f6e3f837d9ec8fb6d5dd2b2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111678 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-27Sidebar Paragraph move RemoveBullet to 3rd place like in menubar, toolbar,andreas kainz
Change-Id: I4dbf093f0bb905d782df175aed09a16d28e7eb69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111670 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2021-02-26drop unneeded includeCaolán McNamara
Change-Id: I07a359887beeee5d06e340b443cfac755d27e94e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111629 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-26don't need to check if IsFloatingMode is trueCaolán McNamara
seeing as... commit a5dbc997bff8f7fe61ddc848f48c880a6e67e448 Date: Thu Feb 25 11:38:02 2021 +0000 drop archaic rollable support assumes !IsRollUp is always true Change-Id: I707a8d93e3c74b049ab9b96b27ed17fb0d896098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111628 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-26Implemented MoveShapeHandle methodmert
This method will be shared among 3 modules via uno:MoveShapeHandle uno command Change-Id: I921a1f7f004e2004e142954b40b4b93282eb8fed Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111373 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111507 Tested-by: Jenkins
2021-02-26Send handle information of selected shapes to LOKmert
Include the handle information to the callback for the new uno command for interactive dragging/resizing operations. Change-Id: I57c03abc22d3831606da2b698f1de080e9b4da78 Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108686 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111506 Tested-by: Jenkins
2021-02-26tdf#132368 svx: empty the interop grab-bag on ending text editMiklos Vajna
Regression from commit aafaf1f55fa413ad49d4556cf7c0a713dd206ae4 (PPTX export: save SmartArt as diagram instead of group of shapes, 2019-03-13), the idea of interop grab-bag was to carry additional information around as long as the object is not changed. However, actual clearing of the grab-bag was never implemented, do this when editing shape text. An alternative would be to do this in SdrObject::SetChanged(), but Writer sets the layer of SdrObjects during layout (when the import filter is already finished and undo is enabled), so that would mean loss of the smartart metadata for DOCX. Change-Id: I9ab205b4ef84169f4b5a16b86fe9a152e3370a6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111560 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-25drop archaic rollable supportCaolán McNamara
Change-Id: I69f94cd8013a31f8f6bcf62d703b99f659a1ebb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111555 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-25allow use of FloatWinPopupFlags without including complete floatwin.hxxCaolán McNamara
Change-Id: Ica412938ead6f213668b3aa876bff81d8f512f1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111526 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-25dockwin.hxx doesn't need to include floatwin.hxxCaolán McNamara
Change-Id: Ib0408f715c9a12f32ce2f8049d2c9c7272201d76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111504 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23fill convert menu via the css::awt::XPopupMenu apisCaolán McNamara
don't poke around at it via vcl Change-Id: I3c7cdc76c9efd45084294cd6f001ded8e3ebe793 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111411 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23loplugin:unusedmethodsNoel
Change-Id: Ie0534244cc7a30ad006e65baf125c59757c90d50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23loplugin:constantparamNoel
Change-Id: Ieaee9a3e3ef4aa9bc390ddb198ee1718f635bcbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111391 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23update pchesCaolán McNamara
Change-Id: I44424081b7f55710c4db7f10d1829de1ae08be76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111363 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23weld clipboard menuCaolán McNamara
Change-Id: Ifbc3154c740e2731f4462324a3413bdcdae068ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111358 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-22convert other svxruler menuCaolán McNamara
Change-Id: Ie7d896139f805ddfc64fc7824741a9daff0dab15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111350 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-22forward declare some things and avoid includesCaolán McNamara
Change-Id: I8bf6e23904c932de646aa84fffab1b5549dbdf31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111349 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-22weld colsmenuCaolán McNamara
Change-Id: I733e101905137abc0b3f93b9fe03e4a26c1bd520 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-22svx: fix unexpected large bezier shapes when created via the UNO APIMiklos Vajna
Regression from commit bc886f523872d4f9845c188c7d525d72a1a60946 (tdf#98584 Correct import draw:transform values skewY and matrix, 2020-01-02), then problem is was that now we handle the transform matrix for path objects the way ODF likes it, but this breaks UNO API clients with existing code. In an attempt to make everyone happy, revert the default to ignore scaling from the transform matrix, but add a way so that xmloff/ can opt in to handle it. This way the ODF import result doesn't regression and UNO API compatibility is not broken, either. Change-Id: I8d525e56954bf68c42d3629eca87fe9b513de507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111340 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-22add two missing use-underline to colsmenuCaolán McNamara
Change-Id: Ibab05afd804cc33f2d47a19355842175500e2925 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111335 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-22drop stray printfCaolán McNamara
Change-Id: I69ebaa5cd620384f583294123e467e88c76a3e27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111309 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-19 10:11:02 +0000