summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-01-04drawinglayer: extract classes from baseprimitive2d.hxx to own filesTomaž Vajngerl
This extracts Primitive2DContainer class to its own file, common typedefs for PrimitiveReference, Primitive2DSequence to own file CommonTypes.hxx, some commonly used and independent functions to Tools.hxx. But for not BufferedDecompositionPrimitive2D class is left as it is. Change-Id: Ia55bafd32fb95eba945d091e2c2ae89b160140d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86086 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-03cid#1401342 Uncaught exceptionCaolán McNamara
Change-Id: Ia8746219c483a92977fa87993cb9a97189d52783 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86188 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03svx: fix heap-use-after-free in PosSizePropertyPanelMiklos Vajna
How to reproduce: start Draw, add a shape, expand the "position and size" property panel on the sidebar, quit -> boom Asan reports: ==27725==ERROR: AddressSanitizer: heap-use-after-free on address 0x616000aa60c0 at pc 0x0000004a5d34 bp 0x7ffd28584a30 sp 0x7ffd285841e0 WRITE of size 40 at 0x616000aa60c0 thread T0 #0 0x4a5d33 in __asan_memcpy lode/packages/llvm-472c6ef8b0f53061b049039f9775ab127beafbe4.src/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cc:22 #1 0x7f18a3b304c7 in weld::Toolbar::connect_clicked(Link<rtl::OString const&, void> const&) /include/vcl/weld.hxx:1990:81 #2 0x7f18a3b2fece in ToolbarUnoDispatcher::dispose() /sfx2/source/toolbox/weldutils.cxx:129:17 #3 0x7f18a3b30144 in ToolbarUnoDispatcher::~ToolbarUnoDispatcher() /sfx2/source/toolbox/weldutils.cxx:133:49 #4 0x7f189b921f95 in std::default_delete<ToolbarUnoDispatcher>::operator()(ToolbarUnoDispatcher*) const lode/opt_private/gcc-7.3.0/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:78:2 #5 0x7f189b91adf9 in std::unique_ptr<ToolbarUnoDispatcher, std::default_delete<ToolbarUnoDispatcher> >::reset(ToolbarUnoDispatcher*) lode/opt_private/gcc-7.3.0/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:376:4 #6 0x7f189b8ef552 in svx::sidebar::PosSizePropertyPanel::dispose() /svx/source/sidebar/possize/PosSizePropertyPanel.cxx:149:23 ... freed by thread T0 here: #0 0x4eb440 in operator delete(void*) lode/packages/llvm-472c6ef8b0f53061b049039f9775ab127beafbe4.src/compiler-rt/lib/asan/asan_new_delete.cc:166 #1 0x7f18806064f0 in (anonymous namespace)::SalInstanceToolbar::~SalInstanceToolbar() /vcl/source/app/salvtables.cxx:1123:5 #2 0x7f189ac45321 in std::default_delete<weld::Toolbar>::operator()(weld::Toolbar*) const lode/opt_private/gcc-7.3.0/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:78:2 #3 0x7f189b91b0e9 in std::unique_ptr<weld::Toolbar, std::default_delete<weld::Toolbar> >::reset(weld::Toolbar*) lode/opt_private/gcc-7.3.0/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:376:4 #4 0x7f189b8ef46d in svx::sidebar::PosSizePropertyPanel::dispose() /svx/source/sidebar/possize/PosSizePropertyPanel.cxx:148:18 I.e. it's important to delete mxArrangeDispatch before mxArrangeTbx, since the dispatch has a reference to the toolbox. Change-Id: Ief294b492bc3778b0d39650a5642d21fa1db66f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86177 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-02tdf#96505 Get rid of cargo cult long integer literalsYusuf Keten
Change-Id: I6b21f25738458a1d85905a3a02eb17c51a626b0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85932 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-02PaperSizeListBox is now unusedCaolán McNamara
Change-Id: I0ce2fbb7f0346f55984a419f741319690a209434 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86121 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-02weld SlideBackgroundCaolán McNamara
Change-Id: I6f8792d8212807b4be4a24885e237290e298dfa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-02remove unused GetI18nNumbering variantCaolán McNamara
Change-Id: Iedf17b5a25bb7c41ebb1f19b06a1d839f7b08ca7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86083 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-02PageNumberListBox is now unusedCaolán McNamara
Change-Id: I2d1c070cb54ca3596eb7f5b07b46f5aa98565633 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86082 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-02sidebar: bring new sidebar commands in-house & be more assertive with sfx2Michael Meeks
Force the sidebar to do it's asynchronous things synchronously to help keep things sane. Also emit our (in-process on Android / iOS) context change notification after everyone else got it & updated their panels. Change-Id: If94de6c83f1b783d7deee515fc2ee9a8d3754765 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86088 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-01weld PageStylesPanelCaolán McNamara
Change-Id: I8e6842a342b242eeaa6d7a27e268dbe5691a9703 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-01weld NumberFormatPropertyPanelCaolán McNamara
including GtkMenuToolButton hackery to support a toggled state Change-Id: Ia1cf5fd7d56c2e475194cd2d0431611f278f5a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85873 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-01tdf#75280 Convert inappropriate use of sal_uIntPtr to better integer typesYusuf Keten
Change-Id: I5a1bbbc677f41fec342484b5244a32ce3a624bd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86049 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-31tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesKemal Ayhan
Change-Id: If89f71675c4fbfaf0a4a2d24133ee3d3167d0836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85964 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-31separate setting toggle and showing menu for ToolbarToggleMenu buttonsCaolán McNamara
Change-Id: I7989c5b85cbf4e7698c76e35a516bcc39da41897 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86038 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-30rename SvxDialControl back to DialControlCaolán McNamara
Change-Id: I4dcf12b6eccf18a0659c5d5f9cd58bd104c4dc6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-30DialControl is now unusedCaolán McNamara
Change-Id: Ifdaa6322c3eb12cb0df5130b0da0596ebca15321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85769 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-30SidebarDialControl is now unusedCaolán McNamara
Change-Id: I949276018ed1867ce2a450c013c7fa41206fe68c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-30weld PosSizePropertyPanelCaolán McNamara
Change-Id: I32bba3a698a4cc78d4159c6f373b312540478ab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85764 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-29acc. check: implement goto for OLE/Graphic objectsTomaž Vajngerl
This implements goto function for Graphic/OLE objects that are reported in a AccessibilityIssue. So this enables to go to the object inside a document for which we have reported an accessibility issue. Change-Id: I699966b116a76ea032cb1acc9a431687fa204e07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85922 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-29acc. check: add "goto" button to see the acc. issue in documentTomaž Vajngerl
This adds the UI for the goto functionality to the UI, but currently no goto implementation to jump to the specific issue area in the document is written. Change-Id: I5b326a000e62231c491c179b1ff8accde15e1e98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85920 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-29acc. check: add writer specific accessibility issueTomaž Vajngerl
This adds sw::AccessibilityIssue and refactors the existing code to work with it. In addition adds AccessibilityIssueCollection which holds the vector of results. Change-Id: Ide0fdbdba337bbf8c2fd18770895fb63a22528b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85919 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26use more TOOLS_WARN_EXCEPTIONNoel Grandin
so we get more useful log messages when stuff goes wrong Change-Id: Ia55db7ab1a4d79b0f281673fbbb06c61745fa89e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-26AccessibilityCheck iface, namespacesTomaž Vajngerl
This adds AccessibilityCheck interface into svx, which also requires addition of namespaces as there is now AccessibilityCheck interface and the implementation in sw (sw::AccessibilityCheck). Change-Id: If7065cdab90b02478c57f22afb7ca716d70b8dce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85837 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26Accessibility check dialogTomaž Vajngerl
This adds the accessibility check dialog which is responsible to show all the accessibility check issues in the current document. Currently this just shows the text message in a list that comes from AccessibilityCheck. Change-Id: I8fd27038e3d85cd31fe172eee5e391fd4b7243ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85821 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-26Add accessibility check to the Writer menuTomaž Vajngerl
Change-Id: I7e4c3267288b238583822489c8098e64319dda16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85819 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-23sal_Char->char in svxNoel Grandin
Change-Id: If7fb907575640b95399419beee5af6cfbd5fafb2 Reviewed-on: https://gerrit.libreoffice.org/85714 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-22svx: LOK: convert background child-dialogs to asyncAshod Nakashian
(cherry picked from commit 625a8c33bd95b4068838caef19af28c5404c59ce) Reviewed-on: https://gerrit.libreoffice.org/83633 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 46a1c0a733f1e664823dcb483796dbcc8a743f4a) Change-Id: I682ab039ce3732aa973e0fe371c191f1ca1b9ef7 Reviewed-on: https://gerrit.libreoffice.org/85677 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-12-21Get rid of two pointless #definesTor Lillqvist
Change-Id: I7479f4f1c440bba1dd9f922c4df32ab877e0a803 Reviewed-on: https://gerrit.libreoffice.org/85619 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 83fedc02f2d831774c12d60097a99e968b56dc5e)
2019-12-20tdf#122280: Hide Block selection mode from CalcAditya
Currently, the Block Selection Mode in pop-up menu is dysfunctional in Calc. It is unreachable - when the user tries to choose "Block selection" from the pop-up menu that lies in the status bar, it shifts back to "Standard selection". Hide the Block Selection mode from Calc, simply because it is dysfunctional and useless. Change-Id: Ib8618b7f0281de13a5f6ef9d35b67330f43c4318 Reviewed-on: https://gerrit.libreoffice.org/84142 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-12-20weld DefaultShapesPanelCaolán McNamara
Change-Id: I7bdd1e15f525fad99394f4ca4360bf7e1339b33a Reviewed-on: https://gerrit.libreoffice.org/85594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-20tdf#126966: Tweak to get the "color bar" below text color controls to show upTor Lillqvist
(In iOS-only code, for now.) No idea where the size that the thing has to fit inside comes from; possibly one could alternatively have made that larger? (cherry picked from commit 4de843ee0de7f9211f536dc6c4ee0d05bf26cc52) Change-Id: Ifc1bec4c08c279403127056ecc61db4b80c03f96
2019-12-20loplugin:duplicate-definesNoel Grandin
only used in one place, so just inline it Change-Id: I198dd22888beab4c7b72e053943d337c9123a03a Reviewed-on: https://gerrit.libreoffice.org/85554 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20weld GraphicPropertyPanelCaolán McNamara
Change-Id: I05293f7421815e7588dcf344fcd221ca337b116d Reviewed-on: https://gerrit.libreoffice.org/85550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-20weld ShadowPropertyPanelCaolán McNamara
Change-Id: I5ffd5881955726823b0e4c6f347e9a1e1767b640 Reviewed-on: https://gerrit.libreoffice.org/85535 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-20SpacingListBox is now unusedCaolán McNamara
Change-Id: I051200802c7841dc6feb9e3ab852385887c29b09 Reviewed-on: https://gerrit.libreoffice.org/85533 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-19SameContentListBox is newly unusedCaolán McNamara
Change-Id: I73b2aa5a140d1442901e6b1c7e1334bce74c5e41 Reviewed-on: https://gerrit.libreoffice.org/85529 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-19weld PageFooterPanelCaolán McNamara
Change-Id: Ice9e7c5ab9c1085021ebb3561cfb2bd0a6727066 Reviewed-on: https://gerrit.libreoffice.org/85526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-19get native gtk widgets in sidebars workingCaolán McNamara
Change-Id: If65aef1249f54a87d7854c3fa2db4319a24a5a05 Reviewed-on: https://gerrit.libreoffice.org/85326 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-18Fix typoAndrea Gelmini
Change-Id: Ia721484c9c39d62e939bb3f5628c8dcaa89d5603 Reviewed-on: https://gerrit.libreoffice.org/85417 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-18tdf#127481: reset active cell reference during table copyStepas Toliautas
During cloning of 1x1 table, SdrTableObjImpl.mxActiveCell reference is set incorrectly, keeping an address of a temporary cell. I clear that reference so it gets assigned to a cell of a new table on first request. An alternative is to find the position of an active cell in source table and set it to a corresponding cell in cloned table (after call to new TableModel()), but I have no opinion on whether newly-cloned table should have active cell marker, and the assignment seems to work in some other fashion for multi-cell tables. So I just zero-init temp object, which should be done anyway. Change-Id: I965b7afbfedf2e57262d3388be1d045687521eee Reviewed-on: https://gerrit.libreoffice.org/85275 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-12-18reduce temporary OUString creationNoel Grandin
speeds up dialog load time a little (5%) Change-Id: Ia4e5f1973bb6f06b2b5ec6a251e4ad07fc3636d2 Reviewed-on: https://gerrit.libreoffice.org/85389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18drop ellipsize on 'and'Caolán McNamara
Change-Id: I60377bf94c2c7c360bb56e0cd85df3d7dabe61e9 Reviewed-on: https://gerrit.libreoffice.org/85323 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-17loplugin:expandablemethodsNoel Grandin
Change-Id: Ifc269d9996928085a3ab78033788465b4f029368 Reviewed-on: https://gerrit.libreoffice.org/85255 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-16lok: send message when in place editingSzymon Kłos
Fixup mis-merge into the wrong module of "lok: send message when in place editing" This reverts commit a5acbbdbce32b25000ad2f1429c7bc307c7d28cb. Change-Id: Ia7ee0b70e2c491274d9fa7eb5808396e83fb3e52 Reviewed-on: https://gerrit.libreoffice.org/80682 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82151 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-15tdf#127481 don't override SdrText::GetItemSet() for cellsThorsten Behrens
No point in overriding GetItemSet() with behaviour similar to parent class (but less robustly so). Change-Id: I2bdff44bfded0a5fa272964b4e0671cacb125f06 Reviewed-on: https://gerrit.libreoffice.org/85148 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-12-14loplugin:expandablemethodsNoel Grandin
Change-Id: Ia8192e03feda9e8ae70e29d8dc98d995f015f9ce Reviewed-on: https://gerrit.libreoffice.org/85135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-13Enable edit chart button on desktop and webMuhammet Kara
Change-Id: Iad98ff3e0b7f3cc6608a119134ce3595dd921e58 Reviewed-on: https://gerrit.libreoffice.org/83755 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/85092 Tested-by: Jenkins
2019-12-13Add Edit Chart button for online's mobile viewMuhammet Kara
To improve UX by providing mobile viewers a way to enter into edit mode of a chart via single tap Change-Id: I3cfb82df166c571a401f195a7f7c806fd6df604e Reviewed-on: https://gerrit.libreoffice.org/83614 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/85091 Tested-by: Jenkins
2019-12-12use covariant return type for SfxPoolItem::CloneCaolán McNamara
and can then remove some casting Change-Id: Id821c32ca2cbcdb7f57ef7a5fa1960042e630ffc Reviewed-on: https://gerrit.libreoffice.org/85022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12Remove some redundant user-provided dtorsStephan Bergmann
...which silences various -Wdeprecated-copy-dtor warnings from Clang 10 trunk about copy functions being implicitly defined as non-deleted even though the class has a user-declared dtor Change-Id: I3409d403c3c709de4ad94eccbc2d7869e41847cc Reviewed-on: https://gerrit.libreoffice.org/85032 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>