summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2016-04-26Resolves: tdf#98366 paste document has 10x10 sized SdPages...Caolán McNamara
so long lines in them are clipped out in the preview. Change-Id: I355986ff4a9c9e53f8e8f5d41b63f74c633f41ee (cherry picked from commit 93efd7ebbad293d3729b8ea4b9726aff498f607f) Reviewed-on: https://gerrit.libreoffice.org/23994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 17c61cc64278c006b06f8b152d79073c0ef16993) Reviewed-on: https://gerrit.libreoffice.org/24418 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-02tdf#96922 Suppress EditView PageVisuailsation in GraphicExporterArmin Le Grand
PageBackground is due to old constraints in exporters not completely hindered when IsPageVisible() is already set for signalling that all EditView-specific Page visualisations should be suppressed. As long as these exporters are not adapted, use the setting of SetPagePaintingAllowed() which consequently achieves this. Change-Id: I2222a799533f763b54b2210a46c24aa8ae92d7a2 Reviewed-on: https://gerrit.libreoffice.org/22837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit f3ff67d3c3047de3ad43f8bb3f805d82eaef0479) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2016-02-04avoid crash with color listbox for nowMarkus Mohrhard
(cherry picked from commit 5ee0e6ab93ad791f5e79506efafd16cb7364ffb1) Change-Id: I36ac6513546961ec8d8d1e9437a8ef88574acbf4 Reviewed-on: https://gerrit.libreoffice.org/22121 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-03tdf#91762: Check wether the row and the cell have text...Xisco Fauli
... in order to set the row's min height Regression from 4f2c8194f485b1527fb4f4dfe23ce804937f1f9c After this commit, the row's min height was set based only on the cells containing text in the row, but the problem appeared when the row didn't have any cell with text. Change logic to check wether there's text in the cell and in the row. Now, height in SdImportTest::testRowHeight() is 507 instead of 508 but I can't figure it out why. However, I believe there's no harm in change the test from 508 to 507 as, visually speaking, the difference can't be distinguish. Change-Id: I0b3a14c34eaeaa8e77227860ca290fb79a0302ce Reviewed-on: https://gerrit.libreoffice.org/21692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit 13d4398820ded5914f635757865e258db2db2b57) Reviewed-on: https://gerrit.libreoffice.org/22009 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-02-02Resolves: tdf#97276 don't clip out line if the underlying page size is unknownCaolán McNamara
Change-Id: I77d88d8020e9ac26bd6b7277e6d8afefed5e3ee7 (cherry picked from commit ad99c633908f7c70d06812ebfb4e0696666f0158) (cherry picked from commit 38b362c58abd0df654665956ffc751d40cfb67ab) Reviewed-on: https://gerrit.libreoffice.org/21814 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-01-13Related: tdf#71622 compress more gfx in odf streamsThorsten Behrens
Except for jpeg and png, most natively-stored image fileformats compress rather well with zlib. adding a number of vector and pixel formats. Change-Id: I97407a98f620520b0d11552911d2339bf004dc5b Reviewed-on: https://gerrit.libreoffice.org/20461 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit ad0edc184792f3aa3f72e8d4ec8b76c3d1bf8479) Reviewed-on: https://gerrit.libreoffice.org/20467 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 26f62c80aa3684301e29dd17f9efba1bcd68264d) Reviewed-on: https://gerrit.libreoffice.org/21438
2015-12-17fix missing BaseURL when loading embedded objectsMichael Stahl
When the object is edited in the UI, the m_xClient is set to a SfxInPlaceClient and the DocumentBaseURL is retrieved from it. But if the object is not edited, it will be loaded during export via the API and without a m_xClient; in this case the DocumentBaseURL must have been set previously to be available during import. There appears to be no way to get the URL of the document via the API while it is being imported; SfxBaseModel's m_sURL is unfortunately only initialized from SfxObjectShell::FinishedLoading(). During ODF import, the SvXMLEmbeddedObjectHelper creates the embedded object, so let's make it pass in the parent's BaseURL. The "DefaultParentBaseURL" parameter already exists but was unused previously. (cherry picked from commit b0fc09daf1086423a9bd457d9a2c043e7ff41451) (cherry picked from commit 4118f8f4c20ae711b95ab3052656bde673aa8852) sw: loading embedded ODF objects requires unordf component (cherry picked from commit b3b7982f4690f4ac0f0e9680970ba544157c36dc) Change-Id: I3d1ed29b3a2c0e77ec606a1d09f7bc07e7860733 Reviewed-on: https://gerrit.libreoffice.org/20761 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-12-03Resolves: rhbz#1277445 CalcOptimalExtraUserWidth() is slowJan Holesovsky
its a (very) expensive operation. Don't call it ~20 times on startup, instead call it once when the user actually opens the styles dropdown. (cherry picked from commit e8bcffc787939294b74492527b60fe309490d5e4) Change-Id: I7bb28d0739bf917d23041f384f60a39a7ed5cbea Reviewed-on: https://gerrit.libreoffice.org/20349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-15Resolves: tdf#94069 call setVisible when setDesignMode is calledCaolán McNamara
void UnoControl::setDesignMode calls setVisible on the XWindow so it seems sensible that FmXGridPeer::setDesignMode should also do so. The desirable side effect is that moving the window in design mode then is moving a un-shown window so nothing is invalidated so the paint loop doesn't happen. Change-Id: Ic5a4ba62590372bec15a29b993b73d6dfb94a8a9 (cherry picked from commit a7816853bad55ada597092c16ba9a0a761e067d0) Reviewed-on: https://gerrit.libreoffice.org/19906 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2015-11-13tdf#95551 - fix image map crash.Michael Meeks
Remove listener we add, and don't crash on callback for disposed dialog. Change-Id: Ia6a1bddd212cb28a0331469e8e87324346d02841 Reviewed-on: https://gerrit.libreoffice.org/19936 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-13svx: loplugin:badstaticsMichael Stahl
(cherry picked from commit d5016b013672056f89f908b6cde38183fad145bb) Change-Id: Ief31d8153fdbf91cdd29df5ac7801bd88a98542e Reviewed-on: https://gerrit.libreoffice.org/19955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-03svx: add result of "badstatics" plugin to fix abuse of VCL BitmapsMichael Stahl
VCL Image/Bitmap/BitmapEx instances must not have static life-time because then they will be destructed after DeInitVCL() and that likely segfaults. (cherry picked from commit bf18f1b3535dd17f9bf584cab15ee6a7fd431257) Omitting the plugin itself, the fixes should be enough for release branch. Change-Id: I3ff8d32de729c971b190028094cb4efe206395e2 Reviewed-on: https://gerrit.libreoffice.org/19742 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-30tdf#88548 fontwork gallery always have transparent/checkered background.Aybuke Ozdemir
Change-Id: I8995ef12edb64c14788ba3a2c3c1c2ceb3775b11 (cherry picked from commit 9b322ace3b8f316104f7138b082d2ffdb282c816) Reviewed-on: https://gerrit.libreoffice.org/19642 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-10-28prepare to enable build with ICU 56Eike Rathke
Accept new UBlockCode enum values. Just make it compile, without adding resource strings and blocks. Excerpt of 5b7e8efbf4d73e385c8fb3469a23c0b2592bfb57 Change-Id: Ia14e4c1c85f8be3e7bae0eb6f5bec1ae33f1a0bf Reviewed-on: https://gerrit.libreoffice.org/19632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-10-27tdf#93487 - protect GetFocus method call post dispose.Michael Meeks
Change-Id: Id61e37e4e9ea62c3dba224e55ddfdc71fb0bfc8c Reviewed-on: https://gerrit.libreoffice.org/19542 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-10-27afl-eventtesting: crash on undoing insert new page in impressCaolán McNamara
this is an intermittent crash in the real world but under event testing we can see that the PaintView is informed that the page has been deleted, but doesn't clear its use of the page if it so happens that there was earlier modification events that caused the fire-modification-timer to be launched If there happens to be no such events then the page is correctly cleared If the timer is active, then the page is not cleared, but eventually the timer will fire and access the deleted page and fall over and die minimal change for backporting ease, follow ups now (cherry picked from commit f8b975995c5d0dc6a9fc8febba0667fe24542ad2) Change-Id: I090ad62cc175545902574c93dec7082225d97ab7 Reviewed-on: https://gerrit.libreoffice.org/19551 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-10-27tdf#72205 when saving changes, mark we did a prepareCloseLionel Elie Mamane
Change-Id: I8a86447bdd227621ff7b0b3551798ee343379c74 Reviewed-on: https://gerrit.libreoffice.org/19437 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-10-23crashtesting+ubsan: kde170880-1.html ANISTOPINSIDE cast to StartInsideItemCaolán McNamara
presumably this is a simple typo and it should be ANISTARTINSIDE Change-Id: I05c6cfb857955c7d418e3997845dd0ef6d2bff36 (cherry picked from commit 8e203f58bc275df13e66e733bf0e43970079abed) Reviewed-on: https://gerrit.libreoffice.org/19529 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-10-20tdf#93618 teach DbCellControl about "Date"/"Time" as known value propertyLionel Elie Mamane
Change-Id: Icbb575b86ff39ce263271110aae6e49e5b4e7ac2 Reviewed-on: https://gerrit.libreoffice.org/19409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2015-10-19afl-eventtesting: deref of null GetSdrPageViewCaolán McNamara
Change-Id: Iec3266746c78e58e3c3a094e6511d79dadc4e4c6 (cherry picked from commit 27ccddf5034ec9e80a5adf93c630247bb5807676) Reviewed-on: https://gerrit.libreoffice.org/19465 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-19afl-eventtesting: deref of null MarkedSdrObjCaolán McNamara
Change-Id: I0fe9cb55de114c7e2ad45cd946e94f9c0e93b85c (cherry picked from commit e63c6fe93ebd702c8c62378830d69343003b91bc) Reviewed-on: https://gerrit.libreoffice.org/19464 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-15tdf#94495 - protect lstbox usage post-dispose, and fix ItemWin focus.Michael Meeks
Change-Id: I2e4d1c79f57ec048d66111ed393491b7803ee3b9 Reviewed-on: https://gerrit.libreoffice.org/19387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-13tdf#94477 Make Format > Character accessible for customizationYousuf Philips
Change-Id: I45d02a6a24986175de2283c09e097f73d90cef73 Reviewed-on: https://gerrit.libreoffice.org/19187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 051667ec91a3fa4175fc8ae59529ac02b95e0683) Reviewed-on: https://gerrit.libreoffice.org/19358 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-09-23make FmXGridCell more disposed-safeLionel Elie Mamane
fixes a segfault (crash) in these conditions: * the form's AfterInsert StarBasic script does a reload() of the form * the insert happens by clicking into a cell which has scripts linked to the events FocusLost and FocusGained. The case that led to discovering this involved a ListBox whose RecordSource changes when focus is gained or lost. Then there was a race condition between the cell's dispose (from the form's reload()) and the _old_ cell's FocusLost being executed. NewStyleUNOScript::invoke would then call xControl->getModel with xControl being the involved cell, leading FmXGridCell::getModel() to call m_pColumn->getModel() with m_pColumn == NULL. Change-Id: Ifb4402d37ee4faec80087ffccabe102acc016d60 Reviewed-on: https://gerrit.libreoffice.org/18669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-08tdf#94006 - re-factor and fix OpenGLContext mis-use.Michael Meeks
Squashes two related patches from master: Don't use rtl::Reference for the global / list state, so the ref-count reflects the number of real users. Hold a reference during ~OpenGLContext. Fix mis-use in: gltf rendering, OpenGL canvas, GL transitions & GL capable (charts) Avoid GLX operations on un-initialized contexts. Signed-off-by: Miklos Vajna <vmiklos@collabora.co.uk> Conflicts: vcl/source/opengl/OpenGLContext.cxx vcl/workben/vcldemo.cxx canvas/source/opengl/ogl_spritedevicehelper.hxx Change-Id: I7ea29b544d53bb80b25fa6663d39f345bf8f4e64
2015-09-08svx: fix font rendering in the style previewMichael Stahl
If the style does not actually have any font items, as is the case for frame, page and number styles in Writer, the maFont will be default-initialized and the maPixelSize incorrect. Avoid using these variables. (cherry picked from commit 07df816d73884d094f0f56be022aa0b4eff00b2d) Change-Id: I084cd8faa90a3d53310ceec55e8dae3af3dd586c Reviewed-on: https://gerrit.libreoffice.org/18383 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-09-08tdf#91383: sw: prevent style preview from actually creating stylesMichael Stahl
The dialog/sidebar should not actually create styles that don't exist yet, because it messes up Undo and the (unused) styles are then unnecessarily exported to documents. Due to Writer's ... unusual SwDocStyleSheet class this is a bit tricky. Add a new function GetItemSetForPreview() and use it from the style preview code. The implementation does not use FillPhysical so will temporarily create and then delete any non-existing styles. Skip page and numbering styles for now since they don't have a useful preview. (regression from ca95307638207db5d662059aa61594151a13e927) (cherry picked from commit 93067f37cf22aa119db5878c4345fea500cbbb42) -Werror,-Wreturn-type (cherry picked from commit 0ed64030f17849ea943800343003c5ec3f4f1388) Change-Id: Id6ee30ea467fc24c991547a4c23a9ce14fdd86c7 Reviewed-on: https://gerrit.libreoffice.org/18381 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-09-05tdf#93928 don't hide the zoom slider and its handle with a tooltipLászló Németh
Change-Id: I8e5a3a02e80b845ef65dfed35cc3c324197ed88c Reviewed-on: https://gerrit.libreoffice.org/18345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-09-04tdf#92843: fix disappearing zoom sliderLászló Németh
Change-Id: I2b45b7cf96af7950cf097c2b6a880e9eda021184 Reviewed-on: https://gerrit.libreoffice.org/18342 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-09-01Related: rhbz#1255200 apparent missing stylesheetCaolán McNamara
Change-Id: Ice9a860ca839d37308b5c2f2eb639852fefe1d15 (cherry picked from commit dcb0738b631c61999364bd8500f401f93bbfb84e) Reviewed-on: https://gerrit.libreoffice.org/18240 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-09-01tdf#73071 Fix minor spacing issue in style sectionYousuf Philips
Change-Id: Ied562af293a4e970b9963f566d85a79375737954 Reviewed-on: https://gerrit.libreoffice.org/18221 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-29tdf#92379: svx: don't overwrite fo:background-color on ODF importMichael Stahl
getSvxBrushItemFromSourceSet() is called once for each property of a frame style that is set, and the "solid" fill-style is set by first applying the BackColorRGB and then BackTransparency property. So there is an intermediate state that has fill-style NONE but a XFillColorItem set - don't reset the color to white in that case! Apparently writerfilter generally relies on the current reset-to-AUTO implementation (loads of test failures), so for now limit the fix for when we know that a frame style is imported from ODF. (regression from 3d399b0e45720354fc64dc3d121ee486e01eff89) (cherry picked from commit 79fb61efb847405fa47235002b52ee8efad5e339) tdf#92379: sw: unit test for frame style background color (cherry picked from commit 982537d77c2db463cc053cfdcd522530a3834c9e) Change-Id: Ia987fe586ec819a1f3cd85acdbfb03c74ca0ec2c Reviewed-on: https://gerrit.libreoffice.org/18037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-28tdf#93558 Hardcode black text on white backgroundMaxim Monastirsky
As agreed in the bug report, a preview shouldn't be themed by the OS theme. (cherry picked from commit fa1807ad5457d10f8fa073c209a27547e8922c8c) Conflicts: include/svx/numvset.hxx svx/source/dialog/svxbmpnumvalueset.cxx Change-Id: Icdc5021c3ac614fe1d490fd513a407a81dbc169e Reviewed-on: https://gerrit.libreoffice.org/18068 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-08-26there might be no modelCaolán McNamara
Change-Id: I9c384587c127ca077803bf8aae63d0e54eda6aaf (cherry picked from commit be95c7430d2fd9858f41ee8e8882d987a5bbe749) Reviewed-on: https://gerrit.libreoffice.org/18025 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-18tdf#93102 : resolved crash on enabling image contourSzymon Kłos
Change-Id: I59a07a62573b8d472d15f8594473e8e8d1077589 Reviewed-on: https://gerrit.libreoffice.org/17758 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-17tdf#93114 insert character: add missing recalculate for font selectionLászló Németh
Fixing missing characters (only characters of the basic Control font showed by Insert special character dialog) and freezing (when LibreOffice tried to replace hundred of characters [missing from the chosen font] during scrolling in the insert special character dialog). Change-Id: I8fd5bd233f16572eb2b740a8f8e7e8608c19d06f Reviewed-on: https://gerrit.libreoffice.org/17792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-13tdf#93407 GrabFocus during disposeMaxim Monastirsky
Reproduced with the gen vclplug Change-Id: Ia8a5c73908f5af47ef55b4431b6e1e5a21609e7d (cherry picked from commit b556f14fab25ddccbe9a54fe53450a641dbc5a49) Reviewed-on: https://gerrit.libreoffice.org/17705 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-13tdf#78111 Sane preferred width for the color mode comboboxMaxim Monastirsky
Don't let long strings (in some languages) make it request so much space. Change-Id: I5b2af9d7cc54d1ba772ae75971cfff27bee31a05 (cherry picked from commit d2f218f54369c6d7fb38d0b701aa86fdf5aae843) Reviewed-on: https://gerrit.libreoffice.org/17699 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-12Resolves: tdf#93113 crash on revisiting insert special characterCaolán McNamara
this effectively reverts commit c43ee00e5d2edfebfa148b310813335aab27db34 Author: Herbert Duerr <hdu@openoffice.org> Date: Wed Aug 15 13:20:51 2001 +0000 #91025# reduce flicker in charmap dialog in favour of the new double buffering Paint is calling RecalculateFont which calls SelectIndex which calls Update which calls Paint, boom Change-Id: I69e9f53b7db09837ff08a2ce9fc6f81a52b5c794 (cherry picked from commit 79395c934771818686e488a7c2e382a00456c8a1) Reviewed-on: https://gerrit.libreoffice.org/17674 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-08-12Related: tdf#78111 Try to guard against too wide panel layoutsMaxim Monastirsky
The sidebar has width limit, so a panel shouldn't attempt to resize more than that. Otherwise we'll get an endless loop. (based on e98cf0c63d6c48ca7c1db87d7413d5c419690c76) Change-Id: Ia36535637e3585595c673c7fc46a1a7b162b74ba Reviewed-on: https://gerrit.libreoffice.org/17667 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-12tdf#93290 Limit the size request of the styles comboboxMaxim Monastirsky
Change-Id: I1ef697008dcd5e993c1d509fce055c5454d80f40 (cherry picked from commit 7d3fa6bae9f7a755eb2d0ca24bf1afd5f3646bb7) Reviewed-on: https://gerrit.libreoffice.org/17668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-12tdf#93382: Make HACK more targeted to avoid collateral damageStephan Bergmann
Change-Id: Ieecad5f244703c4d2436e22a3ab50f719843eef4 (cherry picked from commit 68c6408b1725a8f506a8adb8c9af67a65e667f1c) Reviewed-on: https://gerrit.libreoffice.org/17672 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-07Listen to error only while operating on controller.Lionel Elie Mamane
Else, on any action done directly (not through the FormControllerHelper) on the controller and raising an SQL error, this would silently swallow the error message, and the operation would fail without any message to the user. E.g. when validating an insertion or modification in a grid control by moving the cursor to a different line (as opposed to clicking the "Save Record" button). Change-Id: Ie569d9c826609f803f7b312c0469907155558ef2 Reviewed-on: https://gerrit.libreoffice.org/17268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-08-07form document view activation: prioritise activation of already active formLionel Elie Mamane
This avoids arbitrarily switching to the first form in the document, which would do a (premature!) save to the database of the modifications pending in the active form. This may lead to a database error, when the data is not in a shape to be written to the database, e.g. when on an insertion row and not all mandatory fields have been filled in. This then pops up an error message to the user. Change-Id: I30bb533598ca707b892bb7155e54ce05d4ddf275 Reviewed-on: https://gerrit.libreoffice.org/17269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-07-23tdf#92725 FormattedField: when model value is NULL, force empty display stringLionel Elie Mamane
as opposed to implicitly keeping whatever unrelated string was there before. Change-Id: Ifaf1b41e951e97f209ecb617b32ec4f7522b1d08 Reviewed-on: https://gerrit.libreoffice.org/17297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-07-23ListBox in grid: properly set selection on change from modelLionel Elie Mamane
In particular when changing row. 1) Teach DbCellControl about "SelectedItems" as known value property. 2) Fix DbListBox::updateFromModel to actually use the SelectedItems it reads from the model, as opposed to throwing it away. Change-Id: I7074c13b3d271bf2362aa059378aa857682a040b Reviewed-on: https://gerrit.libreoffice.org/17298 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-07-23svx, sd, sw: GetPoolDefaultItem() can actually return nullptrMichael Stahl
...if you call ResetPoolDefaultItem() first. Crash found by Varun Dhall. Change-Id: I409484c172fb5843270aee2425844076a008b4df (cherry picked from commit bcb1f81668d9b6a6d807ae32d60ccfce0b36ceb5) Reviewed-on: https://gerrit.libreoffice.org/17320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-07-23tdf#92600: Restore ability to apply font settings to controlsKatarina Behrens
SmShowSymbol handles font/fg/bg settings by itself, so make ApplySettings noop there. This partially reverts commit b010e4074e5d5ee3a3905f1351f04efafe937c2a Reviewed-on: https://gerrit.libreoffice.org/17288 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 94ceda8b2fea37587424b664e17fa9ee8b01e158) squashed commit from László Németh <laszlo.nemeth@collabora.com> tdf#92600 fix missing font preview in character set widget The previous fix for tdf#92600 (missing bold text in dialogs) brought back the regression in the special character set widget: the characters show always the default font of the Control class instead of the chosen font, see in the Insert->Special Character... dialog window of Writer. Change-Id: Ib5074684ef1277d9b9b4646bd73dce4cbff3943e 2bdc2300f481dd680877f84ea2a717b9e749c64c Reviewed-on: https://gerrit.libreoffice.org/17303 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-17tdf#92571: add mime types for several image file formatsCarlos Luque
The new mime types were added the followings: - eps -> image/x-eps - wmf -> image/x-wmf - bmp -> image/bmp - pct -> image/x-pct These new mime types are written in the attribute "media-type" of each image in the file "manifest.xml" Change-Id: I16edb625e331d3f917c6e8929df004191e317acc Reviewed-on: https://gerrit.libreoffice.org/17123 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 4d84153e22bdda33b23deb4c32afcace4c1264f7) svx: this was supposed to be "image/x-eps" Change-Id: Ieb9d7f23a0ef1e4546c488a678dbfde085156216 (cherry picked from commit 5351f621d5eb599757af95213c4b391c0f34df2e) Signed-off-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-07-15Resolves: tdf#63955 clip 19km long line to some sane limitCaolán McNamara
Change-Id: If9757a5fa2bb93b56b9cf9f566972f687a4a3a45 Reviewed-on: https://gerrit.libreoffice.org/17036 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d1046e7c3f66e5f3384ee1ef534ef28346702fc6) refactor ensuring polygon has at least a line in it just split that out into a standalone function, no logic change Change-Id: I061d5d716b3fc2a9fb6385e7fb249ce300752130 (cherry picked from commit 83b3349bb94d4c48db4da8fe5f8fdb9b19e633b9) Reviewed-on: https://gerrit.libreoffice.org/17073 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit (git 2.34.1) at 2024-06-07 01:54:23 +0000