summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2015-06-03-fsanitize=float-divide-by-zeroStephan Bergmann
...happens at least during CppunitTest_sd_tiledrendering that aCurrTextSize.Height() is zero: SdrTextObj::ImpAutoFitText(SdrOutliner&, Size const&, bool) svx/source/svdraw/svdotext.cxx:1312:49 SdrTextObj::ImpAutoFitText(SdrOutliner&) const svx/source/svdraw/svdotext.cxx:1290:5 SdrTextObj::BegTextEdit(SdrOutliner&) svx/source/svdraw/svdotxed.cxx:103:9 SdrObjEditView::SdrBeginTextEdit(SdrObject*, SdrPageView*, vcl::Window*, bool, SdrOutliner*, OutlinerView*, bool, bool, bool) svx/source/svdraw/svdedxv.cxx:635:12 sd::View::SdrBeginTextEdit(SdrObject*, SdrPageView*, vcl::Window*, bool, SdrOutliner*, OutlinerView*, bool, bool, bool) sd/source/ui/view/sdview.cxx:704:20 sd::Outliner::EnterEditMode(bool) sd/source/ui/view/Outliner.cxx:1299:9 sd::Outliner::PrepareSearchAndReplace() sd/source/ui/view/Outliner.cxx:1181:9 sd::Outliner::ProvideNextTextObject() sd/source/ui/view/Outliner.cxx:973:29 sd::Outliner::SearchAndReplaceOnce() sd/source/ui/view/Outliner.cxx:674:17 sd::Outliner::StartSearchAndReplace(SvxSearchItem const*) sd/source/ui/view/Outliner.cxx:496:28 sd::FuSearch::SearchAndReplace(SvxSearchItem const*) sd/source/ui/func/fusearch.cxx:132:33 sd::DrawDocShell::Execute(SfxRequest&) sd/source/ui/docshell/docshel3.cxx:222:21 SfxStubDrawDocShellExecute(SfxShell*, SfxRequest&) workdir/SdiTarget/sd/sdi/sdslots.hxx:17034:1 SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) include/sfx2/shell.hxx:210:35 SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) sfx2/source/control/dispatch.cxx:257:13 SfxDispatcher::_Execute(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) sfx2/source/control/dispatch.cxx:847:9 SfxDispatcher::Execute(unsigned short, SfxCallMode, SfxItemSet*, SfxItemSet*, unsigned short) sfx2/source/control/dispatch.cxx:916:9 SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) sfx2/source/control/unoctitm.cxx:823:37 SfxOfficeDispatch::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) sfx2/source/control/unoctitm.cxx:359:9 non-virtual thunk to SfxOfficeDispatch::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) sfx2/source/control/unoctitm.cxx:343:34 comphelper::dispatchCommand(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) comphelper/source/misc/dispatchcommand.cxx:57:5 lcl_search(rtl::OUString const&) sd/qa/unit/tiledrendering/tiledrendering.cxx:338:5 SdTiledRenderingTest::testSearch() sd/qa/unit/tiledrendering/tiledrendering.cxx:361:5 ... Change-Id: I38ab71c5f4024b2d7270a4f6c2aeb4ef502d08f5
2015-06-02Fix indent button icons in impress/draw sidebarYousuf Philips
Change-Id: Ib21c2489e1ff420e651e50a2731dfd3f16c9cef8 Reviewed-on: https://gerrit.libreoffice.org/16028 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann
Change-Id: I35229af6f25db931bd98bdf53add2f2ed65774c0
2015-06-01tdf#88276: Add background colour toolbar and sidebar buttonsKatarina Behrens
but they do nothing yet, follow-up commit(s) add real functionality to them Change-Id: Ieac5d0326b284069b8da1b39f94bdb5a8c84b6dd Reviewed-on: https://gerrit.libreoffice.org/15841 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-01tdf#88276: Add slot and handlers for toolbar|sidebar buttonsKatarina Behrens
those changes make getting/setting of text background colour possible from toolbar and sidebar buttons, but likely more handlers needs to be added to various other places in the code Change-Id: I698ca2304399befdd63317eb8872aa3129f27637 Reviewed-on: https://gerrit.libreoffice.org/15909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-01coverity#1302609 Division or modulo by zeroCaolán McNamara
Change-Id: Ia578a948b776c15372d3940b350f20048bb6124c
2015-06-01svx: nObjAnz -> nObjCountMiklos Vajna
Change-Id: I1ae00035c5ae9ac620f01982d6e4fff593f7c054
2015-05-29dispose SfxControllerItem objects correctlyLászló Németh
Change-Id: Id5f80e06e5609b4e85f3d6db7bc37aabe6ef0dac
2015-05-29tdf#91702 - fix stack-based MessBox allocation.Michael Meeks
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-29loplugin:redundantcast: const_cast to same typeStephan Bergmann
Change-Id: I226413abb1e87fcb9de21a496b359dd7ef33761d
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: Icb31e51575f7fffd36be73bbd87a3c5e56c3aa26
2015-05-28tdf#91653 Give this command a saner nameAdolfo Jayme Barrientos
Change-Id: I0cd1d51d1e16019c87e0c615c046a553eb5dc138
2015-05-28GetFocusFlags::Cursor->GetFocusFlags::CURSORNoel Grandin
to avoid name-clash with X11 headers Change-Id: I727c523f6d9bd7d4db28fe7427e053903626be00
2015-05-28convert GETFOCUS constants to scoped enumNoel Grandin
Change-Id: I7c324bb6358be28c119592850eb7607479279f09
2015-05-28Rewrite all calls like Dialog(params).Execute()Philippe Jung
Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-28Resolves tdf#67712 form controls and draw objectsHenry Castro
anchored to cell but changes position after reopening Also included tdf#68797 "FILEOPEN lost position of lines anchored to cell". It was marked as duplicate but the step to reproduce are different. Conflicts: sc/qa/unit/subsequent_filters-test.cxx Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: Ia1c4010f118749256077a0ecad6ca16b867d22f7 Reviewed-on: https://gerrit.libreoffice.org/15523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-05-27cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I27c24d3284a8e0678fc5c041426b4a7e71cbd363
2015-05-27Fix accidental mis-uses of VclPtr address-of operatorStephan Bergmann
Change-Id: I3a82423378d3198a25f90ddfbf42af55d85c96fb
2015-05-27convert WINDOW_DRAW flags to scoped enumNoel Grandin
Change-Id: I9400a286fab18d683b4c109007961685f01b6da3
2015-05-26Resolves: tdf#91542 crash on pressing return in sidebar line popupCaolán McNamara
Change-Id: I661a51f84827326dfc33a11a02f8065d68e8333a
2015-05-26Related: tdf#91542 line box width cannot be changedCaolán McNamara
Change-Id: Ibbeefcff785ee76a1a7ce46d98c1006fc8fe46fc
2015-05-26convert INVALIDATE constants to scoped enumNoel Grandin
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the IDL docs for XWindowPeer Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d
2015-05-26SdrSnapView: initializae members in the constructorNorbert Thiebaud
remove ClearVars() which was only use by the constructor instead initialize properly things in the constructor itself Change-Id: I20a0ea26c5dce680844f81cf85ee72e1809a7068 Reviewed-on: https://gerrit.libreoffice.org/15890 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-05-25Audit all PostUserEvent calls and instrument for VclPtr.Michael Meeks
Hold a reference on the VclPtr while we're waiting for the UserEvent. Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
2015-05-25tdf#91525 - dispose SfxControllerItem member.Michael Meeks
Change-Id: I71b32c1db2f4695deb90412e83b9e7883e9bf1d7
2015-05-25rename "Lathe Object" to "Rotation Object" in a tooltipStanislav Horacek
because the latter is always used in other places Change-Id: I42c74cf24a900541aa866aec7bc70b1ea3162b10 Reviewed-on: https://gerrit.libreoffice.org/15873 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-25remove some unnecessary casts and convert some to const_castNoel Grandin
Change-Id: I590a87c832bc59947ae04e52d3ac5ea71574bb11 Reviewed-on: https://gerrit.libreoffice.org/15888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-25tdf#91582 initialize charmap when selecting in SvxShowCharSetTomaž Vajngerl
Change-Id: I3f73eef349e65a1d2d283d1116729694c1f40ed9
2015-05-24tdf#62525: use cow_wrapper for SdrTextAttributeThorsten Behrens
Change-Id: I8daf6d155c631cbdb850a6af95c92a578905d6e6
2015-05-24tdf#62525: use cow_wrapper for SdrFormTextOutlineAttributeThorsten Behrens
Change-Id: I7f75833bfec2cde140ded1dfe60aed2684905b0a
2015-05-24tdf#62525: use cow_wrapper for SdrFormTextAttributeThorsten Behrens
Change-Id: I0fd55ea6c775d771e001c0db78bb72c50e9b81cf
2015-05-24tdf#91534: Writer crash using Gallery icon in sidebarJulien Nabet
test mpBrowser1 if not NULL + reorder the disposeAndClear calls (must be reverse order compared to the order of Create calls) Change-Id: Ia5481430791d9ab73e63d49a0ef0d5e0a6016605
2015-05-23tdf#91431 - fix post-dispose focus issue in color window.Michael Meeks
Change-Id: I7990cbddc8c664da5ec6521cf8e036ca67d5ce0e
2015-05-23mark numbers as untranslatableStanislav Horacek
Change-Id: I5c7c2c5bb0ce615d4dda8a634517b627b7d49df6 Reviewed-on: https://gerrit.libreoffice.org/15871 Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org> Tested-by: Joren De Cuyper <jorendc@libreoffice.org>
2015-05-23use sliders in CompressGraphicDialogTomaž Vajngerl
Change-Id: I272d0f9d56a601b78cbc3e67ff1f87db964d5ccd
2015-05-22tdf#91395 - avoid post-dispose charmap crasher.Michael Meeks
Change-Id: Ia3536e0297ecd24f6368b9563002a9888904007a
2015-05-22Avoid overflowing SetSizePixel computationStephan Bergmann
...near the end of SetupEntry, which appears to not be needed here Change-Id: Ia273df8a22d26974572d8e9be8de2a27936ee496
2015-05-22Simplify GetSize().Height() -> GetHeight()Stephan Bergmann
Change-Id: I8541eb13d82d887ef589a0545d36db88e47932e7
2015-05-22convert WINDOW_POSSIZE constants to scoped enumNoel Grandin
Change-Id: Id85137ffc7309a66b04132d588d289db136117b9
2015-05-22convert WINDOW constants for GetWindow() methods to scoped enumNoel Grandin
Change-Id: I0c7c6d095732704eb4ab48f1277a0592b1c7fa33
2015-05-22loplugin:constantfunctionNoel Grandin
Change-Id: I7cb5b0c2cf9ade557173ca596ea5d42d853ff448
2015-05-22convert constants in include/vcl/settings.hxx to scoped enumsNoel Grandin
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3 Reviewed-on: https://gerrit.libreoffice.org/15828 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-22convert POINTER constants to scoped enumNoel Grandin
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-21tdf#91095 svx: avoid unconditional SdrObject -> SdrObjCustomShape static_castMiklos Vajna
Change-Id: I5ed86633e909c13f14ee382b4d9ec8f9c264df1d
2015-05-21convert CVT constants to scoped enumNoel Grandin
Change-Id: I7703816b6a1df2bf24c06cdf9992f9982ae724e8 Reviewed-on: https://gerrit.libreoffice.org/15826 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-20bin/rename-sw-abbreviations.shlibreoffice-5-0-branch-pointChristian Lohmaier
renames the most annoying abbreviations in Writer (and partially in the shared code too). Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2015-05-20convert DEFAULTCONSTANT constant to scoped enumNoel Grandin
Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
2015-05-20convert ANTIALIASING constants to scoped enumNoel Grandin
Change-Id: I175b8ea4e8bc01c3cdd3dd90506eba01b35e0085
2015-05-20convert DRAWMODE constants to scoped enumNoel Grandin
Change-Id: I36cbe8057d09226f8b302963bdd94dc5600b686f