summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2016-12-08convert SFX_HINT to scoped enumNoel Grandin
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07Match conditional for glxtest static library in vclTor Lillqvist
Change-Id: If5b4308a29c78ded311bf300416b2cb4f553a7d5
2016-12-07tdf#104405 Clone Formatting ignores vertical text alignmentNoel Grandin
Change-Id: I56cce69ddb21f7f9336b8f59e181e91306e92019 Reviewed-on: https://gerrit.libreoffice.org/31623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-07tdf#75280 Convert few inappropriate use of sal_uIntPtr to better integer typesGaurav Dhingra
partial fix for Tdf#75280 Change-Id: I81d78449b709c246289ebf6bf3e6cabf1198adcb Reviewed-on: https://gerrit.libreoffice.org/31579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-07tdf#91260 svx, sw: don't paint off-page part of drawing objectMichael Stahl
Since commit a4dee94afed9ade6ac50237c8d99a6e49d3bebc1 Writer no longer forces drawing objects to be entirely on one page. However since there is only one SdrPage for the entire document, a drawing object dangleing off the bottom of one page will be painted again on the next page, which is clearly undesirable since Word doesn't do that (and it also destroys the nice invariant that a fly on page N never overlaps a fly on page N+1). So force the SdrPageView code to ignore the drawing object on the next page, by passing in the area of the page frame so that ViewObjectContactOfSdrObj::isPrimitiveVisible() can verify that the anchor position of the SdrObject is actually on the painted page. This requires passing in another parameter; in the usual case the DisplayInfo::maRedrawArea already contains the page frame since commit 8af09bf33291df2fb2bfbbd6e42f9bf074fcc4fc, but there are special cases in SwFrame::Retouch() and SwFlyFrameFormat::MakeGraphic() where some sub-area is passed in, which cannot be used to check the anchor. Change-Id: Ia0476216ca41dbdaa3de1063fa18cb94fe2e5ae8
2016-12-07convert PolyFlags to scoped enumNoel Grandin
and remove the XPolyFlags enum, which has the same values and was being converted to PolyFlags anyhow Change-Id: Iaead84933c79a7603698a4e50257dd944df89c41 Reviewed-on: https://gerrit.libreoffice.org/31627 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06SafeModeDialog: Rename widget to match labelSamuel Mehrbrodt
Change-Id: I6bb02527fa77846343e55ff73497d1b46b5e1ba8 Reviewed-on: https://gerrit.libreoffice.org/31699 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06SafeModeDialog: Add option to reset bundled extension registrationSamuel Mehrbrodt
Change-Id: Ic83ada7cc76142852643cefa60b4fc9286e0756a Reviewed-on: https://gerrit.libreoffice.org/31694 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06SafeModeDialog: Rename to match realitySamuel Mehrbrodt
This doesn't remove shared&bundled extensions, but resets the registration database from shared extensions. Change-Id: I9f198fc7b771fd3bd31547008fd8d006a6d1b5d5 Reviewed-on: https://gerrit.libreoffice.org/31693 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06Simplify codeSamuel Mehrbrodt
Change-Id: Ibb154ebdacb6f445371cb55d795420f92bed0a22 Reviewed-on: https://gerrit.libreoffice.org/31691 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06SafeModeDialog: Could not activate checkboxes to remove extensionsSamuel Mehrbrodt
Because of missing event handler Change-Id: Id546a2b22a89321ca09ec29ba7787a1315753bcf Reviewed-on: https://gerrit.libreoffice.org/31692 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06Change Read/Write access to Scoped Read/Write accessMark Page
Change-Id: Idbe8e393b64f2a151e20c1851d7c14fa161acf97 Reviewed-on: https://gerrit.libreoffice.org/31635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-06convert PolyStyle to scoped enumNoel Grandin
Change-Id: Ia35fdbb5e40888db9558988ac069741b31721f0e Reviewed-on: https://gerrit.libreoffice.org/31633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05drop these intermediate Images and use BitmapEx directlyCaolán McNamara
Change-Id: Ief15df1722bb59323563c21d76f5af624fbef8c9
2016-12-05convert FSysStyle to o3tl::typed_flagsNoel Grandin
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05silence some BAD_SHIFTsCaolán McNamara
Change-Id: I2a669aff0a8a63eb4b16600344cea9f601d5e68a Reviewed-on: https://gerrit.libreoffice.org/31601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-04tdf#88206 replace cppu::WeakImplHelper* in svtools and svxJochen Nitschke
and remove unused implbase*.hxx and compbase*.hxx includes Change-Id: Iedf6b6dce09b5baf714a1b3394bb7fb3526cca82 Reviewed-on: https://gerrit.libreoffice.org/31594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-02avoid valgrind warningDavid Tardon
Change-Id: I8ffb08bdab452f6a8618eaf466b722e7c8d226d9
2016-12-02use early return to simplify flowNoel Grandin
Change-Id: I98201eac2e038c152422bbc6380cfa321ba266df Reviewed-on: https://gerrit.libreoffice.org/31534 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-02coverity#1371200 Missing move assignment operatorCaolán McNamara
adjust things to not need one Change-Id: I1079f50d8813f86c4828be602687b4cbffe61415
2016-12-02loplugin:unnecessaryoverride (dtors) in svxStephan Bergmann
Change-Id: Icc4d9919cedadc00f1420939564dd095fab74cca
2016-12-01fix bug in FmFormShell::GetStateNoel Grandin
Found when attempting an enum conversion. Not sure what effect this will have, it was introduced with commit a0c7b2bc4511da87c776b92aaa77ba7680542fa1 Author: Oliver Bolte <obo@openoffice.org> Date: Tue Nov 16 10:24:21 2004 +0000 INTEGRATION: CWS eforms2 (1.48.52); FILE MERGED which pushed a whole bunch of stuff together. Change-Id: I571fc228c3c0e164aba261e49233ef68ba87e77d Reviewed-on: https://gerrit.libreoffice.org/31491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-01Add toolbar button for page orientationMuhammet Kara
Change-Id: Ia9458f8ac32bb8c6da6fc08e5fee527ca6fb8bd5 Reviewed-on: https://gerrit.libreoffice.org/31473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-30rename getViewIndependentPrimitive2DSequence..Noel Grandin
to getViewIndependentPrimitive2DContainer to match it's new return type Change-Id: I767bdef45316e355d49f6509ca1b50138a45b3fa
2016-11-29safe mode: Add help button to the dialogKatarina Behrens
Change-Id: I5aa29ccf048dc6f7d927089cc3c9b8b39bf2893c Reviewed-on: https://gerrit.libreoffice.org/31367 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-29Rewrite some (trivial) assignments inside if/while conditions: svxStephan Bergmann
Change-Id: I803f4e1a93f1b97e5446032cf557d39db68159e3
2016-11-29Use Size::Width/Height instead of inherited Pair::A/BStephan Bergmann
Change-Id: Ie0346d5ec054fbe7eff1d4b73814a5e2b9f654c2
2016-11-29safe mode: typos and vocabulary nitpickingKatarina Behrens
Change-Id: I8ddeec03ea96eaca873136ccc3100577eba23939 Reviewed-on: https://gerrit.libreoffice.org/31335 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-29loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-28tdf#98525 Commit font style change to dimension line objectUlrich Gemkow
Change-Id: I59e19e00fd0fdadaa7bffc4fbd1cb79d7e5a9763 Reviewed-on: https://gerrit.libreoffice.org/30609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-11-25give us a chance to see *which* property failedEike Rathke
Change-Id: If0c89760230eebc873bbc57511e44d7706af1c1e
2016-11-25Handle cases where last-used palette disappearedStephan Bergmann
...so PaletteManager::SetPalette(LISTBOX_ENTRY_NOTFOUND) would set PaletteManager::mnCurrentPalette to 65535, and PaletteManager::GetSelectedPalettePath would do out-of-bounds access into PaletteManage::m_Palettes. That the last-used palette (as stored under in the configuration under /org.openoffice.Office.Common/UserColors/PaletteName) may become more common with pending changes like <https://gerrit.libreoffice.org/#/c/31199/> "tdf#104047 Remove dispensable palettes". Change-Id: I5641bae04f50fea8aa69027a75de08c22394c281
2016-11-25convert FRM_VALID constants to o3tl::typed_flagsNoel Grandin
Change-Id: I9a84e0ec9c4319ca2edc8dfcc72bfdb08229ecef
2016-11-25convert MODIFY constants to o3tl::typed_flagsNoel Grandin
Change-Id: I230469605b1b3a2a639f51917c23f1a82ec519b5
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-24use o3tl::typed_flags in ConfigurationListener::ConfigurationChangedNoel Grandin
Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e
2016-11-24convert SFX_VISIBILITY constants to scoped enumNoel Grandin
* split the position and the flags information * remove unused DESKTOP constant Change-Id: Ibfccb44c7567e89d4527bfd36b3915a73682e6e2
2016-11-23make strings localizableAndras Timar
Change-Id: Ic74b55b12926a23e9e98308407a88e73dc9cb0c7
2016-11-23small tidyup in SdrObjEditView::ApplyFormatPaintBrushNoel Grandin
Change-Id: I8c1797e78f644bd15eb6d26a96fcc3ed909c2aab
2016-11-23Revert "tdf#104052: Add LibreColor palette"Tor Lillqvist
Väärin sammutettu. This reverts commit aa522981e6a0953e157fa13ec5193147653d317b. This reverts commit 75fb3f79c3ba5e94740cea947527477bba50b358. This reverts commit 250680f57b74f55071d2431e5941dacffa018be4.
2016-11-23Clear the color set before setting it upTor Lillqvist
Change-Id: I4c4e30be172e8fcb2b6d966f06540b9b1b62b9ad
2016-11-23Avoid OUString construction at library load timeTor Lillqvist
Change-Id: Ie56cea732ade971aa276411e7552d4eefe47621a
2016-11-22tdf#104052: Add LibreColor paletteTor Lillqvist
Based on artwork by Christoph Schaefer, dtp studio oldenburg. Instead of the suggested change which added an incompatibly licensed palette file, add a built-in palette (defined in source code) with the same named colours. Change-Id: I3b97e803c0c7430d2ecde422bb5e6b665731f16a
2016-11-22The Palette subclasses don't need to be publicTor Lillqvist
Change-Id: I40f942c202ab3ba1ca13d1b24d0cd72a4c561868
2016-11-22avoid loss of text in edited placeholderDavid Tardon
How to reproduce: 1. Create an empty presentation. 2. Save it. 3. Click at one of the text placeholders and write something. 4. Save again. 5. Reload. The placeholder is missing. (Actually, it's still there, but empty and 0-size.) This only happens if a11y is enabled. Change-Id: I7ae3d3c6ab0ce91aef01c0e9d62f7963dce965fc
2016-11-22trivial makefile cleanupsMichael Stahl
Change-Id: Ida5bdfa06ecd7907305f4f171ca5ab64260d0259