summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2017-12-29loplugin:passstuffbyref improved return in svxNoel Grandin
Change-Id: I33bdbd416709ce46afb3c17aeab0d2e19a68ab30 Reviewed-on: https://gerrit.libreoffice.org/47150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-28Fix typoAndrea Gelmini
Change-Id: I209c6d62c2e5cfbc6a35da406bc59fc155787ec9 Reviewed-on: https://gerrit.libreoffice.org/47127 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-27Remove leading _ from some variable namesMatteo Casalin
Change-Id: I640bf41ad073fcf1d5b8fcc55c63558f208db73d
2017-12-27Make some bool constMatteo Casalin
Change-Id: Icede71af1edfc0671f5b0bc0dbfd3cfc6af79fcd
2017-12-27Return earlyMatteo Casalin
Change-Id: I2b420141b5986b1d23460d5432c1b7051b11663e
2017-12-27mnHitTolLog is already sal_uInt16Matteo Casalin
Change-Id: I4a0e55818ad8e2f61845484a71b6283e0a7c326a
2017-12-27Avoid temporary PointMatteo Casalin
Change-Id: I09ce2859f7bda468399629fda1336788ed65bcb2
2017-12-27Share common codeMatteo Casalin
Change-Id: Ia6ee42c799e566ad837e89d6456c50c7217da1eb
2017-12-27Do not overwrite data with same valueMatteo Casalin
After emplace_back there are at least 2 elements, and GetPrevPos would point to previous back(). Commit 5e913234da65484778d53179ee2005aec01d0f0e removed a possible modification of such data, so this operation is now pointless. Change-Id: Ia5bec5e9b16e9dc9f34c7cf1dbb8e3f17510d83b
2017-12-27Directly access own data members, remove unused methodsMatteo Casalin
Change-Id: Id86d66738da2f6e4b86d4a4ee8da54940c751787
2017-12-25various coverity exception warningsCaolán McNamara
Change-Id: I7b3588ad42e17f2f363b6a247e318f23c95e578e Reviewed-on: https://gerrit.libreoffice.org/46961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25Adjust includesAron Budea
Change-Id: I11385fc987e6951570454919c110de7167f41f5a Reviewed-on: https://gerrit.libreoffice.org/47036 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2017-12-22lokdialog: Allow switching language of some of the ResMgr's.Jan Holesovsky
This way, it is possible to have all the strings translated in dialogs even when different users use different languages. [It was already possible to have different languages previously, but not everything in the dialog has switched - like the buttons at the bottom of the dialogs etc.] Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9 Reviewed-on: https://gerrit.libreoffice.org/46417 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46979 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-22tdf#42949 Fix some Include What You Use warningsMiklos Vajna
Change-Id: I30121764303579a7cb4ded0f0f48cc1f8fff6c33 Reviewed-on: https://gerrit.libreoffice.org/46946 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-21chart2: suspend/resume setting rects dirty for 3D shapesTomaž Vajngerl
Previously we bypassed setting rects as dirty for a scene just before we are about to create a 3D object. With this change we do it earlier and suspend for the whole time we are creating the scene - so we guarantee to o it for all 3D objects in that code path. Aferwards we resume with setting rects and mark the whole scene as dirty so we don't miss some update. Change-Id: Ie4dec644102140edf282a2f5f6eb7fc9b81dbe48 Reviewed-on: https://gerrit.libreoffice.org/46901 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-12-21TypedWhichId in svx part 2Noel Grandin
Change-Id: Id927679c9f07f1dd820f4fdca9a45eb7aede037c Reviewed-on: https://gerrit.libreoffice.org/46850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-20Bin mysterious pointless '// HACK' commentTor Lillqvist
Change-Id: I40509707bd98be6891f4158428163fa722c6e4d3
2017-12-20svx: CleanAndCheckEmpty() can be in the anonymous namespaceMiklos Vajna
Change-Id: I51c636559aee10791102e70b5507fdab3c9a4e11 Reviewed-on: https://gerrit.libreoffice.org/46819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-20long->sal_uInt16 in SvxShapeNoel Grandin
Change-Id: I28a54497b1a4c236d9d3bdb0f44d3e46f3e55de7 Reviewed-on: https://gerrit.libreoffice.org/46810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-20inline typedefs in svx/dataniviNoel Grandin
and fix a very dubious field declared as css::uno::Reference< css::container::XNameContainer >& in NamespaceItemDialog Change-Id: Icae09704ceb94cc24b4333d76b3fe67fc61f568b Reviewed-on: https://gerrit.libreoffice.org/46808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19wrap scoped enum around css::util::NumberFormatNoel Grandin
Change-Id: Icab5ded8bccdb95f79b3fa35ea164f47919c68fa Reviewed-on: https://gerrit.libreoffice.org/46339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-19Get rid of a dynamic_castTor Lillqvist
Add a virtual member function instead. This improves performance a bit. The time to load a specific pathological customer document dropped from 1min 53s to 1min 47s on my machine. Not hugely, but clearly. Change-Id: I1e59d601e9d0e14b6a756c6e0ad29ce2a1fce66d Reviewed-on: https://gerrit.libreoffice.org/46791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-12-19Silence -Wunknown-attributes with Clang <= 3.6Stephan Bergmann
Change-Id: I2d1ec919da5b26b231598e01a52a1508c72ab815 Reviewed-on: https://gerrit.libreoffice.org/46765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19remove a CONTAINER_APPEND useCaolán McNamara
Change-Id: I266a1741581a06a995c8cb012dcb18a32a38026d Reviewed-on: https://gerrit.libreoffice.org/46699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-18coverity#1426163 Improper use of negative valueCaolán McNamara
started life as sal_uIntPtr and the various checks are typically nPos < thing.size() just checking one bound, so sal_uInt32 looks safer after all Change-Id: Ibac839fc45b10d96ce4d4c8002fd26b20f70ae1c Reviewed-on: https://gerrit.libreoffice.org/46697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-18sal_uLong->sal_uInt32Caolán McNamara
the position here is cast to sal_uInt32 so begin as sal_uInt32 initially Change-Id: I221d97961292988e90a23091ffc9324d42fc366e Reviewed-on: https://gerrit.libreoffice.org/46698 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-18convert SVX_GRAPHICFILTER constants to scoped enumNoel Grandin
Change-Id: I220a2cfe9ea9ef2aa85e4ad8278be70c338891a5 Reviewed-on: https://gerrit.libreoffice.org/46705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18chart2: When creating objects prevent setting object rects dirtyTomaž Vajngerl
3D objects using a E3dScene are traversing all object in the tree when setting rects dirty. When we are creating objects, setting properties and adding them to the tree we trigger setting rects dirty which slows down considerably - more are added objects, bigger the slowdown gets. So the solution here is to temporary disable setting object rects dirty during creation of objects. Change-Id: Id068cda9cb798d49b75bf4228cf6460f7e98c033 Reviewed-on: https://gerrit.libreoffice.org/46446 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-12-18convert ColorPickerMode to scoped enumNoel Grandin
and drop unused Add constant Change-Id: I4e4f0d35e4d081883b78e0205ffd7086c9cadf04 Reviewed-on: https://gerrit.libreoffice.org/46587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18sal_uIntPtr->size_t in ObjOrderChangedNoel Grandin
to match the other position parameters used in SdrObject Change-Id: I100f4fb99f902bb6261b5470dd6b5553aefd764d Reviewed-on: https://gerrit.libreoffice.org/46586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-17Fix typosAndrea Gelmini
Change-Id: I4630ba4a93a32c47753422b29535c36b53ff3d5e Reviewed-on: https://gerrit.libreoffice.org/46635 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-16convert EETextFormat to scoped enumNoel Grandin
and drop unused BIN constant Change-Id: I4ecda96f39147f7e9bceb11ecdb4f0ffe42d2053 Reviewed-on: https://gerrit.libreoffice.org/46589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15tdf#51188: notify that geometry has changed when dragging the connector.Mark Hung
Change-Id: I7b7cb7719c9c735eeb4f964b1ae6ce6819186aed Reviewed-on: https://gerrit.libreoffice.org/46319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-15sal_uIntPtr->sal_Int32 in SvxSuperContourDlgNoel Grandin
Change-Id: I765cd20b16cbb832e4e0fe2beca4c6b89fec7e05 Reviewed-on: https://gerrit.libreoffice.org/46481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15sal_uIntPtr->sal_uInt32 in GalleryTransferableNoel Grandin
to match the underlying field Change-Id: I96bee1b19fb33e00bb09617a458f741654beb7f3 Reviewed-on: https://gerrit.libreoffice.org/46479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15sal_uIntPtr->sal_uLong in SvxRedlinTable and SvxCheckListBoxNoel Grandin
which is not a vast improvement, but at least they are now consistent with the other InsertEntry methods in SvTreeListBox Change-Id: I3789f5fba4cdfee07f5c2f78e42f0071eab47c28 Reviewed-on: https://gerrit.libreoffice.org/46478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15tdf113594: marking gluepoints immediately.Mark Hung
pPV was for the parameter of MarkGluePoint that was removed in ec38966951f2, and was kept somehow and is converted to bool here. Just replace the default boolean value to false ( that means marking instead of unmarking. ) Change-Id: I4c4b9dd368537b7b90cc4effae482a7b8a41eec9 Reviewed-on: https://gerrit.libreoffice.org/46472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-14No need to keep these whitelisted functions decorated with SAL_CALLStephan Bergmann
The only effect SAL_CALL effectively has on LO-internal code is to change non- static member functions from __thiscall to __cdecl in MSVC (where all other functions are __cdecl by default, anyway). (For 3rd-party code, it could be argued that SAL_CALL is useful on function declarations in the URE stable interface other than non-static member functions, too, in case 3rd-party code uses a compiler switch to change the default calling convention to something other than __cdecl. But loplugin:salcall exempts the URE stable interface, anyway.) One could argue that SAL_CALL, even if today it effectively only affects non- static member functions in MSVC, could be extended in the future to affect more functions on more platforms. However, the current code would already not support that. For example, 3af500580b1c82eabd60335c9ebc458a3f68850c "loplugin:salcall fix functions" changed FrameControl_createInstance in UnoControls/source/base/registercontrols.cxx to no longer be SAL_CALL, even though its address (in ctl_component_getFacrory, in the same file) is passed to cppuhelper::createSingleFactory as an argument of type cppu::ComponentInstantiation, which is a pointer to SAL_CALL function. Change-Id: I3acbf7314a3d7868ed70e35bb5c47bc11a0b7ff6 Reviewed-on: https://gerrit.libreoffice.org/46436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-14sal_uIntPtr->sal_Int32 in GalleryThemeNoel Grandin
Change-Id: I3489d2152b104d173676e683c416603dbddbd1bc Reviewed-on: https://gerrit.libreoffice.org/46396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-14sal_uIntPtr->sal_Int32 in SdrUndoGroupNoel Grandin
Change-Id: I286f3cb1362d033d797fdbb4cab35c8e6a30eab3 Reviewed-on: https://gerrit.libreoffice.org/46392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-14sal_uIntPtr->sal_uInt32 in GalleryNoel Grandin
to match GetId() on class GalleryThemeEntry Change-Id: I81944c7e89fa8c9ca65987901f4d598c042d836c Reviewed-on: https://gerrit.libreoffice.org/46391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13tools: remove unused #include from solar.hMichael Stahl
Change-Id: I214e13add371380701ae39403d90a574a63e495d
2017-12-13sal_uIntPtr->void* in GalleryHintNoel Grandin
Change-Id: I50528411bb76d5a204a5e52c4d77a7ecaf7f5ddf Reviewed-on: https://gerrit.libreoffice.org/46390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13convert tolerance params to sal_uInt8Noel Grandin
since their range is 0-255 Also drop pTols from ImplColReplaceParam, since it is always nullptr. Change-Id: I9e9ab7f7596e18cab1d67dd69922e5ac9867f45b Reviewed-on: https://gerrit.libreoffice.org/46274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13sal_uIntPtr->sal_Int32 in GalleryProgressNoel Grandin
to match the underlying type on mxProgressBar->setValue Change-Id: Ib04569235830f16b6507180e0f27816f8cfc50ff Reviewed-on: https://gerrit.libreoffice.org/46347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13use std::unique_ptr in SdrModelNoel Grandin
Change-Id: I1475a12b600fdb693bad71d27dc628992b92588a Reviewed-on: https://gerrit.libreoffice.org/46346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13sal_uIntPtr->sal_uInt32 in SdrModelNoel Grandin
to match the underlying field Change-Id: I4145df0fc308c09eca29f779a0ff241e4301db0b Reviewed-on: https://gerrit.libreoffice.org/46345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13dead flags param in CreateAutoContourNoel Grandin
was being used recursively Change-Id: I2ab920ee62c663f6cdc93ae2ef7eafd142fa0c94 Reviewed-on: https://gerrit.libreoffice.org/46344 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13sal_uIntPtr->sal_Int32 in SdrMarkViewNoel Grandin
Change-Id: Iec5c9e45ec753de98142615fdde16f61c393a6e2 Reviewed-on: https://gerrit.libreoffice.org/46311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-30 12:02:51 +0000