summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2015-06-10coverity#1302618 deref of NULLCaolán McNamara
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-10Remove unnecessary Bool2AnyStephan Bergmann
(It feels better to use explicitly bool-typed css::uno::makeAny<bool>(x) rather than implicitly typed css::uno::makeAny(x) or css::uno::Any(x), in case x is not already of type bool.) Change-Id: I282b3764bb207aeae9f13cc981e68e8ef2b8ab93
2015-06-10tdf#91727 - Unwind non-dispatch of idle handlers.Michael Meeks
This clobbers the functionality from commit: 06d731428ef6cf93c7333e8228bfb6088853b52f make idle timers actually activate only when idle Since now all rendering and re-sizing is done in idle handlers it does effectively the opposite of what was intended. A better solution would allow special-casing the processing of just rendering, re-sizing and window management to spin for eg. progress bar rendering. Also add helpful debugging labels to the idle & timeouts. Also cleanup the Idle vs. Scheduler handling. Also ensure that starting an Idle triggers a mainloop wakeup. Also add a unit test. Change-Id: Ifb0756714378fdb790be599b93c7a3ac1f9209e6
2015-06-10tdf#88055: Don't export transparent background colour as whiteKatarina Behrens
The fix is twofold: 1. retrieve transparency from colour in SvxBackgroundColorItem (add QueryValue, PutValue methods, use additional memberID to retrieve alpha channel as a bool property) 2. add CharBackTransparent bool property to Draw [text] shapes, xmloff needs it to be able to output 'transparent' string instead of '#XXYYZZ' colour code in ODF format Change-Id: Id830bd18fd6da5d9a46e2a94aa254d5d2a6b7ebb Reviewed-on: https://gerrit.libreoffice.org/16182 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-10tdf#88290 Adapt the numbering popup to more than 8 itemsMaxim Monastirsky
The items count of NumberingTypeMgr is limited by 8, but some languages have more items, so remove that limitation. Also fix the behavior of the 10th item. The old sidebar popup had a "None" item, whose id was 10 (defined by DEFAULT_NONE from include/svx/nbdtmg.hxx), and that causes now the 10th item to behave as on/off toggle. Since we don't have a "None" item anymore, get rid of that behavior completely. Change-Id: I5546ca637f9951cc093a7bbf8fda11dc35341d4e
2015-06-10tdf#87651 Add outline buttons to impress sidebarMaxim Monastirsky
Change-Id: Id3cf58660bfcaf7424d027773894ce6888df788a
2015-06-10tdf#91944 Fix inc/dec indent buttons in impressMaxim Monastirsky
Regression from ed6b7d972bf1aee323947f22c6b5de430db4a9a5. These buttons are implemented inside the sidebar, so just changing command names in the ui file won't work. Also, following the decision to use indent buttons across all modules, there is no need for 2 separate toolboxes anymore. Change-Id: Id9af0cd10fd0517be86b9793c187cd6508029732 Reviewed-on: https://gerrit.libreoffice.org/16199 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-06-09More CppunitTest_sw_uiwriter fixesMiklos Vajna
1) Guard against nDPI == 0 in ImplLogicToPixel(), it's the caller's responsibility to ensure that the DPI value is in the expected range. 2) pOut in sdr::overlay::impCheckPossibleOverlayType() is seen as 0. Change-Id: Iab5ff10aa7953993161dcad2d49d99d80c588e01
2015-06-09loplugin:unnecessaryvirtualsNoel Grandin
Improve the plugin a little. Create a python script to process the output. Run it again. Change-Id: I05c21d8a21c8f4243af739c412fda0a521f9b5f0
2015-06-08add (and call before dtor) Commit to SvtSearchOptionsCaolán McNamara
i.e. follow up to commit 465359c35fcd8c30a2bedd3d0beb07c0c1c36cba Author: Michael Stahl <mstahl@redhat.com> Date: Wed Mar 11 16:39:24 2015 +0100 do not call virtual Commit() from dtors of utl::ConfigItem subclasses ~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not invoking its subclasses' ImplCommit() but its own. to avoid assert in SvtSearchOptions dtor Change-Id: I0eaf93450e1daddb81a9463f2c1df48a334dfb22
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I94b2fbbb00e9772b668128f31cf08115bdfb16b5
2015-06-08Setting Maximum Value for Transparency spin button in area sidebar tabRishabh Kumar
Change-Id: Idb1c5051de5ddb0501b8d1440f8abe62074296bc Reviewed-on: https://gerrit.libreoffice.org/16144 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-06-07Resolves: tdf#89905 don't copy palettes from shared to userCaolán McNamara
make this a multi-path element with a shared read-only location and a user read/write location and don't copy the presets, instead just keep them in the shared location Now an admin can copy extra palettes into the shared location and they magically appear in the user deployments Change-Id: I7585789c0c59941094f6128368df94b834d3c2a2
2015-06-07Related: tdf#89905 these PalettePath uses appear to really be UserConfigPathCaolán McNamara
which is the same path at the moment Change-Id: Ifdefa478003a2b5cc5c065b1942194dda1275f5e
2015-06-06Typo: Gourand → GouraudValter Mura
Change-Id: I6c5d4f97bce8f5b29d979e2508e691948e9399fb
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-06Typo: emty->emptyJulien Nabet
Change-Id: I495ae28194da449ab1b31b2b5ec0d9e08fbcc291
2015-06-05Fix: could not convert [...] ‘const char*’ to ‘const rtl::OUString’Tor Lillqvist
Change-Id: Ib94c9f5eed0da67e846705f5c2c233c10583c791
2015-06-05svx: prefix remaining members of SdrDragViewMiklos Vajna
Change-Id: Iac5d80ef4e433c95277237692bda02fa75a24c61
2015-06-04Removed getNormal() from polygontools, it just calls B3DPolygon::getNormal()Zsolt Bölöny
Change-Id: I5a59ff8e0db1aee52d0b683c9c64e4b18b64e66b Reviewed-on: https://gerrit.libreoffice.org/16077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-04coverity#1304135 Missing break in switchCaolán McNamara
from commit 0e2ef262bea4cbc7cb04cfcd1d47f2a9d6092398 Date: Thu May 21 13:58:52 2015 +0200 tdf#88276: Add background colour toolbar and sidebar buttons but they do nothing yet, follow-up commit(s) add real functionality to them I take it that bNeedTextSpacing = true where it used to be mpToolBoxSpacing->Enable() so fall-through that happens anyway also sets bNeedTextSpacing so presumably everything is ok here Change-Id: I8f1d4137a74fcc2c7ba6959e5b5c4b1f7464643c
2015-06-04tdf#91840: Default to transparent text backgroundKatarina Behrens
(+ label the button) Change-Id: Icc6a0c5e3e715bcfe1392496bef2514fd1bdb62b
2015-06-04Use switch-case instead of overly long 'if (a || b || ...)'Katarina Behrens
they were growing a bit out of control Change-Id: I80441179b4d4aacc57c469fc8f3a3937866ceae8
2015-06-04uno::Sequence provides now begin and endNoel Grandin
use begin() and end() when calling std::copy on an uno::Sequence Inspired by commit b34b648fc3262c5d9aa295f621e8fe9c97d4c6b2 "uno::Sequence provides now begin and end" Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b Reviewed-on: https://gerrit.libreoffice.org/16057 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04convert B2DLineJoin to scoped enumNoel Grandin
Change-Id: I4fb8f2c9e2080e3aa542d2ccf838e6784baa8429
2015-06-04convert B2VectorContinuity to scoped enumNoel Grandin
Change-Id: Ifa401dd0d2d1bef8c0ae2987d2aee86100b59816
2015-06-04convert B2VectorOrientation to scoped enumNoel Grandin
Change-Id: Id7e444bc896ae5d52e5a0bd1b471679c4945afa4
2015-06-04convert MediaState to scoped enumNoel Grandin
Change-Id: Idf14f7d344be6c690cdd721cd5f7eb7c328b590c
2015-06-03coverity#1302605 Resource leak in objectCaolán McNamara
Change-Id: I574714c2d587ac22fcc812ffe8217f151ac40cb6
2015-06-03ruler: convert pCtrlItems to use vector of unique_ptrTomaž Vajngerl
Change-Id: Icc6cf55c26d605fd068edf575613cde745385dd2
2015-06-03-fsanitize=float-divide-by-zeroStephan Bergmann
...happens at least during CppunitTest_sd_tiledrendering that aCurrTextSize.Height() is zero: SdrTextObj::ImpAutoFitText(SdrOutliner&, Size const&, bool) svx/source/svdraw/svdotext.cxx:1312:49 SdrTextObj::ImpAutoFitText(SdrOutliner&) const svx/source/svdraw/svdotext.cxx:1290:5 SdrTextObj::BegTextEdit(SdrOutliner&) svx/source/svdraw/svdotxed.cxx:103:9 SdrObjEditView::SdrBeginTextEdit(SdrObject*, SdrPageView*, vcl::Window*, bool, SdrOutliner*, OutlinerView*, bool, bool, bool) svx/source/svdraw/svdedxv.cxx:635:12 sd::View::SdrBeginTextEdit(SdrObject*, SdrPageView*, vcl::Window*, bool, SdrOutliner*, OutlinerView*, bool, bool, bool) sd/source/ui/view/sdview.cxx:704:20 sd::Outliner::EnterEditMode(bool) sd/source/ui/view/Outliner.cxx:1299:9 sd::Outliner::PrepareSearchAndReplace() sd/source/ui/view/Outliner.cxx:1181:9 sd::Outliner::ProvideNextTextObject() sd/source/ui/view/Outliner.cxx:973:29 sd::Outliner::SearchAndReplaceOnce() sd/source/ui/view/Outliner.cxx:674:17 sd::Outliner::StartSearchAndReplace(SvxSearchItem const*) sd/source/ui/view/Outliner.cxx:496:28 sd::FuSearch::SearchAndReplace(SvxSearchItem const*) sd/source/ui/func/fusearch.cxx:132:33 sd::DrawDocShell::Execute(SfxRequest&) sd/source/ui/docshell/docshel3.cxx:222:21 SfxStubDrawDocShellExecute(SfxShell*, SfxRequest&) workdir/SdiTarget/sd/sdi/sdslots.hxx:17034:1 SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) include/sfx2/shell.hxx:210:35 SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) sfx2/source/control/dispatch.cxx:257:13 SfxDispatcher::_Execute(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) sfx2/source/control/dispatch.cxx:847:9 SfxDispatcher::Execute(unsigned short, SfxCallMode, SfxItemSet*, SfxItemSet*, unsigned short) sfx2/source/control/dispatch.cxx:916:9 SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) sfx2/source/control/unoctitm.cxx:823:37 SfxOfficeDispatch::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) sfx2/source/control/unoctitm.cxx:359:9 non-virtual thunk to SfxOfficeDispatch::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) sfx2/source/control/unoctitm.cxx:343:34 comphelper::dispatchCommand(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) comphelper/source/misc/dispatchcommand.cxx:57:5 lcl_search(rtl::OUString const&) sd/qa/unit/tiledrendering/tiledrendering.cxx:338:5 SdTiledRenderingTest::testSearch() sd/qa/unit/tiledrendering/tiledrendering.cxx:361:5 ... Change-Id: I38ab71c5f4024b2d7270a4f6c2aeb4ef502d08f5
2015-06-02Fix indent button icons in impress/draw sidebarYousuf Philips
Change-Id: Ib21c2489e1ff420e651e50a2731dfd3f16c9cef8 Reviewed-on: https://gerrit.libreoffice.org/16028 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann
Change-Id: I35229af6f25db931bd98bdf53add2f2ed65774c0
2015-06-01tdf#88276: Add background colour toolbar and sidebar buttonsKatarina Behrens
but they do nothing yet, follow-up commit(s) add real functionality to them Change-Id: Ieac5d0326b284069b8da1b39f94bdb5a8c84b6dd Reviewed-on: https://gerrit.libreoffice.org/15841 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-01tdf#88276: Add slot and handlers for toolbar|sidebar buttonsKatarina Behrens
those changes make getting/setting of text background colour possible from toolbar and sidebar buttons, but likely more handlers needs to be added to various other places in the code Change-Id: I698ca2304399befdd63317eb8872aa3129f27637 Reviewed-on: https://gerrit.libreoffice.org/15909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-01coverity#1302609 Division or modulo by zeroCaolán McNamara
Change-Id: Ia578a948b776c15372d3940b350f20048bb6124c
2015-06-01svx: nObjAnz -> nObjCountMiklos Vajna
Change-Id: I1ae00035c5ae9ac620f01982d6e4fff593f7c054
2015-05-29dispose SfxControllerItem objects correctlyLászló Németh
Change-Id: Id5f80e06e5609b4e85f3d6db7bc37aabe6ef0dac
2015-05-29tdf#91702 - fix stack-based MessBox allocation.Michael Meeks
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-29loplugin:redundantcast: const_cast to same typeStephan Bergmann
Change-Id: I226413abb1e87fcb9de21a496b359dd7ef33761d
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: Icb31e51575f7fffd36be73bbd87a3c5e56c3aa26
2015-05-28tdf#91653 Give this command a saner nameAdolfo Jayme Barrientos
Change-Id: I0cd1d51d1e16019c87e0c615c046a553eb5dc138
2015-05-28GetFocusFlags::Cursor->GetFocusFlags::CURSORNoel Grandin
to avoid name-clash with X11 headers Change-Id: I727c523f6d9bd7d4db28fe7427e053903626be00
2015-05-28convert GETFOCUS constants to scoped enumNoel Grandin
Change-Id: I7c324bb6358be28c119592850eb7607479279f09
2015-05-28Rewrite all calls like Dialog(params).Execute()Philippe Jung
Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-28Resolves tdf#67712 form controls and draw objectsHenry Castro
anchored to cell but changes position after reopening Also included tdf#68797 "FILEOPEN lost position of lines anchored to cell". It was marked as duplicate but the step to reproduce are different. Conflicts: sc/qa/unit/subsequent_filters-test.cxx Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: Ia1c4010f118749256077a0ecad6ca16b867d22f7 Reviewed-on: https://gerrit.libreoffice.org/15523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-05-27cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I27c24d3284a8e0678fc5c041426b4a7e71cbd363
2015-05-27Fix accidental mis-uses of VclPtr address-of operatorStephan Bergmann
Change-Id: I3a82423378d3198a25f90ddfbf42af55d85c96fb
2015-05-27convert WINDOW_DRAW flags to scoped enumNoel Grandin
Change-Id: I9400a286fab18d683b4c109007961685f01b6da3
generated by cgit (git 2.34.1) at 2024-08-14 11:34:51 +0000