summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-09-15svx UNO API for shapes: allow setting a max factor for autofit text scaleMiklos Vajna
This allows getting the scale factor from multiple shapes (that have text), seeing what factors they use and then setting the factor to the minimum of the values. Towards allowing both "autofit" and "same font size for these shapes" at the same time for SmartArt purposes. (cherry picked from commit 81345de4858d6e72ecb8fc6621396570f4a4ee93) Conflicts: include/svx/unoshprp.hxx Change-Id: I31a5e097c62e6e65b32956a4a32137bc3339c64c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102710 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-09-15svx UNO API for shapes: expose what scaling factor is used for autofit scalingMiklos Vajna
TextFitToSizeScale is 0 when the shape has no text or autofit is not enabled, 100 when there is autofit (but no scale-down), a value between the two otherwise. Towards allowing both "autofit" and "same font size for these shapes" at the same time for SmartArt purposes. (cherry picked from commit cd268f0047443ddbb22361cdc15093e881f83588) Conflicts: include/svx/unoshprp.hxx Change-Id: Iff88fcc4c2e67b543687b1d87d614622cbf2e38a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102709 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-09-08pdfium: only init pdfium library one and destroy on LO exitTomaž Vajngerl
With more and more usage of PDFium, it is hard to keep track of the life-time of the PDFium library, so it can happen that a FPDF_DestroyLibrary happens when we still have another instance where PDFium is still use. The result of this is a crash. To prevent this, just initialize the library once and delete, when on LO exit. This can be improved in the future to only keep the library active when in actual use. [ Leaving out the vector graphic search bits, the motivation is to just have this in libreoffice-7-0, so that recent pdf sig verify improvements can be backported. ] (cherry picked from commit 067a8a954c8e1d8d6465a4ab5fb61e93f16c26c2) Conflicts: vcl/source/graphic/VectorGraphicSearch.cxx Change-Id: I5c7e5de7f8b97d10efb394c67c7a61b976c8d57c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102226 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01tdf#134923 missing mnemonic widget target for labelsCaolán McNamara
presumably since... commit beeef93480fae65840646e4e36aa888efe92579a Date: Tue Mar 8 19:54:57 2016 +0530 tdf#98417, tdf#98539: DIALOG: Improvements to the Find & Replace dialog. Change-Id: Id59d573e1005e10be34994c8cc66c352b2cf500c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101854 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-01Resolves: tdf#136189 don't try and sort until treeview is filledCaolán McNamara
Change-Id: Ic5ac71d88bab7627e14220912f4b9c935f2f1f26 and... Related: tdf#136189 don't assert on unsetting non-existing previous sort column Change-Id: If2330cc83ace9ec0133b99eec8c2f0be3919013e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101710 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-27tdf#132940 Crash in mergedlo!vcl::Region::operator=Noel Grandin
We had a SdrPageWindow accessing a SdPaintWindow that had already been freed. Turns that SdrPageWindow can be "patched" more than once given enough stuff going on in writer, so make the call sites restore the previous state as the stack unwinds. Change-Id: Ia1ef5c9b2f818b7873e8e739c9cdf257554e403a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 445cf499666f21c2d480ce1df9ce6004b9450b64) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101450
2020-08-24tdf#135550 FmXListBoxCell does need to implement XListBox after allCaolán McNamara
regression since... commit 0677d46bcc56c1f6c27b9331662990b38fd452d6 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed May 20 15:22:56 2020 +0100 FmXListBoxCell doesn't need to implement css::awt::XListBox It seems just addItemListener/removeItemListener are needed, stub the rest to make sense just for single-selection mode and avoid the return of the apparently unused multi-selection complexity Change-Id: I46a32bdd23d44273da37cc21cfa45de907674f31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100748 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-24tdf#135550 make XListBox Item status changed event work againCaolán McNamara
Change-Id: I9a5fe6a097c5d06e3ac3ab6c4c77cbe082d1a17d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100747 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-20tdf#135550 make XComboBox Item status changed event work againCaolán McNamara
Change-Id: I323a114d3b71a74267ee7a89c5fb29821611e57e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100704 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-12tdf#135442 min supported version of gtk3 is 3.18 not 3.20Caolán McNamara
Change-Id: Iaa2eefbe08fad3a7dd6eff98bf5fb513053a263d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100533 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-08-10tdf#135438 Paragraph styles preview in sidebar are clippedCaolán McNamara
since... commit fe9a13dc0e6d1384416c2a2343223b33925fc925 Author: Caolán McNamara <caolanm@redhat.com> Date: Sun Apr 26 15:43:25 2020 +0100 weld SfxTemplatePanelControl getRenderSize used to be called after recalculate and before render to change maSizePixel Change-Id: Ifc1b6b0b3399c7de61d5f4d46f8346d13e72a4d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100069 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-08-03Resolves: tdf#134660 listen for 'ShowFontBoxWYSIWYG' config changesCaolán McNamara
instead of checking for changes to them when the fontbox get focus, its now too late at that point to update ComboBox WYSIWYG mode Change-Id: Ieea6a4c00be2eb46909d46af29ddd615fff002d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99602 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-03fix build with (system-)cppunit 1.14.0Rene Engelhard
by #include <unotest/bootstrapfixturebase.hxx> so that CPPUNIT_TEST_FIXTURE is defined Change-Id: Iacbfb2f513df6e7eb7ca04f7900cd4e6b3fd69c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99918 Tested-by: René Engelhard <rene@debian.org> Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-03tdf#135121 don't paint the image over the rect that will contain the colorCaolán McNamara
so that for the transparent color case we remain showing the original background and not that part of the icon Change-Id: I20452c7eccf141fdbede9ed2476270315963022e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99549 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-30tdf#135093: fix wording error dialog on Add Submissions dialog by blank inputJulien Nabet
Don't replace the right string by application name It seems to come from: commit b5483af985ed8c49b0bb9ebcd096cc9530e35a38 Author: Thomas Arnhold <thomas@arnhold.org> Date: Fri Aug 15 21:28:56 2014 +0200 ErrorBoxes from datanavi to String Change-Id: Ifd5a49537d0574bc2fb6530e70d19c31a35da914 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99371 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 1800e22f81959c6cb56f8ed238ac68681dda1a21) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99390 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-28tdf#135121 ImageType::Size26 isn't always 26x26pxCaolán McNamara
so use ImageType just to detect the user has selected a new size, and use the size of the returned image for the icon pixel size Change-Id: If101c586bd2f0d83f668637b48ce3d25a0873358 Related: tdf#135121 update widebuttons on icon-size change too as well as the split-buttons. We don't draw into the icon for widebuttons, but we do need to draw the icon into the replacement wider image so we want to update for widebuttons too Change-Id: Ia37f7de7faa08e63a498ff474a46a98566930acd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99576 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-14tdf#134188 tdf#114223 Don't override vertical text button visibilityMaxim Monastirsky
i.e. restore the fix for tdf#33356, which was removed in commit eeb2d19e77d6dc47c68e8ba0920a02cf64a1247b ("Resolves: tdf#130159 hide writedirection unless CTL is enabled"). But do it in a way that doesn't introduce tdf#114223 (a regression of tdf#33356). We can assume that the visibility state of the button at the point of control initialization is the one set with toolbar customization, as any customization triggers clearing of the whole toolbar, and reconstructing from scratch. Change-Id: I2cdf18e144dd6eb99b8c1e1da968beacddbb3728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98317 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit d3a98b87824f2e2248a45b97d7eef5e8ad596dd3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98760 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-10tdf#60684: graphic type content must correspond with graphic type extensionJulien Nabet
Change-Id: I8075b1b44aa400268b4022decb2a56770c81d83b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98239 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 7272a2edf113f29edeb8987ce649f85b776d9d23) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98342 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-05tdf#134479 allow disable font preview to work on existing font comboboxesCaolán McNamara
not just newly created one. you can only restore back to a text-only view, not a text+(icon/whatever) view Change-Id: Ic3becd7a942ee6b1dbabb57eebf1e25d1b626fdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30tdf#134357 we can reduce the min toolbar sidebar widthCaolán McNamara
since, commit 754bea8c6a17889f9d4d23bf98847b6b67253220 Date: Wed Apr 29 15:06:42 2020 +0100 remove the padding around the dropdown button of GtkMenuToolButtons the GtkMenuToolButton aren't as wide anymore so we don't need a min of 5 GtkToolButtons widths for tdf#130197, now the max of either 4 GtkToolButtons or that of 1 GtkToolButtons + 2 GtkMenuToolButton is sufficient Change-Id: I7296805b4b3c0d86ce3d08cadc8c2659104af619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97502 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-30tdf#134360 some sidebar widgets getting stuck in a disabled stateCaolán McNamara
Change-Id: I655525679dd2471e9d0c1a5af246901594b188ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26tdf#134285 select the item before dragging itCaolán McNamara
so we don't get the previously selected item Change-Id: Ifd6e46d97f1de0de86403b9c237ee8d2cd3a6cd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97137 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-25nActiveTerm is -1 in an empty filter navigatorCaolán McNamara
Change-Id: Ia6eed6291375f136abbe8e50abae51e6f796911f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97052 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-25tdf#134291: make all hatch patterns translatableJulien Nabet
Regression from commit 30a6e9e991fd1b62ead2d393331a0364372c52fb tdf#130928 Area Fill update hatcch section Change-Id: I75377f86bb8eafc24d739073e0341168637f7d62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97093 (cherry picked from commit b5be3d050c9b3ff909be4937cea0bee5fe0b6048) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97064 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-19tdf#134084 use the desired image size, not the current image sizeCaolán McNamara
when updating the color bar Change-Id: I6bf76a38adc034a25c0c31833c14f2b6afe3ec6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96739 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17tdf#133807 re-present search dialog after a short timeoutCaolán McNamara
Change-Id: Icc6016b3a9e3f25fd4c9e065e9f2d9570ad040c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96500 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-16tdf#103474 handle edge cases in ARCANGLETORegina Henschel
The arc-polygon generation in tools does not consider edge cases with zero height or width. That leads to wrong rendering in some ooxml shapes, when the handle is dragged to its extrem position, e.g. in left/right braces/bracket and can. I have switched from tools to basegfx in case ARCANGLETO and added handling for edge cases. Switching to basegfx has the additional advantage, that Bezier curves are used and not polylines. You see the difference, if you convert the shape to curve. ARCANGLETO is not used from our shapes or from import from binary MS Office, but only from OOXML or user-defined custom shapes. tdf#122323 MS Office restricts the swing angle to [-360°,360] in rendering. Such restriction is not in OOXML and not in ODF. Nevertheless, I have added a clamp for ooxml-foo shapes for better interoperability. Change-Id: Ib3233ce14dab950cc521cb8cbac6809a1d3e34a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96068 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 6de8d3109dffa7d4d0cc06f319cca70134f0a8f3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96335 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-11svx: fix loplugin:elidestringvar warningMiklos Vajna
Change-Id: I5424388dfc37988b2f4e5f8f34dcb1a577d9bfb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95806 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96018
2020-06-11let the parent toolbar decide the focus of the buttonsCaolán McNamara
Change-Id: I481fbc1b65b806cdb9eb41d6648fe9476f1326fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96031 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-10tdf#103474 handle quarter angles before using atan2Regina Henschel
sin(basegfx::deg2rad(fEAngleDeg)) does not result in 0 for fEAngleDeg=180 because of rounding errors and therefore atan2 later in the code gives wrong angle. Because the corresponding circle angle is the same as the ellipse angle for 0°, 90°, 180° and 270°, these angles are now handled before using atan2. Change-Id: Iae2a4d188b837ff787f2af4d79f874ba21c9aa2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95772 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 91f06123298bb8870cd6fa4e19d3aea9909f8e5b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95819 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-10grab focus to style combobox when parent gets focusCaolán McNamara
Change-Id: Iaee1a8399e8e4f70a52ce99be113e9e7607a5ab7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95989 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-09tdf#126025: Non-const GetPropertyValueByName must use non-const Sequence []Stephan Bergmann
...which internally calls getArray to make sure it references a unique sequence. Regression introduced with 85f28ec44a2c169c91dac9346e9c71feda6a6cab "Clean up C- style casts from pointers to void". Change-Id: Id80b75f06322c65fc31040cc0b1892fe3a0aeaab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit dd74e75c2692ee50535e2a9c7cf344fafc0e724a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95872
2020-06-07Fix context moreoptions (svx/tablewindow)Julien Nabet
Change-Id: I730fa4295f8515280d3e179350da4c06649b0854 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-04Use "Radius" instead of "Rad" for new propertiesTomaž Vajngerl
Change-Id: Ifd232bccf1519e0ed68195cf4344893175a675e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95331 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 7313ed6a5b63e06ddd8ce90c3b5b2f168743a2c9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95322 Tested-by: Jenkins
2020-06-03lok: add "Remove" param to .uno:ChangeTabStopTomaž Vajngerl
Change-Id: Ic6b71c0bb6177eb10f5be4197d77c5db5f5884a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95330 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 54a241c41f05d882490741b49864bcdd363110d6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95314
2020-06-01tdf#133547 Fix breaking of PDF graphic objectsTomaž Vajngerl
ImpSdrPdfImport did not handle -1 as the page number correctly. When the page number is -1 it means it was never explicitly set and should be treated as page with index 0 most of the time. So instead of allowing -1 as the page index, return it as 0 already in Graphic (VectorGraphicData). Change-Id: I3813f3ceeb5e41cb06fc40d67297d2439d7f3407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95227 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 876d644ccfff9c1097abfd7353cfc2cc17714a0a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95237
2020-05-28Resolves: tdf#133411 drop CONTENT_FLOWS_TO from dialog to search resultsCaolán McNamara
in the document, looks like only the calc one actually works, and when it works on large quantities of results calc grinds to a complete halt This was introduced with: commit b41332475783c31136673fb44cf4c411bb0148f8 Date: Mon Dec 2 15:54:29 2013 +0000 Integrate branch of IAccessible2 and has been a problem on and off with calc's potentially ~infinite grid There is the on-by-default search results dialog in calc (which has a limit on how many it shows) which provides an alternative route to iterate through the results Change-Id: I2685e480d2d15220be0bddbc83baad3992e7d5d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0b94169d820482434dc98a37c3c1633ca46fd0dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95012
2020-05-28Related: tdf#133411 SetDocWin is using the previous search success stateCaolán McNamara
not the new state The order of calls probably didn't matter in the past where the use of the flag was deferred until the Accessibility data was queried which would happen in another event loop. This makes it more clear that it appears that only calc actually does anything productive here. I think this flow-to has created more trouble that its worth and I'll remove it but if we need to restore it, then this, I think, it the working state to restore to. Change-Id: Id6fbb483c081f6d5142100d70c1b29705dcb6452 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95005 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 13769dea65137fc3c537de6257d15cb87b51f8ae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95011
2020-05-27Remove some unused includesMiklos Vajna
Change-Id: Id5a31185faf2a3a13b6ea266e058a7df41d44423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94890 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-26reduce dynamic_cast usage in an O(N^2) algorithmLuboš Luňák
When scrolling down in tdf#130431 this is the major CPU cost. Move the dynamic_cast out of the loops as much as possible. Change-Id: I0ea9f457bb17fbdde880f09b059f07dec4b1790b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94858 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-26tdf#49247, tdf#101181: gtk needs "upper", otherwise the control is disabledMike Kaganski
Change-Id: I3a3204ab0ad2376ee88adca5935813e241e6a049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94831 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-25svx:unit tests for theme count, gallery theme entry functions in galleryAditya
Change-Id: I7ff7f6f5607348e8ff135614d7de1957741a11fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93305 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-24inline some use-once typedefsNoel Grandin
Change-Id: Idddba2f3fd05265b08dbc88edb6152d34a166052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-24tdf#101181: drop useless "GlowEffect" boolean propertyMike Kaganski
Just use GlowEffectRad to indicate effect presense: radius of 0 means effect is disabled. Change-Id: Ic06bba34f5a851f120d3d00cb7e20c429ead9ee1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94732 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-23svx: move LOKit specifics out of SetMarkHandles into own methodTomaž Vajngerl
The SdrMarkView::SetMarkHandles method is too big because it also hosts the LOKit sending of callbacks, so move that into it's own method. Would be a good idea to split even more and move into own class in a future commit. Change-Id: I7e6389bfa98f22c44863c6eddc840692a7f22605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94728 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-22move InterimItemWindow to vclCaolán McNamara
Change-Id: If0a4a14708810c44d087b51961f2ecb3fda4df23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22remove Size arg from Window::Draw and depend on GetSizePixelCaolán McNamara
90% of cases pass GetSizePixel as the Size arg already and this aligns Window::Draw with how Window::PaintToDevice works Change-Id: If5b024179a4b7a3b099177c2f6d4b1fb006b95ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22tdf#41995: sxx: ODF export: save SVG to ODF 1.2 as wellMichael Stahl
... and SVM into ODF 1.2 Extended (compatibility mode). Change-Id: I2056ddac40570fdf69178349ff546cd313709b25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94575 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-21split out labelitemwindowCaolán McNamara
Change-Id: If5121b58538708a47783aee099bc426408989cbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-23 17:59:30 +0000