summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2019-01-25sw: Ctrl + shape insertion was not setting up the layer.Jan Holesovsky
The consequence was that the shapes were inserted into the background layer. The problem was particularly visible with the LOK, but reproducible on the desktop too. Includes unit test. Change-Id: I16137331f944101e25679ec8c4a034bea658bc57 Reviewed-on: https://gerrit.libreoffice.org/66915 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-17Resolves: tdf#120885 Crash on choosing 'more styles'Caolán McNamara
switching to the sidebar destroys the control currently active, just post the event to happen on the next event loop Change-Id: I3e9b629821fa43d8f29e419e72f66ed46d72fdbb Reviewed-on: https://gerrit.libreoffice.org/65543 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 93f26a66a4f6a13beb053edbdba9f906370bf968)
2019-01-17tdf#119648 - even if we fail to import a fontwork, we shouldn't crash.Michael Meeks
Change-Id: Id2dcfb69ad8440ea63564334a5a26a5f9b9bde14 Reviewed-on: https://gerrit.libreoffice.org/62789 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit f10b7e820844d94b4dbec3dcaf24392275940914) Reviewed-on: https://gerrit.libreoffice.org/63061 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 640ae4bf97530882614796aed669be8c4fd91fe4)
2018-12-27Revert tdf#115639 fixesAron Budea
This reverts commit 62cf24fbd48064e3ba309109a92a2c408ae654b6. This reverts commit ea4a9ca0a6ccf747a34997dc1d50efb82f9106ee. This reverts commit 2a664263d043f0327a92d5d5f7507bd10143fd31. Change-Id: If57c9f2aed054335d214ce87f17ab3f62dbebe65 Reviewed-on: https://gerrit.libreoffice.org/65645 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-12-15lok: shape selection: perform the needed unit conversion in a clever wayMarco Cecchetti
Change-Id: I505bd41801b5fd1898a9eddc81b102f2f7ae20b5
2018-12-10lok: shape scaling reworkMarco Cecchetti
Now shape scaling is handled through the transform dialog instead of simulating a drag and drop event in core. For Impress the unit used for length is '100th mm' instead of twips, so we need to transform positions and size from twips to '100th mm'. Anyway since we don't know in SetGeoAttrToMarked if the new data is due to a mouse event or by entering a new value in the transormation dialog or in the side pane, for Impress we need to convert the new values sent by the dialogs from '100th mm' to twips which are converted back in SetGeoAttrToMarked. For performing a uniform scaling when the shape/image is rotated we need to inform the client about the rotation angle for the selected graphic object that has been achieved but appending an angle argument to the graphic selection callback. Now it is also possible to reverse shapes/images through negative scaling. Change-Id: I8a32f3e4b28f36e884a59c59b7e1351e85ef4489 Reviewed-on: https://gerrit.libreoffice.org/64696 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-12-10lok: Right rotation calculation in case of delta angleTamás Zolnai
Change-Id: Ia7d0a573c1902fba3fc1e69f425bbf2dc93a1c82
2018-12-10Avoid moving the shape by rotationTamás Zolnai
The difference between Impress and Writer is the used unit. We can assume that SID_ATTR_TRANSFORM_ROT_X and SID_ATTR_TRANSFORM_ROT_Y contains the values in twips. Change-Id: I44ba9532348200742b2c7c369b89eb2545295684
2018-12-10lok: get correct handlers for a single rotated shapeMarco Cecchetti
Change-Id: I74668ca8079d8d56b8c3f2c4513e2a2ec95872c6
2018-12-10add parameter TransformRotationDeltaAngle to .uno:TransformDialogHenry Castro
Change-Id: Ib22ba6956afedf1eea055e0ac3a78c53b4ee5861
2018-12-10svx: add parameters to .uno:TransformDialogHenry Castro
Change-Id: I6d9e110f48b0f4c6226503d01e10d099cfcb130c
2018-12-10use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/64860 Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-07fix compiler error: shadows a member of 'this'Marco Cecchetti
Fix an annoying bug reported by compiler (warnings as errors enabled) Moreover there are some minor change in formatting reported by clang-format commit-hook Change-Id: I148b0bc3384e9fab070bba4df5b15cbb44ece930 (cherry picked from commit e30214acc7f9d527876354200c8b9b792a323ecf)
2018-11-07lok: Notify about the current editing context.Jan Holesovsky
Change-Id: I47e67b680a6abdb66020b295f55ee6a73b7b5608
2018-11-06Revert "For iOS, do actually export UI builder factory functions"Tor Lillqvist
This doesn't work in a Release build. The functions in question don't get included in the binary. Will have to use a different approach, with actual references to the needed functions. Also revert "Use BUILDER_FACTORY_EXPORT instead of SAL_DLLPUBLIC_EXPORT" This reverts commit 6e9ca7c925671165057743cfdc73272afeffe7ab. This reverts commit 911742479eb5e8e406808f615697fea7caf82479. Change-Id: Iae26d0aac2ea14400725cc330a339c3a9499d85c Reviewed-on: https://gerrit.libreoffice.org/62941 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-11-05Use BUILDER_FACTORY_EXPORT instead of SAL_DLLPUBLIC_EXPORTTor Lillqvist
Relevant for iOS. Helps the Data > Sort dialog in this branch. (For some reason it was not needed in the master branch.) Change-Id: I593a825a2c7237ea3961abdf01776066f6ae5332 Reviewed-on: https://gerrit.libreoffice.org/62920 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-11-05More !HAVE_FEATURE_AVMEDIA falloutTor Lillqvist
Change-Id: I5b2c24e555f77199782d60d56086455f04787821 Reviewed-on: https://gerrit.libreoffice.org/62869 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-11-05Start of work in progress on making dialogs work in the iOS appTor Lillqvist
Build the swui library for non-DESKTOP platforms, too. Handle fallout for !HAVE_FEATURE_DBCONNECTIVITY and !HAVE_FEATURE_AVMEDIA (both of which features we for now don't want to bother with in the iOS app). Make VclAbstractDialogFactory::Create() do its thing also on non-DESKTOP. This commit just causes more code to be compiled for the non-DESKTOP case, dialogs in general surely don't actually work yet in the iOS app. For instance: vcl/source/window/builder.cxx:2060: probably need to implement sfxlo-CustomPropertiesControl or add a makesfxlo-CustomPropertiesControl function Change-Id: I579efba605f519dcbf407b675be88c7c6ee0f19b Reviewed-on: https://gerrit.libreoffice.org/62865 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-11-02tdf#119235 svx,sd: fix drag&drop from ColorBarMichael Stahl
This was using the SfxPoolItem serialisation of XATTR_FILL* items, where only XFillColorItem and XFillStyleItem were actually used; the binary serialisation was removed without being aware of this feature. Fix this by using uno::Any instead, rather than reviving the binary serialisation. Also change the clipboard format strings, just to be safe. (regression from 97b889b8b2b2554ce33fd6b3f0359fc18f39832d) Change-Id: I1828621a9aae606a1ca47835eef608062efe64a0 Reviewed-on: https://gerrit.libreoffice.org/62455 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 0a6813ad5d57d0df72562c797a8b0581bfd65a11) Reviewed-on: https://gerrit.libreoffice.org/62472 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit 24ccbc35e8857cc8de784154d0648800d39ab20b)
2018-10-30Add a HAVE_FEATURE_PDFIUM conditionalTor Lillqvist
Change-Id: I7f4a34bb132141d867b028d40b100da674acaa91 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2018-10-30Put most of this file in #if HAVE_FEATURE_PDFIUM like in masterTor Lillqvist
Change-Id: I43c6e841144b6e5f76d2c78e7b78ab41a29c20e5 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2018-08-20tdf#116350 Better text layout for big shapesSzymon Kłos
Added some horizontal padding - for bigger shapes and vertical adjustment for multi-line labels. Change-Id: I665b238b0d08a499cd846952d831fe449f72f575 Reviewed-on: https://gerrit.libreoffice.org/58975 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/59161 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-08-10tdf#118860 svx opengl: avoid SalBitmap creation without solar mutexMiklos Vajna
The bugdoc has 2 slides. When switching to the second slide, the graphic is loaded in the background, but OpenGLSalBitmap::Create() can't work correctly if the caller doesn't own the solar mutex. This already asserts in OpenGLContext::prepareForYield() in a less obvious way. Focus on the correctness, so just hold the solar mutex during the whole ImportGrpahic() call. If it turns out that the purpose of running this on a thread is to avoid synchronous network traffic, then the data could be first copied to a memory stream, and only then take the lock + import the graphic. (cherry picked from commit 919ccaba419531d689231b76a43ab29c6a9ec65a) Change-Id: I88203c12b4e7a5f2b689928c01e2ba953c5b13c5 Reviewed-on: https://gerrit.libreoffice.org/58126 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2038ab9d4cbb7282172a65352e4ed1a852404b29)
2018-08-10Resolves: tdf#118862 new instances cannot be editedCaolán McNamara
Change-Id: I9b10ff4f043949c7140852ac9ad9106ca611c98c Reviewed-on: https://gerrit.libreoffice.org/57963 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 239ce8ea56527c96bd1b30b68a3448872f382b47)
2018-08-10tdf#118022: fix crash when searching record in form by handling SQLExceptionJulien Nabet
See https://bugs.documentfoundation.org/attachment.cgi?id=142760 Found thanks on gdb with command catch throw com::sun::star::sdbc::SQLException First SQLException was dealt but not the second one Reviewed-on: https://gerrit.libreoffice.org/55836 (cherry picked from commit f94292e8c4d469bd3123e1649b0f2a94d4b357b3) Change-Id: I7d5d3ad612db132a3bda97cff14367912ae885f9 Reviewed-on: https://gerrit.libreoffice.org/55853 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 44f72ca3747deb1c8824626f216d295815b5ceff)
2018-08-10tdf#116350 Correctly display text on arcSzymon Kłos
Change-Id: Ice8c141db20d43ccc8d6e2b56004a4a28d2b257a Reviewed-on: https://gerrit.libreoffice.org/58729 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-02tdf#119015: don't call TableModel::optimize in CellCursor::merge()Mike Kaganski
Better do that explicitly in the SvxTableController::MergeRange, so that the UI-driven operation still optimizes the table, but import code gets the initial column count, and not throw trying to access the deleted column. Change-Id: Ib4b4d716935ec2036ccb839c36f1be5b0cb878d5 Reviewed-on: https://gerrit.libreoffice.org/58359 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/58371 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-07-10fix previous commitcp-6.0-6Andras Timar
Change-Id: I204f83aede085bbe4f5bd6937238b2117e51c86a (cherry picked from commit 4553bc1bfa72dce55566971e27b94f3a5bfcdc79)
2018-07-10don't show inaccessible crashreport linksAndras Timar
(cherry picked from commit 0d045c85fb8dbdb7fa2e116ef9983e0a60bd2b99) Change-Id: I3c4ed28cb1a02049fb009f576943f80b8ba8e627
2018-07-10Collabora Crashreport DialogAndras Timar
(cherry picked from commit c51dc04cc3cd48e7d5ab51a1f88e36bda8707c73) Change-Id: Id44e446684993984cf5778c82eb0a990bdd2f465
2018-07-10enable crashreport on WindowsAndras Timar
(cherry picked from commit ce263269dff121af85634ada7870f33632e02bdd) Change-Id: I55df3da63919f76afcd4905b1898287e26c8c4f1
2018-07-06tdf#118506: Disable orientation page in read onlyXisco Fauli
Change-Id: I30994b95e65ddd70df7872f5cc41c339bf906f19 Reviewed-on: https://gerrit.libreoffice.org/56875 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 0c3f7154f4d2919f7d28a5db9578fc308f2c0d02) Reviewed-on: https://gerrit.libreoffice.org/56999 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 3aaca9586a566a52210212bd2c8b54f2b6e358ab)
2018-07-06Resolves: tdf#115816 second 'Insert' menu is pasteCaolán McNamara
reuse existing translation to be backportable wrt no new translations Change-Id: I1fb94f66d696f836e8f6a10ba2d6933f69cfac95 Reviewed-on: https://gerrit.libreoffice.org/56245 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 74b897f9c578cb0b64124ef9563f2355680c8d84)
2018-06-27tdf#103913 keep ".emf" file extension and mime typeLászló Németh
in documents, don't change them to wmf and image/x-wmf silently, resulting for example, dropping or rejecting modified documents by firewall packet filtering. Reviewed-on: https://gerrit.libreoffice.org/56045 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> Conflicts: svx/source/xml/xmlgrhlp.cxx (cherry-pick from commit 4cb1e86e5217f09e1d98e51e46803a06fb72f5ce) Change-Id: I3b8634ae022c7c026b0ed4ebc345c1c3b3f96337 Reviewed-on: https://gerrit.libreoffice.org/56084 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c959815d55919967c9697dc8862ddec6844b7796)
2018-06-11Resolves: tdf#116876 don't reselect index on resize if it wouldn't changeCaolán McNamara
selecting the index sets it as active and updates the previews, so if its an inactive index and resize happens, leave it as inactive but selected Change-Id: If823f6b3e8f2ee4e77ba5e5d0202d72893ed614c Reviewed-on: https://gerrit.libreoffice.org/55346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 63e1546668ac464d1ba0b02ba5e76fb064e63100)
2018-06-11tdf#117537 block rentry to CheckAndMarkUnknownFontCaolán McNamara
Change-Id: I70e75a39d13e93e929c7aef5407b1100bb2a7c12 Reviewed-on: https://gerrit.libreoffice.org/55131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit c6c82096301180cfa7942dd9fb9d1cb66c7ecc04)
2018-06-01tdf#117172 - Image context menu Save fails to do anythingMarco Cecchetti
Change-Id: I5c0980d85ef5ed050bfafbc368576c5ad72a80a7 Reviewed-on: https://gerrit.libreoffice.org/54359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 796bee47e90efee7c076f6acdc2a95004ed081d0) Reviewed-on: https://gerrit.libreoffice.org/54931 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b582ec97fbcce88fa1a39bc7fe2a2ae084f30e35)
2018-06-01tdf#117821: fix copy-paste wrong control typeJulien Nabet
Since 5ad8376d1698026ccab0634605fdb17ea3c59f3a Resolves: tdf#111080 framework user of convert menu needs action names set 2017-08-08 Change-Id: I2ec8358005e335941bd1c2530f30ce696d3e808f Reviewed-on: https://gerrit.libreoffice.org/54865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 1e9e01dff0a8d65bb10d5a886cca7899b43979da) Reviewed-on: https://gerrit.libreoffice.org/54871 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 694e18cffd8cadc70e76c2b18b614b5ccceafefd)
2018-06-01tdf#117614 svx: make drawing.GraphicExportFilter work with sw imagesMiklos Vajna
A Writer image has an underlying SdrObject, but GetSdrObjectFromXShape() won't work for it, also we can't an sw SdrObject into an XShape because SvxDrawPage::CreateShape() has no idea how to handle sw's SdrInventor::Swg inventor. Fix the problem by just getting the Graphic of the Writer image and improve GraphicExportFilter to be able to work with just a Graphic as well. (cherry picked from commit aca5e1ba7f33c8913304b5f90ef478f316e64263) Conflicts: svx/CppunitTest_svx_unit.mk svx/source/unodraw/UnoGraphicExporter.cxx Change-Id: I3c9b3005366fcc87815597a27df3cb8a99a8876c Reviewed-on: https://gerrit.libreoffice.org/54688 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-06-01svx: set the font name of imported PDF textAshod Nakashian
Change-Id: I79dde3c8983a70311de2d2a46093fac2722fb372
2018-06-01svx: update PDFium patch and codeAshod Nakashian
Change-Id: I07c6a7c65d5631b70da64927a35d7a3b371eff25
2018-06-01svx: cleanup pdfium importerAshod Nakashian
Change-Id: Id925ba7734a2c73270e40f19d3fc50552441c34e
2018-06-01svx: transform PDF text rectangles while importingAshod Nakashian
Change-Id: I7675a183bfb691a8783950f33dc34826f91cb768
2018-06-01svx: set the Model explicitly before using SDR objectsAshod Nakashian
Change-Id: I176d1c1c7f759904ab36796a47e879e45ce4a5af
2018-06-01svx: support no fill and no stroke paths in PDF importAshod Nakashian
Change-Id: Ida5daa71d469805fd52e08e804fb9fa182d7d008
2018-06-01svx: support sub-paths in PDF importAshod Nakashian
Change-Id: Ibcfd30383db6846e791aea7609ab196c4f3f2da4
2018-06-01svx: import processed PDF textAshod Nakashian
Some PDFs don't include spaces in the text. Instead, they rely on the explicit positioning of each character to render visually separated words. Latex seems to be prone to this approach, though not exclusively. Luckily, PDFium does process text and inserts "generated" spaces where necessary, which is what we retrieve and use as the text string while importing. Change-Id: Ic21fe6c8416ecaba66f06b6260f1d6b040ff12af
2018-06-01svx: correctly possition form objects from PDFAshod Nakashian
Change-Id: I7d216ca61b8a10219628877db7dd593a4987ef60
2018-06-01svx: support importing forms from PDFsAshod Nakashian
Still missing the context matrix transformations. Change-Id: Id9457c6475463127d3bc444f36fa373a6ec8fcb6
2018-06-01sd: support breaking any PDF pageAshod Nakashian
Change-Id: Ifa5f58163bef209a988fc0f88e2b609b1973e0d4
generated by cgit (git 2.34.1) at 2024-07-01 16:04:07 +0000