summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-02-14drop unneeded includeCaolán McNamara
Change-Id: Iad7851542b9bb68eb0a5672c797a5b8ffb7deea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88727 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14use fwd decl of SpinFieldCaolán McNamara
Change-Id: Ifea23e791ec53448a8591583f283b87430ef38c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14split StringToMetric and TextToValue into fieldvalue.hxxCaolán McNamara
Change-Id: I5d1102f7a50a7a246df9f6de8b7a6df6557eb54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88682 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14split out MetricField value conversion functionsCaolán McNamara
Change-Id: I67a33bd2a5cb06dc66e471918b5c378044a2eff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14tdf#130373 substitute color only works if left set to transparent.Noel Grandin
regression from commit e27be9dfbcf8636a7440f828435b1860dfa38977 Date: Wed Jul 3 15:07:44 2019 +0200 move some Bitmap replace logic inside vcl Change-Id: I0d985314367e26134c940e54f485db373d4c3642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88675 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14use forward decls to reduce including unnecessary headersCaolán McNamara
Change-Id: Iaa25ac1ac99e0dcf09bce21f4bad8cb9b5568a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14weld SearchLabelToolboxControllerCaolán McNamara
and split out LabelItemWindow to reuse it Change-Id: Ie14f1bdc6d8684db088c018afd341e10bee9d977 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88623 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14don't need to include split.hxx or scrbar.hxxCaolán McNamara
Change-Id: I775e77a0f303d66ca571e1851205b8286c840bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14de-duplicate some codeCaolán McNamara
Change-Id: I5900ee56cf5c80f00743060d1d22dfd3d383f1eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88622 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14weld SearchFormattedControl Item WindowCaolán McNamara
Change-Id: Ifda9e514ae0329a756ec365a40ec1ccfcfea14ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88621 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14weld MatchCaseControl Item WindowCaolán McNamara
Change-Id: I33a8d96c449e653284d570ef534dcc453f27ad5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88619 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13Restore simple undo and redo buttons for the basctl moduleMaxim Monastirsky
Changed in commit c34edadf5bd3d1d9f3c9c056af28b8964d8f1ca0 ("rework SvxUndoRedoControl to be a PopupWindowController"), but the dropdowns do not work in that module. These buttons used to be managed by SvxSimpleUndoRedoController, but that's no longer the case. The reason is that ToolBarManager::CreateControllers checks first for controllers registered in Controller.xcu, and only if none found it checks for sfx2 controllers. So SvxSimpleUndoRedoController by using a sfx2-style registration, has no chance to be ever selected for .uno:Undo or .uno:Redo. This commit removes the unused controller, and restores the previous behavior with the other controller. Change-Id: Ia774195511e41ab11562856fe1cf2ec7f170710a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88606 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-13weld FindTextFieldControlCaolán McNamara
Change-Id: Ib5861855d37c72d2be2b11b77173a141db90444e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13nStyle is always set to WB_DROPDOWN | WB_VSCROLLCaolán McNamara
Change-Id: I8978d910cba881e8c0343111f600ba3f6aef9025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88603 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12tdf#130614: Revert "tdf#125520 Fix OLE objects drag&drop with 'Insert as Copy'"Xisco Faulí
This reverts commit e4cea049c80f4fd6d2a586e73fe9fa08ebd08371. Change-Id: Ic925cb5660df152208cdc63bfee62d82fe912717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88493 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-12cypress: mobile: Font size combobox is broken on core/master.Caolán McNamara
a) for vcl version, listen to modify and select, instead of just modify so we can get the artificial select via uiobject that the mobile makes use of. (and disregard the modify which we know will lead to select so we get just one event in that case) b) default to assuming something has been picked "directly" unless we know otherwise. ideally the result is that https://cgit.freedesktop.org/libreoffice/online/commit/?id=08d6c3fdf9bac4ad8318151ab1402690eb950f52 isn't needed Change-Id: Ibbf33eab88dabd55d0c329aa00c8adaf001a4f50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12lok: add "type" information when a graphic is selectedHenry Castro
Change-Id: I67a36d3aabbc197d9ac8f6ca4509dafd6f2620f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87991 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12Allow boolean valued statechange messages for...Dennis Francis
object align commands : ObjectAlignLeft [SID_OBJECT_ALIGN_LEFT] ObjectAlignRight [SID_OBJECT_ALIGN_RIGHT] AlignCenter [SID_OBJECT_ALIGN_CENTER] What is pending is to set correct align state items for Impress in DrawViewShell::GetMenuStateSel(). For doing that we need to store the object align state somewhere when we execute SID_OBJECT_ALIGN_* in DrawViewShell::FuTemporary(). For Writer the align state information was already available in frame-format-manager object. Change-Id: I86fcf59cfc66af98097611277201ecaa3b8c22cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88077 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88452 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12move some svx/ headers inside the moduleNoel Grandin
Change-Id: I8d9a50039a8139caebb2cfb83ca476d39432f255 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12clang-analyzer-deadcode.DeadStoresNoel Grandin
Change-Id: Ifa384933569b27d0d08eb479bb95b799163ae386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88450 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-11tdf#114694: Make default value in language settings the first elementYusuf Keten
For Languages, to make the default value ​​the first element in the list, I've added 3 parameters to SvxLanguageBox::SetLanguageList(). With this parameters, function adds default value according to its existence before other values. For sorting User Interface and Currency, I removed the make_sorted function. I added std::sort with lambda expressions for both of them. Change-Id: Iae37bfe09aaac4d8ecde1caad7a14e11df551eae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87926 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-11weld FillControl item windowCaolán McNamara
Change-Id: I5f943a9cf881494fe8a9fecea6a957a7085a5582 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88378 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11cypress: mobile: Font size combobox is broken on core/master.Caolán McNamara
so https://cgit.freedesktop.org/libreoffice/online/commit/?id=08d6c3fdf9bac4ad8318151ab1402690eb950f52 isn't needed Change-Id: I8836969ae064342835287a63065e591f083f2220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11on main window getting focus gtk is destroying the popup windows itselfCaolán McNamara
so copy the data we need before it can do that Change-Id: If35d7ba0f272475e82f969bd80c6ff44131a3d2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88376 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11surface attribute disappearedCaolán McNamara
Change-Id: I195fc92ff6fea962ceca06df5e5e562d729bcc5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88374 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10set a narrow width so it takes the width of its fellow panel membersCaolán McNamara
Change-Id: I846d1918fbd470439ea1efe591ff8eb392464bce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88377 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10weld SvxFmAbsRecWin item windowCaolán McNamara
Change-Id: I6a11d8ba226b28447e2ab04925090491d6953132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10weld SvxFmTbxCtlRecTotal label item windowCaolán McNamara
and SvxFmTbxCtlRecText label item window and SvxFmTbxCtlRecFromText label item window Change-Id: I5c5bbdacfe7e69abd44b9a548deadbf6c4d2a7d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10DROPDOWNONLY should have been DROPDOWNCaolán McNamara
Change-Id: Id69413752779ee076e2a81330990f1230264a8f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88346 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10tdf#90834: Turn in-line version control comments into good commentsPelin Kuran
Change-Id: I366badf234f00536cd208a516eff9667f99d2f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87719 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-09Fix undo and redo dropdowns in non-sfx2 modulesMaxim Monastirsky
after commit c34edadf5bd3d1d9f3c9c056af28b8964d8f1ca0 ("rework SvxUndoRedoControl to be a PopupWindowController") accidentally enabled them there, instead of the simple buttons those modules used to have. Just implement the necessary stuff, instead of hiding the dropdown again. Change-Id: Ic93114f7f3cec8e96f3389ceb0d52552cde02a83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88333 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-09Fix typoAndrea Gelmini
Change-Id: Ic203814f0bce207bb8b8b8590b825534609bdd8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88321 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-09Fix typoAndrea Gelmini
Change-Id: Ibea0f9c3e5b82fc475de71c2964d8c89e16866c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88319 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-09Fix typoAndrea Gelmini
Change-Id: I032a69e517e5a94b2191869552b77379d55f4b8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88320 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08pack some data structuresNoel Grandin
Change-Id: I7ef990b8aa7b26c413b54186c360ed3f858d4e26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07weld ImplGrafControl ItemWindowCaolán McNamara
Change-Id: I1c3551ffe510d49ea7ddce9d896f59857f4b2946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88213 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07weld ImplGrafModeControl ItemWindowCaolán McNamara
Change-Id: Ib71436cf9ecb312ea9f273bb974954556868e613 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88189 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07rename URLBox back to SvtURLBoxCaolán McNamara
Change-Id: Icd90eeb492002c45ddd8ff562a6da411abead122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07SvtURLBox is now unusedCaolán McNamara
Change-Id: Iab78b3803272ceb62c4df74241b64f23b1437b03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88184 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07weld URLBox ItemWindowCaolán McNamara
Change-Id: I7dad000404a188e2f5588b90d73ea9b1236bd301 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07use swap instead of copy and clearNoel Grandin
Change-Id: I51aa680e66aa0a5186edadf9d5a2d57798be4103 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07test: move component context from subclasses to BootstrapFixtureMiklos Vajna
To avoid duplication. Change-Id: I0ee7c26d5d55bd868ead04c77e7f4ef2582f90e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88138 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-07remove use of macro DeclPrimitive2DIDBlock in everywhereTomaž Vajngerl
Change-Id: I3fcba604ee3bc95274700ae7406f27e292cd09ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88154 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-07loplugin:unusedmethodsNoel Grandin
Change-Id: I7296b2fc2862d0ad1f68658b19b2a25cb7609df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-06weld ClassificationControl ToolboxWindowCaolán McNamara
Change-Id: Idda0b5187201aa77b5b6d682b740a8e55719742a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88129 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06Fix typoAndrea Gelmini
Change-Id: I8ece4e0ea5ba4756a6b0f9d87ccf1451290a7adc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88119 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-06weld SvxMetricFieldCaolán McNamara
split off SdPagesField as its not really a MetricSpinButton and can be a SpinButton with a custom output function. while I'm at it use ngettext to provide better plurals for the output. Change-Id: Idc9ce0513c9fce60c8713c7361fd40f0dbd01f64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06rename nFirstLineOfst -> nFirstLineOffsetNoel Grandin
Change-Id: Ic56453d5bffe5b0c0edd354bbaa2c3e78db52a13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-06merge FillTypeLB with SvxFillTypeBoxCaolán McNamara
Change-Id: Ia6229e8cc04c88e6740a12648c50cf5efca3bbd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06drop unnecessary includeCaolán McNamara
Change-Id: Ifb7e34d5648238a1cf0a893a6713671fa6881161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88066 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>