summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-11-12New loplugin:stringviewparamStephan Bergmann
...to "Find functions that take rtl::O[U]String parameters that can be generalized to take std::[u16]string_view instead." (Which in turn can avoid costly O[U]String constructions, see e.g. loplugin:stringview and subView.) Some of those functions' call sites, passing plain char string literals, needed to be adapted when converting them. Change-Id: I644ab546d7a0ce9e470ab9b3196e3e60d1e812bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105622 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-12Revert "remove Fraction::operator tools::Long()"Noel Grandin
This reverts commit 48b667a7e7d25f835f95df89162a7849d6972531. Reason for revert: some discussion required Change-Id: Ia0990d280837fb68b7ddc9f472ec78b1467b4311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105540 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-12Use translated standard styles for styles listboxSzymon Kłos
In online we can have users with multiple languages. Select style in sidebar depending on translated name and also universal/English. Change-Id: Ia33df29526e5fd8de5c7e0f7f6f74e0b0f559477 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103000 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105592 Tested-by: Jenkins
2020-11-12remove BigInt::operator tools::Long()Noel
which was introduced in commit adf0738d2dbfa742d0e9ef130954fb4638a8e90d Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Jan 3 14:25:15 2018 +0200 long->sal_Int32 in BigInt presumably to make the conversion easier. Instead just fix the call-sites to select a better conversion, BigInt only returns 32-bits of precision anyway. Change-Id: I2e4354bcfded01763fe3312a715ef37800297876 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-12remove Fraction::operator tools::Long()Noel
which was added in commit 331e2e5ed3bf4e0b2c1fab3b7bca836170317827 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Sep 14 08:49:52 2017 +0200 long->sal_Int32 in Fraction presumably to make the change impact less code. Instead, update the call sites to reflect the actual bitwidth of the data we will be receiving. Change-Id: If2a678b1cf534f39cb8cb249757462be53658309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11loplugin:stringviewNoel
Add new methods "subView" to O(U)String to return substring views of the underlying data. Add a clang plugin to warn when replacing existing calls to copy() would be better to use subView(). Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11convert more long -> tools::LongNoel
found by grepping and changed by hand. Change-Id: I3c720859dba430fde3abc76c6c5cb58269efaf4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105512 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11lok: Add posibility to change chart fill gradientSzymon Kłos
Change-Id: I942d478cd870036710390d2c03413b6fc0454038 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103619 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104808 Tested-by: Jenkins
2020-11-11pdfium: eliminate remaining direct calls to FPDFPageObj_GetType()Miklos Vajna
And also introduce an enum class for the return type. Change-Id: I6577c7678889ac5bb8efbf0d0cfeb575aac06e27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105567 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-11make tools::Long 64-bit on Windows platformNoel Grandin
This is only for the 64-bit windows platform. I don't see the point in messing with the 32-bit platforms, they are (a) become more and more rare (b) unlikely to even have enough available process memory to load extremely large calc spreadsheets The primary problem we are addressing here is bringing Windows-64bit up to same capability as Linux-64bit when it comes to handling very large spreadsheets, which is caused by things like tools::Rectangle using "long", which means that all the work done to make Libreoffice on 64-bit Linux capable of loading large spreadsheets is useless on Windows, where long is 32-bit. The operator<< for tools::Rectangle needs to be inside the tools namespace because of an interaction with the cppunit printing template stuff that I don't understand. SalPoint changed to use sal_Int32, since it needs to be the same definition as the Windows POINT structure. Change-Id: Iab6f1af88847b6c8d46995e8ceda3f82b6722ff7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104913 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-10set resize-toplevel true for GtkExpandersCaolán McNamara
because that's what we currently do in practice Change-Id: Ib1154a4a7597dbabb20b1cb7b051995a72256e62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105563 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-10Let's assume that sal_uInt16 is unlikely to be less than zeroMike Kaganski
Change-Id: I3e93d111bf22e54771ad4f2c7498a49d477dd3d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105533 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-09Fix typoAndrea Gelmini
Change-Id: If69267e6ef9cc73842a6aee805d3c07b088aa9bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105488 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-11-09tdf#137993 ensure the toplevel vcl::Window is activatedCaolán McNamara
when the search entry gains focus so that SfxViewFrame::Current is valid Change-Id: Ibb21db12688a7d44758cf607da618035c22a062a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105484 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-09tdf#137949 Fix table row heigths.Gülşah Köse
Consider "Height" property of the the table while calculating the minimum row height. Change-Id: I4dbb0f7f87517423fd3075515b4b9817d6a9a71a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105422 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-11-070xffffffff is COL_TRANSPARENT/COL_AUTOCaolán McNamara
Change-Id: I17d4a3d3a05913f4f0fc11508f2196b30661b88a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-06make SdrObject Identifiers SdrObjKind enum membersCaolán McNamara
with unique values so that, e.g. if (pObj->GetObjIdentifier() == OBJ_LINE) is only true if pObj is a SdrPathObj and not a E3dScene Change-Id: I30c91e57eb27141390c644dec42e2a4bee96edf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105374 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-05tdf#138011: Revert "tdf#137949 Fix table row heigths."Xisco Fauli
This reverts commit 7dc234fa57ca409d0db131c93abea738014b5e1f. Reason for revert: introduced tdf#138011 Change-Id: I44229135878524557dee29a6976f9bb1cf42766b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105351 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-05clean up some temp files after running testsAndras Timar
Change-Id: Ia28e96cf1f6ec476f202e99877fa80e93d691278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105314 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-11-04tdf#137949 Fix table row heigths.Gülşah Köse
Consider "Height" property of the the table while calculating the minimum row height. Change-Id: I4a57b69c4c0fc4dd004c895bd105ebc70f0c4bb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105228 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-11-04Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Id868397185ab487882a95a298e33a967df810a9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104737 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins
2020-11-04loplugin:constantparamNoel
Change-Id: Ia2fea86f940d0d2d1dba5ed56660584f3d3fb028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-03Resolves tdf#137059 - Use application colors for font previewHeiko Tietze
Background is set to document's application color now (options > application colors > document) to provide a true WYSIWYG experience (except for modifications to the page background color). Change-Id: Ifd78e667f3eeff3573ff09bcb4d2a9634dd49c99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105011 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03Resolves: tdf#136611 chart doesn't support corner style or capsCaolán McNamara
Change-Id: Ibee5b90fff28504d87462b3839bb58dfc6911a39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105248 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03tdf#137886 condition for asian and ctl property seems wrongTomoyuki Kubota
Change-Id: Ifc11f3bbcc499143904ac7c206674cc692cf5239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105054 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-11-02create common macro and method for logging unknown attributesNoel
instead of repeating the code everywhere Change-Id: Idb94054b392ed256e64259cdb17d1522bf3c52b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105184 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-02Resolves tdf#137813 - Status bar info 'PDF selected'Heiko Tietze
Change-Id: I60cc75dfe8e63d7d545211a9bf58efc9d34d51ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104996 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-11-02make SvXMLImport capable of mixing fast- and slow- contexts adhocNoel
so I can convert even *ImportContext subclasses in the middle of a context stack, and thus break the cyclic dependency nature of the writer import. and adjust the xmlimport loplugin for the new rules. As a consequence of the loplugin:xmlimport's checking, we remove a bunch of now unnecessary overrides of startFastElement. Change-Id: I97464522ede8ec5e345e928cdafa4b18364b1b80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-02Sidebar Area alignment updateandreas kainz
Change-Id: Ie8155e73adc2c52e8f3ec3455a5cdb4ed596c352 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105160 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-01use officecfg for ShowLinkWarningDialogNoel Grandin
Change-Id: I92a42eb2ff48bff4e635f1a37a25c8ecb9ac1347 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-31tdf#137865 use stack background to match the other notebookbar areasCaolán McNamara
while the StylesPreviewWindow_Impl is the lone InterimItemWindow in the notebookbar Change-Id: Ie00d5c5ce3b257891696e95a91e6c88bfa0cbcde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-30don't need to include sfx2/sidebar/SidebarToolBox.hxxCaolán McNamara
Change-Id: I712a7f7d32387623e47d32c9d8c0a61bd307209a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105040 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-30convert some tools::Long->sal_Int32Noel
in places where it is obvious we only need a sal_Int32, because we are dealing with rows and columns, and not even calc needs more than 32 bits for that. Change-Id: I114417e639c224d45bfd9fc6838122ab195eefa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-29StylesPreview in Writer NB arrangement in two rowsandreas kainz
Change-Id: I05e0b903e7d51cb2487f18f5bbeb6228ba7c945f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105008 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-10-29Notebookbar stylespreview up and down icon use default NB sc_ sizeandreas kainz
Change-Id: I21bf71496433522b9dcf419dd082eda1cd0327fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104985 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-10-28convert some more long -> tools::LongNoel
Change-Id: Ide9811c1a7582454b3fcf655b70ea106ed56509a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104914 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-28tdf#137790 calc: Minimal line width for different line stylesSerge Krot
Change-Id: I4d062f054a5ef6da7ef595190a7b3c6e2a0b191e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104865 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-10-28std::set->o3tl::sorted_vector in InterfaceBagNoel Grandin
Change-Id: I28ecffdcf6c97f9153e62974bf76b972452747eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104901 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-28convert some more long -> tools::LongNoel
grepping for stuff in template params this time Change-Id: Ia37bfd85480b3a72c3c465489581d56ad8dde851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-27Resolves: tdf#137620 add DeleteSurroundingText at vcl::Window levelCaolán McNamara
a) give it a default implementation based on the current one b) re-use code introduced for WeldEditView::DeleteSurroundingText for the EditView containing vcl::Window in impress/draw and various similar Annotation windows Change-Id: I55547c70e90ee394795b5545450cf8131538fad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104781 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-26std::unique_ptr -> std::optionalNoel
Change-Id: Ibbfe8097f1604122eda80aa0c49f7960e9f2815d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-26tdf#137650 sw page top border relative orientation: add UISzabolcs Toth
as new menu item "page text area top" of Position/Vertical popup menu "to:" in Position and Size dialog window of shapes. Follow-up of commit 1c593e1916c9164c7db71da2017cfc26972f8e9f (tdf#133045 sw: add shape alignment to the top page border). See also commit 8af2c4e3a517e3b75f2ace9719c1ca03153baddf (sw from-bottom relative orientation: add UI) Change-Id: I98671fa9c7c184c8f360ccb35e671df68cd271b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104661 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-26switching long to a 64-bit type on 64-bit windowsNoel
(*) create a rewriting plugin to do most of the work, heavily based on the fakebool plugin (*) but there are still a number of "long"s in the codebase that will need to be done by hand (*) the plugin needs lots of handholding, due to needing to add #include and update macros Change-Id: I8184d7000ca482c0469514bb73178c3a1123b1e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104203 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-24use SetSelection and DeleteSelected to make cursor go to the right placeCaolán McNamara
Change-Id: I6452f9a45fac67b64c7b84f290029e96eb9623e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104735 Tested-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-23Resolves: tdf#137615 fix EffectPropertyPanelandreas kainz
Change-Id: I451850524948a623d496920ef832af0fef5b5a52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104700 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22set all .ui min require version of gtk to 3.20Caolán McNamara
and update the version mentioned in our min req in the readme.xrm follow up to commit 0c9ccc7dbf6deb4d012e0d1e6eb934e54e0f19bc Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Oct 2 21:21:45 2020 +0100 raise min version of gtk to 3.20.0 Change-Id: Ibae55c97e1ee577f4b7435d124cda6a21005ad0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22always call GetFocus if GrabFocus succeededCaolán McNamara
so the CustomWidgetController can replace vcl::Control more seamlessly Change-Id: I3c2ff9c45ff0dc55b09863611df2a7d941d1c534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104574 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-21Fix typosAndrea Gelmini
Change-Id: Ia66e31a0ad71dde1a6c1caa911d6083e1fb9eb61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104538 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-10-21new tools::Degree10 strong typedefNoel Grandin
partly to flush some use of "long" out the codebase, but also to make it obvious which units are being used for angle values. Change-Id: I1dc22494ca42c4677a63f685d5903f2b89886dc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104548 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20CppunitTest_svx_unit: directly use asserts hereXisco Fauli
if it failed, it wouldn't be clear why Change-Id: Ib96674a2d243bea946abff429a267c3ce4fc64f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104559 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-08-01 15:46:15 +0000