summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2021-07-17drop sal_uInt16* constructor in SfxItemSetNoel Grandin
Change-Id: Ifb283a49b01c9c6421e385f697e749439db6a53f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119008 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-16tdf#92796 ODF import: remove unused bitmap fillsMichael Stahl
With CWS impress64 a partial fix for this was implemented to drop unreferenced named items including all non-color fills after ODF import, but this is only done in sd so move the code that does that to svx and call it from sc and sw as well. Implement some UNO interface for this, it's at least better than a magic string, and not obvious how a better solution would look like since it's known only at the end of the import if a bitmap is used or not. Another problem: when the Area tab is used to change to a different kind of fill, the items with the details for the previous fill aren't cleared, and so they are written to ODF files. Hence bitmaps in the file can be referenced even if they aren't actually used, and bloat up the files. Fix this by dropping all unused draw:fill-image-name attributes in ODF import. Also do the same for Gradient and Hatch fills; Transparency gradients can be combined with anything so leave them as they are. Change-Id: I0b591fd9f963d974d0c3e7208b99621ad61dd93c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118950 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-07-16Use WhichRangesContainer in editengMike Kaganski
Change-Id: Ia6516df33341181990c2b8b8affa859395831007 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119013 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-16Move validity check to svl::Items, to avoid invalid WhichRangesContainerMike Kaganski
This uncovered lots of pre-existing invalid ranges, e.g. introduced in commit 6dbfbebad37fd84208e4c336f0864d26019db153, or in much older commit 46952138c938730afcc3607e1a524bb590b0e30e. Also this makes the static in svl::Items to be array of WhichPair, to avoid questionable reinterpret_cast in WhichRangesContainer ctor. Change-Id: I86030b2a2ac0a6d98870f8f7f5cc83e071c6597c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119003 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-16Resolves: tdf#143372 Exclude {qtz} KeyID from SvxLanguageBox listEike Rathke
Change-Id: I3e52407a33f79713635063ff4ba374267eb98005 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119002 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-07-15drop the Pair constructor from SfxItemSetNoel Grandin
just so we have one fewer odd constructors here Change-Id: I81278e9436747a4eb46a33da9bfec7a8b30079b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118982 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-15resave with latest gladeCaolán McNamara
Change-Id: I76a4d8f77b39563d1f7c0a1b0387b69764437ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118975 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-15tdf#143355: fix crash with .uno:FontWorkJulien Nabet
with gen rendering part of bt: 2 0x00007fbfb39f440f in __assert_fail_base (fmt=0x7fbfb3b5d128 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7fbfac2531b0 "!w || dynamic_cast<T*>(w)", file=0x7fbfac2531ca "/home/julien/lo/libreoffice/include/vcl/builder.hxx", line=438, function=<optimized out>) at assert.c:92 3 0x00007fbfb3a03662 in __GI___assert_fail (assertion=0x7fbfac2531b0 "!w || dynamic_cast<T*>(w)", file=0x7fbfac2531ca "/home/julien/lo/libreoffice/include/vcl/builder.hxx", line=438, function=0x7fbfac3ad73e "T *VclBuilder::get(const rtl::OString &) [T = VclBox]") at assert.c:101 4 0x00007fbfabb27ace in VclBuilder::get<VclBox>(rtl::OString const&) (this=0x6e07e70, sID="DockingFontwork") at include/vcl/builder.hxx:438 5 0x00007fbfabb065e5 in SalInstanceBuilder::weld_box(rtl::OString const&) (this=0x6ce97c0, id="DockingFontwork") at vcl/source/app/salvtables.cxx:6811 6 0x00007fbfb07d3fe9 in SfxDockingWindow::SfxDockingWindow(SfxBindings*, SfxChildWindow*, vcl::Window*, rtl::OString const&, rtl::OUString const&) (this= 0x6e37c90, vtt=0x7fbfafd55730 <VTT for SvxFontWorkDialog+8>, pBindinx=0x34f62b0, pCW=0x6e39c00, pParent=0x34f6f40, rID="DockingFontwork", rUIXMLDescription="svx/ui/dockingfontwork.ui") at sfx2/source/dialog/dockwin.cxx:774 7 0x00007fbfaf7c3be8 in SvxFontWorkDialog::SvxFontWorkDialog(SfxBindings*, SfxChildWindow*, vcl::Window*) (this=0x6e37c90, pBindinx=0x34f62b0, pCW=0x6e39c00, _pParent=0x34f6f40) at svx/source/dialog/fontwork.cxx:179 8 0x00007fbfaf7c728c in VclPtrInstance<SvxFontWorkDialog>::VclPtrInstance<SfxBindings*&, SvxFontWorkChildWindow*, vcl::Window*&>(SfxBindings*&, SvxFontWorkChildWindow*&&, vcl::Window*&) (this=0x7ffc6e31bf70, arg=@0x7ffc6e31bf78: 0x34f62b0, arg=@0x7ffc6e31bf68: 0x6e39c00, arg=@0x7ffc6e31bf80: 0x34f6f40) at include/vcl/vclptr.hxx:279 9 0x00007fbfaf7c1dcc in SvxFontWorkChildWindow::SvxFontWorkChildWindow(vcl::Window*, unsigned short, SfxBindings*, SfxChildWinInfo*) (this=0x6e39c00, _pParent=0x34f6f40, nId=10256, pBindings=0x34f62b0, pInfo=0x7ffc6e31c230) at svx/source/dialog/fontwork.cxx:169 See full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=173585 with gtk3 rendering, no crash but: (soffice:33916): GLib-GObject-WARNING **: 20:40:33.018: invalid cast from 'GtkGrid' to 'GtkBox' put grid into a toplevel box (git show -w to see minimal diff) Change-Id: I05f9a295cd839f782467b85d6bafd652a405b14d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118953 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-15tdf#143327 keep selection bounds on replacing colorCaolán McNamara
so select-all and type 'a' will retain cursor at position 1 and delete/backspace keep cursor position in a semi-rational way Change-Id: I802f132e58cea9f111deb1c6d157706d08cb5b81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118978 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-15WhichRangesContainer, reduce malloc in SfxItemSetNoel Grandin
SfxItemSet shows up in perf profiles frequently, and the hottest part is the malloc of the two arrays we need. But most of the time, one of those arrays is a compile-time constant. So this change introduces (*) WhichRangesContainer, which manages whether the SfxItemSet owns the array it points at or not. (*) a static const member in svl::Items (idea from mkaganski) to store the data. Change-Id: Icb8cdbc4d54fd76739565c575e16a744515e5355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118703 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-14tdf#58114 Remember last selected folder when saving image in ImpressSamuel Mehrbrodt
Change-Id: Ic095f461d794091716e7defcfd9850dd21493ba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118816 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-07-13Split the which id ranges merged in c4f615b359be56e88e4fbf9aaaf30affb29d57e2Mike Kaganski
... after specifying adjacent ranges became possible in commit d8bb5bb58ef62bc0e32d17f00f5fe695c81b5606. This allows to have the used ranges expressed explicitly, and makes it safe in case when new which ids potentially added between SDRATTR_SOFTEDGE_LAST and SDRATTR_TEXTCOLUMNS_FIRST. Change-Id: I94b75bc89e4cf2b490ffc55f692d4ebb593681a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118848 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-13a11y crash on teardown of FmXGridPeerCaolán McNamara
the XAccessible is destroyed before the attempt to dispose via the IAccessibleBrowseBox* so call that first before the XAccessible is destroyed Change-Id: I908a3fbc05f92b5e56b8b6f2bc0b27757d39d1fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118825 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-13Add PowerPoint compatible screen size for ImpressJun NOGATA
I realized that Impress does not have the same screen size as PowerPoint. tdf#142286, tdf#142288 When I load a PowerPoint slide into Impress, it was a custom size, but when I add this screen size, it shows up with the screen size name. And when I load a slide with the added screen size into PowerPoint, it also shows up with the PowerPoint preset screen size name and not the custom size. The screen sizes I have added are as follows * Widescreen (Current PowerPoint default) * On-scren Show (4:3) * On-scren Show (16:9) (Google slide defualt) * On-scren Show (16:10) Change-Id: I33e2bbc36b2c92ecbb85c610c864f735bf540d03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116374 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-13Resolves tdf#143272 - Window text color for border linesHeiko Tietze
Change-Id: If57e391328f0f49161b3ffae83a0077bc34ac10f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118820 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-07-12tdf#126665 Remember last used file picker directorySamuel Mehrbrodt
This introduces internal tracking of last used directories. Each caller of the file picker can pass a "context". The selected directory will then be saved & restored when opening the file picker with the same context again. After ffa636ba74b04b3258ec9a696bc4eac33581fa24 , the Windows file picker no longer tracks the last used directory itself. This is a replacement and an improvement at the same time, since there is not one global last used directory, but one per context. Change-Id: I10650cfb9359922690954fa65c89b4e47477e2c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118597 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-07-11editengine-columns: tdf#143258 Fix handling rotated textMike Kaganski
This reverts modifications to existing unit tests made in commit d0a1616ccad0dd5f5a02c1b0204f537b57d0b4b5. My idea that those changes were required because of more correct calculations was wrong, and in fact they were caused by off-by-1 error in height calculations. Change-Id: Ib94878a911238c977c35a8f8e3e5694cedc79a89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118705 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-08Related: tdf#143153 these are GtkBox properties not GtkGrid onesCaolán McNamara
nothing to do with the crash though Change-Id: If7645a904de9147d20f548017bf5390fc57af6cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118641 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-08return value of PixelToLogic ignoredCaolán McNamara
the other uses of SdrObjListPrimitiveHit operate in Logic Position Change-Id: Id6a834a17e6e2252bd4f58d10cd95f7425191203 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118606 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-08tdf#125533 Update Calc style names for style sidebar dropdownThorsten Wagner
Style names for Calc are updated to current style names. As default styles shown by sidebar dropdown are hardcoded, styles Accent 1, Accent 2, and Accent 3 were added to offer a few more options. Change-Id: I0e4b00f7e8a64e1ded077c559ed208fe71d784ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118038 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-07-07tdf#132740 avoid some WeakReference cost in accessibilityNoel Grandin
reduces time by 20% for me Change-Id: Ife78248fd36099298eb2401b362f16a1ae3c0434 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118534 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-05store the SfxItemSet inside SfxSetItem by valueNoel Grandin
rather than on the heap, avoiding an allocation Change-Id: I3f1504f9a2d4178a9ba59e98de182a0ab98cdce0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118356 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-02add use-underline to color picker buttonCaolán McNamara
Change-Id: Ice9d2a155c4237b30134bd8faf7931ec980829e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118316 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-02no need to allocate return val on heap for GetItemSetForPreviewNoel Grandin
Change-Id: I261182ec2348df045171c5e1beb33579e2c0c766 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118284 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-02convert AccessibleBrowseBoxObjType to scoped enumNoel Grandin
Change-Id: Iaf764c905d080e4decabd853bd3847b34cb79cdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118279 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01can allocate these SfxItemSet on the stackNoel Grandin
Change-Id: Ib2b89613ad3e8f2bcdd51bee10bab3559a64fce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118208 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01BmpCombine::And is deadNoel Grandin
ever since commit ddd2639a482befb4a3bf1f75a88e66c21a691b67 Date: Sat Feb 27 15:50:37 2021 +0200 drop mask from BitmapEx Change-Id: I45fae0140067e2bfe5ce1ae2f5014ce733835ef1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-30fix a size warningLuboš Luňák
d7855213ae60d79f converted this incorrectly, the code right above may set the size as (0,0), and before the commit the invalid size was only negative. Change-Id: I198d025f5c02780ae509f97782bc41ac77fa3407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-06-30swap text and background colors in colorsetsTomaž Vajngerl
Change-Id: I1e1da85d6c58e3ed5ab4c44c2ab0ae7c3b080251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118149 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-30uitest: combine create_doc_in_start_center methodsXisco Fauli
Change-Id: I59ea0d0dbd203590e7cedec51d0481c953e5172b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118155 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30uitest: guard the remaining create_doc_in_start_centerXisco Fauli
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I2a6149b318d1fdaa36efe5d65af4c238827eaaf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118154 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30tdf#139301 tdf#141933 (related) Translate new preset dash namesGabor Kelemen
Change-Id: I9cd7ad0eca1a6fb471a284fb2828a7ad12816337 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117024 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-29constructing SaveOptions just to read default versionNoel Grandin
can be a little expensive sometimes, since it loads a bunch of other stuff at the same time. So create a custom method that just loads the version Change-Id: Ic480d95c4d64c68e57faf1b52f1d102141b7e246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118047 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-29Related: tdf#143088 return early on notification from frozen editengineCaolán McNamara
processing EE_NOTIFY_PROCESSNOTIFICATIONS from an EditEngine with an UpdateMode mode of false will just to on to cause AccessibleTextHelper_Impl::GetTextForwarder to throw an exception as a Frozen EditEngine is considered Invalid so return early instead Change-Id: I86f9647b7bf839cf3c7cf2f029be8c7c5aeef1f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-29uitest: combine execute_dialog_through_command methodsXisco Fauli
Change-Id: Iaa03d37a9ac3862b8cb08a81e37a611632433880 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118077 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-29uitest: guard remaining execute_dialog_through_commandXisco Fauli
Mostly done with a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: Ib8e7c5f5e2c9b8a7756fe533ea4f30349dd68761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118076 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-29new ODF numbered list parameter loext:num-list-formatVasily Melenchuk
Instead of style:num-prefix and style:num-suffix new list format is much more flexible for storing list multilevel numberings. Now it is possible to have not just prefix/suffix but any random separators between levels, arbitrary levels order, etc. Internal LO format for list format is changed: instead of placeholders like %1, %2, etc we right now use %1%, %2%... Reason: for ODT documents, having more than 9 levels there is ambiguity in "%10": it is "%1" followed by "0" suffix, or "%10"? Aux changes: * removed zero width space hack: since format string is always defined this hack is interfering with standard list numbers printing (see changes in ooxmlexport14.cxx, ww8export3.cxx tests) * changed cross-references values to lists: they are now including full list label string: previously this was bit self-contradictory (see changes in odfexport.cxx and check_cross_references.py tests) Change-Id: I9696cc4846375c5f6222539aeaadbca5ae58ce27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117156 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-28loplugin:indentation improve checks for brace alignmentNoel Grandin
Change-Id: I333100fda7e181f68f36b03279b3fbb8cb768310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-28tdf#139549 DOCX import: document got modified at import timeRegényi Balázs
Regression of bda05ba17362222b74727872579b65b3fa14e3d8 "tdf#41466 DOCX import: fix VML v:shape/v:textbox". Co-authored-by: Tünde Tóth Change-Id: I8762aa8a710c3a37290e1db854b8cc86db6757b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109436 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-27cid#1486528 silence Uncaught exceptionCaolán McNamara
Change-Id: I03b71a11dda7b818a99525d65cbbc42f40dd2eee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117949 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-27svx: adds a test for SdrRectObj rendering into primitivesTomaž Vajngerl
This adds a new test that checks how a model with a rectangle object is being rendered / transformed into drawinglayer primitives. Change-Id: I81851e122f182ebe5ed8486fdab8d04bb8c9e68a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117886 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-27svx: clean-up, init in constructor, rename master pages variableTomaž Vajngerl
- maMaPag to maMasterPages - cleanup the constructor variable initialization - change degree chart from define to const variable Change-Id: Idc607b8b386855b90001ed389df2c7849969ee86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117887 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-25loplugin:finalclasses in svxNoel Grandin
Change-Id: I7dd8d1a900694687fbed3f3f29b0ea4bb11b7d72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117790 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-24Revert "uitest: guard create_doc_in_start_center"Xisco Fauli
This reverts commit 374baf308979306aa35575118c40ccd7caae1e29. Many uitests are failing randomly in jenkins for no apparent reason Change-Id: I5960330fab4967518bfeea32b3b8c5f8bfbea57e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117752 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-23EMF+ tdf#142975 Add brush support to DrawString recordBartosz Kosiorek
Change-Id: Icfcb4199dcd755fb20e14a8166571b6d6e763f2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117671 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-06-22uitest: guard create_doc_in_start_centerXisco Fauli
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I75ef7712af3676363a9a464acf83f6f68ffc4f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117617 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-21bundle the FolderPicker instantiations behind a single callCaolán McNamara
in prep to add parent support Change-Id: I2aa4b9343f895ae866f600dd3260b7fdc4e1efec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117579 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21drawinglayer: put BufferedDecompositionPrimitive2D in its own fileTomaž Vajngerl
And fix includes all over the place... Change-Id: I6e2696bbeeac6ab7467cac70545fa7209aa981a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117528 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-20drawinglayer: remove ImplPrimitive2DIDBlock macroTomaž Vajngerl
We can just implement the simple getPrimitive2DID method in all primitives. The ImplPrimitive2DIDBlock macro doesn't save us anything. Change-Id: I02f44d4891d7b340220890bf52a7ebfc8e41850a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117509 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-19svx: prefix member variables for SdrTextObj and othersTomaž Vajngerl
All classes in svdotext.hxx Change-Id: Ib15deca2a625d8352a2572d9fc3e15188b4e718a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117478 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>