summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-21Fix typosAndrea Gelmini
Change-Id: I2297bf392a405f02be2450f4624f1c9fc0b512ce Reviewed-on: https://gerrit.libreoffice.org/16373 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-19fix tabpage renderingLászló Németh
Change-Id: I2448787c306a8a4ba531c0560e0435fefadb4dc8
2015-06-19rendercontext: Fix crash with double-buffering in the Styles combo box.Jan Holesovsky
Decouple the actual window from rendercontext in UserDrawEvent. Change-Id: Ic440c4e7f59fcffb7800c578146e8eb528cbb7b4
2015-06-19Catch inadvertent uses of OUString(sal_Unicode) ctorStephan Bergmann
...with numeric values that are not meant to be characters. Inspired by <https://gerrit.libreoffice.org/#/c/16339/> "OUString: add constructor from single Unicode code point" and ecaf1cb3861c1b519a1495487fc796884cf37b92 "seems to be what was meant." Found e46e8d19458fd64ff20b1013e5eeabd07e62379c "Shall this produce a string representation of a number?" and f2a0e4032734d6be635f14ade3dea499c29ec6c2 "Don't truncate a UTF-32 code point to a UTF-16 code unit." (LIBO_INTERNAL_ONLY mostly because it uses a C++11 delegating ctor for simplicity, but also because it requires mild modifications to client code, see additional changes in this commit and some other recent commits.) Change-Id: I8a156f01d1b772c6052d7afaa088ae13ed234e2b
2015-06-19Revert "optimise SdrObjList::SetObjectOrdNum"Noel Grandin
This reverts commit 30e87214781dd9ca5830aad674e08354d3f9ae30. which I accidentally pushed.
2015-06-19optimise SdrObjList::SetObjectOrdNumNoel Grandin
the benefit here is that we avoid setting bObjOrdNumsDirty to true, because we almost always need the ord number the very next time this is called. Change-Id: I0b974b79e69754d35095e197400584df4a89bfe9
2015-06-18There are only 8 available stringsMaxim Monastirsky
for RID_SVXSTR_SINGLENUM_DESCRIPTIONS, but since 71b35212265bb93b10ca35ab964a36e6b6cc552b, we're allowing here more than 8 items. So don't try to get strings for those items, the same way we restrict that in SvxNumValueSet::SetNumberingSettings. (Although these string are (still) not used anywhere AFAIK.) Change-Id: Iaa538e4aebfc72729646f0befc7bcf8e58d6cbee
2015-06-18Fix typosAndrea Gelmini
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17Some missing SolarMutexGuard around VclPtr acquire/releaseStephan Bergmann
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so apparently rely on the SolarMutex being locked whenever they are called. Fixed those places that caused "make check" to fail for me when temporarily adding DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is that a class fails to ensure the SolarMutex is locked around the destruction of non-null VclPtr members.) Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
2015-06-17svx: nHdlAnzMerk -> nSavedHdlCountMiklos Vajna
Assuming "anzahl merken". Change-Id: I3bfd6ce9ca9240c3bec71a72aed028889151891c
2015-06-16Line Section reorganisationRishabh Kumar
Arrow Style, Corner Style and Cap Style are hidden Change-Id: I0bfab4b23219d01ebfdb3a9ff0dc36777a412ec5 Reviewed-on: https://gerrit.libreoffice.org/16264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f Reviewed-on: https://gerrit.libreoffice.org/16309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56 Reviewed-on: https://gerrit.libreoffice.org/16300 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I549635318f46718042e50c8f89ce3c620cade990 Reviewed-on: https://gerrit.libreoffice.org/16281 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16tdf#73071:Styles tab addition to the sidebar for writerRishabh Kumar
Addition of .uno:StyleApply , .uno:StyleUpdateByExample and .uno:StyleNewByExample uno commands to the sidebar Change-Id: Iab6f1fb465066fce523fd376038a059189f1b842 Reviewed-on: https://gerrit.libreoffice.org/16279 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-15Resolves: tdf#92082 crash on closing color bar after redocking itCaolán McNamara
Change-Id: I015306a37abeaef17830ceab0f39cb2f3a98155c
2015-06-15cppcheck:unreadVariableNoel Grandin
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15sdr tiled rendering: stop animation timer's taskHenry Castro
Change-Id: Ia7281c853454e283150bba3c79aa9579363c7ca3
2015-06-15cppcheck: variableScopeCaolán McNamara
Change-Id: Idbf5301d17d413077c7dc436a6f140a412ae71cd
2015-06-15Related: tdf#87651 Swap buttons and align to the rightMaxim Monastirsky
Change-Id: I74d799f10d4a1d88256c683f913b8c639d2694c1
2015-06-15Fix typosAndrea Gelmini
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37 Reviewed-on: https://gerrit.libreoffice.org/16263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-14Paragraph related part of Background Tab is unused nowZolnai Tamás
For paragraphs Area Tab is used for setting background. Change-Id: I83859a1b2125374b81c084cfa45487a42adcd5a6
2015-06-14Remove unused OpenGLObjectZolnai Tamás
Change-Id: I5c4832bd076cc5f05f936ac0d6a80027344e40ff
2015-06-14Avoid duplicated attribute names in RID_ATTR_NAMESZolnai Tamás
It causes trouble to localiztation tools and also makes hard to distinguish these items on the UI. e.g. Edit -> Find & Replace -> Other options -> Attributes. Change-Id: Ie7a17e02947200a570b5e6209c8a99d1883a6860
2015-06-14cppcheck: redundantCondition [part2]Julien Nabet
Change-Id: I23e8a4834fa7858adb292ce0a4dfa5dab1ab5f00
2015-06-14cppcheck: redundantCondition [part1]Julien Nabet
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-13TyposJulien Nabet
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
2015-06-12svx: prefix remaining SdrMarkView membersMiklos Vajna
Change-Id: Ia1b65264fea95077c9dc2fb1288a20c6df0ef84c
2015-06-11SdrCustomShapeEngine/DataItem are just SfxStringItemStephan Bergmann
Change-Id: I94f8c268781f5a5b4da9da78af183adefc0c2925
2015-06-10coverity#1302618 deref of NULLCaolán McNamara
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-10Remove unnecessary Bool2AnyStephan Bergmann
(It feels better to use explicitly bool-typed css::uno::makeAny<bool>(x) rather than implicitly typed css::uno::makeAny(x) or css::uno::Any(x), in case x is not already of type bool.) Change-Id: I282b3764bb207aeae9f13cc981e68e8ef2b8ab93
2015-06-10tdf#91727 - Unwind non-dispatch of idle handlers.Michael Meeks
This clobbers the functionality from commit: 06d731428ef6cf93c7333e8228bfb6088853b52f make idle timers actually activate only when idle Since now all rendering and re-sizing is done in idle handlers it does effectively the opposite of what was intended. A better solution would allow special-casing the processing of just rendering, re-sizing and window management to spin for eg. progress bar rendering. Also add helpful debugging labels to the idle & timeouts. Also cleanup the Idle vs. Scheduler handling. Also ensure that starting an Idle triggers a mainloop wakeup. Also add a unit test. Change-Id: Ifb0756714378fdb790be599b93c7a3ac1f9209e6
2015-06-10tdf#88055: Don't export transparent background colour as whiteKatarina Behrens
The fix is twofold: 1. retrieve transparency from colour in SvxBackgroundColorItem (add QueryValue, PutValue methods, use additional memberID to retrieve alpha channel as a bool property) 2. add CharBackTransparent bool property to Draw [text] shapes, xmloff needs it to be able to output 'transparent' string instead of '#XXYYZZ' colour code in ODF format Change-Id: Id830bd18fd6da5d9a46e2a94aa254d5d2a6b7ebb Reviewed-on: https://gerrit.libreoffice.org/16182 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-10tdf#88290 Adapt the numbering popup to more than 8 itemsMaxim Monastirsky
The items count of NumberingTypeMgr is limited by 8, but some languages have more items, so remove that limitation. Also fix the behavior of the 10th item. The old sidebar popup had a "None" item, whose id was 10 (defined by DEFAULT_NONE from include/svx/nbdtmg.hxx), and that causes now the 10th item to behave as on/off toggle. Since we don't have a "None" item anymore, get rid of that behavior completely. Change-Id: I5546ca637f9951cc093a7bbf8fda11dc35341d4e
2015-06-10tdf#87651 Add outline buttons to impress sidebarMaxim Monastirsky
Change-Id: Id3cf58660bfcaf7424d027773894ce6888df788a
2015-06-10tdf#91944 Fix inc/dec indent buttons in impressMaxim Monastirsky
Regression from ed6b7d972bf1aee323947f22c6b5de430db4a9a5. These buttons are implemented inside the sidebar, so just changing command names in the ui file won't work. Also, following the decision to use indent buttons across all modules, there is no need for 2 separate toolboxes anymore. Change-Id: Id9af0cd10fd0517be86b9793c187cd6508029732 Reviewed-on: https://gerrit.libreoffice.org/16199 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-06-09More CppunitTest_sw_uiwriter fixesMiklos Vajna
1) Guard against nDPI == 0 in ImplLogicToPixel(), it's the caller's responsibility to ensure that the DPI value is in the expected range. 2) pOut in sdr::overlay::impCheckPossibleOverlayType() is seen as 0. Change-Id: Iab5ff10aa7953993161dcad2d49d99d80c588e01
2015-06-09loplugin:unnecessaryvirtualsNoel Grandin
Improve the plugin a little. Create a python script to process the output. Run it again. Change-Id: I05c21d8a21c8f4243af739c412fda0a521f9b5f0
2015-06-08add (and call before dtor) Commit to SvtSearchOptionsCaolán McNamara
i.e. follow up to commit 465359c35fcd8c30a2bedd3d0beb07c0c1c36cba Author: Michael Stahl <mstahl@redhat.com> Date: Wed Mar 11 16:39:24 2015 +0100 do not call virtual Commit() from dtors of utl::ConfigItem subclasses ~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not invoking its subclasses' ImplCommit() but its own. to avoid assert in SvtSearchOptions dtor Change-Id: I0eaf93450e1daddb81a9463f2c1df48a334dfb22
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I94b2fbbb00e9772b668128f31cf08115bdfb16b5
2015-06-08Setting Maximum Value for Transparency spin button in area sidebar tabRishabh Kumar
Change-Id: Idb1c5051de5ddb0501b8d1440f8abe62074296bc Reviewed-on: https://gerrit.libreoffice.org/16144 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-06-07Resolves: tdf#89905 don't copy palettes from shared to userCaolán McNamara
make this a multi-path element with a shared read-only location and a user read/write location and don't copy the presets, instead just keep them in the shared location Now an admin can copy extra palettes into the shared location and they magically appear in the user deployments Change-Id: I7585789c0c59941094f6128368df94b834d3c2a2
2015-06-07Related: tdf#89905 these PalettePath uses appear to really be UserConfigPathCaolán McNamara
which is the same path at the moment Change-Id: Ifdefa478003a2b5cc5c065b1942194dda1275f5e
2015-06-06Typo: Gourand → GouraudValter Mura
Change-Id: I6c5d4f97bce8f5b29d979e2508e691948e9399fb
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-20 11:31:04 +0000