summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2017-02-08replace localresource of strings and keys with StringArrayCaolán McNamara
Change-Id: I4abce924a89f611c28d0441ae097b310193b5dae
2017-02-08replace localresource of strings and keys with StringArrayCaolán McNamara
Change-Id: I402f5485af0c1e60677b8291c879bc7ca14633d3
2017-02-08drop unused error stringsCaolán McNamara
includes ERRCODE_SFXMSG_STYLEREPLACE which has the knock on effect that the flags argument can be removed from a bunch of methods Change-Id: I72b58bc2a19376bb4609e61aa44e71f734efb333
2017-02-08move the extra data of ERRCODE_SFXMSG_STYLEREPLACE out of the .srcCaolán McNamara
Change-Id: I5c39d785d1f2a78e1fcfcd763deac60f047a5e4b
2017-02-08remove unused SCHATTR_DIAGRAM_STYLENoel Grandin
and associated SvxChartStyleItem and SvxChartStyle Change-Id: I1564a4583125dd32af71e4eff338dfcefc6517c4 Reviewed-on: https://gerrit.libreoffice.org/33988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07Revert "create ErrorHandlerFlags scoped enum for error handling flags"Michael Stahl
This reverts commit 05e78bde26d8b8b257ed22a0ce20c5b386a629d1. Depends on the other commit that needs reverting
2017-02-07Always use split button for .uno:CharBackColorMaxim Monastirsky
Change-Id: I4dd01ec8692fff77a94d6fa698e438581f6dbf37
2017-02-07tdf#105631 Notebookbar doesn't use wide buttonsMaxim Monastirsky
So we want non-split behavior only in SidebarToolBox, not in the derived NotebookbarToolBox. Change-Id: I064bbe59b97da301a13889ad78a31227cfd693ee
2017-02-07convert resources containing strings to stringarray resourcesCaolán McNamara
Change-Id: I61e815a9545f55a3b886322e7d2c0d50040584bd
2017-02-07Related: tdf#105371 we can do this with a sizegroupCaolán McNamara
Change-Id: Ie37a3d960ec244033f2b05e7a902c7a23ba9b94d
2017-02-07revert unready stuffCaolán McNamara
Change-Id: I2b112a17a2bc70bfe4d5a6af7964a3c1d7eacf9b
2017-02-07convert resources containing strings to stringarray resourcesCaolán McNamara
Change-Id: I8a306b417dcf533a148e34a6314e37589dcdda12
2017-02-07create ErrorHandlerFlags scoped enum for error handling flagsNoel Grandin
Change-Id: I30c80979c87bad7bc98f36a158c31c88d80d1caf Reviewed-on: https://gerrit.libreoffice.org/33991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07mark numbers in compress dialog as untranslatableStanislav Horacek
Change-Id: Id7761bdc7569c84a5f4edc5d2c7d764ea1ccd506 Reviewed-on: https://gerrit.libreoffice.org/32814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-02-07convert GalleryBrowserTravel to scoped enumNoel Grandin
and drop unused GALLERYBROWSERTRAVEL_CURRENT value Change-Id: Id91824cbe024d4b5109ee0755b518164837bc6a6 Reviewed-on: https://gerrit.libreoffice.org/33965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-04tdf#105656 only delete path if less than 2 pointsRegina Henschel
This prevents the crash. It might be related to gerrit #/c/33654 Change-Id: I92907c7874964af722b69ed8afd9249e110b3401 Reviewed-on: https://gerrit.libreoffice.org/33907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-02-03TyposJulien Nabet
Change-Id: I36f443c266670bd26aa6b813075e18653f372f52 Reviewed-on: https://gerrit.libreoffice.org/33900 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-03tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctordilekuzulmez
Change-Id: Iaedabfa4c4242f5a37f818572fddfbcca88d5b9a Reviewed-on: https://gerrit.libreoffice.org/33849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Tested-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-02-03new loplugin:unusedenumconstantsNoel Grandin
These are the simple removals, where it is obviously safe, the more complex ones will come in separate commits Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308 Reviewed-on: https://gerrit.libreoffice.org/33828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03tdf#105707 PPTX import: warn when SmartArt is missing DrawingML fallbackMiklos Vajna
By the time DiagramGraphicDataContext::onCreateContext() completes, we know if there will be a DrawingML fallback for the SmartArt (called ExtDrawing in the code) or not. Warn about this case once at the end of the import when in interactive mode. Headless mode silently ignores the warning as expected. Change-Id: I2bfeeedcaa244f08d8a0c208167e79d7bb697e6d Reviewed-on: https://gerrit.libreoffice.org/33866 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-03tdf#105371, tdf#99456 Alignment in find & replace dialogheiko tietze
Fix width of labels removed and code added to define it on runtime Fix height of buttons commented out Resizable flag unset Change-Id: I3ffb38b5c9b23447ac914dc8c13fa95072897ced Reviewed-on: https://gerrit.libreoffice.org/33370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-02-02tdf#91795: prevent default item overwrite actual values.Mark Hung
A few properties of FillProeprties have the same nWID but have different nMemberId, such as FillGradient, FillGradientName,FillHatch,FillHatchName, FillBitmap, FillBitmapName, and FillBitmapURL. When putting value of an item, the default item was put first, despite the value of the item might have already been put. Move the part of the code that put default item upfront so that it will not overwrite actual value accidentally. Change-Id: I54288420abde333e5b3e4cdd31ca9fae0c3ed7ab Reviewed-on: https://gerrit.libreoffice.org/33594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-02tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctordilekuzulmez
Change-Id: I2a48e513ad71609b11eb02eb5da7aa7d76860e7d Reviewed-on: https://gerrit.libreoffice.org/33841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-02loplugin:stringconstantTor Lillqvist
Change-Id: I20b245e69dcd1bd5f9345b3e0950a2299905bfa0
2017-02-02convert method names in tools::SvRef to be more like our other..Noel Grandin
reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02convert BmpCombine to scoped enum and drop unusedNoel Grandin
Change-Id: Ic67474683a25a25e5753777f4bbbeded6ceba414 Reviewed-on: https://gerrit.libreoffice.org/33793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01tdf#105669 tdf#82707 A single click in the status bar is now enoughAdolfo Jayme Barrientos
Change-Id: I5acc6ce95a3dc7fe6e23088ef2ec9c6a93d32670
2017-02-01Need <config_features.h> here, tooTor Lillqvist
Change-Id: I9dc03760831f3f1ff433c67abde95060d533ea14
2017-01-31tdf#105566 Show InfoBar when signature is invalidSamuel Mehrbrodt
gpg4libre Change-Id: I272ac155889e25b9af91ff723a014588a65b045a Reviewed-on: https://gerrit.libreoffice.org/33737 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31more SAL_WARN_UNUSEDNoel Grandin
Change-Id: Idf44fe0302b4504c443f083e527b63b2461ada85
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31a whole bunch of SAL_WARN_UNUSEDNoel Grandin
Change-Id: Iea28debc7d3abc58cca21bd3856cb65b321dc1e6 Reviewed-on: https://gerrit.libreoffice.org/33693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30lok: Allow to edit comment by postit idPranav Kant
Change-Id: Ice1d40b7813226fe99c423047392b3416d763dd4 Reviewed-on: https://gerrit.libreoffice.org/33614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27getColorWindow calling itself, so undisposed windows lying aroundCaolán McNamara
Change-Id: I5902c7a677b8b0d3d2891a5f793e5f8e457f25fa
2017-01-27lok: Allow to reply to comments using postit idPranav Kant
Change-Id: Ic6aaa3066923d62f197bc2b0e02e8049c9d7cd2c Reviewed-on: https://gerrit.libreoffice.org/33612 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-26Related: tdf#104312 create palette on demandCaolán McNamara
Change-Id: I741323c41231a08fe9561d72ca6079079e888e90
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25tdf#105520: "Selection Count" does not appear on Status bar when selectedTamás Zolnai
Change-Id: I6ade03b39aeafffa08cfbfcca4739cfe5a73d4ac Reviewed-on: https://gerrit.libreoffice.org/33561 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-25move Image ctor variant with mask color to callersCaolán McNamara
Change-Id: I81a52aeb855edca823881360831b26e252780053
2017-01-25tdf#105502 sd increase font size: handle table selectionMiklos Vajna
In part of a table shape is selected, then only operate on the selected cells, not on all of them. Change-Id: I3a9ba2b99bcaa2e355b6fcdafdd142d4a809bce6 Reviewed-on: https://gerrit.libreoffice.org/33524 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-25loplugin: unnecessary destructor svxNoel Grandin
Change-Id: I7feed30eea4f7367943fa2d6e0d75be5ca209068 Reviewed-on: https://gerrit.libreoffice.org/33516 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25Fix typo in comments: relativ -> relativeTakeshi Abe
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09 Reviewed-on: https://gerrit.libreoffice.org/33488 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-24coverity#1399021 Unchecked dynamic_castCaolán McNamara
Change-Id: I3befc9be20f8d414ec786f1a94f1f85ce94fb44b
2017-01-24teach unusedvariablecheck plugin about SfxPoolItem subclassesNoel Grandin
which can all be treated as SAL_WARN_UNUSED The eehtml.cxx change probably fixes some CJK/CTL bug somewhere Change-Id: I6852129540f316075aee907971ac19418d71dd9a
2017-01-24use range based loopsJochen Nitschke
Change-Id: I8144aa147883120cfbeacddaff0bcec486f84be2 Reviewed-on: https://gerrit.libreoffice.org/33449 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24Fix typo in comments: absolut -> absoluteTakeshi Abe
Change-Id: I8aab9004001a9a2ddd54b4c73857b6f9c5b51515 Reviewed-on: https://gerrit.libreoffice.org/33486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23tdf#102142 : disable paragraph spacing icons in the print preview modeSzymon Kłos
Change-Id: Ia75581ae6fe2942d8c28892f38abda2dd425f33b Reviewed-on: https://gerrit.libreoffice.org/33474 Reviewed-by: Szymon Kłos <eszkadev@gmail.com> Tested-by: Szymon Kłos <eszkadev@gmail.com>