summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2016-06-23tdf#83830: Page Styles PanelSusobhan Ghosh
Added new helper class to svx for numbering Change-Id: Ie7db4059568024e9bed460fcf7c9215bd2ef788f Reviewed-on: https://gerrit.libreoffice.org/26020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-22Resolves: tdf#88985 block app from exiting during macro executionCaolán McNamara
but stop basic execution on the exit attempt, and then resend exit at a safe place when basic execution has stopped Change-Id: I77c43acffa0b82e8125dcb3b10ad9bf0d6dd26c3
2016-06-21tdf#90078 Add import bitmap button to Area PanelSusobhan Ghosh
Change-Id: I49712f807d38a614fd707d06c9453545360db89f Reviewed-on: https://gerrit.libreoffice.org/26527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-21remaining LibreOffice → %PRODUCTNAME in crash dialogChristian Lohmaier
Change-Id: Ied3f0644e90a05d7d38755c4f42165247edb6b37
2016-06-21GALLERY_USE_CLIPBOARD unused since 2001Noel Grandin
Change-Id: Idd21f60187e27fc100021ba07374357f502150e7 Reviewed-on: https://gerrit.libreoffice.org/26508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-20improve wording for crash report dialog a bitMike Saunders
Change-Id: Ibf27d45d9a9a0dd57a82fdf9c44f4017a43d953a Reviewed-on: https://gerrit.libreoffice.org/26525 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20Remove no longer needed SdrModel::libreOfficeKitCallback()Miklos Vajna
All former clients are changed to call SfxViewShell::libreOfficeKitViewCallback() instead. Change-Id: Ic5dcf0a8a4241338fcd6941f13ce438157676481 Reviewed-on: https://gerrit.libreoffice.org/26521 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-19loplugin:defaultparamsStephan Bergmann
Change-Id: I7a74f10d3dbae16641c6c3aa3b8e53dde12df047
2016-06-19loplugin:salbool: Implicit conversions from non-Boolean fundamental typesStephan Bergmann
Change-Id: I67eac95686678e6f5a2d60798535b2c65a9ba5d7
2016-06-19LOK: tile rendering regression fixAshod Nakashian
Calc fast rendering requires us to offset the are being rendered and shift all bitmaps accordingly. This however is breaking Impress rendering since the offseting logic is common (in svx and vcl). This adds new API to enable or disable this local rendering (as opposed to rendering a full document as was previously done. The new flag is then set by Calc to enable the offseting logic in isolation without affecting other applications. In one case isolation was achieved by checking the MapModeUnit. Change-Id: Ia0aadfc3f6df7c1a891b97dc731f5897414c9420 Reviewed-on: https://gerrit.libreoffice.org/26367 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 60fdcda65bad242f99895cb453182578250fbdea) Reviewed-on: https://gerrit.libreoffice.org/26378 Tested-by: Jenkins <ci@libreoffice.org>
2016-06-18better message for crash report dialogMarkus Mohrhard
Change-Id: I02903cda46809798ec7664cf620c06ea7687e54e Reviewed-on: https://gerrit.libreoffice.org/26443 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-17LOK: fast tile rendering (graphics and buttons)Ashod Nakashian
Since embedded graphics and buttons use absolute coordinates, we set the origin to be the top-left corner of the tile. This includes the origin + ScrPos (see previous patch). Then, the coordinates of the graphic is shifted by this amount to make sure it renders in its relative position to the tile. This renders embedded graphics and buttons at their correct position, with some limitations. Tiles large enough to cover a graphic object show the graphic object where it should be. However, rendering a relatively small tile doesn't render the graphic. This seems to be an issue with moving the graphic's coordinate at a later stage than the 2D Processor decides what objects intersect with the 'view area' that is rendered. Another issue is that graphs don't render. What they seem to suffer is incorrect scale and a fix coordinates (they show up as tiny thumbnails at the top-left corner and grow in proportion to the real graph when resized). These shall be addressed in a separate patch. Reviewed-on: https://gerrit.libreoffice.org/26204 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 5f01d80f75dc86b393cc2fdb66b94aece964c674) Change-Id: I4b71bf5f2e357d1114d46022bc00905ceed0c2f9 Reviewed-on: https://gerrit.libreoffice.org/26376 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-17comphelper lok: remove the g_bViewCallback globalMiklos Vajna
Its purpose was to allow incrementally migrate all callers of SdrModel::libreOfficeKitCallback() to use SfxViewShell::libreOfficeKitViewCallback() (which allows notifying only the currently active or all views) instead. That is done by now, so it can go. Change-Id: I521bbbe5c638dfd844ebf025153459a37362d3c3 Reviewed-on: https://gerrit.libreoffice.org/26413 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16[GSoC] Member function to identify PatternRishabh Kumar
Change-Id: I72ca21204248bfe279445f01ab247f19ec958fb1 Reviewed-on: https://gerrit.libreoffice.org/26361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-06-16Resolves: tdf#82532 parent mutex dtored before child dtor uses itCaolán McNamara
Mutex belonged to DisposeListenerGridBridge which inherits from FmXDisposeListener, FmXDisposeListener dtor accesses a reference to the parent mutex in its dtor, but the mutex has been destroyed at this point. Move the mutex from parent to child. FWIW these classes are on the candidate list to merge. Change-Id: Ic639eaed97c2b0625c368ed249f09920af37f94e
2016-06-16tdf#85949 Add 1.15 to the Line Spacing dropdownSamuel Mehrbrodt
Change-Id: I45b63522c43086f62f451ea0a17e8bdd15911ea1 Reviewed-on: https://gerrit.libreoffice.org/26369 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-16tdf#94724: Make Gradient and Hatch preset names consistentRishabh Kumar
Change-Id: If191fe7dd5a3986a5f75e149d2d37c36c1256b04 Reviewed-on: https://gerrit.libreoffice.org/26277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-15sfx2: bring the view shell's LOK callback up to date with SdrModelMiklos Vajna
This fixes CppunitTest_sw_tiledrendering in the LOK_VIEW_CALLBACK=1 case. Change-Id: Ib79e57908c3edda0154341baba8279ede4281a42 Reviewed-on: https://gerrit.libreoffice.org/26313 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-15Resolves: tdf#91603 if we cancel/discard recovery dialog, continue as normalCaolán McNamara
Change-Id: Ifd5df74063bcaf2f3a198b090ed2126449d7b8f8
2016-06-14tdf#96505 Get rid of cargo cult long integer literalsapurvapriyadarshi
removed 0L and make it 0 Change-Id: I7adf48009bf67c2cf0ac43cc05285075bb1d85ce Reviewed-on: https://gerrit.libreoffice.org/25600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-14svx: implement per-view LOK_CALLBACK_TEXT_SELECTIONMiklos Vajna
To fix table shape selections. Change-Id: I85810c20b8cc51646d3c8a8b974d0e8a4f96d1ae Reviewed-on: https://gerrit.libreoffice.org/26242 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-12convert more DBG_ASSERT(false to SAL_WARNNoel Grandin
Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55 Reviewed-on: https://gerrit.libreoffice.org/26195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12convert DBG_ASSERT(false, to SAL_WARN(Noel Grandin
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c Reviewed-on: https://gerrit.libreoffice.org/26187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-10Clean up uses of Any::getValue() in svxStephan Bergmann
Change-Id: Ie0b253227df8ea4bd24643aa2622afadabf4eb54
2016-06-10editeng: implement per-view LOK_CALLBACK_INVALIDATE_VISIBLE_CURSORMiklos Vajna
Given that the per-view callback is in SfxViewShell, and editeng doesn't depend on sfx2, add an interface class in editeng to invert the dependency. With this, gtktiledviewer no longer crashes when starting editeng text edit with per-view callbacks. Change-Id: I783cdc646b890a6b597000f1d88428c8042417cf Reviewed-on: https://gerrit.libreoffice.org/26169 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-10tdf#87667 If image is cropped, set cropped size as original size.Gulsah Kose
Change-Id: Ief76037f087a2225442294b972d331fc4476bbec Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/25486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-06-10Move accessibility relations to .ui files, Part 8: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/function calls, and making proper changes in the related .ui files. Change-Id: I04244b360b4bb32ccbbe5bde4756a9166ae1fcaf Reviewed-on: https://gerrit.libreoffice.org/26018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-10dispose of ImplEscherExSdr correctlyNoel Grandin
to remove the warnings messages, and turn the warn into an assert to prevent it coming back Change-Id: Ie754ac07f8bb505439a1194f843d09c396353aa6
2016-06-10svx: implement per-view LOK_CALLBACK_TEXT_SELECTION for graphic selMiklos Vajna
Handle multiple views when clicking on a graphic, and thus sending a "text selection is now empty" callback. This avoids an assert when clicking on a Writer image in gtktiledviewer. Change-Id: I2b6d7e561ccc4a6e0782fdad37d4b104c08f1eeb Reviewed-on: https://gerrit.libreoffice.org/26152 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-10loplugin:mergeclasses SdrItemBrowserNoel Grandin
Change-Id: I90c6006be05f182fd442ce8d3641f4f17cdb6793
2016-06-10svx: implement per-view LOK_CALLBACK_INVALIDATE_TILESMiklos Vajna
This is the last callback that was unconditionally invoked on the model on load, before the SfxBindings timer starts. Change-Id: Id494963459ac2bee4d0f9e642af88e04e94353c3 Reviewed-on: https://gerrit.libreoffice.org/26129 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09svx: implement per-view LOK_CALLBACK_GRAPHIC_SELECTIONMiklos Vajna
With this, selecting an image sends the selection callback only to the relevant view. Change-Id: I0d5d611b969715d8eafa8d813202984acff32fbd Reviewed-on: https://gerrit.libreoffice.org/26112 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09svx lok: assert that per-view callbacks don't invoke the model callbackMiklos Vajna
They should invoke SfxViewShell::libreOfficeKitViewCallback() instead. Change-Id: Ie7150e9decb40de917a5257aa4090595bdc5e387 Reviewed-on: https://gerrit.libreoffice.org/26108 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09ditch SIP_SA_AUTOGROWSIZECaolán McNamara
put SIP_SA_CHAINNEXTNAME into that position to keep this list in the same order as the SDRATTR_TEXT_ list Change-Id: I6be4b373d188a2a6e4cd52cc1c8a18f3f9514503
2016-06-09Resolves: tdf#93135 there is no SDRATTR_TEXT_AUTOGROWSIZE propertyCaolán McNamara
as far as I can see there is no use of SDRATTR_TEXT_AUTOGROWSIZE anywhere, just a reuse of SDRATTR_TEXT_AUTOGROWHEIGHT for a different mechanism to resize the surrounding shape to fit text in custom shapes. Note there is another different feature to resize text to fit into its frame of SDRATTR_TEXT_FITTOSIZE. Change-Id: Icf08966c70ef79271f462da7d4b2c6e8e855d5df
2016-06-09tdf#89329: use unique_ptr for pImpl in dataaccessdescriptorXisco Fauli
Change-Id: I0d04c23b8760ce2e7df9523d99a1fd862e501038 Reviewed-on: https://gerrit.libreoffice.org/25938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08loplugin:passstuffbyrefStephan Bergmann
Change-Id: I637e1c9d5af1f9d8ad5141c8d07ea72232656070
2016-06-08tdf#100269 svx: fix undo of table column resizeMiklos Vajna
SdrTableObjImpl::LayoutTable() assumed no re-layout is needed in case the total width of the table and the number of columns is the same, but undo of resize is a situation where we also need to check the individual widths of the columns, otherwise layout won't be up to date. Change-Id: Ia5ebb05af79dda1c0d8c5bb10e7f37f81ee1d035 Reviewed-on: https://gerrit.libreoffice.org/26061 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-08Related: tdf#100269 sd xml dump: expose layout of table shapesMiklos Vajna
So that it's possible to assert the layout from cppunit tests. Change-Id: I09631f978ed44bb1c27806089b6d69c70db643c3 Reviewed-on: https://gerrit.libreoffice.org/26054 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-08tdf#96099 Remove various smart pointer typedefsMark Page
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f Reviewed-on: https://gerrit.libreoffice.org/26014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08remove "object is disposed" warning in OBroadcastHelperVar::removeListenerNoel Grandin
doesn't add anything of value. Change-Id: Ie2dea7c43570640284771c992d0072ab61de425e Reviewed-on: https://gerrit.libreoffice.org/25871 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08Apparently a copy/paste typoStephan Bergmann
...introduced with 1ffd7e1accbee482d4bb6698d4ad145d8a6a780d "INTEGRATION: CWS impresstables2". Change-Id: I7303a63c16c819c8fd808ffc43008c3ab3402819
2016-06-07tdf#89329: use unique_ptr for pImpl in unoshapeXisco Fauli
Change-Id: I1a7a7b68f58430d0975087b0f7c7ab36dc29a686 Reviewed-on: https://gerrit.libreoffice.org/25966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-07Any::getValue always returns non-nullStephan Bergmann
What this code looks like it wants to do is check whether rValue is either a Sequence<sal_Int8> or else a Reference to XBitmap or XGraphic. It was introduced with 1ffd7e1accbee482d4bb6698d4ad145d8a6a780d "INTEGRATION: CWS impresstables2" which mentions "fixed merge error" multiple times in the commit message. Change-Id: I81467074efb433e0b52eb82e2c81d4b5890e67e9
2016-06-07Move accessibility relations to .ui files, Part 7: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/funciton calls, and making proper changes in the related .ui files. Change-Id: I059bf02bc6ea29bf1b92d21f5a10a76548ecd1fc Reviewed-on: https://gerrit.libreoffice.org/25973 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-07Remove unnecessary strings in bmpmask dialog tdf#87026Muhammet Kara
By moving accessibility relations to the related .ui file, and deleting calls to SetAccessibleName where possible. Change-Id: Ic2b309d54d3579158bdf33468f0895ca2b2a393e Reviewed-on: https://gerrit.libreoffice.org/25956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-07tdf#89329: use unique_ptr for pImpl in float3dXisco Fauli
Change-Id: I80eb64cd91651f521fb6dba6bef22dc1d77188e1 Reviewed-on: https://gerrit.libreoffice.org/25937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-07tdf#89329: use unique_ptr for pImpl in svdoole2Xisco Fauli
Change-Id: Ie189576336e0670102d7675b59f30e3fc357671d Reviewed-on: https://gerrit.libreoffice.org/25942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>