summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2017-12-18vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49 (cherry picked from commit 6bb20609a2fd1d591cedc7fa2b9cabb589c346c7) (cherry picked from commit 03bfafb36107d18c0cccf53efdd550c0b7a81b8f)
2017-12-18use o3tl::typed_flags in ConfigurationListener::ConfigurationChangedNoel Grandin
Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e (cherry picked from commit 04a84913ead2f82510d91eea2bb8526274feeeae) (cherry picked from commit acd0975a4e660096d6c575e8db022e96c7680aca)
2017-12-18convert SFX_VISIBILITY constants to scoped enumNoel Grandin
* split the position and the flags information * remove unused DESKTOP constant Change-Id: Ibfccb44c7567e89d4527bfd36b3915a73682e6e2 (cherry picked from commit 5af0071d42e5962ed849261134ef0630c7ec3b45) (cherry picked from commit 82577130d5a1e40396053e86fd0d7beb14170fbd)
2017-12-18convert DecodeMechanism to scoped enumNoel Grandin
(cherry picked from commit bfde4866e07746eafa2f0d6173c29d805cc35ad0) (cherry picked from commit 3de922d4a695e253d4ca2d42b70e0b35b52e9b7c) Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2017-12-18convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
(cherry picked from commit 803215142efa6437515348f63bd70ffdcf5d45f1) (cherry picked from commit 736cd289d4cdb0db61d92134bcc9d48aa7e79613) Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2017-12-18convert PolyFlags to scoped enumNoel Grandin
and remove the XPolyFlags enum, which has the same values and was being converted to PolyFlags anyhow Change-Id: Iaead84933c79a7603698a4e50257dd944df89c41 Reviewed-on: https://gerrit.libreoffice.org/31627 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a08cb3b52ea4a071ce8eb5a1786ea45fd211ab78) (cherry picked from commit e13bb8d5290b27281d7742a9b7034929561d51aa)
2017-12-05simplify Bitmap operator==/IsEqual (stage2)Noel Grandin
Now that we've sorted out which bits are rightfully internal (see commit 7a4064cf87d23bffac987b3e39bf87d9b4d158fc), and which bits need a comparison operator, rename IsEqual to operator==. Change-Id: Iec229a7571d76ee18fbc0a4fe672cc2e50a44948 Reviewed-on: https://gerrit.libreoffice.org/42851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 09917566b6ce86ea65a246f2055b5d1f41df4e76) Reviewed-on: https://gerrit.libreoffice.org/45456 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit f641e9d9f472110ccb61c01210e8acf280ad9bf3)
2017-12-05Fix typosAndrea Gelmini
Reviewed-on: https://gerrit.libreoffice.org/42726 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit e44c188a7353cc183fac8ece0cbf3611d842835e) Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2 Reviewed-on: https://gerrit.libreoffice.org/45454 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 50e37a41acae8597fdb097715f8b76b16bce9f31)
2017-12-05remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin
Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2e8acde112e1c6754df26902e79a78346ba45a2d) Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/45452 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 2887aefa4d4f60ba8b0cd7efd5d3a73ffb209781)
2017-12-05remove UL/L suffixes from shift-by-constant expressionsNoel Grandin
Change-Id: Ia470f643e3eefeccc14183133603db260460bd53 Reviewed-on: https://gerrit.libreoffice.org/41212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 224b770fa77fe12ad5dc543ce020aca316b6558d) (cherry picked from commit 58c171983d4f828d36bf1f6d8fb8329e69424c7e)
2017-12-05tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c (cherry picked from commit 9e51007039770370182839846676b205f5c34c57) (cherry picked from commit a090e1e17962c5ca95f66c9d18fca6ac5dd4bca0)
2017-12-05convert BmpConversion to scoped enumNoel Grandin
and drop unused 4BIT_TRANS and 1BIT_MATRIX enumerators Also fix a bug in x11::convertBitmapDepth where we were incorrectly passing BmpConversion enumeratirs to ReduceColors Reviewed-on: https://gerrit.libreoffice.org/34062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b5699cd01b6a52906880c107bac6f3802ea7353d) Change-Id: I903c6866750e46ee752e10a17c05fcaaf6b11242 (cherry picked from commit 2d171734f349c0f9868106f57f5644a70fbeb945)
2017-12-05convert BmpCombine to scoped enum and drop unusedNoel Grandin
Change-Id: Ic67474683a25a25e5753777f4bbbeded6ceba414 Reviewed-on: https://gerrit.libreoffice.org/33793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 52360bf8dd567598593cb212ac85f0c919315618) (cherry picked from commit af8e50a21ad47aa15fe3773c053735f8321fcf46)
2017-12-05new loplugin: useuniqueptr: vclNoel Grandin
Reviewed-on: https://gerrit.libreoffice.org/32948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e8b49f09074fe184374bee5062715357427ae044) Change-Id: Idcbc8655108ff57c06c33bbcabd652387bf3c4ec (cherry picked from commit fb68934e81bebdf1580d0fad25fad8912eaf3450)
2017-12-05convert BmpFilter to scoped enumNoel Grandin
Change-Id: I22c5b49f108d4ce103dea5098a2a0dc9d6bc854c Reviewed-on: https://gerrit.libreoffice.org/32292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 41f7878ccbc457ef0431c999d38d9d77265d5dc7) (cherry picked from commit 36b35a92b44b65756e594d67354fdb75f385825a)
2017-10-26tdf#97630 xmloff: ODF extended draw:fit-to-size messMichael Stahl
The plan: 1. As Regina points out, there is already (in ODF 1.2, but not ODF 1.1) a style:shrink-to-fit attribute for shapes, so use this to represent the AUTOFIT value. The fallback from AUTOFIT to draw:fit-to-size="true" was a stupid idea anyway, probably "false" is less annoying in practice. There are 2 different shapes that implement TextFitToSize property: a) text shapes already interpret ALLLINES and PROPORTIONAL exactly the same b) fontwork custom shapes interpret ALLLINES but do nothing for PROPORTIONAL As Regina points out, there is no shape that needs to distinguish between ALLLINES and PROPORTIONAL, so we do a minor behavioral API CHANGE and from now on interpret PROPORTIONAL as ALLLINES on fontwork custom shapes. This obviates the need to distinguish the values in ODF and so we don't need a new attribute, just use draw:fit-to-size="true" for both. On import, use MID_FLAG_MERGE_PROPERTY to combine the 2 attributes into one value. 2. Restrict the export of draw:fit-to-size to only the standard values "true"/"false". This implements step 1, the step 2 will be done in the future when most users have the import of the style:shrink-to-fit. Reviewed-on: https://gerrit.libreoffice.org/43521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 33eb9fdb61033b3fd35d923900b1f5791f4b71c8) Reviewed-on: https://gerrit.libreoffice.org/43596 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 244dfe2f3fa874d99dacea191e2265a288457a98) Change-Id: I4a378aa110fdb82db7a99a839d7ff207248a73e7
2017-10-26Resolves: tdf#113214 change back to previous entry after 'more' is dispatcherCaolán McNamara
Change-Id: Ic5bd5f9182e47c6dfdab8fcd6399ffc482a4fb6a Reviewed-on: https://gerrit.libreoffice.org/43512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7ff293f2d2793b30f30d2f499b332e5329d4ddb4) Reviewed-on: https://gerrit.libreoffice.org/43518 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 91a2e5f1193d6b20d871f2b8a3467a1301ca3f81)
2017-09-14Resolves: tdf#106163 safe fix for wrong final row/col selection in rtlCaolán McNamara
Change-Id: I773de03768b0a5b28e6b4f63bd65dd270dc975cd Reviewed-on: https://gerrit.libreoffice.org/42199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit a3ea07e14bab234ee04c441e0dca7a9d12dc7a9b)
2017-09-14implementing callback for ruler invalidationAditya Dewan
adding commands to fetch and changee ruler state '.uno:RulerState' and '.uno:RulerStateChange' Change-Id: I66107039a7ae5893691feb45c8ab2e4aa476ea76 Reviewed-on: https://gerrit.libreoffice.org/40727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-09-01Resolves: tdf#112017 crash on particular odtCaolán McNamara
Change-Id: I6ba2e73562a16afecb6abdfe4f1a40b1e316379e Reviewed-on: https://gerrit.libreoffice.org/41712 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 932a81e9c31a3a5bf5edad3d9e79b111e19b113d)
2017-08-21tdf#85909: EDITING: Native tables visualization not refreshedTamás Zolnai
... after changes to borders Regression from: 26b06662ebc3e5d664400bc95c39d6220de03136 "avoid repeated table layouting (fdo#75622)" It was a performance change, but it was a bad idea to avoid table layout refresh on this way Anyway I added a call for border update even if not all the table layouting is done. I tested with the test document attached to fdo#75622, import time seems similar so it does not cause perfromance issue to do that. Change-Id: I7c6fcf105c89233512390dc2ecbd111a32f6779a Reviewed-on: https://gerrit.libreoffice.org/41116 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 3f72879a8e54e18f3ad587f7284b84db592c8d1a) Reviewed-on: https://gerrit.libreoffice.org/41120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 296a15773bec15c6aedec1a6be7b938fb60adc58)
2017-08-03lok - add support for in place chart editingMarco Cecchetti
This commit add a minimal support for editing chart embedded in a spreadsheet or a text document or a presentation. Graphic object can be moved and resized, text object can be edited. Change-Id: I8e637dabf328a94bd6bb0e309a245302cff421d8 Reviewed-on: https://gerrit.libreoffice.org/40681 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-31Resolves: tdf#109289 add SvxColorListBox::IsValueChangedFromSavedCaolán McNamara
and remove PushButton::IsValueChangedFromSaved (cherry picked from commit 39fd7e97c253153a10161ef3694b64e90e65e80a) Related: tdf#109289 move PushButton::IsValueChangedFromSaved to consumer inheriting the IsValueChangedFromSaved from PushButton has allowed undesirable behaviour to be selected (cherry picked from commit 247607727986df0fd0fef198459eb6646e056ea3) Change-Id: Ib1c51e27fd708c5d4811c90ef5659b4d55dd8860 fccb1657d2565005e6f9e239c6118f2e5ae7970c Reviewed-on: https://gerrit.libreoffice.org/40486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit d747a00f550cc8556e29b29b08c57f84afb4078f)
2017-07-31fix image map item idsCaolán McNamara
broken since... commit 4bbf35572d94efe8b321e3159e9810f52bc3f9f8 Date: Mon Jul 7 11:24:48 2014 +0200 RID_SVXDLG_IMAP conversion to .ui Change-Id: Ic08b82af0b8890fb910153c87fb170618d95f34f Reviewed-on: https://gerrit.libreoffice.org/40407 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit a8f791ec013d9b703d12eb9f045e42d9b0e8bd1f)
2017-07-31svx: make SdrGrafObj::mpReplacementGraphic swappableMichael Stahl
These GraphicObjects clog up the GraphicManager cache so it's effectively useless. Round-tripping the ML bugdoc, this doesn't provide much of a speed-up by itself, but together with the previous fix it goes from 3:00 to 1:30 (in an optimized build). (cherry picked from commit c96e3e226fe4eb8f25c54cce4d653d12eda63ce2) Reviewed-on: https://gerrit.libreoffice.org/39967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit c60344481a60f77ff86e7e5f1f1e952f7ba76d90) Reviewed-on: https://gerrit.libreoffice.org/40178 (cherry picked from commit 142ab1c3e452109d2e5143d26abc6f13e904d7a7) Change-Id: If52e176c790b94ffef9984be53376a34345b06e3
2017-07-28support for filter dialog when an image is exported from context menuMarco Cecchetti
When user save the selected image in a non-vector format the filter dialog used in Draw pops up for filter setting. Conflicts: svtools/source/filter/SvFilterOptionsDialog.cxx svx/source/xoutdev/_xoutbmp.cxx Change-Id: Ic98b48a47322e807627b7a2ccd8044ec0db30efc Reviewed-on: https://gerrit.libreoffice.org/40243 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-13tdf#109050: Moving table object with ALT+Arrow keys does not work properlyTamás Zolnai
ALT+up/down behaves differently inside a table: cursor is moved to the left/right neighbouring cell instead of up/down. However when the whole table is selected a different behavior is expected: moving the table as an object. Change-Id: I82c7a3cc7d215b21f19fbf08dcdb7318a7e75289 Reviewed-on: https://gerrit.libreoffice.org/39810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit f5637ae74ad6bb517255510a8ae786fd2a3cf977) Reviewed-on: https://gerrit.libreoffice.org/39839 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-07-12svx: assert on undisposed AbstractSvxHpLinkDlgMichael Stahl
3 in () at /lib64/libc.so.6 4 in VclPtr<AbstractSvxHpLinkDlg>::~VclPtr() (this=0x88d47e8, __in_chrg=<optimized out>) at include/vcl/vclptr.hxx:115 5 in SvxHlinkDlgWrapper::~SvxHlinkDlgWrapper() (this=0x88d47a0, __in_chrg=<optimized out>) at include/svx/hyperdlg.hxx:34 6 in SvxHlinkDlgWrapper::~SvxHlinkDlgWrapper() (this=0x88d47a0, __in_chrg=<optimized out>) at include/svx/hyperdlg.hxx:34 7 in SfxChildWindow::Destroy() (this=0x88d47a0) at sfx2/source/appl/childwin.cxx:182 8 in SfxWorkWindow::RemoveChildWin_Impl(SfxChildWin_Impl*) (this=0x6c83940, pCW=0x683bc20) at sfx2/source/appl/workwin.cxx:1425 9 in SfxWorkWindow::ToggleChildWindow_Impl(unsigned short, bool) (this=0x6c83940, nId=5678, bSetFocus=true) at sfx2/source/appl/workwin.cxx:1832 10 in SfxViewFrame::ToggleChildWindow(unsigned short) (this=0x6afdae0, nId=5678) at sfx2/source/view/viewfrm.cxx:2964 Change-Id: I84a1ba817dc8449dc1942b6ebd443ec955e8c622 (cherry picked from commit 07341af48ed8ec2368aee87d120942f3e6bb6d49) Reviewed-on: https://gerrit.libreoffice.org/39805 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit c9b3f21706e5cfc2f49c52a6d04d7b342ea543e0)
2017-07-07tdf#107505: Impress - crash with two people co-editing one slideTamás Zolnai
In tiledrendering mode cursor inside shapes are not handled very well now. Different LO instances manipulates the same cursor instead of having one separate cursor for all instances (as in case of simple text editing in Writer). Crashes caused by that one cursor is owned (created and destroyed) by one LO instance but used by an other instance in the meantime. We can avoid this by not making this cursor available to the other instances. Cursor is hidden anyway so don't need to have it set to the corresponding Window. Change-Id: Id78f79e73eda88f3c2c6aa7f534c32f3f8aba174 Reviewed-on: https://gerrit.libreoffice.org/39432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 258df6f41d89a606a980942df6337d446634c0a6) Reviewed-on: https://gerrit.libreoffice.org/39436 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-07-05support for saving a modified image instead of original versionMarco Cecchetti
Normally when you save an image through the "Save..." entry in the context menu for an image, the saved image is the original one more eventually applied filters (which are not removeable). Further applied transformations like rotation, cropping, color effects are not included in the saved image. This patch offers the user to choose if saving the original image (with filters) or the modified version through a pop-up dialog. The new feature is available in Writer, Draw and Calc. Change-Id: I4f983e3a5e8a6839fa5789a96c4d8c44477c1fd7 Reviewed-on: https://gerrit.libreoffice.org/39487 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-27Resolves: tdf#108419 use spinfield preferred size as transparency widget sizeCaolán McNamara
Change-Id: I7b5c8aeb087efe007c687dc1f206bcb0e8b0173e Reviewed-on: https://gerrit.libreoffice.org/38866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 459914cd491598c32cad203fed6c7b90491f6a52)
2017-06-27tdf#93968 bullet char style preview is unreadable, cause uses opensymbolCaolán McNamara
Change-Id: I1bd0a0e85c9d956184680d7e15709b3a7b590c30 Reviewed-on: https://gerrit.libreoffice.org/39010 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/39053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit d8e6d7a86adb102ae1bb4df99ef73ebead962105)
2017-06-18tdf#107666: EDITING: No caret outside the textbox after inserting a textboxTamás Zolnai
This reverts commit 44555103217df34b218787f3dc6a2634b41fe52e. Now revert the related commit, need to revisit the original bug later. Change-Id: I08f42c4e859277ab411e4be5ad065fe3cca8bbb6 Reviewed-on: https://gerrit.libreoffice.org/38927 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-06-13tdf#108480: Undo from clone formating does not remove vertical alignmentTamás Zolnai
In the related change: d36aa2ba3132ce62a370b7260ca620642cbf7dbf wrong method was used to set cell properties, which does not handle undo actions, so use the proper function. Other issue was related to undo handling of vertical text alignment in general. In some cases undo actions were lost after user clicked out of the cell. It is because vertical alignment is not affecting the outliner and so the related undo actions were just dropped in EndTextEdit() method. Reviewed-on: https://gerrit.libreoffice.org/38699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 37d8ac12902506f4185e10f1de4f566dbaf53e42) Change-Id: I3a6a95fac711056a658a3dee616733939cd13330
2017-06-06tdf#101885: fix crash in AccFrameSelectorcp-5.3-16Julien Nabet
Deal with no parent case 0x00007ffff5e98240 in vcl::Window::GetChildCount() const () 0 0x00007ffff5e98240 in vcl::Window::GetChildCount() const () 1 0x00007ffff54f2d1f in svx::a11y::AccFrameSelector::getAccessibleIndexInParent() () See https://bugs.documentfoundation.org/attachment.cgi?id=127141 Change-Id: I795dc4c083d743466b5605d3dcc8f9fca8674c43 Reviewed-on: https://gerrit.libreoffice.org/37575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit c9275062ed745a8c5d52a3863299baf8bcf86ea7) Reviewed-on: https://gerrit.libreoffice.org/38414 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 75d14731e79b66a75e2d3327b94721f6218eb4d7)
2017-06-01Related: tdf#107961 ensure notifyhdl is unset after disposeCaolán McNamara
Change-Id: I69790c8d3cfffc09ee6d6c165e17823223c5058a Reviewed-on: https://gerrit.libreoffice.org/38238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit cbd8fd58c6d5ad40561b936b1c7f3b75f518b6c2)
2017-05-31tdf#100072 zero height of shape's path was causing geometry errorsVasily Melenchuk
DOCX custom geometry shape's path width and height are now used independently for scaling calculations. Reviewed-on: https://gerrit.libreoffice.org/37639 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 5477f7274e4df1210298c0f503a54eabc0f06bfc) plus: tdf#100072 extra test for DOCX shape import with zero height Corresponding bug is already fixed in tdf#107104. However created tests do care only for width, but not for height, like we have in this testcase. Reviewed-on: https://gerrit.libreoffice.org/37538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit cffc5a04661fc0a84dff9fa5da954236d88a8b38) Change-Id: If5d5499f402379df125b0f31dd071ca51b2553f1 Reviewed-on: https://gerrit.libreoffice.org/38224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 9c3100a4b9f258a7dc0aff93bc01fa39f7501d2c)
2017-05-30Resolves: tdf#107981 SID_FM_CTL_PROPERTIES colorbox needs a 'default' entryCaolán McNamara
we don't need MakeHexStr either, the colorbox will do that on its own Reviewed-on: https://gerrit.libreoffice.org/37898 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7539c77fd49889015ad3a952009e33fac5324df6) Change-Id: Ifad523092c0f15cd51d0d829790c0cec1c96bb53 Reviewed-on: https://gerrit.libreoffice.org/37905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit c05f35f4f56a1e65b92f4b1bc43b0fa6138d209c)
2017-05-30make SfxGetpApp just get and move GetOrCreate to the peripheryCaolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/34957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry-picked from commit 3d213b3dc5130bdbacbd64be00867eecad6373e8) Conflicts: svx/source/gengal/gengal.cxx Change-Id: If3b22635e46dbccf0fad101f51bb653cbbcd3a32 Reviewed-on: https://gerrit.libreoffice.org/38166 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-05-16fix gdi resource leak (svx/compressgraphicdialog)Julien Nabet
Change-Id: Iea6e481384cee4d7e2ff6787c64d3048ba9c9d65 Reviewed-on: https://gerrit.libreoffice.org/37587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 68a1cb23ede1d4ae6195850190fca6953c30417f) Reviewed-on: https://gerrit.libreoffice.org/37592 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit c41d6c4db6a29fb85b4547b0cf04b3693c472764)
2017-05-16fix gdi resource leak with unreleased virtual deviceMarkus Mohrhard
Change-Id: I1fd8c76a206cfc940e3d646e4025618785985e52 Reviewed-on: https://gerrit.libreoffice.org/37583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 289711c2a469bfbe06aef3b3870b65f9c788f56d) Reviewed-on: https://gerrit.libreoffice.org/37585 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit e4fdaa5d9a7b0c507278ef70aab7ce4c9e7ee62d)
2017-05-16tdf#107706 fix crash when closing Calc documentNoel Grandin
regression from commit e8b49f09074fe184374bee5062715357427ae044 "new loplugin: useuniqueptr: vcl" Change-Id: I07ac157a02aa82b1ddbb741797fea093772f93f1 Reviewed-on: https://gerrit.libreoffice.org/37497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2ff893426093652221a8602e71c7924c46d3386f)
2017-05-07Collabora Office: remove Safe Mode from menus and Windows start menuAndras Timar
Change-Id: I9eaf6ef76597be6bc35462308f1cee61cb9bae5a
2017-05-05don't show inaccessible crashreport linksAndras Timar
Change-Id: I3c4ed28cb1a02049fb009f576943f80b8ba8e627
2017-05-02tdf#107505: Impress - crash with two people co-editing one slideTamás Zolnai
Deleting outliner view removes the pointed Cursor (pTECursorMerker). Change-Id: Iac17386d1d02bf52bd5322073e49da05c6e89d9b Reviewed-on: https://gerrit.libreoffice.org/37085 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 44555103217df34b218787f3dc6a2634b41fe52e) Reviewed-on: https://gerrit.libreoffice.org/37097 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-04-24lok: When we actually have the OutputDevice, prefer that.cp-5.3-7Jan Holesovsky
Writer invalidation functionality depends on this actually. Change-Id: I0933c56ff3999a09118112ccf49bf00062c42444 Reviewed-on: https://gerrit.libreoffice.org/36914 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-04-18tdf#105286: Implement text rotation for Impress tablesTamás Zolnai
Typo: TopToBotton -> TopToBottom Change-Id: I1b4d3ab9ec1d1383d76a56c9662ffeeb9fe69655 Reviewed-on: https://gerrit.libreoffice.org/36014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 334e6e2f1ad3da319be0849ec426aa64b18cb599) Add SvxTextRotateItem inherited from SvxCharRotatItem I will be use it later for text rotation inside a table. Change-Id: I4cbaf05953b0e71331d2f3fdb45b7c4254a2b8cc Reviewed-on: https://gerrit.libreoffice.org/36021 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 1e30d2aface12a31687e5a27126e2061efd4b0cd) Introduce text rotation for Impress tables * Introduce new table property for text rotation * Support only two rotation angle (270° and 90°) * Implement editing and rendering of 270° rotated text (90° rotation was already implemented) (cherry picked from commit c671094154ecec6f3ba5beea9d26ff0d2d4d86ad) Change-Id: Ifc2e0f171e9c840e86b365e9af2c30aa97ecd92e Implement RotateAngle API property for Impress table cells (cherry picked from commit a0755ab8772d01797f4945016a978a2bbd8fdf20) Change-Id: I01379c0fc21e8fe294bc882bf824f64502863ff4 tdf#100926: PPTX import of table with rotated text (cherry picked from commit 2436cf17304f25c7d34da52a321d6da0e9011d19) Change-Id: I05a8e979ac11b179e15784023032a56edc5b569b ODF import / export of rotated text in Impress table (cherry picked from commit bcb371b1a830442610ad7fda476eda5271427a50) Change-Id: I57136e32ed2db5e405a45e8e4bad1b8d459b7ae8 Fix vertical text and bitmap bullet rendering Change-Id: I881fce0511c81b164516d68f72c7e750687d4e0e (cherry picked from commit 15ac3f9f4dc65fc0c6020284064e3725956f5d0a)
2017-04-18LOK - Calc: commit 92716ab follow-upMarco Cecchetti
This patch is a follow-up for commit: 92716ab (Images are not painted below row 1000). There is no need to set the origin to (0,0) when checking the view range / object range overlapping. Change-Id: Id9fe9364155edd5a50c2d60ab08dd0bdcd1f568a Reviewed-on: https://gerrit.libreoffice.org/36588 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-04-12fix previous commitAndras Timar
Change-Id: I204f83aede085bbe4f5bd6937238b2117e51c86a
2017-04-12Collabora Crashreport DialogAndras Timar
Change-Id: Id44e446684993984cf5778c82eb0a990bdd2f465