summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-06-26update some pchesCaolán McNamara
Change-Id: I54b734062d94a59c2651827c02349d9562ac6cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26tdf#134285 select the item before dragging itCaolán McNamara
so we don't get the previously selected item Change-Id: Ifd6e46d97f1de0de86403b9c237ee8d2cd3a6cd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97187 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-25update svx pchCaolán McNamara
Change-Id: I70b0ac22454aefc03d9cca04c576704f7abdb73c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97182 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-25weld NavigatorTreeCaolán McNamara
Change-Id: I019021fa5a522b1238d74702c9222afdfd7540c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96961 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-25nActiveTerm is -1 in an empty filter navigatorCaolán McNamara
Change-Id: Ia6eed6291375f136abbe8e50abae51e6f796911f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97080 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-25tdf#134291: make all hatch patterns translatableJulien Nabet
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=30a6e9e991fd1b62ead2d393331a0364372c52fb tdf#130928 Area Fill update hatcch section Change-Id: I75377f86bb8eafc24d739073e0341168637f7d62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97093 Reviewed-by: Sophie Gautier <sophi@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-06-25Get the property dump of the text at the cursorShivam Kumar Singh
We need the property dump consisting of 1) Character Properties 2) Paragraph Properties 3) Character Style Properties 4) Paragraph Style Properties This patch gives all the properties related to 'Character Styles' at the cursor. This patch manages inheritance features, which means, it lists any property only at that level in which the property has been redefined for the last time. Change-Id: Ice2ae9ac92aec4af9d395885e06602753e636457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95094 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-25use tools::JsonWriter for dumping property treeNoel Grandin
Change-Id: I8f55af19ba10b71bd621e69b27000ab7cb565309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96677 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-25loplugin:unusedfieldsNoel Grandin
Change-Id: I7d8cd41c6b4b97a6d33764a8580f08413e584a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-24show warning for a bad colorCaolán McNamara
Change-Id: Ib0b43e6d27e32e5fef97b3ee003614ec7d8c3500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97047 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-24two entries missing use-underline propertyCaolán McNamara
Change-Id: Ia6e6b73a9bb4948e3938105ffffa1d912bca5b61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96979 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-24use more std::container::insert instead of std::copyNoel Grandin
which is both more compact code, and more efficient, since the insert method can do smarter resizing Change-Id: I17f226660f87cdf002edccc29b4af8fd59a25f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-23inline typedef WeakSdrObjectContainerTypeNoel Grandin
Change-Id: Icdbdc73552b81a71d2551c36f54218deba6149bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-23weld DataNavigatorCaolán McNamara
Change-Id: I78241701de0756f5fe9bc9b793dadccd4ae119d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96750 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-23svx:Refactor members of GalleryTheme class to GalleryBinaryEngineAditya
Move those data members and functions in GalleryTheme that deal with reading and writing of binary files to the new class GalleryBinaryEngine. These internal changes must not reflect any change in the behaviour. Functions moved in this patch: ImplReadSgaObject(), ImplWrite(), ImplCreateUniqueURL() Change-Id: Ifd30bc7920f31007dfe7fe2ffdc539dfc43976ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96541 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-21weld DateField Calendar floating windowCaolán McNamara
Change-Id: I8d839a09b787e2b8ac1389633a39a3cd969fb1c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96816 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-19tdf#134084 use the desired image size, not the current image sizeCaolán McNamara
when updating the color bar Change-Id: I6bf76a38adc034a25c0c31833c14f2b6afe3ec6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96738 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-18weld SvxUndoRedoControlCaolán McNamara
Change-Id: If78886a40243da01109364d8df02fb664fd1f011 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17don't highlight the row under the searched for pointCaolán McNamara
Change-Id: I6f3bfdb25c335735a70bc78c5167e88d5dbb4ddb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17tdf#133807 re-present search dialog after a short timeoutCaolán McNamara
Change-Id: Icc6016b3a9e3f25fd4c9e065e9f2d9570ad040c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17svx: Refactor GalleryTheme classAditya
Change-Id: I60ce3b5a9ca5a28e499015c3ac118d2f6a091f16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96527 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-17Styles preview widgetSzymon Kłos
Change-Id: Ib9723c9793244069407ceaa4935a11da08db3795 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95998 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-06-16Remove some unused includesMiklos Vajna
Change-Id: Iba6d787de4b61c71ce9edbfed748aeae2b7f1f39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96407 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-15svx:move functions from GalleryThemeEntry to GalleryBinaryEngineAditya
These functions deal with reading and writing of binary files. They need to be moved because code is being refactored. This change should not result in any change in the external behaviour. Change-Id: Ib21f8df8d1f038993af4f7142cac5a25f0eac87e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96253 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-14tdf#103474 handle edge cases in ARCANGLETORegina Henschel
The arc-polygon generation in tools does not consider edge cases with zero height or width. That leads to wrong rendering in some ooxml shapes, when the handle is dragged to its extrem position, e.g. in left/right braces/bracket and can. I have switched from tools to basegfx in case ARCANGLETO and added handling for edge cases. Switching to basegfx has the additional advantage, that Bezier curves are used and not polylines. You see the difference, if you convert the shape to curve. ARCANGLETO is not used from our shapes or from import from binary MS Office, but only from OOXML or user-defined custom shapes. tdf#122323 MS Office restricts the swing angle to [-360°,360] in rendering. Such restriction is not in OOXML and not in ODF. Nevertheless, I have added a clamp for ooxml-foo shapes for better interoperability. Change-Id: Ib3233ce14dab950cc521cb8cbac6809a1d3e34a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96068 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-06-14Fix typosAndrea Gelmini
Change-Id: I9fbb2e38632d8baa48fb9325824fd2bf7a064d10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95840 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-14Removed executable permission on filesAndrea Gelmini
Change-Id: I3e399ec1fe38e3dac7638f59bb242324f446e834 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96265 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-13svx: Gallery code refactoringAditya
Older classes like Gallery, GalleryTheme, GalleryThemeEntry have reading and writing data members and member functions included in the classes which makes the code unclear and less organized. Introduce new class Gallery Binary Engine that would deal with these member functions in such a way that older classes will have no knowledge about reading and writing. Only change the internal structure of the project and no change in behaviour of output must be there. Change-Id: Ia05eb3c692976b775a3d00e7d09fecc861bced2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95922 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-13Changed the source code location for InspectorShivam Kumar Singh
The Inspector has been instead of defining in svx now defined such that the main implementation is in sw folder whereas there is a common interface in svx. This change has been done as a progressive step towards cleaner code. Change-Id: I49af862f87b4315385c2e275b1079394c326b119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95657 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-11loplugin:unusedmethodsNoel Grandin
Change-Id: I1050fabdc0c98bbb0cc1d81a41c5b6ac3404cacf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96111 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-10let the parent toolbar decide the focus of the buttonsCaolán McNamara
Change-Id: I481fbc1b65b806cdb9eb41d6648fe9476f1326fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96020 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-10grab focus to style combobox when parent gets focusCaolán McNamara
Change-Id: Iaee1a8399e8e4f70a52ce99be113e9e7607a5ab7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96019 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-10sd signature line: localize signature graphicMiklos Vajna
Now the svg template is free from user-visible strings. Change-Id: Ibdbb73bbd1a1088a66dc25a5669df567b338b375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96021 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10uitest: Add support for Calc / Format cell / background color selectorShiko
- Add wrapper for the color-win set - Add the factory function in the correct class - Add a demo for cell background color and recent color selector - Extend the ability of ComboBoxUIObject to be able to select with text Change-Id: Ie84ba7fff2f84c3fec7f5adbb5b1cdc6c80729f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95667 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com>
2020-06-10sd signature line: set graphic of signature shapeMiklos Vajna
All placeholders are replaced, but the template is still English-only. Change-Id: Ia361447ff0a69fa0f80db4af07274d1a764a3d64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95991 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMichael Warner
Change-Id: Id747848b222f69af3293a2095a62542f1e1116d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95215 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-06-09sd signature line: select certificate after drawing the shape's rectangleMiklos Vajna
Also move the shape-type-specific setup to FuConstructRectangle::SetAttributes() where the rest of the shape types are handled. Change-Id: I9ecf94957ec82ba187f2767b01d96fb14de2b657 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95958 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-09sd doc model xml dump: show grab-bag of shapeMiklos Vajna
Which is contained directly for some reason, not inside mpProperties. Change-Id: I0f7d2d5afbeae2d399710d5ce271f3ad4ab9866d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95913 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-09tdf#126025: Non-const GetPropertyValueByName must use non-const Sequence []Stephan Bergmann
...which internally calls getArray to make sure it references a unique sequence. Regression introduced with 85f28ec44a2c169c91dac9346e9c71feda6a6cab "Clean up C- style casts from pointers to void". Change-Id: Id80b75f06322c65fc31040cc0b1892fe3a0aeaab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-08sd signature line: extract part of signature line UI from cui to svxMiklos Vajna
So the "sign existing pdf" code in sd can reuse that. Change-Id: If51fae203ed0c68ed8e5e63368e60ae1c705bade Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95841 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-08svx: fix loplugin:elidestringvar warningMiklos Vajna
Change-Id: I5424388dfc37988b2f4e5f8f34dcb1a577d9bfb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95806 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-08tdf#103474 handle quarter angles before using atan2Regina Henschel
sin(basegfx::deg2rad(fEAngleDeg)) does not result in 0 for fEAngleDeg=180 because of rounding errors and therefore atan2 later in the code gives wrong angle. Because the corresponding circle angle is the same as the ellipse angle for 0°, 90°, 180° and 270°, these angles are now handled before using atan2. Change-Id: Iae2a4d188b837ff787f2af4d79f874ba21c9aa2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95772 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-06-06Fix context moreoptions (svx/tablewindow)Julien Nabet
Change-Id: I730fa4295f8515280d3e179350da4c06649b0854 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95653 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-05Upcoming loplugin:elidestringvar: svxStephan Bergmann
Change-Id: Ia7b4f69361b6cc29f6e5c0093b13cf0b48e25ba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95576 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Update ShadowPrimitive2D to support shadow blurA_GAN
Add attribute for the blur radius and get function. give more range for the shadow depends on the size of the blur radius. update the blur radius to be imported in Hmm and the test function. Change-Id: I32faaf02884d9a6b2f11a9033178b3b6bb419580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95388 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04loplugin:simplifypointertobool improve (2)Noel Grandin
to look for the x.get() == null pattern, which can be simplified to !x Change-Id: I0eddf93257ab53ab31949961d7c33ac2dd7288ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95400 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-03pdfium: only init pdfium library one and destroy on LO exitTomaž Vajngerl
With more and more usage of PDFium, it is hard to keep track of the life-time of the PDFium library, so it can happen that a FPDF_DestroyLibrary happens when we still have another instance where PDFium is still use. The result of this is a crash. To prevent this, just initialize the library once and delete, when on LO exit. This can be improved in the future to only keep the library active when in actual use. Change-Id: I5c7e5de7f8b97d10efb394c67c7a61b976c8d57c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95391 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02OOXML support for shadow blurA_GAN
Add a new property for the blur radius and define an ID for it to support the import of OOX files. Add a test for importing the blur radius from PPTX file Change-Id: Iffaa33ff7159019ce9478cee558622bd61bcf60e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95090 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02svx: add ability to show sub-selections in a marked objectTomaž Vajngerl
Draws selection rectangles inside the object window. Change-Id: I994477426489ea4cea89c86f9e51c9978f16b350 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95347 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02Use "Radius" instead of "Rad" for new propertiesTomaž Vajngerl
Change-Id: Ifd232bccf1519e0ed68195cf4344893175a675e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95331 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>