summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2013-01-30the name field for SdrShadowColorItem seems to be redundant nowCaolán McNamara
Change-Id: I6e90cdfc9577bfa0ee1dd1018a41aa7979dfaf04
2013-01-30SdrShadowColorItem(long nIndex, ...) variant never usedCaolán McNamara
Change-Id: Ibae83ceac3c2e1f678c35a12d68ef3779879314d
2013-01-30make basic XubString freeCaolán McNamara
Change-Id: Iea5c01fe902b052a55c86ca3b879bcca12c80690
2013-01-29fix build with older icu versionLuboš Luňák
... that's still allowed by the configure check Change-Id: I1abfdfc09522dcfbd487d87a6ff49a0b4803daad
2013-01-29sw: import draw:fill-gradient-name for Writer textframesMiklos Vajna
Change-Id: I695cf16bc3b06823ae9e0546cb751e41eb201706
2013-01-29SvXMLExport::_ExportStyles: also try to export text gradientsMiklos Vajna
They are not exported automatically, as SvxUnoNameItemTable needs a Which ID, and it's different for drawinglayer and Writer gradients. Change-Id: I5dd7d828b1f0e577e26510e3c5ca74386d000f16
2013-01-29Related: fdo#59922 add new unicode blocks, detect newer in futureCaolán McNamara
so that if a new ones appears in icu we should compile time warn about it Change-Id: Ic116dce40a2aedee417320bc5291bb5b7d0ac391
2013-01-29Resolves: fdo#59922 Incorrect character range for "Katakana Phonetic"OKANO Takayoshi
Change-Id: Ic541e2510567ca0f264730568c482fef521e6318
2013-01-29Repeated call to namespace tableGokul
Change-Id: I7cde7c609ee4e5e2cd9ab0be8f973b2626670f13 Reviewed-on: https://gerrit.libreoffice.org/1875 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-29Resolves the bug fdo#59117 missing borders of last columnkarth
When writingmode is set to RTL, the table is start drawn from Last column to first column. There is no problem with left&right lines, Because these are not depends on the LTR or RTL writingmode. But the bottom & top line depends on writing mode. As these two lines are drawn from previous cell to next cell(left to right) the nX value should be nX-1 in RTL writingmode. Change-Id: I3e21c7dd469ed5ba29e66f79da471b662632182e Reviewed-on: https://gerrit.libreoffice.org/1834 Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa> Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
2013-01-28use SvtModuleOptions::ClassifyFactoryByServiceName to determine moduleCaolán McNamara
Change-Id: Ic0f8101c2619bf83feddbe0bd74d0b88941bbbe7
2013-01-28 fdo#59397 Use more precise wording at 'Find & Replace - More Options - Styles'Vishv Brahmbhatt
Change-Id: I5013e8b2ce99478f2445756e181f009b93d4e746 Reviewed-on: https://gerrit.libreoffice.org/1905 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2013-01-28WaE: declaration of nWhich shadows a member of ´this´Miklos Vajna
Change-Id: I0a56ecd13b59997c202acd327e0647f69a1b8db7
2013-01-28fix previous string conversion:Michael Stahl
- SdrAngleItem::GetPresentation missing space - SwFmtFrmSize::GetPresentation spurious s - crstrvl.cxx build breaker Change-Id: I4f1ce51943dff002ce250aff6f37f090c727bb00
2013-01-28fdo#38838 Some removal/replacement of the String/UniString with OUStringJean-Noël Rouvignac
Changed SfxItemPool::GetPresentation( SfxItemPresentation ePres, SfxMapUnit eCoreMetric, SfxMapUnit ePresMetric, String &rText ) const; to use OUString. Change-Id: I656c1d321ff96f1f2e5b77f6adc103ef0a6fdf66
2013-01-28XFillGradientItem: don't assume the default Which IDMiklos Vajna
Change-Id: I2baced123f957fb47f7710c122664842e0b1bb1d
2013-01-28SwXTextFrame: use XFillGradientItem instead of extending SvxBrushItemMiklos Vajna
Change-Id: I8863cbe1d01fceac0f4b4152264c1464c90e02b8
2013-01-28SwXTextFrame: use XFillStyleItem instead of extending SvxBrushItemMiklos Vajna
Change-Id: I03b841ed703503425c9f1a2045d6399c8899815f
2013-01-28Resolves: fdo#59965 crash dialog title area text is missingCaolán McNamara
Change-Id: I19adc5047d744acee243c94ff4e31531ae8c458a
2013-01-26gbuild: fix silly "expandtabs" in makefile VIM modelinesMichael Stahl
Change-Id: I54d8923ad315e8041fd3904da3a29f1a7a8c8b16
2013-01-26gbuild: remove various pointless calls that don't add anythingMichael Stahl
Change-Id: I7eccac4fa8890c2873c6bbd7f8f5bf5b0dd006d2
2013-01-26gbuild: do not copy boost headers aroundMichael Stahl
- do not use gb_UnpackedTarball_copy_header_files for boost - adapt the optimization in concat-deps.c for new path - use boost_headers in all LinkTargets that require it - add explicit include paths to mysqlc, mysqlcppconn, libvisio, liborcus Change-Id: I0c43e73ed43cc9d2e6bce8faf55e992d655a0bb9
2013-01-25set mnemonic widgets in asian phonetic guide dialogCaolán McNamara
Change-Id: I0f41fb345b8f0822c98f19bc9de2c7e9c15133a9
2013-01-24Remove RTL_CONSTASCII_USTRINGPARAM in svxChr. Rossmanith
replace equals() with == Change-Id: Ic1aed52398beb2132d8c6824335b865ceb4255b3
2013-01-24Change GetSavedValue() to return OUStringChr. Rossmanith
removed temporarily added OUString(...GetSavedValue()...) constructs again Change-Id: I11477654d217a5ae127c1ef1b19cbff56ed052a6
2013-01-24rename SfxSingleTabDialog to SfxNoLayoutSingleTabDialogCaolán McNamara
Change-Id: I4922b719bf819879909e9949bf7946f20914d1e5
2013-01-24Replace the frequent functioncallsK_Karthikeyan
The function getHorizontalEdge contains more function calls to the getRowCount(). Instead we store the return value of getRowCount() value in a const integer varible nRowCount and use it. Change-Id: I3e1460913099d1060d5005329e0b63e5ebcd362c Reviewed-on: https://gerrit.libreoffice.org/1777 Reviewed-by: Radek Doulík <rodo@novell.com> Tested-by: Radek Doulík <rodo@novell.com>
2013-01-24fdo#59101 - [Feature Request] Make Find hotkey (Ctrl+F) a toggle commandJoren De Cuyper
Change-Id: I8cf518a18e4846f9e687d05c7f7c0eb774abba6f Reviewed-on: https://gerrit.libreoffice.org/1751 Reviewed-by: Radek Doulík <rodo@novell.com> Tested-by: Radek Doulík <rodo@novell.com>
2013-01-22Remove RTL_CONSTASCII_USTRINGPARAM in svxChr. Rossmanith
replaced equals() with == Change-Id: I8697cc700d9780306ac83f52253b60ea55be6853
2013-01-22Tutorial step #8 clean unused .src|.hrc remaindersCaolán McNamara
1. Remove the DLG_CHINESETRANSLATION dialog from the .src 1.1. Remove the .src from AllLangResTarget_<module>.mk if that that .src is now empty. 1.2. Remove from any .hrc files any defines which are now unused due to removing that .src hunk 1.3. Remove any .hrc files which are now empty and remove any #includes of those Change-Id: I872f97e4d3ec7404f4d8978c32e397bb20e96783
2013-01-22Tutorial step #7 remove FreeResourceCaolán McNamara
1. Remove the call to FreeResource, the dialog is no long resource based, so it will crash otherwise 2. make dev-install, cross fingers, launch app and dialog 3. launch under gdb if it crashes, typically asserts indicate typos in widget names or mismatched widget types Change-Id: I50df1b5d73e904c8d64feb06f23a9331340e40af
2013-01-22Tutorial step #6 convert remaining widgetsCaolán McNamara
1. repeat step #5 for each remaining widget, this time making up more memorable names for the widgets we want to access and updating the .ui with them in parallel with adapting the code Change-Id: I29eba9fd0f8680d170412d45a39ff1e562261267
2013-01-22Tutorial step #5 convert first remaining widgetCaolán McNamara
taking m_aBP_OK as a standalone example: 1. Change OKButton m_aBP_OK in header to OKButton* m_pBP_OK; 1.1. Remove m_aBP_OK ctor call and change to get(<pointer>, "name in .ui file"), e.g. get(m_aBP_OK, "ok"); 1.1. Mass-convert calls from "m_aBP_OK." to "m_pBP_OK->" e.g. :%s/m_aBP_OK./m_pBP_OK->/g 1.2. Search for anyremaining m_aBP_OK instances and adapt Change-Id: Iadb3ed674413c0b8eca3ba7a00bafaab112d8ff5
2013-01-22Tutorial step #4 remove redundant FixedLine/FixedText constructorsCaolán McNamara
1. It's nearly always the case that the FixedLine can be elided entirely as its only a visual effect with no methods called on it except its ctor, so explicit mention of it can be removed. 2. Thats's often the case for FixedText labels as well. Change-Id: Icd7434ee28d044d169f1d1ea230fbe9df9156bdc
2013-01-22Tutorial step #3 remove redundant button widget constructorsCaolán McNamara
1. It's nearly always the case that the Help button has no methods called on it except its ctor, i.e. no changes to its default behaviour, so explicit mention of it can be removed. 2. Thats's often the case for the Cancel button 3. That's occasionally the case for the OK button Change-Id: Ic192962b2e55546cd448d7a69394ae13a743299e
2013-01-22Tutorial step #3 change Dialog constructorCaolán McNamara
Change-Id: Ibdd805d568da2006caaa2d0b756e809e48786f0c
2013-01-22Tutorial step #2 improve .ui prototypeCaolán McNamara
1. Pick a button to be the default button 1.1. Select can-default and has-default 2. Pretty it up a little 2.1. Set 12 pixel row spacing to toplevel grid 2.2. Set 6 pixel row spacing on second level grids 2.3. Set 6 pixel col spacing on second level grid 2.4. Add 6 pixel top spacing to alignments 3. Resize behaviour 3.1. Select "translate common terms" to horizontally expand 3.2. Select frame1 and frame2 to vertically expand 3.3. Resize dialog in glade and confirm behaviour is as desired 3.4. confirm with glade-previewer 3.5. confirm with ui-previewer Change-Id: I3a77f92394afdc849b45c38e16aab6e0349165e8
2013-01-22Tutorial step #1 initial .ui prototypeCaolán McNamara
1. Give the dialog the right title, "Chinese Conversion" 2. save as chineseconversiondialog.ui to <module>/uiconfig/ui 3. add to <module/UI_<module>.mk 4. Add the dialog action area buttons 5.1. use stock gtk-ok, gtk-cancel, gtk-help, etc. for standard buttons 5.2. call them "ok", "cancel", "help" for consistency 6. Visually the old dialog has two frames, "Conversion direction" and "Common terms" 6.1. Add a GtkGrid, one column, two rows 6.2. Add a GtkFrame to each 6.3. Copy and paste in the frame titles from the .src 6.4. Format the frame labels to use bold text and not bold markup as per https://live.gnome.org/GnomeGoals/RemoveMarkupInMessages 7. Conversion direction has two radio buttons 7.1. Add a GtkGrid, one column, two rows to Conversion direction frame 7.2. Add two radiobuttons, cut and paste in text from .src 7.3. Convert vcl "~" mnemonic indication to .ui "_" and click use underline 7.4. Group radiobutton1 with radiobutton2 and radiobutton2 with radiobutton1 7.5. Set the radiobuttons that are not to be default selected as inactive 8. Common terms has one checkbox and a pushbutton 8.1. Add a GtkGrid, two columns, one row 8.2. Add a checkbox and button, copy and paste in text from .src 8.3. do the ~ to _ + underscore conversion Change-Id: I49af68b8280876d8687fe9ecad4d80d12c9607c4
2013-01-22remove always false and disabled m_aCB_Use_Variants checkboxCaolán McNamara
Change-Id: I770c867a2cb014fd34c5289d47ff030aa774579d
2013-01-22remove unused chinese_translationdialog.src, see chinese_dialogs.srcCaolán McNamara
Change-Id: If32174be8ec197f83797a3e06b60c9114d4ce21f
2013-01-22do not second-guess which classes use a stylesheetDavid Tardon
Change-Id: I76b23bcdca2e7394fd5ab67e8341f4cdb46f8a64
2013-01-21Changed SetText() / GetText() to take/return OUStringChr. Rossmanith
replaced lots of Len() with isEmpty() Change-Id: I6b82d48245ee2a0782e05a326f7934e9357227d0 Reviewed-on: https://gerrit.libreoffice.org/1795 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-21resolve fdo#59619 Spelling error - heigthJoren De Cuyper
Change-Id: Ice59129d20c6b7e3aa0dbabfefabd14bad8199b6 Reviewed-on: https://gerrit.libreoffice.org/1782 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-01-21Replaced O[U]String::valueOf( static_cast<> ) with O[U]String::number()Jean-Noël Rouvignac
Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de Reviewed-on: https://gerrit.libreoffice.org/1784 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-20splitcelldlg.hxx moved into cui long ago, this copy should be removedCaolán McNamara
Change-Id: Id019b80e12eaaed1d181af2eb2599cc1db26ee25
2013-01-18PRODUCTEXTENSION: fix various obvious strings and such...Michael Stahl
... to look pretty; most of these expect PRODUCTEXTENSION to be a word like "Beta" but nowadays it is ".micro.rc.alphabeta" numbers so there should be no space before it. ReplaceStringHookProc adds insult to injury by refusing to replace %ABOUTBOX variables unless some %PRODUCT is in the string. Change-Id: Ib676f3837ab0785529a226fc9359e8defacf3459
2013-01-18split out background page and adapt code to .uiCaolán McNamara
I've being putting this one off for a while as its a complicated set of hidden pieces shows for different background types format->frame->background shows transparency option table->properties->background shows "for cell/table/row" options flipping as graphic/color should show different contents Change-Id: I4a63d3bbe8898ad2421d6ddef011da9ae67b5a4f
2013-01-17Const correct-ness in one place...Kohei Yoshida
And an avalanche of changes that ensued. Change-Id: I7f882b621ba5af4cd01b2ac7f482ee3eed24e3d5
2013-01-17Proper construction of the impl class, using initializer.Kohei Yoshida
And make sure the whole thing still builds. Change-Id: I49d3c01d288df800e3261ce7d4f07080be2a4098
2013-01-17callcatcher: remove newly unused codeCaolán McNamara
Change-Id: I3ec055cf7aff5674def54cb75d348f3fb3336c4a