summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2016-11-14related: if we're empty, we're back to initial 'sorted' stateMike Kaganski
commit ae922863c4932be38ef53ae5e985a668724e8f15 followup Change-Id: Ia9b8749880cc8c2b83dd59b4d7325cd666881c46 Reviewed-on: https://gerrit.libreoffice.org/30837 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-14coverity#703927 Unchecked return valueCaolán McNamara
make these less odd and simply return the thing they selected, rather than a bool that indicates that the rpObj arg was successfully set to non-null, so there's one flag to check not two which both mean the same thing. Change-Id: If70e412f98dea8b7114fb77f26a9c59aab93be50 Reviewed-on: https://gerrit.libreoffice.org/30794 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-13drop useless semicolonsDavid Tardon
Change-Id: I039f8ff491b42ea9c3936bf13922df8095434228
2016-11-13coverity#1371152 Missing move assignment operatorCaolán McNamara
Change-Id: I7cf3ed2c1cd392b149d21ee884aac695d5d01be2 Reviewed-on: https://gerrit.libreoffice.org/30796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-13if we're empty, we're back to initial 'sorted' stateCaolán McNamara
Change-Id: Id85c670ab40d9d0e9848f91f4f2d14212f52c1a1 Reviewed-on: https://gerrit.libreoffice.org/30795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-12svx: prevent customshape handles go far away when adjusting.Mark Hung
Change-Id: I4d1efd52320093a8edf4a5b7b1032a0754275f39 Reviewed-on: https://gerrit.libreoffice.org/30604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-11-12tdf#100733 svx: use RefR and RefAngle for polar handles.Mark Hung
Shapes imports from ooxml use RefR and RefAngle that refers to adjustment to be updated. Though the properties exist but the functions weren't implemented before. Change-Id: Ib45c2e8b16c9a7b41387a3e8c356b803eaf74b77 Reviewed-on: https://gerrit.libreoffice.org/30603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-09Revert "Revert "convert sdr::animation::EventList to o3tl::sorted_vector""Noel Grandin
This reverts commit 0e0e3ea312dc09de6726318c3579671fec7de7ee. and fixes the call to o3tl::sorted_vector::erase that causes a crash. Change-Id: Ic8ef07eb045a63dc8eaaa33886895f1d8f73098c Reviewed-on: https://gerrit.libreoffice.org/30715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09Revert "convert sdr::animation::EventList to o3tl::sorted_vector"Caolán McNamara
This reverts commit c0c69ccd2aac45e4cca0de7d4deaa6d02ec27f4d. because soffice --headless --convert-to odp ooo75571-1.odp crashes after this change
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09Restore the color picker icon in colorwindow.uiMaxim Monastirsky
Caused by a bug in Glade. Change-Id: I8acc923093f7ef1e8a2a5831bc96c63e4c7f0341
2016-11-08Remove obsolete OxygenOffice stringsGabor Kelemen
These belonged to extra galleries, introduced in 49d5bdcf4d516b21721f1ed6d313ea4a170d39eb I missed to remove these in 8dc38d9ded92960eda46343b67da8a8b95404b5a Change-Id: I32c649d56053b32f2c2993aeda51425d7586c9b7 Reviewed-on: https://gerrit.libreoffice.org/30698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-08typo fix: ressource -> resourceAndras Timar
Change-Id: Id8d1c01b17e711a057a9f3f20e1d0f955b2ea6c8 Reviewed-on: https://gerrit.libreoffice.org/30690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-08simplify mark points and gluepoints managementCaolán McNamara
Change-Id: I52070cfe4909a13189d9c130114d98565ced9089
2016-11-08reduce copying when decomposing drawinglayer primitivesNoel Grandin
instead of returning a Primitive2DContainer from each method which we are then going to immediately append to another container, pass down a single container by reference which we can append to Change-Id: I0f28a499d2ec54f7111a7044c30099767aa079e1 Reviewed-on: https://gerrit.libreoffice.org/30258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08coverity#1394268 Resource leakCaolán McNamara
Change-Id: I8f4a76d4f7e5cb2429ed5911c6026535590c681e
2016-11-08tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: I2f7e2fd8b9ae45e1aa45cf97750a6107ed9f3036 Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07Revert "Reverts a commit series that cripple windows ci."Caolán McNamara
with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-07Fix typos (also in the code)Andrea Gelmini
Change-Id: I45d45513b102f4fdcb55e8de20b95b37f66ea463 Reviewed-on: https://gerrit.libreoffice.org/30658 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-11-07ensure checkForUniqueItem on inserting a new slideCaolán McNamara
On copying slides from another presentation into one, we end up with two XBitmapItems with the same name and different properties. because the names are supposed to be unique, only one gets exported so the presentation looses graphics on export there is a bunch of places which use checkForUniqueItem to block this from happening, add another at the point where we insert the new page into the model Change-Id: If708b1997c7e83e4787d9d54f84c8b0516e6cf6b Reviewed-on: https://gerrit.libreoffice.org/30664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-07loplugin:unnecessaryvirtual in svx..swNoel Grandin
Change-Id: I4ae8de558550e6577c28b95e0aaed74f00d79c29 Reviewed-on: https://gerrit.libreoffice.org/30650 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07convert sdr::animation::EventList to o3tl::sorted_vectorNoel Grandin
instead of home-grown linked list Change-Id: I7cf24692e7b9919ac83e404e2d0167c3015b97de Reviewed-on: https://gerrit.libreoffice.org/30569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-05Reverts a commit series that cripple windows ci.Norbert Thiebaud
Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
2016-11-04replace OColorPopup with SvxColorWindowCaolán McNamara
Change-Id: I1aa06f70016b935bb13a0f6e93234eea10ba8b84
2016-11-04drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALIDCaolán McNamara
it doesn't appear to exist/be implemented and makes the reportdesigner font dialog from conditional formatting crash Change-Id: Iad929fec8aedfa31f6e8f9dfaa0055d61a9ff6f3
2016-11-04move now combined ColorLB to location of last userCaolán McNamara
Change-Id: I5dc1204c28b65d5dca993bf38aea217bbb49e913
2016-11-04fold ColorListBox and ColorLB togetherCaolán McNamara
Change-Id: I485109acd7cd4d6c2dc53e29f4b01bfc202a38f3
2016-11-04move ColorListBox beside sole thing that uses itCaolán McNamara
Change-Id: Ia458ded8881c415badd5d75bddad0daca57a1a25
2016-11-04extensions leaks out details of Color Selector, patch it upCaolán McNamara
and rebase it on SvxColorListBox Change-Id: I3afef689ab0dc3c34e465810d82bf21797907558
2016-11-04inherit FillAttrLB from ListBox not ColorListBoxCaolán McNamara
Change-Id: Icd6f51b61ec0d006c10c6a75da649cc83057b9f1
2016-11-04unify color selectorsCaolán McNamara
Note: this removes the use of auto-color from writer's asian text grid, because its always invisible as far as I can see in practice. Change-Id: Ie850790d740a4d56c43015e493e093678cef3b4e
2016-11-04Fix dialog name and titleSamuel Mehrbrodt
Change-Id: I55d628d6e61d4035155d42fa45270418a3e10387 Reviewed-on: https://gerrit.libreoffice.org/30563 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03svx: add missing ~CONVERT_TWIPS mask in SvxPageItem::PutValue()Miklos Vajna
With this, it's possible to use AttributePage.* keys in macros. Change-Id: I3f0b1ea8fb6274e7c18511c2e80774205206a2ba
2016-11-03SafeModeDialog: Adapt label to realitySamuel Mehrbrodt
Change-Id: I649b1f1f9b8f5c50e69f2cd4228394cfa4d2974a
2016-11-03Fix some commentsSamuel Mehrbrodt
Change-Id: Ie74eaead67620decf9c9b954be1d13a8e5f400c6
2016-11-03SafeModeDialog: Improve descriptionSamuel Mehrbrodt
Change-Id: I86f4a322f3d68caafcfe206e2d0f2164bc789bd8
2016-11-03SafeModeDialog: Better grouping of optionsSamuel Mehrbrodt
Disable/Deinstall extensions are mutually exclusive, so group them appropriately Change-Id: I6dc9c53ef4c18103c7521d494a769d522b0412dd Reviewed-on: https://gerrit.libreoffice.org/30522 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03SafeModeDialog: Improve labelsSamuel Mehrbrodt
Change-Id: If90b25e569a8feaa86e5c43da5966d5314cf0f14 Reviewed-on: https://gerrit.libreoffice.org/30521 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03SafeModeDialog: Fix enabling/disabling of widgetsSamuel Mehrbrodt
Change-Id: I7133b64f975fa8e68550d41056b689dfc18cf172 Reviewed-on: https://gerrit.libreoffice.org/30520 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03SafeModeDialog: Allow to create zip file from profileSamuel Mehrbrodt
Change-Id: I4296d1cf5058be359ffed46745673cf26eba3375 Reviewed-on: https://gerrit.libreoffice.org/30479 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03Omit the default comparator std::less<key_type>Takeshi Abe
Change-Id: Iaf873fc8b5ca673d5e829be33074dffd8680ae03 Reviewed-on: https://gerrit.libreoffice.org/30452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-02upgrade to ICU 58Eike Rathke
Change-Id: I4a992447df65b337721a2a2627d974172a14cba5 Reviewed-on: https://gerrit.libreoffice.org/30487 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-11-02drop SvxColorWindow::ResizeCaolán McNamara
Change-Id: I22ed6ace464cdfd4ee0c12e8269d8141efce57a6
2016-11-02move SvxColorWindow to include/svxCaolán McNamara
Change-Id: Ie2e11c8582cbb204178c0616580f942d1ce773fb
2016-11-02rename SvxColorWindow_Impl to SvxColorWindowCaolán McNamara
Change-Id: I84941f4566792e11a9070f8623857a3fac44591d
2016-11-02loplugin:unusedfieldsNoel Grandin
Change-Id: I96634c18ba6600f8f7d5d04a162dcd7e1e312923 Reviewed-on: https://gerrit.libreoffice.org/30474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01SafeModeDialog: Close dialog before restartingSamuel Mehrbrodt
Change-Id: I714040d0892cf154e002209dbdb4831b40ec08bc Reviewed-on: https://gerrit.libreoffice.org/30472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit (git 2.34.1) at 2025-02-11 17:46:25 +0000